corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
796,093 Commits 1 Branch 0 Tags
f4139c1440af43fae4bc901b40e80d1028d2738c
Commit Graph

585 Commits

Author SHA1 Message Date
William Durand
646444ad1e Bug 1797050 - Part 4 - Use browser_specific_settings instead of applications in remaining tests. r=rpl,application-update-reviewers,bytesized 
Differential Revision: https://phabricator.services.mozilla.com/D160060
 2022-10-28 09:53:10 +00:00
Gijs Kruitbosch
6f5d442adc Bug 1797540 - Firefox View should send telemetry for 0 tabs as well, r=sclements 
Differential Revision: https://phabricator.services.mozilla.com/D160426
 2022-10-27 11:06:49 +00:00
Sandor Molnar
9fbee3a9f1 Backed out changeset 53ce60b1b515 (bug 1797050) for causing bc failures in browser/components/preferences/tests/browser_extension_controlled.js CLOSED TREE 2022-10-26 15:01:23 +03:00
William Durand
00c4a3becb Bug 1797050 - Part 4 - Use browser_specific_settings instead of applications in remaining tests. r=rpl,application-update-reviewers,bytesized 
Differential Revision: https://phabricator.services.mozilla.com/D160060
 2022-10-26 11:15:12 +00:00
Mark Banner
17403914cb Bug 1795880 - Add an ESLint rule to enforce using static imports where possible. r=arai,geckoview-reviewers,m_kato 
Differential Revision: https://phabricator.services.mozilla.com/D160131
 2022-10-26 09:37:46 +00:00
Sammy Khamis
0c4a2fad3b Bug 1791851 - replace desktop tabs with the rust tabs engine r=teshaq,LougeniaBailey,markh,sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D157981
 2022-10-25 20:03:23 +00:00
negin
c9abcc5baf Bug 1790382 - Update Firefox View Feature Callout so that screenreaders read expected content in the proper order r=emcminn 
Differential Revision: https://phabricator.services.mozilla.com/D159762
 2022-10-25 16:14:06 +00:00
Cristian Tuns
01b2b78526 Backed out changeset cf4f7e5d0f9d (bug 1790382) for causing mochitest failures in browser_feature_callout_resize.js CLOSED TREE 2022-10-25 10:26:35 -04:00
negin
e39e4874d2 Bug 1790382 - Update Firefox View Feature Callout so that screenreaders read expected content in the proper order r=emcminn 
Differential Revision: https://phabricator.services.mozilla.com/D159762
 2022-10-25 13:50:19 +00:00
Sarah Clements
33f2a969c4 Bug 1791076 - prevent a closed tab from being opened with mousedown + drag outside item r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D160061
 2022-10-25 13:25:54 +00:00
Hanna Jones
bc09027cd8 Bug 1791474 - show more specific message for locked primary password error r=sfoster,fluent-reviewers 
* Updated the error message to use the text [here](https://www.figma.com/file/SE4xHgOW84yLiv7vFugm9R/Firefox-View-Stepping-Stone)
* Updated the existing password test to verify the message contents

Differential Revision: https://phabricator.services.mozilla.com/D159787
 2022-10-24 18:29:53 +00:00
Marian-Vasile Laza
22a37b6925 Backed out changeset caddc49839d3 (bug 1793088) for causing bc failures on browser_firefoxview_tab.js. CLOSED TREE 2022-10-24 17:49:47 +03:00
Kelly Cochrane
3305772c50 Bug 1793088 - Make first available tab focusable when Fx View is open r=dao 
Differential Revision: https://phabricator.services.mozilla.com/D159766
 2022-10-24 12:32:44 +00:00
Niklas Baumgardner
c19d5f3962 Bug 1785734 - Add test for keyboard focus in Firefox View. r=sfoster,ayeddi,Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D155253
 2022-10-20 18:57:30 +00:00
Noemi Erli
55e26cd909 Backed out changeset 0a1431ca8979 (bug 1793088) for causing failures browser_firefoxview_tab.js CLOSED TREE 2022-10-20 18:53:41 +03:00
Kelly Cochrane
1c701caf06 Bug 1793088 - Make first available tab focusable when Fx View is open r=dao 
Differential Revision: https://phabricator.services.mozilla.com/D159766
 2022-10-20 14:43:31 +00:00
Gijs Kruitbosch
49893169f5 Bug 1787980 - add a pref for the firefox view tab notification dot and disable it by default, r=niklas 
I opted to add a pref and effectively disable things by default rather than
just removing everything, because it seems likely we'll want to re-introduce
this in some form at some point soon, plus this is a much smaller change to
uplift and keeps the test coverage for now, too.

Differential Revision: https://phabricator.services.mozilla.com/D159707
 2022-10-19 19:35:57 +00:00
Kelly Cochrane
ff59c7c418 Bug 1795299 - Update Fx View logo container to full width with centered logo in narrower viewports r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D159595
 2022-10-18 15:17:37 +00:00
Shane Hughes
7a6dea3750 Bug 1787532 - Let Feature Callouts perform actions on page events. r=mviar 
Add a new module and feature callout functions to support messages
performing actions when a specified event is dispatched from the
content. This will allow Feature Callout messages to be dismissed when a
button is clicked within the page in which they are rendered. A screen
just needs to provide a `page_event_listeners` property, which is an
array of objects, each containing event listener parameters (event type,
target selector, and optional parameters) and an action specification
like those already used for buttons. The event listener will be added to
all elements matching the selector, so multiple different buttons could
dismiss or advance the message, if necessary. The new screen property
has this form:
```
page_event_listeners: [
  {
    params: {
      type: string,
      selectors: string,
      options?: {
        capture?: boolean,
        once?: boolean,
        preventDefault?: boolean,
      },
    },
    action: {
      type?: string,
      data?: object,
      dismiss?: boolean,
      etc...
    },
  },
]
```

Differential Revision: https://phabricator.services.mozilla.com/D158899
 2022-10-18 14:29:27 +00:00
Sam Foster
0d9a297863 Bug 1795752 - Use fx-view rather than firefoxview as the entry point param for FxA signin/signup. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D159528
 2022-10-18 00:22:26 +00:00
Cristian Tuns
39cbafb6a7 Backed out changeset d734d1d10478 (bug 1795752) for causing mochitest failures on browser_feature_callout.js CLOSED TREE 2022-10-17 17:17:49 -04:00
Sam Foster
1969a620bf Bug 1795752 - Use fx-view rather than firefoxview as the entry point param for FxA signin/signup. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D159528
 2022-10-17 20:35:31 +00:00
Tim Giles
9fa180f7e9 Bug 1794474 - Force tabs sync when a user reloads Firefox View. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D159401
 2022-10-17 18:39:27 +00:00
negin
c8bf42e95d Bug 1792667 - The “Tab Pickup” callout message points to another section when the “Tab Pickup” section is collapsed r=mviar,emcminn 
try: https://hg.mozilla.org/try/rev/92340ece620dd2d64e2f2c9826a4f6d9a387acc6

Differential Revision: https://phabricator.services.mozilla.com/D158699
 2022-10-17 15:18:39 +00:00
Kelly Cochrane
044d219619 Bug 1793638 - Collapse synced tabs list to single column on narrower viewports r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D159327
 2022-10-14 14:09:02 +00:00
hanna alemu
34fd1f0af1 Bug 1794592 - Investigate use of message property in Fx view messages/ remove if not used r=mviar 
The "message" property of the pref "browser.firefox-view.feature-tour" seems to have no actual use, and only one value of "FIREFOX_VIEW_FEATURE_TOUR". We can remove it to reduce complexity.

Differential Revision: https://phabricator.services.mozilla.com/D159131
 2022-10-13 19:41:01 +00:00
Bernard Igiri
24a6b79c9b Bug 1784323 - Prevent hidden Firefox View tab from triggering the closing multiple tabs warning r=dao,Gijs 
Updated the tab closing prompt logic to use the number of visible tabs open to determine if the prompt should show.

Differential Revision: https://phabricator.services.mozilla.com/D157965
 2022-10-13 16:39:41 +00:00
Tim Giles
9c4d623be8 Bug 1792680 - Fix Firefox View not being a reloadable tab. r=dao 
Differential Revision: https://phabricator.services.mozilla.com/D159212
 2022-10-13 14:28:16 +00:00
Mark Hammond
21bd24ad69 Bug 1792550 - ensure the primary password is unlocked before signing in to sync. r=Mardak,sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D158719
 2022-10-12 22:31:37 +00:00
Sarah Clements
afeab23b18 Bug 1785853 - Close device connected tab after user returns to Firefox View r=sfoster 
* Add _closeDeviceConnectedTab to FirefoxViewHandler that's called by the TabSelect event handler
* Add test coverage

Differential Revision: https://phabricator.services.mozilla.com/D158031
 2022-10-12 16:39:39 +00:00
Norisz Fay
f7de136a6d Backed out changeset 9b1e2e6ceb70 (bug 1785853) for causing mochitest failures on browser_setup_state.js CLOSED TREE 2022-10-12 17:50:02 +03:00
Sarah Clements
bf8716d193 Bug 1785853 - Close device connected tab after user returns to Firefox View r=sfoster 
* Add _closeDeviceConnectedTab to FirefoxViewHandler that's called by the TabSelect event handler
* Add test coverage

Differential Revision: https://phabricator.services.mozilla.com/D158031
 2022-10-12 13:26:41 +00:00
Sarah Clements
233f73e5bd Bug 1793754 - Fix sync error when user disconnects a device r=sfoster 
* Only show sync error if user is not signed in and give them a way out when try again button is clicked

Differential Revision: https://phabricator.services.mozilla.com/D158972
 2022-10-12 10:12:36 +00:00
Marian-Vasile Laza
b853119e5f Backed out changeset d6922083e8a9 (bug 1788996) for causing bc failures on browser_feature_callout.js. CLOSED TREE 2022-10-12 02:37:47 +03:00
Jason Prickett
167ac274a4 Bug 1788996 - Add telemetry call when feature callout parent doesn't exist r=mviar 
Differential Revision: https://phabricator.services.mozilla.com/D157750
 2022-10-11 22:45:02 +00:00
Kelly Cochrane
1a02174385 Bug 1792099 - Allow for text selection in Recently Closed Tabs when holding Alt/Opt key r=Gijs,sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D158708
 2022-10-11 21:47:16 +00:00
Bernard Igiri
3d983163c2 Bug 1794481 - Updated browser_media_query_dom_sorting.js test to use withFirefoxView function. r=Gijs 
Updated browser_media_query_dom_sorting.js test to use withFirefoxView function.

Differential Revision: https://phabricator.services.mozilla.com/D158990
 2022-10-11 19:26:48 +00:00
Hanna Jones
92d8095a44 Bug 1789982 - handle case where sync is connected but user is logged out r=sclements 
This patch adds logic to show an error when a user becomes disconnected due to changing their password on another device. We will now show the `sync-disconnected` error, which should direct the user to their sync settings where they can enter their new password/sign in again.

This patch also includes a test for this new error case, as well as some small changes to an existing test that started failing due to a slight mismatch between the UIState representation used in the test and the UIState we expect when a user logs out.

Differential Revision: https://phabricator.services.mozilla.com/D158043
 2022-10-11 18:34:24 +00:00
Meg Viar
c349d50364 Bug 1793660 - Allow feature callout to point to elements that are above and to its end r=jprickett 
Differential Revision: https://phabricator.services.mozilla.com/D158610
 2022-10-11 13:25:44 +00:00
Shane Hughes
2e181ef8b8 Bug 1788702 - Reduce feature callout test zoom factor. r=mviar 
Differential Revision: https://phabricator.services.mozilla.com/D158921
 2022-10-10 19:58:22 +00:00
Tim Giles
8bd3107d96 Bug 1792503 - Add keyboard toggle test for tab pickup list. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D158675
 2022-10-10 15:20:00 +00:00
Tim Giles
2e2a811fe0 Bug 1792503 - Add keyboard toggle test for recently closed tabs list. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D158674
 2022-10-10 15:20:00 +00:00
Cieara Meador
cda52a1caf Bug 1783279 - Readjust mobile promo description font size r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D158863
 2022-10-08 02:17:54 +00:00
Bernard Igiri
bec652a910 Bug 1780239 - Fix screen reader order of Colorway Landmark in FxView r=Gijs 
Added dynamic DOM reordering to FX View so that the order of announcement in screen readers and tab sorting, matches the visual changes made by the responsive CSS layout.

Differential Revision: https://phabricator.services.mozilla.com/D157256
 2022-10-07 20:21:49 +00:00
Cieara Meador
36d3a3b861 Bug 1783279 - Adjust mobile promo font sizes r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D158794
 2022-10-07 18:49:59 +00:00
Hanna Jones
1f3c5e627d Bug 1782583 - fix clientType in synced tabs mock r=Gijs 
It looks like the linked bug is caused by a different issue, but this still seemed worth fixing considering the mock data got moved to `head.js` and is being used in a few different test files now.

Differential Revision: https://phabricator.services.mozilla.com/D158705
 2022-10-07 13:22:32 +00:00
Sarah Clements
e0825872b3 Bug 1792191 - Fix the Turn on syncing to continue error state r=sfoster 
* Rename fxaSignedIn to fxaSignedInAndSyncEnabled to better reflect what its doing
* Re-enable the test_sync_disconnected_error test case and add another

Differential Revision: https://phabricator.services.mozilla.com/D158201
 2022-10-07 10:04:35 +00:00
Sam Foster
6ac7e4855e Bug 1791115 - Ensure we switch back to fx-view tab after removing the tab opened in test_time_updates_correctly. r=sclements 
Differential Revision: https://phabricator.services.mozilla.com/D158706
 2022-10-06 19:37:46 +00:00
Mark Hammond
942c5075fe Bug 1793702 - show an empty string for timestamps of 0 instead of '53 years ago'. r=sclements 
Differential Revision: https://phabricator.services.mozilla.com/D158616
 2022-10-05 21:33:38 +00:00
Shane Hughes
50150eeff7 Bug 1788702 - Fix feature callout accessibility test. r=mviar 
Differential Revision: https://phabricator.services.mozilla.com/D158553
 2022-10-05 00:10:40 +00:00