Commit Graph

585 Commits

Author SHA1 Message Date
Kelly Cochrane
80a04751cb Bug 1846607 - Update hover text for context menu buttons in Firefox View r=jsudiaman,fluent-reviewers,fxview-reviewers,flod,sclements
Differential Revision: https://phabricator.services.mozilla.com/D185596
2023-08-08 16:37:12 +00:00
Kelly Cochrane
cd7a096ba5 Bug 1845709 - Add a cards-container in synced tabs to fix scrolling issues. r=kcochrane,fxview-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D185590
2023-08-08 14:11:13 +00:00
Narcis Beleuzu
30f0660a38 Backed out changeset 2d7623e5cb0e (bug 1845709) for bc failure on browser_syncedtabs_errors_firefoxview_next.js . CLOSED TREE 2023-08-08 00:03:10 +03:00
Mike Kaply
25cfdd9427 Bug 1845709 - Add a cards-container in synced tabs to fix scrolling issues. r=kcochrane,fxview-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D185590
2023-08-07 20:06:53 +00:00
Mike Kaply
98e49dc18a Bug 1845489 - Don't set errorState if there isn't one. r=jsudiaman,fxview-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D185565
2023-08-07 19:49:24 +00:00
Mike Kaply
62b75caa84 Bug 1845909 - Hide button from accessibility since it's handled by the outer category. r=kcochrane,fxview-reviewers,ayeddi
Differential Revision: https://phabricator.services.mozilla.com/D185440
2023-08-07 19:48:20 +00:00
Mike Kaply
92124f0bcb Bug 1847242 - Show backup icon if we don't have one. r=sclements,fxview-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D185447
2023-08-05 12:04:29 +00:00
Sandor Molnar
a02140aac8 Backed out changeset ea1a5147d972 (bug 1847242) for causing failures in skin/extensions/defaultFavicon.svg CLOSED TREE 2023-08-04 21:26:34 +03:00
Mike Kaply
d8fc3aa36b Bug 1847242 - Show backup icon if we don't have one. r=sclements,fxview-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D185447
2023-08-04 18:00:47 +00:00
Mike Kaply
863ecf7e7c Bug 1847270 - Show pointer cursor when hovering over category items. r=jsudiaman
Differential Revision: https://phabricator.services.mozilla.com/D185459
2023-08-04 18:00:32 +00:00
Kelly Cochrane
066edfc517 Bug 1845475 - Add title/hover text to expand/collapse buttons for cards in Firefox View r=jsudiaman,fxview-reviewers,sclements
Differential Revision: https://phabricator.services.mozilla.com/D185345
2023-08-04 13:29:32 +00:00
Mike Kaply
cf21f6166f Bug 1828673 - Add support for overview page in synced tabs. r=desktop-theme-reviewers,fxview-reviewers,jsudiaman,dao,sfoster,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D184414
2023-08-03 18:46:32 +00:00
Kelly Cochrane
aadbaf770f Bug 1846393 - Fix for browser_history_firefoxview_next.js test failures r=fxview-reviewers,sclements
Differential Revision: https://phabricator.services.mozilla.com/D185080
2023-08-02 14:18:53 +00:00
Kelly Cochrane
8ad9025409 Bug 1843408 - Remove 'View more browsing history' link from Recently closed tabs page in Fx View r=mkaply
Differential Revision: https://phabricator.services.mozilla.com/D184949
2023-08-02 14:18:22 +00:00
Gregory Pappas
a57c4f9405 Bug 1845311 - [Part 2] Use ChromeUtils.defineLazyGetter in more places r=arai,webcompat-reviewers,necko-reviewers,extension-reviewers,settings-reviewers,application-update-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,sync-reviewers,anti-tracking-reviewers,tabbrowser-reviewers,bytesized,twisniewski,sgalich,mak,kershaw,sclements,pbz,robwu,geckoview-reviewers,amejiamarmol
Differential Revision: https://phabricator.services.mozilla.com/D184623
2023-08-01 23:01:02 +00:00
Iulian Moraru
081f900d00 Bug 1846393 - disable browser_history_firefoxview_next.js for permanent test failure which started with new month
The new month triggered a new card for July

Differential Revision: https://phabricator.services.mozilla.com/D184993
2023-08-01 15:10:54 +00:00
Mike Kaply
8098393414 Bug 1845122 - Use ID for indexing devices to properly handle duplicates. r=sfoster,fxview-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D184764
2023-08-01 11:49:09 +00:00
Butkovits Atila
1823f92da6 Backed out changeset 02777f9d9ba2 (bug 1828673) for causing failures at test_fxview_tab_list.html. CLOSED TREE 2023-08-01 01:17:16 +03:00
Mike Kaply
369f938aa8 Bug 1828673 - Add support for overview page in synced tabs. r=desktop-theme-reviewers,fxview-reviewers,jsudiaman,dao,sfoster
Differential Revision: https://phabricator.services.mozilla.com/D184414
2023-07-31 19:45:28 +00:00
Mike Kaply
913e46f6b9 Bug 1845485 - Update how we navigate between view pages. r=kcochrane,fxview-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D184951
2023-07-31 19:44:22 +00:00
Mike Kaply
8c334909cb Bug 1845218 - Pass -1 as maxTabsLength so all tabs are displayed. r=fxview-reviewers,kcochrane
Differential Revision: https://phabricator.services.mozilla.com/D184952
2023-07-31 19:38:52 +00:00
Sam Foster
7bb84fd335 Bug 1842610 - Add SessionStore.forgetClosedWindowById and forgetClosedTabById and update RecentlyClosedTabsInView to use the new forget and aggregated getClosedTabData methods. r=kcochrane,fxview-reviewers,sessionstore-reviewers,dao,sclements
* We already make use of the closedId in RecentlyClosedTabsInView to re-open the tab via SS.undoCloseById so it made sense to do the same for forgetting a closed tab
* In the test setup, one of tabs is opened and closed in a different window. This gives us coverage both for the closed tab list rendering, as well as re-opening and forgeting tabs with different source windows
* Both the forget-by-closed-id methods match undoClosedById's behavior and throw if the closedId doesnt match a closed window or tab

Differential Revision: https://phabricator.services.mozilla.com/D184192
2023-07-31 18:54:43 +00:00
Mike Kaply
ae820a2651 Bug 1846064 - Don't use getImageURL for icons. r=kcochrane,fxview-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D184854
2023-07-29 09:40:44 +00:00
Shane Hughes
0f4e587520 Bug 1845862 - Support primary buttons in Feature Callout. r=jprickett
Differential Revision: https://phabricator.services.mozilla.com/D184788
2023-07-28 20:51:17 +00:00
Shane Hughes
b6556b9453 Bug 1845419 - Allow Feature Callout page_event_listeners to set timers and hook callout lifecycle events. r=jprickett
Differential Revision: https://phabricator.services.mozilla.com/D184536
2023-07-27 16:26:26 +00:00
Gregory Pappas
e9950eccfd Bug 1845311 - Use ChromeUtils.defineLazyGetter in more places r=arai,webdriver-reviewers,geckoview-reviewers,extension-reviewers,application-update-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,anti-tracking-reviewers,sessionstore-reviewers,pbz,joschmidt,robwu,issammani,bytesized,owlish,dao
Differential Revision: https://phabricator.services.mozilla.com/D184481
2023-07-26 16:28:11 +00:00
Mike Kaply
5612d54862 Bug 1845138 - Use correct syntax for descriptionLink. r=kcochrane,fxview-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D184438
2023-07-25 18:58:40 +00:00
Mark Banner
d3d891e3d7 Bug 1845079 - Update more consumers to import ES modules directly. r=arai,settings-reviewers,credential-management-reviewers,sync-reviewers,sgalich
Differential Revision: https://phabricator.services.mozilla.com/D184371
2023-07-24 15:32:45 +00:00
Mike Kaply
064e2e5319 Bug 1844672 - No need to look for current device, it's not in the tab array. r=fxview-reviewers,sfoster
Differential Revision: https://phabricator.services.mozilla.com/D184169
2023-07-23 16:02:54 +00:00
Shane Hughes
0e39523d2a Bug 1838295 - Feature Callout fallback anchor system. r=jprickett
Differential Revision: https://phabricator.services.mozilla.com/D184067
2023-07-23 02:57:02 +00:00
Cristian Tuns
f0bbf8faa6 Backed out changeset 6f0a2e1e42f5 (bug 1838295) for causing bc failures in browser_feature_callout_in_chrome.js CLOSED TREE 2023-07-22 01:40:06 -04:00
Shane Hughes
ab73a1849d Bug 1838295 - Feature Callout fallback anchor system. r=jprickett
Differential Revision: https://phabricator.services.mozilla.com/D184067
2023-07-22 03:47:34 +00:00
Mike Kaply
576833f1d2 Bug 1833664 - Add three-dot menu to tabs on other devices. r=jsudiaman
Differential Revision: https://phabricator.services.mozilla.com/D184237
2023-07-21 19:45:53 +00:00
Kelly Cochrane
61f962b3b3 Bug 1844616 - Check for allHistoryItems map size in order to display 'Show all history' link in about:firefoxview-next#history r=jsudiaman
Differential Revision: https://phabricator.services.mozilla.com/D184126
2023-07-21 19:33:16 +00:00
Kelly Cochrane
912de5f4f2 Bug 1842903 - Correct improper use of span elements in about:firefoxview-next#history r=mkaply
Differential Revision: https://phabricator.services.mozilla.com/D184125
2023-07-21 18:35:38 +00:00
Mike Kaply
dd0f7bbe26 Bug 1833673 - Add menu for history items. r=sclements,fxview-reviewers,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D183899
2023-07-20 17:38:56 +00:00
Kelly Cochrane
87f5a31d01 Bug 1841795 - Add Recently Closed empty states in about:firefoxview-next r=mkaply,fluent-reviewers,fxview-reviewers,flod,sclements
Differential Revision: https://phabricator.services.mozilla.com/D184029
2023-07-20 15:46:51 +00:00
Jonathan Sudiaman
f4a53f1a04 Bug 1836261 - Add additional options to PlacesQuery#getHistory() r=mak,kcochrane,fxview-reviewers,bolsson
Differential Revision: https://phabricator.services.mozilla.com/D182922
2023-07-20 01:57:06 +00:00
Tooru Fujisawa
ce5ebcc064 Bug 1843789 - Part 3: Rewrite testing/mochitest/BrowserTestUtils/BrowserTestUtils.sys.mjs consumers in html/xhtml to use ChromeUtils.importESModule. r=ahal,fxview-reviewers,sfoster
Differential Revision: https://phabricator.services.mozilla.com/D183659
2023-07-18 23:06:30 +00:00
Tooru Fujisawa
75ea53fcda Bug 1843788 - Part 2: Rewrite testing/modules/TestUtils.sys.mjs consumers in html/xhtml to use ChromeUtils.importESModule. r=ahal,credential-management-reviewers,fxview-reviewers,sgalich,sfoster
Differential Revision: https://phabricator.services.mozilla.com/D183656
2023-07-18 23:06:29 +00:00
Mike Kaply
789c41c489 Bug 1842896 - Add ID so clicking label works. r=jsudiaman DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D183900
2023-07-18 21:10:43 +00:00
Mike Kaply
1264da4c06 Bug 1826608 - Implement open tabs from other device in new Firefox View. r=sclements,kcochrane,fluent-reviewers,fxview-reviewers,bolsson
Differential Revision: https://phabricator.services.mozilla.com/D180836
2023-07-18 19:08:04 +00:00
Kelly Cochrane
ab66bdc5e6 Bug 1826604 - Add History empty states and banner in about:firefoxview-next r=mkaply,fxview-reviewers,sclements,bolsson
Differential Revision: https://phabricator.services.mozilla.com/D183197
2023-07-18 13:42:11 +00:00
Sarah Clements
80033d41ab Bug 1843587 - Change getClosedTabData param to default to non-private window object r=sfoster,fxview-reviewers,sessionstore-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D183739
2023-07-18 11:11:21 +00:00
Mike Kaply
ca31a9d37c Bug 1843603 - Update category icons for View. r=sfoster,fxview-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D183602
2023-07-17 11:58:47 +00:00
Shane Hughes
99e82b0f08 Bug 1821826 - Refactor FeatureCallout to support generic triggers. r=omc-reviewers,fxview-reviewers,tabbrowser-reviewers,dao,jprickett,sclements
Also disable the Firefox View feature tour to avoid any risk of
regressions. The feature tour code will be removed in a later patch.
It's still present for now for testing purposes.

Differential Revision: https://phabricator.services.mozilla.com/D180927
2023-07-11 16:00:40 +00:00
Kelly Cochrane
51cec58770 Bug 1828606 - Implement Recently Closed component in next iteration of Firefox View r=sfoster,fluent-reviewers,fxview-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D182600
2023-07-10 19:46:10 +00:00
Cristina Horotan
4754aab8ed Backed out changeset 00270dd961d6 (bug 1828606) for causing leaked window related bc failures 2023-07-10 17:29:20 +03:00
Kelly Cochrane
24c3ac8d12 Bug 1828606 - Implement Recently Closed component in next iteration of Firefox View r=sfoster,fluent-reviewers,fxview-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D182600
2023-07-10 13:46:53 +00:00
Sam Foster
1bd6b02cd7 Bug 1819675 - Introduce a feature pref to toggle the recently-closed tabs from all windows behavior.r=sclements,dao,extension-reviewers,fxview-reviewers,robwu,sessionstore-reviewers
* Add a default-true pref to provide an escape hatch allowing us to revert to previous behavior
* in which recently-closed tabs are per-window,
* and undoing closed tabs restores them to the window they were closed from.
* Ensure we set the pref for tests which depend on its value
* Add some spot-checks in tests with the pref off

Differential Revision: https://phabricator.services.mozilla.com/D179574
2023-07-06 22:49:52 +00:00