corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
796,093 Commits 1 Branch 0 Tags
f4139c1440af43fae4bc901b40e80d1028d2738c
Commit Graph

585 Commits

Author SHA1 Message Date
Norisz Fay
f9c8a126ea Backed out changeset de7440f21f9a (bug 1788996) for causing mochitest failures on browser_feature_callout.js CLOSED TREE 2022-10-04 22:22:24 +03:00
Angel_V129
e3be76313a Bug 1788756 - [Themes] Convert browser/theme JSM modules to ESMs. r=kpatenio 
Differential Revision: https://phabricator.services.mozilla.com/D157037
 2022-10-04 19:02:24 +00:00
Jason Prickett
b899f0a12e Bug 1788996 - Add telemetry call when feature callout parent doesn't exist r=mviar 
Differential Revision: https://phabricator.services.mozilla.com/D157750
 2022-10-04 18:37:02 +00:00
Kelly Cochrane
8c00d2304d Bug 1791898 - Renaming --fxview-element-* css variables to match common.css conventions r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D158388
 2022-10-04 14:10:18 +00:00
Shane Hughes
a8178cd2f3 Bug 1790819 - Feature callouts: more overflow protection. r=mviar 
Try to keep feature callouts within the viewport if possible. Make some
changes to fix a bug where callouts could overflow ~10px over the
available space before being repositioned, and also fix a minor typo
issue. Choose the backup position with the greatest available space
instead of based on the position's order in the `positions` object.

Differential Revision: https://phabricator.services.mozilla.com/D157688
 2022-10-04 07:56:34 +00:00
Csoregi Natalia
d301388c8f Backed out changeset d91a621a39be (bug 1785853) for multiple failures e.g.browser_setup_state.js CLOSED TREE 2022-10-03 19:48:44 +03:00
Sarah Clements
f13f2edf01 Bug 1785853 - Close device connected tab after user returns to Firefox View r=sfoster 
* Add _closeDeviceConnectedTab to FirefoxViewHandler that's called by the TabSelect event handler
* Add test coverage

Differential Revision: https://phabricator.services.mozilla.com/D158031
 2022-10-03 16:07:54 +00:00
Shane Hughes
5bb99ae41f Bug 1792736 - Expose zap_gradient theme property to system pages. r=desktop-theme-reviewers,dao 
Pass down the zap_gradient experimental theme property to pages that
load contentTheme.js, and use it to set the zap gradient value in
Firefox View (with a generic fallback color for themes that don't set
this experimental property)

Differential Revision: https://phabricator.services.mozilla.com/D158278
 2022-09-30 22:14:27 +00:00
Dão Gottwald
474fd7d31f Bug 1792814 - Don't load the home page in hidden tabs such as Firefox View. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D158396
 2022-09-30 20:04:37 +00:00
Shane Hughes
f6100340bc Bug 1790381 - Clean up existing feature callouts before adding new ones. r=jprickett 
Also avoid loading redundant resources and listeners when a feature
callout is added on visibilitychange.

Differential Revision: https://phabricator.services.mozilla.com/D158300
 2022-09-30 04:58:25 +00:00
Cieara Meador
a9596700f6 Bug 1785736 - Invert Firefox View progress bar HCM palette r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D158395
 2022-09-30 03:58:07 +00:00
Andrew McCreight
670df172aa Bug 1792457 - Revert workarounds for weak references to XPCWJS crashes. r=Gijs 
I have fixed the underlying XPConnect issue, so these workarounds should
no longer be needed.

There are also two more in browser/base/content/browser-siteProtections.js
that I have not fixed.

Differential Revision: https://phabricator.services.mozilla.com/D158158
 2022-09-29 11:40:19 +00:00
Mark Banner
a49b8ef78f Bug 1792365 - Convert toolkit/modules consumers to use ES module imports directly. r=webdriver-reviewers,perftest-reviewers,geckoview-reviewers,extension-reviewers,preferences-reviewers,desktop-theme-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,robwu,Gijs,sgalich,bytesized,AlexandruIonescu,dao,m_kato 
Differential Revision: https://phabricator.services.mozilla.com/D158094
 2022-09-29 06:52:34 +00:00
Mark Banner
79b9557a71 Bug 1792398 - Enable ESLint rule 'strict' on mjs files as the directive is not necessary for modules. r=arai,pip-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D158115
 2022-09-26 21:47:50 +00:00
Marian-Vasile Laza
b7f6194b8d Backed out changeset 0679274d6ed5 (bug 1792398) for causing bc failures on browser_sendQuery.js. CLOSED TREE 2022-09-26 22:53:00 +03:00
Shane Hughes
1577034f2f Bug 1791770 - Prevent add-ons from showing Fx View tab. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D158009
 2022-09-26 19:33:52 +00:00
Mark Banner
5dcae1ed44 Bug 1792398 - Enable ESLint rule 'strict' on mjs files as the directive is not necessary for modules. r=arai,pip-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D158115
 2022-09-26 18:51:57 +00:00
Dan Mosedale
d86e156394 Bug 1791873 - fix FxView sync-setup-container kbd access,r=Gijs 
Backout tabIndex changes that caused the problem and add an integration test.

Differential Revision: https://phabricator.services.mozilla.com/D157988
 2022-09-26 18:43:31 +00:00
Narcis Beleuzu
95ae6b7d0f Backed out changeset 849faf753208 (bug 1792398) for bc failures on browser_sendQuery.js . CLOSED TREE 2022-09-26 20:44:40 +03:00
Mark Banner
ff212fab8b Bug 1792398 - Enable ESLint rule 'strict' on mjs files as the directive is not necessary for modules. r=arai,pip-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D158115
 2022-09-26 16:51:10 +00:00
Sam Foster
9bd8844f3d Bug 1780236 - Tighen up the spacing between section header, description and lists in fx-view. r=sclements 
Differential Revision: https://phabricator.services.mozilla.com/D157868
 2022-09-23 16:09:07 +00:00
Shane Hughes
2e20c34814 Bug 1791649 - Add tests for Firefox View Spotlight promo. r=pdahiya 
Differential Revision: https://phabricator.services.mozilla.com/D157756
 2022-09-23 01:32:49 +00:00
Kelly Cochrane
6a3fd20663 Bug 1791707 - Check for tablets when showing Fx View mobile promo r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D157936
 2022-09-22 18:45:53 +00:00
Kelly Cochrane
e1313c43f7 Bug 1789826 - Update z-index of section headers to prevent focus ring from being obscured r=dao 
Differential Revision: https://phabricator.services.mozilla.com/D157664
 2022-09-22 17:28:35 +00:00
Kelly Cochrane
bc0dc089e8 Bug 1790714 - Set Tab pickup open state pref to true when signing in r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D157857
 2022-09-22 13:39:10 +00:00
Shane Hughes
9a941ec9d1 Bug 1790888 - Add some HCM styles for Firefox View. r=Gijs 
Apply the usual HCM hover style to buttons in Firefox View, but also
override some of the custom properties for HCM so that Emily's patch for
bug 1790396 can use the same custom properties for feature callout hover
styles that we use in system content generally.

Differential Revision: https://phabricator.services.mozilla.com/D157364
 2022-09-21 23:22:30 +00:00
Sam Foster
c222a61eb4 Bug 1791652 - Wait for setup to be hidden before checking for tabs container properties in test. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D157859
 2022-09-21 22:59:24 +00:00
Bernard Igiri
758c474634 Bug 1785274 - Changed container of Fx View logo and title to a non-navigational tag r=sclements 
Replaced tag containing Fx View logo and title with a non-navigational tag, so that screen readers do not announce it as a navigational element.

Differential Revision: https://phabricator.services.mozilla.com/D157260
 2022-09-21 12:37:16 +00:00
Punam Dahiya
a223d61beb Bug 1790835 - Add Intro Spotlight Modal Screen to Feature Tour r=Mardak 
Differential Revision: https://phabricator.services.mozilla.com/D157691
 2022-09-20 20:31:36 +00:00
hanna alemu
c326560584 Bug 1783684 - Suggest Firefox View with a CFR panel for users who have closed tabs but haven't opened it r=Mardak 
Differential Revision: https://phabricator.services.mozilla.com/D156588
 2022-09-20 19:39:02 +00:00
Sam Foster
51a14bac68 Bug 1787619 - Handle primary password and sync login errors. r=Gijs,markh 
* Show the error state when the Primary Password is locked and the user is signed-in
* Trigger a tab sync when the  user clicks the "try again" button from the setup error step.
  This will also result in an unlock prompt if the primary password is locked.

Differential Revision: https://phabricator.services.mozilla.com/D156360
 2022-09-20 17:58:08 +00:00
Noemi Erli
9a3ab27e92 Backed out changeset 9239a20afb93 (bug 1787619) for causing failures in browser_setup_errors.js CLOSED TREE 2022-09-20 20:07:29 +03:00
Sam Foster
bb6c2d9701 Bug 1787619 - Handle primary password and sync login errors. r=Gijs,markh 
* Show the error state when the Primary Password is locked and the user is signed-in
* Trigger a tab sync when the  user clicks the "try again" button from the setup error step.
  This will also result in an unlock prompt if the primary password is locked.

Differential Revision: https://phabricator.services.mozilla.com/D156360
 2022-09-20 15:49:45 +00:00
Dão Gottwald
308590ef34 Bug 1789022 - Insert tabs opened from Firefox View at the beginning of the tab strip. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D157724
 2022-09-20 13:50:34 +00:00
Kelly Cochrane
6904dbb905 Bug 1790110 - Removing margin bottom for Colorways figure on smaller screens r=dao 
Differential Revision: https://phabricator.services.mozilla.com/D157647
 2022-09-19 14:59:51 +00:00
Cosmin Sabou
4d2a07b5af Backed out changeset 4eed140eab3f (bug 1783684) for causing several bc failures. CLOSED TREE 2022-09-18 20:04:16 +03:00
hanna alemu
bd65360b11 Bug 1783684 - Suggest Firefox View with a CFR panel for users who have closed tabs but haven't opened it r=Mardak 
Differential Revision: https://phabricator.services.mozilla.com/D156588
 2022-09-18 16:01:11 +00:00
Sebastian Hengst
978e5f920c Bug 1791097 - update default bugzilla component for Firefox View files. r=Gijs DONTBUILD 
Component got added to Bugzilla in bug 1780070.

Differential Revision: https://phabricator.services.mozilla.com/D157527
 2022-09-15 22:32:09 +00:00
Sam Foster
a78fec7c03 Bug 1789885 - Show the loading message only when we have no recent synced tabs data and no tab sync has completed yet r=Gijs,markh 
* Remove the synced-tabs-not-ready state and instead make a waitingForTabs boolean the container can check when updating
* Refactor around the maybeUpdateUI so we either pass in a force-update param, or conditionally send
  the notification if the state changes
* Observe 'services.sync.tabs.changed' instead of the pref which gets updated as a side-effect of a
  tab sync
* Check recent tabs via SyncedTabs.jsm in TabsSetupFlowManager and queue up SyncedTabs.syncTabs() and refreshDevices() calls when the user signs in.

Differential Revision: https://phabricator.services.mozilla.com/D156997
 2022-09-15 21:58:43 +00:00
Dan Mosedale
39c12bfdc2 Bug 1790651 - place focus better on feature callout close, r=ayeddi,emcminn 
When the user moves focus outside of a callout popup while it's open, this patch tracks and saves the most recently focused element until the focus moves back to the popup. Once the user exits the callout series, the focus is (visibly) placed back where the user last left it.

Differential Revision: https://phabricator.services.mozilla.com/D157398
 2022-09-15 19:11:19 +00:00
Cieara Meador
5a74791af6 Bug 1785736 - Progress bar HCM palette changes r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D157370
 2022-09-15 14:30:35 +00:00
Meg Viar
0096bcb2fa Bug 1790321 - Ensure that the Firefox View feature tour is displayed when users already have tab sync enabled r=jprickett 
Differential Revision: https://phabricator.services.mozilla.com/D157163
 2022-09-14 21:33:29 +00:00
Shane Hughes
5b7b6ec7d7 Bug 1788754 - Add a primary CTA to the tab pickup message. r=mviar 
Differential Revision: https://phabricator.services.mozilla.com/D157066
 2022-09-14 19:54:38 +00:00
Jared Hirsch
0ca0f19c16 Bug 1779384 - Persist collapsed state of Firefox View lists r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D156754
 2022-09-14 17:18:35 +00:00
Sarah Clements
e04c7ffb66 Bug 1787979 - keyboard shortcut navigates to the wrong tab from Firefox View tab r=dao 
* Remove index: 0 in FirefoxViewHandler.openTab
* Add condition in tabbrowser _selectNextTab for FirefoxView tab
* Fix tests

Differential Revision: https://phabricator.services.mozilla.com/D156688
 2022-09-14 15:20:01 +00:00
Marian-Vasile Laza
2e7d3531bc Backed out changeset 9bf0a16672ec (bug 1787979) for causing bc failures on browser_sma_click_element.js. CLOSED TREE 2022-09-14 16:45:04 +03:00
Sarah Clements
26d455d485 Bug 1787979 - keyboard shortcut navigates to the wrong tab from Firefox View tab r=dao 
* Remove index: 0 in FirefoxViewHandler.openTab
* Add condition in tabbrowser _selectNextTab for FirefoxView tab
* Fix tests

Differential Revision: https://phabricator.services.mozilla.com/D156688
 2022-09-14 11:24:58 +00:00
Gijs Kruitbosch
d4092a7277 Bug 1790074 - default to showing warning logs only for fxview tabs-setup-manager, r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D157255
 2022-09-14 09:50:59 +00:00
Sandor Molnar
e5de5b30e6 Backed out changeset dd71b6e79551 (bug 1779384) for causing browser-chrome failures in browser/components/firefoxview/tests/browser/browser_recently_closed_tabs.js CLOSED TREE 2022-09-14 04:59:04 +03:00
Jared Hirsch
e2d8d3f927 Bug 1779384 - Persist collapsed state of Firefox View lists r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D156754
 2022-09-13 23:18:34 +00:00