corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
796,093 Commits 1 Branch 0 Tags
f4139c1440af43fae4bc901b40e80d1028d2738c
Commit Graph

585 Commits

Author SHA1 Message Date
Kelly Cochrane
9e73c55f7b Bug 1792017 - Prevent ability to multiselect hidden tabs such as Fx View r=sclements 
Differential Revision: https://phabricator.services.mozilla.com/D167306
 2023-01-23 14:44:23 +00:00
Meg Viar
04e1d3b419 Bug 1806425 - Make value of source in Feature Callout and page in its telementry more consistent r=jprickett,aminomancer 
Unify the values of "source" and "page" as used in FeatureCallout.sys.mjs:
- Explicitly pass in a value for "page" when instantiating a Feature Callout and use this for the value of "page" when sending Feature Callout telemetry and as the "source" when making calls to `sendTriggerMessage`. This avoids the risk of including non-about: page URLs or PDF file extensions in our telemetry.
- Set the value of "page" in an HTML data attribute that can be accessed for use in about:welcome telemetry for Spotlight and Feature Callouts.
- Update references to the page value previously used as the page/source for telemetry from `about:firefoxview` Feature Callouts from "firefoxview"  to "about:firefoxview"
- Pass the token "chrome" when creating a callout from the browser chrome and update references to the source in PDF.js messages' targeting
- Update the page value expected in automated tests as needed

Differential Revision: https://phabricator.services.mozilla.com/D165910
 2023-01-20 16:53:30 +00:00
Kelly Cochrane
522db5de48 Bug 1796409 - Don't display synced tabs with duplicate URLs unless it's the most recently accessed instance r=sclements,markh 
Differential Revision: https://phabricator.services.mozilla.com/D166579
 2023-01-20 16:37:14 +00:00
Gijs Kruitbosch
5a903703c5 Bug 1810995 - update BrowserTestUtils.loadURI consumers to use loadURIString (automated) - browser - r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D167153
 2023-01-19 20:16:42 +00:00
Shane Hughes
8c9da4944a Bug 1810653 - Update feature callout position tests. r=jprickett 
Differential Revision: https://phabricator.services.mozilla.com/D166979
 2023-01-18 11:22:19 +00:00
Bernard Igiri
f996886057 Bug 1785268 - Prevent FxView subtitles from being announced as clickable by VO r=Gijs 
Changed the the section subtitles to heading tags so that VO will recognize them as part of the heading and not a separate clickable element.

Differential Revision: https://phabricator.services.mozilla.com/D165217
 2023-01-17 15:03:55 +00:00
Cosmin Sabou
bff0bdcee9 Bug 1784343 - disable browser_feature_callout_position and browser_firefoxview_feature_callout_a11y because of permafailures. a=test-only 2023-01-17 04:55:57 +02:00
Kelly Cochrane
7fdda39974 Bug 1804244 - Remove existing tabs in Recently Closed tabs list in Fx View if not found in latest closed tabs data r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D166208
 2023-01-12 20:20:55 +00:00
Norisz Fay
6a7b899764 Backed out changeset 2acf2ea39486 (bug 1804244) for causing failures on browser_recently_closed_tabs.js CLOSED TREE 2023-01-12 21:17:15 +02:00
Kelly Cochrane
89fd2e6fb8 Bug 1804244 - Remove existing tabs in Recently Closed tabs list in Fx View if not found in latest closed tabs data r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D166208
 2023-01-12 18:35:15 +00:00
Kelly Cochrane
e1f1276411 Bug 1801976 - Increase margin between Tab Pickup header and setup card to be consistent with Recently Closed section in Fx View r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D166217
 2023-01-10 20:34:47 +00:00
Kelly Cochrane
03dfada2e1 Bug 1802889 - Resolve Fx View mobile promo message being incorrectly shown when signing out of current FxA device r=Gijs 
There are two things I've added here:
  - The observers for when FxA devices are connected/disconnected were not added/removed as part of this update: https://phabricator.services.mozilla.com/D153069.
  - When a mobile device is the only synced device beyond the current one (desktop) and you remove the current device (desktop), then sign back in from Fx View Tab Pickup banner, `fxAccounts.device.recentDeviceList` only returns the mobile device for some reason (possibly due to device cache). This causes our checks for a secondary device to fail (as we now only have access to the mobile device from `recentDeviceList`, and we're assuming the one device we DO have access to is our current device - which is not the case). This is why Tab Pickup was incorrectly displaying the "Connect a mobile device" message. I've added a check at the start of `refreshDevices()` to manually refresh the device list (ignoring device cache) if the `recentDeviceList` doesn't contain a device with `isCurrentDevice` set to `true`. This is really a workaround for the caching stuff going on behind the scenes, but this does seem to fix things from our end.

Differential Revision: https://phabricator.services.mozilla.com/D165960
 2023-01-06 13:11:01 +00:00
Meg Viar
58cfaea214 Bug 1807850 - Firefox View feature reminder messages should not show within 24 hours of skipping feature tour r=aminomancer 
Depends on D164824

Differential Revision: https://phabricator.services.mozilla.com/D165629
 2022-12-30 20:41:44 +00:00
Jason Prickett
9d80e97429 Bug 1805413 - Implement relative position for feature callout positioning overrides r=mviar 
Differential Revision: https://phabricator.services.mozilla.com/D164628
 2022-12-29 20:50:48 +00:00
Meg Viar
79eec33848 Bug 1805930 - Change featureCallout.mjs to featureCallout.sys.mjs and update all references to filename r=barret,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D164824
 2022-12-29 14:27:02 +00:00
Mark Banner
df47c60747 Bug 1806359 - Convert telemetry imports to direct ES imports. r=necko-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,janerik,mconley,sgalich,bytesized,kershaw 
Differential Revision: https://phabricator.services.mozilla.com/D165002
 2022-12-23 12:37:07 +00:00
Cristian Tuns
b20d6daa49 Backed out 2 changesets (bug 1805413, bug 1805385) for causing mochitest failures CLOSED TREE 
Backed out changeset 9010e3c9421e (bug 1805385)
Backed out changeset c168847136ae (bug 1805413)
 2022-12-21 21:47:33 -05:00
Jason Prickett
e499ffdb98 Bug 1805385 - Flip direction of absolutely positioned feature callout in RTL layouts r=mviar 
Depends on D164628

Differential Revision: https://phabricator.services.mozilla.com/D164592
 2022-12-22 01:53:49 +00:00
Jason Prickett
c184d1652c Bug 1805413 - Implement relative position for feature callout positioning overrides r=mviar 
Differential Revision: https://phabricator.services.mozilla.com/D164628
 2022-12-22 01:53:49 +00:00
Stanca Serban
eb72a57ac6 Backed out changeset a92af276c945 (bug 1805930) for causing bustages in packager.mk. CLOSED TREE 2022-12-19 21:41:40 +02:00
Meg Viar
2cf660435c Bug 1805930 - Change featureCallout.mjs to FeatureCallout.sys.mjs and update all references to filename r=barret 
Differential Revision: https://phabricator.services.mozilla.com/D164824
 2022-12-19 18:55:05 +00:00
Sam Foster
e4876baab3 Bug 1805391 - Ensure support links get their hrefs populated. r=sclements 
Differential Revision: https://phabricator.services.mozilla.com/D164926
 2022-12-19 10:42:57 +00:00
Kelly Cochrane
c2dc105999 Bug 1802902 - Correct HCM text/background colors for Tab Pickup and Recently Closed headers of Fx View r=sfoster,ayeddi 
Differential Revision: https://phabricator.services.mozilla.com/D164711
 2022-12-16 17:19:45 +00:00
prathikshaprasadsuman
412010c031 Bug 1789533 - Improve title text (tooltips) experience in Firefox View. r=sclements 
Differential Revision: https://phabricator.services.mozilla.com/D164460
 2022-12-14 21:39:00 +00:00
Bernard Igiri
412503fb9c Bug 1799393 - Prevent hidden Fx View tab from triggering the closing multiple tabs warning in Windows and Linux r=Gijs 
Updated the tab closing prompt logic to use the number of visible tabs open to determine if the prompt should show in Windows and Linux.

Differential Revision: https://phabricator.services.mozilla.com/D162627
 2022-12-13 14:27:17 +00:00
Kelly Cochrane
d101839611 Bug 1804055 - Part 2: Update grid columns for recently closed tabs in Fx View to ensure vertical alignment r=sclements 
Differential Revision: https://phabricator.services.mozilla.com/D164221
 2022-12-08 17:11:24 +00:00
Sam Foster
1cf1592081 Bug 1803505 - Simplify the tab-pickup-container initialization. r=sclements 
* Adds a promise that resolves when the tab-pickup-list is ready
* Use that promise to trigger tab data request for the list when we enter the setup-complete state
* Remove the workarounds for overlapping setup and tabs requests

Differential Revision: https://phabricator.services.mozilla.com/D163750
 2022-12-07 16:42:19 +00:00
Meg Viar
78633c6857 Bug 1804309 - [Cleanup] Set default value of browser.pdfjs.feature-tour to have a message id of empty string r=hanna_a 
Cleanup patch to set the default value of the PDF.js feature tour pref to an empty string - this screen ID will be updated via Nimbus for treatment branches in the PDF.js annotation experiment

Bonus - updating a check that currently compares two objects rather than their ids. This update should not effect behavior for users but will ensure we don't bother with rerendering the callout with the same message.

Differential Revision: https://phabricator.services.mozilla.com/D163980
 2022-12-07 16:17:58 +00:00
Kelly Cochrane
60c2e8256e Bug 1804099 - Add new telemetry event for recording tab dismissal from Recently Closed tabs in Fx View r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D163878
 2022-12-07 15:05:13 +00:00
Kelly Cochrane
86e0ba2b73 Bug 1803794 - Align dismiss button of Recently Closed tabs in Fx View to the center to prevent varying height r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D163728
 2022-12-07 12:34:57 +00:00
Kelly Cochrane
ce8b710319 Bug 1804055 - Update column size for recently closed tabs in Fx View to ensure vertical alignment r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D163848
 2022-12-06 23:37:35 +00:00
Jason Prickett
a880490eae Bug 1803660 - Hide and show feature callout surface when tabs are changed r=mviar 
Depends on D163639

Differential Revision: https://phabricator.services.mozilla.com/D163642
 2022-12-06 23:22:50 +00:00
Noemi Erli
38df0ec770 Backed out changeset ab219eb65432 (bug 1803660) for causing failures in /browser_newtab_ping.js CLOSED TREE 2022-12-06 22:29:16 +02:00
Jason Prickett
fd2e0452f9 Bug 1803660 - Hide and show feature callout surface when tabs are changed r=mviar 
Depends on D163639

Differential Revision: https://phabricator.services.mozilla.com/D163642
 2022-12-06 19:27:40 +00:00
Shane Hughes
3e873bc26b Bug 1803983 - Refactor feature callout code. r=mviar 
Differential Revision: https://phabricator.services.mozilla.com/D163798
 2022-12-06 16:04:28 +00:00
Gijs Kruitbosch
965c6e86fc Bug 1803158 - convert session restore consumers to reference the sys.mjs files instead, r=webdriver-reviewers,perftest-reviewers,extension-reviewers,credential-management-reviewers,Standard8,sgalich,whimboo,sparky,willdurand 
Differential Revision: https://phabricator.services.mozilla.com/D163350
 2022-12-06 16:02:03 +00:00
Sarah Clements
83cc18d749 Bug 1794610 - Change error state for password change r=sfoster,kcochrane,fluent-reviewers,flod 
* Add new strings and add a new signed-out error type
* Update tests

Differential Revision: https://phabricator.services.mozilla.com/D162275
 2022-12-06 14:30:39 +00:00
Mark Striemer
d68bb36f24 Bug 1780237 - Align firefoxview arrows and cards r=sclements 
Differential Revision: https://phabricator.services.mozilla.com/D161819
 2022-12-05 17:08:35 +00:00
Shane Hughes
96765efb25 Bug 1799195 - Adjust feature callout resize test window sizes. r=mviar 
Differential Revision: https://phabricator.services.mozilla.com/D163797
 2022-12-05 15:38:55 +00:00
Meg Viar
6f631b5ce5 Bug 1803654 - Update PDF.js annotation Feature Callout messages to include both treatment branches r=jprickett 
Differential Revision: https://phabricator.services.mozilla.com/D163639
 2022-12-02 20:27:20 +00:00
Cosmin Sabou
cd11fb3af8 Backed out changeset 988063d03a9e (bug 1803654) for causing Talos crashes on pdfpaint. 2022-12-03 02:18:56 +02:00
Meg Viar
4a255de9fe Bug 1803654 - Update PDF.js annotation Feature Callout messages to include both treatment branches r=jprickett 
Differential Revision: https://phabricator.services.mozilla.com/D163639
 2022-12-02 20:27:20 +00:00
Kelly Cochrane
d989c8bc35 Bug 1803763 - Add title attribute to recently closed tab dismiss button r=dao,fluent-reviewers,flod 
Differential Revision: https://phabricator.services.mozilla.com/D163719
 2022-12-02 19:31:45 +00:00
Stanca Serban
fb83fffbb8 Backed out changeset 6c9b61f0bdaf (bug 1803763) for causing bc failures on browser_recently_closed_tabs.js. CLOSED TREE 2022-12-02 19:34:20 +02:00
Kelly Cochrane
085abb39b4 Bug 1803763 - Add title attribute to recently closed tab dismiss button r=dao,fluent-reviewers,flod 
Differential Revision: https://phabricator.services.mozilla.com/D163719
 2022-12-02 16:06:53 +00:00
Anna Yeddi
cc13332459 Bug 1800982 - Improve HCM support on macOS for Last Active badge background in Fx View. r=sfoster,desktop-theme-reviewers 
Ensuring that on macOS users of `Increase Contrast` mode get high contrast combination of the text and background for the `Last active` badge.

Differential Revision: https://phabricator.services.mozilla.com/D163014
 2022-12-01 22:51:52 +00:00
Greg Tatum
b9cd5fa6a0 Bug 1685180 - Ensure tests all properly set fluent args; r=nordzilla,settings-reviewers,Gijs 
Either provide the dynamic data correctly in tests, or provide empty
strings when it doesn't exist.

Differential Revision: https://phabricator.services.mozilla.com/D162336
 2022-12-01 21:40:57 +00:00
Shane Hughes
db26095c40 Bug 1795288 - Feature Callouts: add dismiss telemetry. r=mviar 
Differential Revision: https://phabricator.services.mozilla.com/D163531
 2022-12-01 16:42:18 +00:00
Hanna Jones
c238132e26 Bug 1788800 - run colorways card tests in the same window take two r=sfoster 
This patch completes what I tried to do in D162617. Poking around at this again I realized (embarassingly) that I forgot to change one test to run in the same window, and it was the test that failed consistently on try when run in isolation.

Based on the profile Florian helped me look at it seemed like we had a window leak and were possibly still trying to run animations in a window that had been closed. It  feels plausible that going back to what we were doing before my initial change - running all the tests in the same window and only closing that window once they had all finished - might still be the fix for this intermittent.

Recent try push looked good: https://treeherder.mozilla.org/jobs?repo=try&revision=3836fc6ceeb2f9c522a2d2a0126f6bdc9aea1bb6&selectedTaskRun=arwidi8RROCcJkUY-hMg1g.0

Compared to running similar jobs without this one change: https://treeherder.mozilla.org/jobs?repo=try&revision=8c2345419537e5465104edfd29c270496db90cef

Differential Revision: https://phabricator.services.mozilla.com/D163476
 2022-11-30 21:24:16 +00:00
Kelly Cochrane
bacaafe92b Bug 1787945 - Add dismiss functionality to recently closed tabs list items in Fx View r=ayeddi,sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D161848
 2022-11-30 16:24:15 +00:00