corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
872,378 Commits 1 Branch 0 Tags
b068dcffb1324b82fb2cfab5454360760cb15f45
Commit Graph

585 Commits

Author SHA1 Message Date
Tim Giles
9c4d623be8 Bug 1792680 - Fix Firefox View not being a reloadable tab. r=dao 
Differential Revision: https://phabricator.services.mozilla.com/D159212
 2022-10-13 14:28:16 +00:00
Sarah Clements
afeab23b18 Bug 1785853 - Close device connected tab after user returns to Firefox View r=sfoster 
* Add _closeDeviceConnectedTab to FirefoxViewHandler that's called by the TabSelect event handler
* Add test coverage

Differential Revision: https://phabricator.services.mozilla.com/D158031
 2022-10-12 16:39:39 +00:00
Norisz Fay
f7de136a6d Backed out changeset 9b1e2e6ceb70 (bug 1785853) for causing mochitest failures on browser_setup_state.js CLOSED TREE 2022-10-12 17:50:02 +03:00
Sarah Clements
bf8716d193 Bug 1785853 - Close device connected tab after user returns to Firefox View r=sfoster 
* Add _closeDeviceConnectedTab to FirefoxViewHandler that's called by the TabSelect event handler
* Add test coverage

Differential Revision: https://phabricator.services.mozilla.com/D158031
 2022-10-12 13:26:41 +00:00
Sarah Clements
233f73e5bd Bug 1793754 - Fix sync error when user disconnects a device r=sfoster 
* Only show sync error if user is not signed in and give them a way out when try again button is clicked

Differential Revision: https://phabricator.services.mozilla.com/D158972
 2022-10-12 10:12:36 +00:00
Marian-Vasile Laza
b853119e5f Backed out changeset d6922083e8a9 (bug 1788996) for causing bc failures on browser_feature_callout.js. CLOSED TREE 2022-10-12 02:37:47 +03:00
Jason Prickett
167ac274a4 Bug 1788996 - Add telemetry call when feature callout parent doesn't exist r=mviar 
Differential Revision: https://phabricator.services.mozilla.com/D157750
 2022-10-11 22:45:02 +00:00
Kelly Cochrane
1a02174385 Bug 1792099 - Allow for text selection in Recently Closed Tabs when holding Alt/Opt key r=Gijs,sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D158708
 2022-10-11 21:47:16 +00:00
Bernard Igiri
3d983163c2 Bug 1794481 - Updated browser_media_query_dom_sorting.js test to use withFirefoxView function. r=Gijs 
Updated browser_media_query_dom_sorting.js test to use withFirefoxView function.

Differential Revision: https://phabricator.services.mozilla.com/D158990
 2022-10-11 19:26:48 +00:00
Hanna Jones
92d8095a44 Bug 1789982 - handle case where sync is connected but user is logged out r=sclements 
This patch adds logic to show an error when a user becomes disconnected due to changing their password on another device. We will now show the `sync-disconnected` error, which should direct the user to their sync settings where they can enter their new password/sign in again.

This patch also includes a test for this new error case, as well as some small changes to an existing test that started failing due to a slight mismatch between the UIState representation used in the test and the UIState we expect when a user logs out.

Differential Revision: https://phabricator.services.mozilla.com/D158043
 2022-10-11 18:34:24 +00:00
Meg Viar
c349d50364 Bug 1793660 - Allow feature callout to point to elements that are above and to its end r=jprickett 
Differential Revision: https://phabricator.services.mozilla.com/D158610
 2022-10-11 13:25:44 +00:00
Shane Hughes
2e181ef8b8 Bug 1788702 - Reduce feature callout test zoom factor. r=mviar 
Differential Revision: https://phabricator.services.mozilla.com/D158921
 2022-10-10 19:58:22 +00:00
Tim Giles
8bd3107d96 Bug 1792503 - Add keyboard toggle test for tab pickup list. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D158675
 2022-10-10 15:20:00 +00:00
Tim Giles
2e2a811fe0 Bug 1792503 - Add keyboard toggle test for recently closed tabs list. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D158674
 2022-10-10 15:20:00 +00:00
Bernard Igiri
bec652a910 Bug 1780239 - Fix screen reader order of Colorway Landmark in FxView r=Gijs 
Added dynamic DOM reordering to FX View so that the order of announcement in screen readers and tab sorting, matches the visual changes made by the responsive CSS layout.

Differential Revision: https://phabricator.services.mozilla.com/D157256
 2022-10-07 20:21:49 +00:00
Hanna Jones
1f3c5e627d Bug 1782583 - fix clientType in synced tabs mock r=Gijs 
It looks like the linked bug is caused by a different issue, but this still seemed worth fixing considering the mock data got moved to `head.js` and is being used in a few different test files now.

Differential Revision: https://phabricator.services.mozilla.com/D158705
 2022-10-07 13:22:32 +00:00
Sarah Clements
e0825872b3 Bug 1792191 - Fix the Turn on syncing to continue error state r=sfoster 
* Rename fxaSignedIn to fxaSignedInAndSyncEnabled to better reflect what its doing
* Re-enable the test_sync_disconnected_error test case and add another

Differential Revision: https://phabricator.services.mozilla.com/D158201
 2022-10-07 10:04:35 +00:00
Sam Foster
6ac7e4855e Bug 1791115 - Ensure we switch back to fx-view tab after removing the tab opened in test_time_updates_correctly. r=sclements 
Differential Revision: https://phabricator.services.mozilla.com/D158706
 2022-10-06 19:37:46 +00:00
Shane Hughes
50150eeff7 Bug 1788702 - Fix feature callout accessibility test. r=mviar 
Differential Revision: https://phabricator.services.mozilla.com/D158553
 2022-10-05 00:10:40 +00:00
Norisz Fay
f9c8a126ea Backed out changeset de7440f21f9a (bug 1788996) for causing mochitest failures on browser_feature_callout.js CLOSED TREE 2022-10-04 22:22:24 +03:00
Angel_V129
e3be76313a Bug 1788756 - [Themes] Convert browser/theme JSM modules to ESMs. r=kpatenio 
Differential Revision: https://phabricator.services.mozilla.com/D157037
 2022-10-04 19:02:24 +00:00
Jason Prickett
b899f0a12e Bug 1788996 - Add telemetry call when feature callout parent doesn't exist r=mviar 
Differential Revision: https://phabricator.services.mozilla.com/D157750
 2022-10-04 18:37:02 +00:00
Shane Hughes
a8178cd2f3 Bug 1790819 - Feature callouts: more overflow protection. r=mviar 
Try to keep feature callouts within the viewport if possible. Make some
changes to fix a bug where callouts could overflow ~10px over the
available space before being repositioned, and also fix a minor typo
issue. Choose the backup position with the greatest available space
instead of based on the position's order in the `positions` object.

Differential Revision: https://phabricator.services.mozilla.com/D157688
 2022-10-04 07:56:34 +00:00
Csoregi Natalia
d301388c8f Backed out changeset d91a621a39be (bug 1785853) for multiple failures e.g.browser_setup_state.js CLOSED TREE 2022-10-03 19:48:44 +03:00
Sarah Clements
f13f2edf01 Bug 1785853 - Close device connected tab after user returns to Firefox View r=sfoster 
* Add _closeDeviceConnectedTab to FirefoxViewHandler that's called by the TabSelect event handler
* Add test coverage

Differential Revision: https://phabricator.services.mozilla.com/D158031
 2022-10-03 16:07:54 +00:00
Dão Gottwald
474fd7d31f Bug 1792814 - Don't load the home page in hidden tabs such as Firefox View. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D158396
 2022-09-30 20:04:37 +00:00
Shane Hughes
1577034f2f Bug 1791770 - Prevent add-ons from showing Fx View tab. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D158009
 2022-09-26 19:33:52 +00:00
Dan Mosedale
d86e156394 Bug 1791873 - fix FxView sync-setup-container kbd access,r=Gijs 
Backout tabIndex changes that caused the problem and add an integration test.

Differential Revision: https://phabricator.services.mozilla.com/D157988
 2022-09-26 18:43:31 +00:00
Shane Hughes
2e20c34814 Bug 1791649 - Add tests for Firefox View Spotlight promo. r=pdahiya 
Differential Revision: https://phabricator.services.mozilla.com/D157756
 2022-09-23 01:32:49 +00:00
Kelly Cochrane
6a3fd20663 Bug 1791707 - Check for tablets when showing Fx View mobile promo r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D157936
 2022-09-22 18:45:53 +00:00
Sam Foster
c222a61eb4 Bug 1791652 - Wait for setup to be hidden before checking for tabs container properties in test. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D157859
 2022-09-21 22:59:24 +00:00
Punam Dahiya
a223d61beb Bug 1790835 - Add Intro Spotlight Modal Screen to Feature Tour r=Mardak 
Differential Revision: https://phabricator.services.mozilla.com/D157691
 2022-09-20 20:31:36 +00:00
hanna alemu
c326560584 Bug 1783684 - Suggest Firefox View with a CFR panel for users who have closed tabs but haven't opened it r=Mardak 
Differential Revision: https://phabricator.services.mozilla.com/D156588
 2022-09-20 19:39:02 +00:00
Sam Foster
51a14bac68 Bug 1787619 - Handle primary password and sync login errors. r=Gijs,markh 
* Show the error state when the Primary Password is locked and the user is signed-in
* Trigger a tab sync when the  user clicks the "try again" button from the setup error step.
  This will also result in an unlock prompt if the primary password is locked.

Differential Revision: https://phabricator.services.mozilla.com/D156360
 2022-09-20 17:58:08 +00:00
Noemi Erli
9a3ab27e92 Backed out changeset 9239a20afb93 (bug 1787619) for causing failures in browser_setup_errors.js CLOSED TREE 2022-09-20 20:07:29 +03:00
Sam Foster
bb6c2d9701 Bug 1787619 - Handle primary password and sync login errors. r=Gijs,markh 
* Show the error state when the Primary Password is locked and the user is signed-in
* Trigger a tab sync when the  user clicks the "try again" button from the setup error step.
  This will also result in an unlock prompt if the primary password is locked.

Differential Revision: https://phabricator.services.mozilla.com/D156360
 2022-09-20 15:49:45 +00:00
Dão Gottwald
308590ef34 Bug 1789022 - Insert tabs opened from Firefox View at the beginning of the tab strip. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D157724
 2022-09-20 13:50:34 +00:00
Cosmin Sabou
4d2a07b5af Backed out changeset 4eed140eab3f (bug 1783684) for causing several bc failures. CLOSED TREE 2022-09-18 20:04:16 +03:00
hanna alemu
bd65360b11 Bug 1783684 - Suggest Firefox View with a CFR panel for users who have closed tabs but haven't opened it r=Mardak 
Differential Revision: https://phabricator.services.mozilla.com/D156588
 2022-09-18 16:01:11 +00:00
Sam Foster
a78fec7c03 Bug 1789885 - Show the loading message only when we have no recent synced tabs data and no tab sync has completed yet r=Gijs,markh 
* Remove the synced-tabs-not-ready state and instead make a waitingForTabs boolean the container can check when updating
* Refactor around the maybeUpdateUI so we either pass in a force-update param, or conditionally send
  the notification if the state changes
* Observe 'services.sync.tabs.changed' instead of the pref which gets updated as a side-effect of a
  tab sync
* Check recent tabs via SyncedTabs.jsm in TabsSetupFlowManager and queue up SyncedTabs.syncTabs() and refreshDevices() calls when the user signs in.

Differential Revision: https://phabricator.services.mozilla.com/D156997
 2022-09-15 21:58:43 +00:00
Dan Mosedale
39c12bfdc2 Bug 1790651 - place focus better on feature callout close, r=ayeddi,emcminn 
When the user moves focus outside of a callout popup while it's open, this patch tracks and saves the most recently focused element until the focus moves back to the popup. Once the user exits the callout series, the focus is (visibly) placed back where the user last left it.

Differential Revision: https://phabricator.services.mozilla.com/D157398
 2022-09-15 19:11:19 +00:00
Meg Viar
0096bcb2fa Bug 1790321 - Ensure that the Firefox View feature tour is displayed when users already have tab sync enabled r=jprickett 
Differential Revision: https://phabricator.services.mozilla.com/D157163
 2022-09-14 21:33:29 +00:00
Shane Hughes
5b7b6ec7d7 Bug 1788754 - Add a primary CTA to the tab pickup message. r=mviar 
Differential Revision: https://phabricator.services.mozilla.com/D157066
 2022-09-14 19:54:38 +00:00
Jared Hirsch
0ca0f19c16 Bug 1779384 - Persist collapsed state of Firefox View lists r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D156754
 2022-09-14 17:18:35 +00:00
Sarah Clements
e04c7ffb66 Bug 1787979 - keyboard shortcut navigates to the wrong tab from Firefox View tab r=dao 
* Remove index: 0 in FirefoxViewHandler.openTab
* Add condition in tabbrowser _selectNextTab for FirefoxView tab
* Fix tests

Differential Revision: https://phabricator.services.mozilla.com/D156688
 2022-09-14 15:20:01 +00:00
Marian-Vasile Laza
2e7d3531bc Backed out changeset 9bf0a16672ec (bug 1787979) for causing bc failures on browser_sma_click_element.js. CLOSED TREE 2022-09-14 16:45:04 +03:00
Sarah Clements
26d455d485 Bug 1787979 - keyboard shortcut navigates to the wrong tab from Firefox View tab r=dao 
* Remove index: 0 in FirefoxViewHandler.openTab
* Add condition in tabbrowser _selectNextTab for FirefoxView tab
* Fix tests

Differential Revision: https://phabricator.services.mozilla.com/D156688
 2022-09-14 11:24:58 +00:00
Gijs Kruitbosch
d4092a7277 Bug 1790074 - default to showing warning logs only for fxview tabs-setup-manager, r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D157255
 2022-09-14 09:50:59 +00:00
Sandor Molnar
e5de5b30e6 Backed out changeset dd71b6e79551 (bug 1779384) for causing browser-chrome failures in browser/components/firefoxview/tests/browser/browser_recently_closed_tabs.js CLOSED TREE 2022-09-14 04:59:04 +03:00
Jared Hirsch
e2d8d3f927 Bug 1779384 - Persist collapsed state of Firefox View lists r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D156754
 2022-09-13 23:18:34 +00:00