From what I can tell switching to `withFirefoxView` and opening a new window to run these tests in + closing that window before disabling the theme messed with the timing of these tests in such a way that we started getting that vsync error shown in the logs. I've switched to running all these tests in the same window, which looks good from a couple of try pushes:
https://treeherder.mozilla.org/jobs?repo=try&revision=9a5f379ecc48bda08eab67210278b547f558f856https://treeherder.mozilla.org/jobs?repo=try&revision=76b909924455fda54165ffeaa00b3654b4decd09
I'll file a follow up bug to change the default behaviour of `withFirefoxView` is to run tests in the same window, as this has come up before.
Also worth noting that even if this patch lands and fixes the new frequent intermittent we will likely still see the less frequent intermittents that happened prior to the change for Bug 1780441.
Differential Revision: https://phabricator.services.mozilla.com/D162617
The switch to using `withFirefoxView` caused another onboarding prompt to show. After the fx view tabstrip button has been clicked for the 3rd time we display a new message. This wasn't happening before because the pref that controls this is tied to that button click, so didn't get incremented when we were opening about:firefoxview in a new tab.
Differential Revision: https://phabricator.services.mozilla.com/D162427
Changed the aria role from tab to button to fix the VO announcement so that it correctly reports when the Fx View tab is actually selected.
Differential Revision: https://phabricator.services.mozilla.com/D159887
This commit moves the test_keyboard_accessibility task into the
firefoxview_accessibility test file.
Additionally, a shared variable and a cleanup function are moved to
head.js.
The cleanup function is renamed for clarity.
Differential Revision: https://phabricator.services.mozilla.com/D160961
This commit moves the "feature_callout_is_accessible" task to the
"browser_firefoxview_feature_callout_a11y" test.
This change required some additional refactoring as well, moving some
shared selectors and functions to head.js.
The waitForCalloutScreen function was refactored to take full string IDs
as there were multiple implementations of this function that conflicted
with each other.
This waitForCalloutScreen change also caused these tests to use an
explicit ID such as "FEATURE_CALLOUT_1" or
"FIREFOX_VIEW_COLORWAYS_REMINDER".
Differential Revision: https://phabricator.services.mozilla.com/D160957
I opted to add a pref and effectively disable things by default rather than
just removing everything, because it seems likely we'll want to re-introduce
this in some form at some point soon, plus this is a much smaller change to
uplift and keeps the test coverage for now, too.
Differential Revision: https://phabricator.services.mozilla.com/D159707
Add a new module and feature callout functions to support messages
performing actions when a specified event is dispatched from the
content. This will allow Feature Callout messages to be dismissed when a
button is clicked within the page in which they are rendered. A screen
just needs to provide a `page_event_listeners` property, which is an
array of objects, each containing event listener parameters (event type,
target selector, and optional parameters) and an action specification
like those already used for buttons. The event listener will be added to
all elements matching the selector, so multiple different buttons could
dismiss or advance the message, if necessary. The new screen property
has this form:
```
page_event_listeners: [
{
params: {
type: string,
selectors: string,
options?: {
capture?: boolean,
once?: boolean,
preventDefault?: boolean,
},
},
action: {
type?: string,
data?: object,
dismiss?: boolean,
etc...
},
},
]
```
Differential Revision: https://phabricator.services.mozilla.com/D158899
The "message" property of the pref "browser.firefox-view.feature-tour" seems to have no actual use, and only one value of "FIREFOX_VIEW_FEATURE_TOUR". We can remove it to reduce complexity.
Differential Revision: https://phabricator.services.mozilla.com/D159131
