corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
872,378 Commits 1 Branch 0 Tags
b068dcffb1324b82fb2cfab5454360760cb15f45
Commit Graph

585 Commits

Author SHA1 Message Date
Sammy Khamis
994493e803 Bug 1909783: Synced tabs list should de-dupe r=markh,fxview-reviewers,sync-reviewers,tabbrowser-reviewers,firefox-desktop-core-reviewers ,dao 
Differential Revision: https://phabricator.services.mozilla.com/D217700
 2024-07-26 20:31:03 +00:00
Sandor Molnar
94a8e09b3e Bug 1880113 - Disable browser_firefoxview_search_telemetry.js on linux for frequent failures. r=fxview-reviewers,nsharpley DONTBUILD 
Differential Revision: https://phabricator.services.mozilla.com/D216512
 2024-07-17 13:25:05 +00:00
hanna alemu
d7c67f44bd Bug 1828508 - Clean up Firefox View Feature Tour + Notification r=omc-reviewers,fluent-reviewers,fxview-reviewers,nsharpley,bolsson,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D209404
 2024-06-11 18:24:35 +00:00
Sukhmeet
3ad327de7f Bug 1893013 - Remove browser.firefox-view.search.enabled preference r=kcochrane,fxview-reviewers,jsudiaman 
Differential Revision: https://phabricator.services.mozilla.com/D211353
 2024-06-03 15:12:53 +00:00
Jonathan Sudiaman
8dec778c2c Bug 1859774 - Add new Firefox View search component to Storybook r=kcochrane,fluent-reviewers,fxview-reviewers,reusable-components-reviewers,hjones 
Simplified debouncing logic to avoid depending on DeferredTask. Add missing `aria-label` which is needed for the edge case of showing a search box without placeholder.

Differential Revision: https://phabricator.services.mozilla.com/D210701
 2024-05-24 20:32:56 +00:00
Norisz Fay
f646873f96 Backed out changeset 223f467f78df (bug 1859774) for causing mochitest failures on test_fxview_search_textbox.html CLOSED TREE 2024-05-24 19:04:17 +03:00
Jonathan Sudiaman
dec03dc0a3 Bug 1859774 - Add new Firefox View search component to Storybook r=kcochrane,fluent-reviewers,fxview-reviewers,reusable-components-reviewers,hjones 
Simplified debouncing logic to avoid depending on DeferredTask. Add missing `aria-label` which is needed for the edge case of showing a search box without placeholder.

Differential Revision: https://phabricator.services.mozilla.com/D210701
 2024-05-24 15:16:26 +00:00
Sandor Molnar
a92ccd5e4d Backed out changeset 56007d13fdf6 (bug 1859774) for causing mochitest failures @ browser/components/firefoxview/tests/chrome/test_fxview_search_textbox.html CLOSED TREE 2024-05-24 00:46:06 +03:00
Jonathan Sudiaman
37a0386948 Bug 1859774 - Add new Firefox View search component to Storybook r=kcochrane,fluent-reviewers,fxview-reviewers,reusable-components-reviewers,hjones 
Simplified debouncing logic to avoid depending on DeferredTask. Add missing `aria-label` which is needed for the edge case of showing a search box without placeholder.

Differential Revision: https://phabricator.services.mozilla.com/D210701
 2024-05-23 20:20:03 +00:00
Jonathan Sudiaman
bc6869de58 Bug 1883231 - Don't update search results for a stale query in Firefox View. r=nsharpley,fxview-reviewers,places-reviewers,Standard8,sidebar-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D208946
 2024-05-09 13:34:37 +00:00
Jonathan Sudiaman
22ee9cc924 Bug 1887220 - Rework map computations in history r=fxview-reviewers,places-reviewers,sidebar-reviewers,nsharpley,sclements 
- Consolidates `historyMapByDate`, `historyMapBySite`, and `searchResults` into one single `historyCache`, which represents all of the visits that should be rendered by the host and what options are currently in place.
- Converts `HistoryController` to a system level module.
- Adds preventative code to account for race conditions in cases during test verification.

Differential Revision: https://phabricator.services.mozilla.com/D207861
 2024-04-30 20:03:14 +00:00
Nikki Sharpley
048795cc79 Bug 1887237 - Intermittent TV browser/components/firefoxview/tests/browser/browser_firefoxview_paused.js r=fxview-reviewers,kcochrane 
- reduce number of tests in `browser_firefoxview_paused.js` to solve timeout issue

Differential Revision: https://phabricator.services.mozilla.com/D207453
 2024-04-17 20:02:08 +00:00
Kelly Cochrane
d6edc29a5a Bug 1873942 - Add test coverage for device connection and sync r=fxview-reviewers,nsharpley 
Differential Revision: https://phabricator.services.mozilla.com/D207750
 2024-04-17 20:00:35 +00:00
Anna Yeddi
48b41ed8f4 Bug 1884986 - Update tests to check for new ARIA roles. r=fxview-reviewers,sfoster. 
Depends on D206272

Differential Revision: https://phabricator.services.mozilla.com/D207488
 2024-04-16 23:57:19 +00:00
Nikki Sharpley
183b5d4b3c Bug 1851697 - Remove Firefox View button notification dot r=fxview-reviewers,desktop-theme-reviewers,dao,jsudiaman 
This was disabled in bug 1787980 so we needed to remove the obsolete code.

Differential Revision: https://phabricator.services.mozilla.com/D207473
 2024-04-16 22:02:52 +00:00
Kelly Cochrane
bba0403101 Bug 1873957 - Add missing test coverage for error states for Synced Tabs in Firefox View r=fxview-reviewers,nsharpley,sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D206956
 2024-04-11 15:45:31 +00:00
Sam Foster
3f160bb689 Bug 1888841 - Fix typo when passing sourceWindowId to SessionStore's forgetClosedTabById. r=fxview-reviewers,jsudiaman,kcochrane 
Differential Revision: https://phabricator.services.mozilla.com/D206431
 2024-04-09 22:59:27 +00:00
Yi Xiong Wong
bef11a2dc2 Bug 1880914 - Move browser/tab closing functions. r=Gijs,perftest-reviewers,devtools-reviewers,fxview-reviewers,sessionstore-reviewers,sfoster,kshampur 
Differential Revision: https://phabricator.services.mozilla.com/D206197
 2024-04-08 17:21:01 +00:00
Sam Foster
37f9d61967 Bug 1858460 - Include source events in OpenTabsTarget events and improve how we test the recency-sorted tab lists. r=fxview-reviewers,sclements 
* Include a list of source events in the debounced and consolidated change events dispatched by OpenTabsTarget
* Rework browser_opentabs_recency.js to use session restore for window and tab creation
* Eliminate some of the races in the test by waiting for the correct tab list state
* Re-enable the test for windows - it remains intermittent on macos and linux
* Add sizemodechange as a tab-recency-related event

Differential Revision: https://phabricator.services.mozilla.com/D206174
 2024-04-04 16:27:32 +00:00
Yi Xiong Wong
3df27d805a Bug 1880914 - Move BrowserOpenTab. r=Gijs,webdriver-reviewers,perftest-reviewers,extension-reviewers,sessionstore-reviewers,tabbrowser-reviewers,home-newtab-reviewers,thecount,whimboo,dao,afinder,omc-reviewers,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D205529
 2024-04-03 10:32:27 +00:00
Jonathan Sudiaman
da4a683e56 Bug 1861400 - Remove sync if disabled by policy r=fxview-reviewers,nsharpley,kcochrane 
Brings the Firefox View behavior in line with what is done in `browser-sync.js`.

Differential Revision: https://phabricator.services.mozilla.com/D205881
 2024-04-01 21:50:10 +00:00
Hanna Jones
f6c7368e07 Bug 1850037 - Part 2: Use moz-button to remove ghost button styles in fxview r=fxview-reviewers,desktop-theme-reviewers,reusable-components-reviewers,kcochrane,mstriemer,dao 
Differential Revision: https://phabricator.services.mozilla.com/D187932
 2024-04-01 16:08:41 +00:00
Yi Xiong Wong
9457049851 Bug 1880914 - Move BrowserHome. r=Gijs,extension-reviewers,sessionstore-reviewers,dao 
Differential Revision: https://phabricator.services.mozilla.com/D205528
 2024-03-28 17:05:02 +00:00
Jonathan Sudiaman
e1987c2eb6 Bug 1887647 - Tabs from other devices doesn't render on first load r=fxview-reviewers,nsharpley,sfoster 
Ensure that we always call `requestUpdate()` when needed.

Differential Revision: https://phabricator.services.mozilla.com/D205582
 2024-03-28 13:42:33 +00:00
Kelly Cochrane
c64a9447f3 Bug 1880542 - Refactor fxview-tab-list and fxview-tab-row r=sfoster,fxview-reviewers,jsudiaman 
Differential Revision: https://phabricator.services.mozilla.com/D205499
 2024-03-26 18:01:02 +00:00
Kelly Cochrane
d65e0d0ea0 Bug 1883876 - Update window list in Open Tabs in Fx View when moving a tab between windows r=fxview-reviewers,sclements,sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D203971
 2024-03-22 17:02:53 +00:00
Stanca Serban
766c9f922a Backed out changeset 319a405e8b57 (bug 1883876) for causing mochitests failures in browser_blanking.js. 2024-03-22 18:22:25 +02:00
Kelly Cochrane
7cc1085907 Bug 1883876 - Update window list in Open Tabs in Fx View when moving a tab between windows r=fxview-reviewers,sclements,sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D203971
 2024-03-22 14:02:18 +00:00
Sandor Molnar
ae3c7d9083 Backed out changeset 153aa2b4247f (bug 1883876) for causing multiple bc failures @ browser/components/firefoxview/<...> & browser/components/aboutwelcome/<...> 2024-03-21 21:46:22 +02:00
Kelly Cochrane
8b550e92b2 Bug 1883876 - Update window list in Open Tabs in Fx View when moving a tab between windows r=fxview-reviewers,sclements,sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D203971
 2024-03-21 18:44:36 +00:00
Jonathan Sudiaman
500347dd76 Bug 1880539 - Refactor firefoxview/syncedtabs.mjs to make business logic more reusable r=fxview-reviewers,nsharpley,sclements 
Decoupling complex business logic from UI components.

https://treeherder.mozilla.org/jobs?repo=try&revision=a65ebee15c1ef5f47411326b0c9ba2394e17d80f

Differential Revision: https://phabricator.services.mozilla.com/D204081
 2024-03-19 23:21:13 +00:00
Anna Yeddi
ffcc38c3ed Bug 1886114 - Remove fail-if notation from the Firefox View test passing a11y-checks. r=sfoster,fxview-reviewers 
the updated version of the Show More link activation has resolved the issue that was there before: the link used to be clicked when it still had `hidden` attribute on - probably, right before it was rendered as shown/un-hidden, since the test harness is moving too fast. In this updated case, all the instances of the Show More links being clicked while they are visible and, therefore, accessible for the Accessibility API. We could safely remove the `fail-if` since it's working now as expected

Differential Revision: https://phabricator.services.mozilla.com/D205151
 2024-03-19 23:07:42 +00:00
Sandor Molnar
ac42f14d15 Backed out changeset 2092d43bfaae (bug 1880539) for causing bc failures @ browser/components/firefoxview/tests/browser/<...> CLOSED TREE 2024-03-19 18:29:33 +02:00
Jonathan Sudiaman
4076b15f24 Bug 1880539 - Refactor firefoxview/syncedtabs.mjs to make business logic more reusable r=fxview-reviewers,nsharpley,sclements 
Decoupling complex business logic from UI components.

https://treeherder.mozilla.org/jobs?repo=try&revision=a65ebee15c1ef5f47411326b0c9ba2394e17d80f

Differential Revision: https://phabricator.services.mozilla.com/D204081
 2024-03-19 14:03:41 +00:00
Dave Townsend
a0c83bc943 Bug 1864896: Autofix unused function arguments (browser). r=webcompat-reviewers,mconley,fxview-reviewers,desktop-theme-reviewers,omc-reviewers,migration-reviewers,twisniewski,aminomancer,dao,sclements,firefox-desktop-core-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D203005
 2024-03-19 09:36:35 +00:00
Sam Foster
688e369bcf Bug 1877678 - Improve window switching in the opentabs cards tests. r=fxview-reviewers,sclements 
* Adds a new switchToWindow helper and calls it in openFirefoxViewTab to ensure we wait until the window is active
* Fix some fallout from this change in the browser_opentabs_recency.js test

Differential Revision: https://phabricator.services.mozilla.com/D201861
 2024-03-18 21:08:13 +00:00
Sam Foster
db523bd98e Bug 1877678 - Split out the some of the open tabs tests into their own file. r=fxview-reviewers,sclements 
Differential Revision: https://phabricator.services.mozilla.com/D202486
 2024-03-18 21:08:12 +00:00
Nikki Sharpley
c5dc18eeec Bug 1880540 - Refactor History component functionality into Lit controller r=fxview-reviewers,jsudiaman,sclements,hjones 
Extrapolate common history functionality to a controller that can be used across view and sidebar.
This includes the ability to delete from history, visit a link from history, sort by options, search history and format results.

Differential Revision: https://phabricator.services.mozilla.com/D202726
 2024-03-18 04:59:43 +00:00
Anna Yeddi
62176e33f3 Bug 1884278 - Add exceptions from a11y_checks for clicks on a not focusable pinned media button on Firefox View. r=kcochrane,fxview-reviewers 
The Firefox View tests, i.e. `browser/components/firefoxview/tests/browser/browser_opentabs_pinned_tabs.js:test_mute_unmute_pinned_tab` sends [a click on a pinned mute/unmute control](https://searchfox.org/mozilla-central/rev/b55a24116575b1b6c17f1aa56a0b142d86dfa41c/browser/components/firefoxview/tests/browser/browser_opentabs_pinned_tabs.js#324-325,341-342) that is intentionally made not focusable to follow the existent tab panel behavior.

A keyboard-only user could mute/unmute this pinned tab via the context menu, while we do not want to create an additional, unnecessary tabstop for this control as well. Thus we add an exception from the a11y_checks for this tests via `setEnv` and remove the `fail-if` notation from its test manifest.

Depends on D203987

Differential Revision: https://phabricator.services.mozilla.com/D203988
 2024-03-12 14:32:45 +00:00
Anna Yeddi
a19a18f721 Bug 1879447 - Update AccessibilityUtils to support intervening generics between a tab and its tablist in isKeyboardFocusableTabInTablist check. r=Jamie,fxview-reviewers 
There are cases in our code base, in the reusable component that is using Lit components, where a tablist includes a tab component wrapper (that has an accessible role `ROLE_TEXT_CONTAINER`) - the `<moz-page-nav-button>` - we want to include this case in the calculation of the tabs within a tablist calculation when checking the tablist's keyboard accessibility.

Differential Revision: https://phabricator.services.mozilla.com/D203987
 2024-03-12 14:32:45 +00:00
Kelly Cochrane
675a186e05 Bug 1884322 - Only toggle mute/unmute tabs in Fx View with Enter/Space keys if using keyboard navigation r=fxview-reviewers,jsudiaman 
Differential Revision: https://phabricator.services.mozilla.com/D204042
 2024-03-09 17:14:17 +00:00
Nikki Sharpley
f77658f22b Bug 1877786 - Test for muting and unmuting a tab via tab row keyboard navigation r=fxview-reviewers,kcochrane 
Differential Revision: https://phabricator.services.mozilla.com/D203936
 2024-03-08 19:58:02 +00:00
Cosmin Sabou
0e89801978 Bug 1877678 - Disable browser_opentabs_cards.js on linux and osx1100 opt for frequent failures. r=#intermittent-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D203861
 2024-03-07 00:19:37 +00:00
Nikki Sharpley
0fed7c98ce Bug 1883610 - skip a11y tests for browser_history_firefoxview.js` temporarily r=ayeddi,fxview-reviewers 
Until we have a fix for the sidebar navigation component buttons, `moz-page-nav-button`, in bug 1850591, disable a11y tests referencing these buttons.

Differential Revision: https://phabricator.services.mozilla.com/D203617
 2024-03-06 21:05:26 +00:00
Kelly Cochrane
bf4070efdc Bug 1883337 - Ensure focus is moved when mute/unmute button is removed in Fx View r=fxview-reviewers,nsharpley,jsudiaman 
Differential Revision: https://phabricator.services.mozilla.com/D203484
 2024-03-05 15:49:24 +00:00
Norisz Fay
81c5a0094d Backed out changeset c23d6a5f066e (bug 1883337) for causing bc failures on browser_opentabs_pinned_tabs.js CLOSED TREE 2024-03-05 17:10:15 +02:00
Kelly Cochrane
4a30e42b73 Bug 1883337 - Ensure focus is moved when mute/unmute button is removed in Fx View r=fxview-reviewers,nsharpley,jsudiaman 
Differential Revision: https://phabricator.services.mozilla.com/D203484
 2024-03-05 13:49:03 +00:00
Nikki Sharpley
615a7e4a90 Bug 1876862 - Add extra logs and update waitForCondition to resolve browser_history_firefoxview.js timeouts r=fxview-reviewers,sclements,kcochrane 
- added extra log in for when `waitForCondition` `historyComponentReady` fails
- added extra `waitForCondition` for history component selection.
- added helper function for creating history entries

Try submission: https://treeherder.mozilla.org/jobs?repo=try&revision=4682e0db2e42e87278e9d6dd321c0174f67cfe49&selectedTaskRun=G8kefdugSt6U4J0VsfMsXQ.0

This seems to resolve bug 1877594 as well.

Differential Revision: https://phabricator.services.mozilla.com/D201223
 2024-03-04 17:55:35 +00:00
Jonathan Sudiaman
a85f5fcf62 Bug 1876165 - Create BookmarkList class that internally stays up-to-date to indicate bookmarked open tabs in Fx View r=mak,fxview-reviewers,places-reviewers,fluent-reviewers,bolsson,sfoster,desktop-theme-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D201759
 2024-03-04 13:02:16 +00:00
Nikki Sharpley
3d5f2a1927 Bug 1882605 - Fix intermittent browser_tab_list_keyboard_navigation failure due to reordering of tabs r=fxview-reviewers,kcochrane,jsudiaman 
This patch also disables `browser_tab_list_keyboard_navigation` a11y failing tests noted in Bug 1882597
until Bug 1850591 resolves a11y checks for the `moz-page-nav-button` button to be focusable.

Differential Revision: https://phabricator.services.mozilla.com/D203182
 2024-03-02 00:51:33 +00:00