corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
872,378 Commits 1 Branch 0 Tags
b068dcffb1324b82fb2cfab5454360760cb15f45
Commit Graph

585 Commits

Author SHA1 Message Date
Dão Gottwald
662ecc18a6 Bug 1788257 - Hide collection expiry date when a colorway is selected. r=bigiri 
Differential Revision: https://phabricator.services.mozilla.com/D157208
 2022-09-13 19:51:56 +00:00
Niklas Baumgardner
6d0b8eb558 Bug 1789641 - Telemetry enchancements for Firefox View. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D156728
 2022-09-12 20:37:52 +00:00
Emily McMinn
5cf7cfb2e6 Bug 1779427 - Turn on Firefox View feature tour by default r=mviar 
Split out position tests to simplify re-enabling bulk of tests. Fix preference getter leak with weakDoc.

Differential Revision: https://phabricator.services.mozilla.com/D155482
 2022-09-11 15:59:15 +00:00
Shane Hughes
7deb89ce64 Bug 1788764 - Suppress Feature Callouts when feature recommendations are disabled by pref. r=mviar 
Only show Feature Callout messages when the user preference
`browser.newtabpage.activity-stream.asrouter.userprefs.cfr.features`
is enabled (it's enabled by default). This corresponds to the setting
labeled "Recommend features as you browse" in about:preferences.

Differential Revision: https://phabricator.services.mozilla.com/D156357
 2022-09-10 20:35:12 +00:00
negin
07953d5d61 Bug 1786341 - Continous Onboarding - Firefox View: Tab pick up r=mviar,fluent-reviewers,flod 
Differential Revision: https://phabricator.services.mozilla.com/D155994
 2022-09-09 22:52:53 +00:00
Jason Prickett
d76e44a172 Bug 1786347 - Adding continuous onboarding colorways reminder to firefox view feature callout r=mviar,fluent-reviewers,flod 
Differential Revision: https://phabricator.services.mozilla.com/D156700
 2022-09-09 22:38:11 +00:00
Mike Conley
ae11f3c9d0 Bug 1785282 - Open 'Choose what to sync' dialog when users click 'Turn sync on in settings' in Firefox View. r=sclements 
Differential Revision: https://phabricator.services.mozilla.com/D156578
 2022-09-09 14:26:50 +00:00
Meg Viar
2a8638fb36 Bug 1788231 - Add ability to trigger a button on parent page from Feature Callout CTA and implement for Firefox View: Tab pick up message r=emcminn 
Differential Revision: https://phabricator.services.mozilla.com/D156203
 2022-09-08 21:50:37 +00:00
Sam Foster
6f44add480 Bug 1784676 - Extract the setup error and sync-disabled tests into their own test files. r=niklas,sclements 
Differential Revision: https://phabricator.services.mozilla.com/D156730
 2022-09-08 19:40:42 +00:00
Mike Conley
1b1c5a94b2 Bug 1786565 - Re-enable testNotificationDotOnMultipleWindows test in browser_notification_dot.js. r=dao 
Differential Revision: https://phabricator.services.mozilla.com/D156579
 2022-09-07 12:58:40 +00:00
Dão Gottwald
5709bd7bd4 Bug 1787797 - Let the Firefox View menu item re-add the button to the tabs toolbar if it got previously removed. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D156412
 2022-09-07 12:21:25 +00:00
Andreea Pavel
eb1398daa7 Bug 1784343 - disable browser_feature_callout.js to reduce failure rate r=intermittent-reviewers,MasterWayZ DONTBUILD 
Differential Revision: https://phabricator.services.mozilla.com/D156496
 2022-09-06 00:45:30 +00:00
Gijs Kruitbosch
d38c0659ad Bug 1788813 - do not report spurious telemetry events for the toggling of the recently closed or tab pickup lists as a result of pageload, r=sclements 
Differential Revision: https://phabricator.services.mozilla.com/D156370
 2022-09-05 10:39:07 +00:00
Gijs Kruitbosch
6e20818109 Bug 1787565 - update recently closed tab entries in Firefox View based on delayed tab navigation information from session history, r=sclements 
I don't love this solution but it appears to work and I can't think of anything better.

Differential Revision: https://phabricator.services.mozilla.com/D155920
 2022-09-04 08:04:09 +00:00
Sandor Molnar
ed37cce0b5 Backed out changeset 08105e2d612c (bug 1785734) for causing browser-chrome failures in browser_keyboard_focus.js CLOSED TREE 2022-09-04 02:27:23 +03:00
Niklas Baumgardner
3141273c56 Bug 1785734 - Add test for keyboard focus in Firefox View. r=ayeddi,Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D155253
 2022-09-03 21:42:02 +00:00
Iulian Moraru
5282da4259 Backed out changeset b63ab5a39b53 (bug 1787565) for causing bc failures on browser_recently_closed_tabs.js. CLOSED TREE 2022-09-03 14:09:15 +03:00
Gijs Kruitbosch
8f8fa020b4 Bug 1787565 - update recently closed tab entries in Firefox View based on delayed tab navigation information from session history, r=sclements 
I don't love this solution but it appears to work and I can't think of anything better.

Differential Revision: https://phabricator.services.mozilla.com/D155920
 2022-09-03 09:53:55 +00:00
Sam Foster
1bbdf0032f Bug 1784902 - Implement the collapsible fx-view sections as details/summary elements. r=Gijs 
* Both CEs now extend HTMLDetailsElement
* Keep the title string on the twisty/toggle element
* The whole summary element gets the focus highlight, and is clickable to collapse/expand the associated content
* Maintain the hover behavior on the twisty button to provide a visual cue for collapsibility
* The setup cards will be collapsible in all states, bug 1779384 will ensure we ignore a persisted closed state during sync setup so this content is always initially visible in a new session

Differential Revision: https://phabricator.services.mozilla.com/D155508
 2022-09-02 18:53:21 +00:00
Dão Gottwald
02c7a85d0a Bug 1787973 - Colorway closet entrypoint in Firefox View should show the "new colorways soon" null state if colorway closet nimbus variable is disabled. r=bigiri 
Differential Revision: https://phabricator.services.mozilla.com/D156188
 2022-09-02 14:39:24 +00:00
Butkovits Atila
dd9a633a7c Backed out changeset df6d4e6e452c (bug 1787565) for causing failures at browser_ext_browserAction_popup_resize_bottom.js. 2022-09-02 16:26:14 +03:00
Gijs Kruitbosch
40bbc1905a Bug 1787437 - close the Firefox View tab when removing the FxView toolbar item completely, r=dao 
Differential Revision: https://phabricator.services.mozilla.com/D155921
 2022-09-02 12:49:54 +00:00
Gijs Kruitbosch
2a1088e2f8 Bug 1787565 - update recently closed tab entries in Firefox View based on delayed tab navigation information from session history, r=sclements 
I don't love this solution but it appears to work and I can't think of anything better.

Differential Revision: https://phabricator.services.mozilla.com/D155920
 2022-09-02 12:32:45 +00:00
Noemi Erli
ec9494988d Backed out changeset 59536058a947 (bug 1784902) for causing failures in browser_setup_state.js 2022-09-02 04:42:49 +03:00
Sam Foster
fe2b36be03 Bug 1784902 - Implement the collapsible fx-view sections as details/summary elements. r=Gijs 
* Both CEs now extend HTMLDetailsElement
* Keep the title string on the twisty/toggle element
* The whole summary element gets the focus highlight, and is clickable to collapse/expand the associated content
* Ensure the summary focus outline doesnt get clipped by the zap-card border below it
* Maintain the hover behavior on the twisty button to provide a visual cue for collapsibility
* The setup cards will be collapsible in all states, bug 1779384 will ensure we ignore a persisted closed state during sync setup so this content is always initially visible in a new session

Differential Revision: https://phabricator.services.mozilla.com/D155508
 2022-09-01 22:30:42 +00:00
Narcis Beleuzu
d2e96de8c9 Backed out changeset aa77f15a38d9 (bug 1779427) for assertion failure on DOMJSProxyHandler.cpp . CLOSED TREE 2022-09-02 00:34:30 +03:00
Emily McMinn
456f4168e4 Bug 1779427 - Turn on Firefox View feature tour by default r=mviar 
Differential Revision: https://phabricator.services.mozilla.com/D155482
 2022-09-01 19:15:01 +00:00
Meg Viar
27b13cf2f2 Bug 1787563 - Second Feature Callout screen is positioned too low r=Mardak 
Differential Revision: https://phabricator.services.mozilla.com/D155881
 2022-09-01 14:48:40 +00:00
Niklas Baumgardner
712e8dd8c0 Bug 1784294 - Sync tabs when Firefox View tab is selected. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D154825
 2022-09-01 13:06:50 +00:00
Iulian Moraru
a5b6c2be53 Backed out changeset c739e6f1b109 (bug 1779427) for causing mochitest failures. CLOSED TREE 2022-08-31 22:29:06 +03:00
Emily McMinn
959884abac Bug 1779427 - Turn on Firefox View feature tour by default r=mviar 
Differential Revision: https://phabricator.services.mozilla.com/D155482
 2022-08-31 18:39:16 +00:00
Meg Viar
248755e275 Bug 1786647 - Split up Feature Callout messages and fetch from ASRouter on page load, focus, and screen advance r=Mardak 
Differential Revision: https://phabricator.services.mozilla.com/D155524
 2022-08-31 16:09:26 +00:00
Meg Viar
f608e67d28 Bug 1787387 - No feature callout tour shown if tab sync is already set up r=Mardak 
Differential Revision: https://phabricator.services.mozilla.com/D155743
 2022-08-30 15:00:26 +00:00
Gijs Kruitbosch
4ef04e9049 Bug 1784085 - correct sync finishing topic identifier used in Firefox View so errors clear correctly, r=markh 
Differential Revision: https://phabricator.services.mozilla.com/D155922
 2022-08-30 09:32:56 +00:00
Gijs Kruitbosch
63a87376ea Bug 1784244 - do not surface sync errors in Firefox View if we previously synced successfully, r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D155845
 2022-08-30 08:52:54 +00:00
Sandor Molnar
8aaea79f98 Backed out changeset 225b8bbe0912 (bug 1786647) for causing browser-chrome failures in toolkit/components/messaging-system/schemas/TriggerActionSchemas/test/browser/browser_asrouter_trigger_docs.js CLOSED TREE 2022-08-30 01:43:39 +03:00
Meg Viar
91ba440ce8 Bug 1786647 - Split up Feature Callout messages and fetch from ASRouter on page load, focus, and screen advance r=Mardak 
Differential Revision: https://phabricator.services.mozilla.com/D155524
 2022-08-29 20:19:16 +00:00
Csoregi Natalia
591eeff1af Backed out changeset ba0784c1646a (bug 1786647) for fxms failures. CLOSED TREE 2022-08-29 19:51:17 +03:00
Meg Viar
4f744927cf Bug 1786647 - Split up Feature Callout messages and fetch from ASRouter on page load, focus, and screen advance r=Mardak 
Differential Revision: https://phabricator.services.mozilla.com/D155524
 2022-08-29 16:18:42 +00:00
criss
351bc28d66 Backed out changeset 56ba242e0732 (bug 1786647) for causing python fxms failures . CLOSED TREE 2022-08-29 17:14:11 +03:00
Meg Viar
605bbe0b26 Bug 1786647 - Split up Feature Callout messages and fetch from ASRouter on page load, focus, and screen advance r=Mardak 
Differential Revision: https://phabricator.services.mozilla.com/D155524
 2022-08-29 13:29:31 +00:00
Katherine Patenio
377e9d145e Bug 1747229 - implement telemetry probes for colorway closet r=bigiri,dao,rpl 
Differential Revision: https://phabricator.services.mozilla.com/D151771
 2022-08-26 17:05:58 +00:00
Gijs Kruitbosch
a50a0a7200 Bug 1785234 - use abbreviated timestamps in Firefox View for both recently closed tab list and tab pickup, r=niklas 
Differential Revision: https://phabricator.services.mozilla.com/D155700
 2022-08-26 16:25:55 +00:00
Meg Viar
c114df74a0 Bug 1786356 - Create Firefox View open Tracker r=niklas,jprickett 
Differential Revision: https://phabricator.services.mozilla.com/D155432
 2022-08-26 16:16:17 +00:00
Cristian Tuns
a7c8ce5b60 Backed out changeset 44c1ce2f6854 (bug 1779427) for causing mochitest failures on browser_setup_state.js CLOSED TREE 2022-08-26 11:25:42 -04:00
Emily McMinn
4c96951e8e Bug 1779427 - Turn on Firefox View feature tour by default r=mviar 
Differential Revision: https://phabricator.services.mozilla.com/D155482
 2022-08-26 14:30:11 +00:00
Sam Foster
1eecd465c0 Bug 1784130 - Hide mobile promo when signed out. r=niklas 
* Only show the mobile promo when tab syncing is enabled
* Toggle the promo & confirmation visibility in all setup states to ensure it gets hidden when we re-enter the sign-in to FxA state
* Add test coverage for signing out
* Ensure we always restore the mocks

Depends on D155427

Differential Revision: https://phabricator.services.mozilla.com/D154850
 2022-08-26 05:37:49 +00:00
Butkovits Atila
acc81a64dd Backed out changeset d4db9e3554d5 (bug 1784130) for causing failures at browser_setup_state.js. 2022-08-25 23:07:58 +03:00
Sam Foster
c0c5dc6cc6 Bug 1784130 - Hide mobile promo when signed out. r=niklas 
* Only show the mobile promo when tab syncing is enabled
* Toggle the promo & confirmation visibility in all setup states to ensure it gets hidden when we re-enter the sign-in to FxA state
* Add test coverage for signing out

Differential Revision: https://phabricator.services.mozilla.com/D154850
 2022-08-25 19:12:39 +00:00
Sam Foster
9695132afd Bug 1786615 - Only show an error when sync isnt connected/enabled if we're currently signed in. r=markh 
Differential Revision: https://phabricator.services.mozilla.com/D155427
 2022-08-24 22:48:12 +00:00