corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
796,093 Commits 1 Branch 0 Tags
f4139c1440af43fae4bc901b40e80d1028d2738c
Commit Graph

1298 Commits

Author SHA1 Message Date
Meg Viar
a294dbd3c2 Bug 1734852 - The mouse cursor changes into a text selector when hovering between the colorways r=emcminn 
Differential Revision: https://phabricator.services.mozilla.com/D132813
 2021-12-03 20:08:45 +00:00
Andrei Oprea
02d7dc18a9 Bug 1740718 - Switch Messaging System to use the NimbusFeatures API r=k88hudson 
Differential Revision: https://phabricator.services.mozilla.com/D131241
 2021-11-26 11:34:50 +00:00
Scott
a292bae478 Bug 1739147 - Pocket newtab load more button hide if there are not enough stories. r=gvn 
Differential Revision: https://phabricator.services.mozilla.com/D130516
 2021-11-16 20:17:45 +00:00
Miriam Onuoha
d49918a212 Bug 1739420 - Re-added styles in _Search.scss. r=harry 
Differential Revision: https://phabricator.services.mozilla.com/D130454
 2021-11-08 17:32:39 +00:00
Ed Lee
527bb6cf07 Bug 1735841 - Update template with hidden text that is shown on a link click for Total Cookie Protection r=andreio 
Introduce an extra expanded text with a learn more toggle button. Allow for message configuration of various sizes.

Differential Revision: https://phabricator.services.mozilla.com/D129556
 2021-10-28 14:24:59 +00:00
Scott
6f90c65607 Bug 1729949 - Removing old Pocket newtab components for list and hero cards. r=gvn 
Differential Revision: https://phabricator.services.mozilla.com/D129441
 2021-10-26 21:43:28 +00:00
Emily McMinn
ec69c1f3b6 Bug 1733683 - Hide steps for Thanks page r=pdahiya 
Differential Revision: https://phabricator.services.mozilla.com/D127496
 2021-10-26 17:14:37 +00:00
Emily McMinn
ac15419098 Bug 1735860 - Change step indicator var to work with Dark themes in HCM, adjust theme varation buttons to match HCM colors r=pdahiya 
Differential Revision: https://phabricator.services.mozilla.com/D128745
 2021-10-26 16:35:29 +00:00
Emily McMinn
192c8fa16b Bug 1734814 - Make the sign-in button visible when it overlaps noodles r=pdahiya 
Differential Revision: https://phabricator.services.mozilla.com/D128782
 2021-10-22 19:36:15 +00:00
Emily McMinn
25dc5e596a Bug 1735350 - Fix HCM backgrounds and colors for about:welcome elements r=pdahiya 
Differential Revision: https://phabricator.services.mozilla.com/D128398
 2021-10-22 17:16:38 +00:00
Geoff Lankow
f044ee051e Bug 1698112 - Stop referencing browser files from toolkit, and prevent it happening again with a test. r=preferences-reviewers,mossop 
Differential Revision: https://phabricator.services.mozilla.com/D128974
 2021-10-21 21:54:52 +00:00
secret.okra
cd6779c2c3 Bug 1733574 - Increase visibility of shortcut image field for dark theme. r=harry 
Differential Revision: https://phabricator.services.mozilla.com/D128767
 2021-10-20 14:26:39 +00:00
Ed Lee
f349dc2560 Bug 1735388 - Keep the variant when changing colorways on upgrade spotlight and about:welcome r=pdahiya 
Rework theme and variant activation to make variants sticky. Reorder Default to show Light then Auto so that Light and Soft are the same index. Also select the initial index based on current dark or light theme. Add transitions for variation children. Compute about:welcome variant index based on active theme instead of specifying both default variants for system and colorways.

Differential Revision: https://phabricator.services.mozilla.com/D128404
 2021-10-14 00:40:23 +00:00
Punam Dahiya
ae445a8ee7 Bug 1735155 - Theme preview area is blank when Alpenglow theme was previously enabled r=Mardak 
Differential Revision: https://phabricator.services.mozilla.com/D128325
 2021-10-13 15:16:22 +00:00
Emily McMinn
13ae957417 Bug 1734851 - Set z-index to make "not now" clickable when H2 spans two lines r=pdahiya 
Differential Revision: https://phabricator.services.mozilla.com/D128307
 2021-10-12 23:18:04 +00:00
Emily McMinn
9cea07a766 Bug 1734126 - Make sure the autoClose doesn't persist if we navigate away from the Thanks page r=pdahiya 
Differential Revision: https://phabricator.services.mozilla.com/D127892
 2021-10-12 20:50:48 +00:00
Emily McMinn
f77136b659 Bug 1733690 - Various a11y fixes: step indicators, title transparency, button hover r=Mardak 
Differential Revision: https://phabricator.services.mozilla.com/D127991
 2021-10-12 05:12:12 +00:00
Punam Dahiya
467ff8afd3 Bug 1733688 - Add background to theme variations selector r=pdahiya 
Reuse backgrounds from upgrade spotlight and copy over styles including transitions. Convert colorway state to track next color to transition it in. Also adjust colorway screen styling, e.g., focus, variant spacing, transitions (bug 1733689).

Differential Revision: https://phabricator.services.mozilla.com/D127695
 2021-10-08 00:18:06 +00:00
Noemi Erli
c05f0b2129 Backed out changeset 7f38124d29f5 (bug 1733688) for causing newtab failures CLOSED TREE 2021-10-08 03:09:39 +03:00
Punam Dahiya
aaf6356899 Bug 1733688 - Add background to theme variations selector r=pdahiya 
Reuse backgrounds from upgrade spotlight and copy over styles including transitions. Convert colorway state to track next color to transition it in. Also adjust colorway screen styling, e.g., focus, variant spacing, transitions (bug 1733689).

Differential Revision: https://phabricator.services.mozilla.com/D127695
 2021-10-07 23:15:58 +00:00
Ed Lee
4ac98a358d Bug 1734264 - Upgrade spotlight visual adjustments from design feedback r=pdahiya 
Fix background sizing of horizontal color circles with updated hover styles and improved spacing among/around. Position primary button with invisible secondary button. Update noodle svg to avoid aliasing. Adjust variant disc and color circles gradient colors and direction (vertical) now always with black variant text and increased button font size. Also adjust about:welcome thank you confetti and fancy header. Update a couple backgrounds and positioning.

Differential Revision: https://phabricator.services.mozilla.com/D127601
 2021-10-07 19:30:32 +00:00
Punam Dahiya
9d5f7c528f Bug 1734127 - Fix displayed colorways name inside variation circle r=Mardak 
Differential Revision: https://phabricator.services.mozilla.com/D127574
 2021-10-06 04:55:10 +00:00
Scott
4b13dd6aa5 Bug 1733675 - Fixes some nits in Pocket newtab experiment. r=gvn 
Differential Revision: https://phabricator.services.mozilla.com/D127338
 2021-10-04 20:39:08 +00:00
Harry Twyford
f6c835067b Bug 1733646 - Use secondary background color in newtab context menus. r=amy 
Differential Revision: https://phabricator.services.mozilla.com/D127293
 2021-10-01 20:37:05 +00:00
Emily McMinn
d7efd82d81 Bug 1730571 - Add Thank You page to about:welcome flow r=pdahiya,fluent-reviewers,flod 
Differential Revision: https://phabricator.services.mozilla.com/D126406
 2021-10-01 15:06:27 +00:00
Punam Dahiya
d5c83d4cec Bug 1728852 - Add monochromatic themes to about:welcome r=Mardak,fluent-reviewers,flod 
Differential Revision: https://phabricator.services.mozilla.com/D126346
 2021-09-30 22:32:58 +00:00
Scott
bae6836889 Bug 1730017 - Adding save to Pocket button to newtab Pocket cards on hover. r=fluent-reviewers,flod,gvn 
Differential Revision: https://phabricator.services.mozilla.com/D126748
 2021-09-29 20:20:32 +00:00
Scott
b1ecb29b6d Bug 1730018 - New Pocket footer section on newtab r=gvn,fluent-reviewers,flod 
Differential Revision: https://phabricator.services.mozilla.com/D126268
 2021-09-23 22:08:37 +00:00
Scott
d88d5f1009 Bug 1729946 - Adding Pocket newtab load more button. r=fluent-reviewers,gvn,flod 
Differential Revision: https://phabricator.services.mozilla.com/D125631
 2021-09-23 02:48:38 +00:00
Andrei Oprea
52cf1b8ef5 Bug 1729943 - Fix json schema for Messaging System Spotlight component r=dmose 
Differential Revision: https://phabricator.services.mozilla.com/D125389
 2021-09-22 10:00:01 +00:00
Butkovits Atila
91d0db9a30 Backed out 3 changesets (bug 1719939, bug 1726437, bug 1730262) for causing failures on test_browserGlue_migration_ctrltab_recently_used_order.js. 
Backed out changeset ea1653e9644f (bug 1719939)
Backed out changeset 01f90db715a7 (bug 1726437)
Backed out changeset c0e23b2acfbb (bug 1730262)
 2021-09-21 05:15:31 +03:00
Junjie Ying
11151d13b2 Bug 1719939 - Remove last fragments of code manually checking the browser.proton.enabled pref. r=mhowell 
Differential Revision: https://phabricator.services.mozilla.com/D125345
 2021-09-21 00:03:49 +00:00
Andrei Oprea
bb93a041e0 Bug 1730497 - Add targeting attribute to detect browser pinned status r=Mardak 
Differential Revision: https://phabricator.services.mozilla.com/D125858
 2021-09-17 11:54:54 +00:00
Harry Twyford
44fb51f43f Bug 1727319 - Part 3 - Remove unused hardcoded colors in _variables.scss. r=Mardak 
Differential Revision: https://phabricator.services.mozilla.com/D125609
 2021-09-16 21:50:30 +00:00
Harry Twyford
bd18b6c4d2 Bug 1727319 - Part 2 - Remove intermediary variables in _theme.scss. r=Mardak 
Differential Revision: https://phabricator.services.mozilla.com/D125608
 2021-09-16 21:50:29 +00:00
Harry Twyford
fb98c10513 Bug 1727319 - Assign set of colors from bug 1727317 to the existing new tab CSS variables. r=Mardak 
While this is mainly a refactoring patch, a few visible effects are expected:
- Proton Primary teal is now used correctly in dark mode. I confirmed with UX that we want this.
- Various minor elements now may use slightly different colors than before. Things like hover states and borders are now functions of the main colors on the page rather than their own hardcoded colors. While one might be able to spot differences in a side-by-side comparison, the general idea is to capture the same "feeling".

Differential Revision: https://phabricator.services.mozilla.com/D125607
 2021-09-16 21:50:29 +00:00
Harry Twyford
2c68cf2971 Bug 1727317 - Define set of color variables to use in newtab. r=Mardak 
Differential Revision: https://phabricator.services.mozilla.com/D125606
 2021-09-16 21:50:29 +00:00
Scott
79862bace3 Bug 1717682 - Pref and implementation for compact 4 card row layout for Pocket newtab. r=fluent-reviewers,gvn,flod 
Differential Revision: https://phabricator.services.mozilla.com/D125307
 2021-09-15 23:47:41 +00:00
Harry Twyford
02b78f9fd1 Bug 1727333 - Add ntp_card_background theme API property. r=desktop-theme-reviewers,dao,mixedpuppy 
We want to introduce this new variable to be able to theme more surfaces on the NTP. ntp_card_background is the color of cards (top site tiles, Pocket cards, etc).

This patch changes browser_ext_themes_ntp_colors_perwindow.js and browser_ext_theme_ntp_colors.js. These aren't the most reliable tests; they fail on central and have [a lot of issues](https://bugzilla.mozilla.org/buglist.cgi?f5=component&f3=OP&f2=OP&f8=status_whiteboard&f9=cf_crash_signature&list_id=15832113&v8=toolkit%2Fcomponents%2Fextensions%2Ftest%2Fbrowser%2Fbrowser_ext_themes_ntp_colors_perwindow.js&o8=substring&query_format=advanced&v9=toolkit%2Fcomponents%2Fextensions%2Ftest%2Fbrowser%2Fbrowser_ext_themes_ntp_colors_perwindow.js&o9=substring&o5=substring&f10=CP&v5=toolkit%2Fcomponents%2Fextensions%2Ftest%2Fbrowser%2Fbrowser_ext_themes_ntp_colors_perwindow.js&bug_status=UNCONFIRMED&bug_status=NEW&bug_status=ASSIGNED&bug_status=REOPENED&bug_status=RESOLVED&bug_status=VERIFIED&bug_status=CLOSED&f6=alias&classification=Client%20Software&classification=Developer%20Infrastructure&classification=Components&classification=Server%20Software&classification=Other&o4=substring&v4=toolkit%2Fcomponents%2Fextensions%2Ftest%2Fbrowser%2Fbrowser_ext_themes_ntp_colors_perwindow.js&o7=substring&v1=Graveyard&f11=CP&o1=notequals&v7=toolkit%2Fcomponents%2Fextensions%2Ftest%2Fbrowser%2Fbrowser_ext_themes_ntp_colors_perwindow.js&j3=OR&f4=product&f1=classification&f7=short_desc&v6=toolkit%2Fcomponents%2Fextensions%2Ftest%2Fbrowser%2Fbrowser_ext_themes_ntp_colors_perwindow.js&o6=substring). I will follow-up and attempt to fix them to be more reliable.

Differential Revision: https://phabricator.services.mozilla.com/D125115
 2021-09-15 18:54:02 +00:00
Harry Twyford
9ffc6060d1 Bug 1730560 - Fix newtab customize checkbox color. r=Mardak 
This patch also renames --customize-menu-primary-action-text to --customize-menu-slider-fill, since that's the only place its used.

Differential Revision: https://phabricator.services.mozilla.com/D125461
 2021-09-13 21:24:37 +00:00
Harry Twyford
75f4dc3868 Bug 1727321 - Part 4 - Stop using color variables elsewhere in newtab. r=thecount 
Differential Revision: https://phabricator.services.mozilla.com/D124401
 2021-09-08 22:06:27 +00:00
Harry Twyford
1cbd7abe67 Bug 1727321 - Part 3 - Stop using color variables in box-shadows. r=thecount 
Differential Revision: https://phabricator.services.mozilla.com/D124399
 2021-09-08 22:06:27 +00:00
Harry Twyford
a327978c95 Bug 1727321 - Part 2 - Stop using color variables in buttons. r=thecount 
Differential Revision: https://phabricator.services.mozilla.com/D124398
 2021-09-08 22:06:26 +00:00
Harry Twyford
913233dfed Bug 1727321 - Part 1 - Stop using color variables in links. r=thecount 
The purpose of this stack of patches is to stop using color variables directly in newtab CSS in favour of the semantic variables defined in _theme.scss. That way, we can later refactor _theme.scss to use theme variables instead of hardcoded colors.

There's a lot of dead CSS/components in new tab. This stack of patches refactors dead code as well, mostly because it's not clear what is dead and what is not. I tried to keep things generally looking the same on visible surfaces, but there are some minor style differences in dead components and in asrouter devtools. I spoke to Mardak on Slack and he confirmed it would be okay to slightly change the look of dead components. Scott, I tagged you for review since you know what is dead and what is not.

Differential Revision: https://phabricator.services.mozilla.com/D124397
 2021-09-08 22:06:26 +00:00
Harry Twyford
ff0ec1287a Bug 1726432 - Part 4 - Remove unused variables. r=amy 
Differential Revision: https://phabricator.services.mozilla.com/D123387
 2021-09-08 22:06:26 +00:00
Harry Twyford
b421d1a2ae Bug 1726432 - Part 3 - Consolidate variables with their '-nte' equivalents. r=amy 
Differential Revision: https://phabricator.services.mozilla.com/D123386
 2021-09-08 22:06:25 +00:00
Harry Twyford
edebf41522 Bug 1726432 - Part 2 - Consolidate newtab-background-secondary variable. r=amy 
This is the variable we will eventually replace with ntp_secondary or equivalent.

Differential Revision: https://phabricator.services.mozilla.com/D123385
 2021-09-08 22:06:25 +00:00
Harry Twyford
89b1a551a1 Bug 1726432 - Part 1 - Remove newtab-experience class. r=amy 
Differential Revision: https://phabricator.services.mozilla.com/D123384
 2021-09-08 22:06:24 +00:00
Harry Twyford
48fbf1d8f5 Bug 1710937 - Part 6 - Remove code related to showing fallback screenshots in Top Sites. r=amy 
I confirmed with Julian Gaibler that we don't want to show screenshots as fallbacks in Top Sites. We still want to support custom icons and screenshots in the "Recent activity" section, both of which are unchanged.

Differential Revision: https://phabricator.services.mozilla.com/D123253
 2021-09-08 22:06:24 +00:00
Harry Twyford
caf54ef43c Bug 1710937 - Part 4 - Remove SectionMenus and section header icons. r=amy 
Differential Revision: https://phabricator.services.mozilla.com/D123251
 2021-09-08 22:06:23 +00:00