Commit Graph

1298 Commits

Author SHA1 Message Date
Ed Lee
4b8f18eec6 Bug 1715917 - Remove dependency on deprecated node-sass r=pdahiya
Update yamscripts to use sass command line interface with input:output args and appropriate --options, and also fix incorrect watchmc as bundle:css was && chained. Fix up sass errors (multiline string variable) and warnings (divide vs css / separator).

Differential Revision: https://phabricator.services.mozilla.com/D117484
2021-06-16 01:46:19 +00:00
Sandor Molnar
3f5ffca65d Backed out changeset 463f9505434d (bug 1715917) for causing browser-chrome failures in browser_parsable_css. CLOSED TREE DONTBUILD 2021-06-16 02:11:14 +03:00
Ed Lee
9f062a2141 Bug 1715917 - Remove dependency on deprecated node-sass r=pdahiya
Update yamscripts to use sass command line interface with input:output args and appropriate --options, and also fix incorrect watchmc as bundle:css was && chained. Fix up sass errors (multiline string variable) and warnings (divide vs css / separator).

Differential Revision: https://phabricator.services.mozilla.com/D117484
2021-06-15 22:07:06 +00:00
Emily McMinn
aca8b9bfe1 Bug 1714617 - Update noodle positions & sizes on about:welcome to more closely match design spec r=pdahiya
Differential Revision: https://phabricator.services.mozilla.com/D117047
2021-06-15 18:50:57 +00:00
Andrei Oprea
55a44da2ef Bug 1695764 - Remove code related to CFR ML Experiment r=k88hudson
Differential Revision: https://phabricator.services.mozilla.com/D113963
2021-06-15 10:44:15 +00:00
Csoregi Natalia
ffd72a0bf5 Backed out changeset f7a108e738ee (bug 1712215) for failures on browser_parsable_css.js. CLOSED TREE 2021-06-09 23:27:29 +03:00
amy churchwell
75a7e5a7ac Bug 1712215, 1712221 - Update drop shadows. r=thecount
Differential Revision: https://phabricator.services.mozilla.com/D116048
2021-06-09 16:59:46 +00:00
Emily McMinn
a715392922 Bug 1712797 - Fix progress indicator fill for HCM r=Mardak
Differential Revision: https://phabricator.services.mozilla.com/D116778
2021-06-07 19:44:25 +00:00
Nan Jiang
d4557c4288 Bug 1713596 - Block all sponsored tiles from a sponsor upon the dismissal r=dao
This patch implements the sponsor level blocking for the sponsored Top Sites.

When a sponsored top site gets dismissed, Firefox will extract the sponsor (hostname) out of the URL, and persist it to the pref `browser.topsites.blockedSponsors` as a JSON array. When Firefox fetches the sponsored tiles from Contile again, it will filter all the tiles whose sponsor has been blocked before.

Differential Revision: https://phabricator.services.mozilla.com/D116413
2021-06-04 14:58:57 +00:00
Emily McMinn
184a25b96b Bug 1712800 - HCM fix for button hover r=pdahiya
Differential Revision: https://phabricator.services.mozilla.com/D116164
2021-06-03 14:34:01 +00:00
Rob Wu
adc169f2ba Bug 1713783 - Remove inaccurate theme tests for about:welcome r=rpl,pdahiya
The tests do not reflect reality, see the bug for more details.

The content area of the Proton `about:welcome` uses
`var(--in-content-page-color)` and `var(--in-content-page-background)`
for the text and background color. The main background itself already
has colors distinct from the default background. Moreover,
`about:welcome` is part of the onboarding experience, at which point
users will likely not have a custom theme, so it's not necessary to
adjust the colors.

Differential Revision: https://phabricator.services.mozilla.com/D116453
2021-06-02 16:30:17 +00:00
emcminn
fdce50e307 Bug 1712178 - Update noodles to match marketing colors, update pin images r=Mardak
Differential Revision: https://phabricator.services.mozilla.com/D115733
2021-05-27 22:48:42 +00:00
Ed Lee
ab80e5196f Bug 1711899 - Remove "Sign in" button and FxA metrics from about:welcome when FxA is disabled r=emcminn
Prepare content for both isProton and pre-proton designs. Also deep clone to avoid directly deleting from pre-proton DEFAULT object.

Differential Revision: https://phabricator.services.mozilla.com/D115834
2021-05-26 21:29:18 +00:00
Ed Lee
98021f9dfa Bug 1711860 - Use even spacing between about:welcome theme options r=pdahiya
Switch themes to flex to allow items to be equally sized and evenly spaced with adjusted whitespace. Allow wrapping for pre-proton design.

Differential Revision: https://phabricator.services.mozilla.com/D115732
2021-05-25 22:41:52 +00:00
emcminn
4b6941d3fe Bug 1711428 - Adjust styles for about:welcome sign in link r=Mardak
Differential Revision: https://phabricator.services.mozilla.com/D115738
2021-05-25 21:01:10 +00:00
Ed Lee
9bcf55d9cf Bug 1711858 - Avoid "Fire starts here" from getting hidden by noodles r=pdahiya
Remove explicit section-left children widths to allow the parent to flex with a static width section-main for initial screen. Clean up some breakpoint sizing with percent/viewport widths.

Differential Revision: https://phabricator.services.mozilla.com/D115546
2021-05-24 19:01:16 +00:00
Bernard Igiri
872b3d586d Bug 1705855 - Fix newtab padding r=thecount
Modified padding on newtab eliminate unnecessary scrollbars and only apply snippet specific padding when snippets are present.

Differential Revision: https://phabricator.services.mozilla.com/D114530
2021-05-21 00:27:42 +00:00
Csoregi Natalia
afa9449e7e Backed out changeset 335bbc7eb086 (bug 1705855) for causing newtab failures. CLOSED TREE 2021-05-20 20:46:14 +03:00
Bernard Igiri
e7eea83ac7 Bug 1705855 - Fix newtab padding r=thecount
Modified padding on newtab eliminate unnecessary scrollbars and only apply snippet specific padding when snippets are present.

Differential Revision: https://phabricator.services.mozilla.com/D114530
2021-05-20 16:25:25 +00:00
Punam Dahiya
e8a53af326 Bug 1711700 - Use default screens when no screen variable set in experiment r=Mardak
Differential Revision: https://phabricator.services.mozilla.com/D115549
2021-05-20 07:10:50 +00:00
Ed Lee
be0ff6377f Bug 1711430 - Ignore multiple welcome button clicks while transitioning out r=pdahiya
Differential Revision: https://phabricator.services.mozilla.com/D115237
2021-05-17 23:52:50 +00:00
Dorel Luca
ca784c7d7f Backed out changeset 2c19c6b038a4 (bug 1705855) for Newtab failures in content-src/components/Base/_Base.scss. CLOSED TREE 2021-05-17 17:22:53 +03:00
Bernard Igiri
3a760931ae Bug 1705855 - Fix newtab padding r=thecount
Modified padding on newtab eliminate unnecessary scrollbars and only apply snippet specific padding when snippets are present.

Differential Revision: https://phabricator.services.mozilla.com/D114530
2021-05-17 13:36:41 +00:00
Punam Dahiya
5db326ae31 Bug 1708489 - Support proton background noodles for custom flow with more than 3 screens r=Mardak
Differential Revision: https://phabricator.services.mozilla.com/D114778
2021-05-13 00:50:09 +00:00
emcminn
4ea31694c2 Bug 1707575 - Screen reader focus on main content H1 r=eeejay
Differential Revision: https://phabricator.services.mozilla.com/D114539
2021-05-12 17:09:36 +00:00
Andrei Oprea
559f418e53 Bug 1708681 - Remove assets associated with the addon recommendation CFRs r=desktop-theme-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D113964
2021-05-10 17:24:52 +00:00
emcminn
7fcd24ff3d Bug 1680215 - Adjust dotted border to match Proton styling r=Mardak
Differential Revision: https://phabricator.services.mozilla.com/D114547
2021-05-07 18:03:03 +00:00
Eitan Isaacson
84427e082d Bug 1707022 - p5: Clean up menu transition CSS. r=amy
I took the liberty to clean up the CSS a bit. There is no need to have
special exceptions for how `visibility` is animated. Since this is a
binary property it becomes invisible at the end of a transition
duration, and visible at the begining.

Differential Revision: https://phabricator.services.mozilla.com/D113869
2021-05-07 17:42:21 +00:00
Eitan Isaacson
2d2e8fecb2 Bug 1707022 - p4: Hide personalize button when menu is showing. r=amy
When the menu is showing the personalize button is obscured, yet
keyboard users can still tab to it. This can be confusing.

I made the transition timeout 50ms longer than the menu transition
because I didn't want it to go away when it was focused before the
close button was focused. This can cause a brief confusion.

Differential Revision: https://phabricator.services.mozilla.com/D113868
2021-05-07 17:42:20 +00:00
Eitan Isaacson
dcf81f7f9d Bug 1707022 - p3: Focus open or close buttons when menu is toggled. r=amy
The `timeout` for the CSSTransition needs to match the actual duration
of the CSS transition. This is needed because the close button needs to
be visible before focus() is called on it or else it won't recieve
focus.

Differential Revision: https://phabricator.services.mozilla.com/D113867
2021-05-07 17:42:20 +00:00
Eitan Isaacson
06f4e87994 Bug 1707022 - p2: Add dialog role and label to personalize menu. r=amy,flod
Differential Revision: https://phabricator.services.mozilla.com/D113866
2021-05-07 17:42:20 +00:00
Eitan Isaacson
4712448b3f Bug 1707022 - p1: Put PersonalizeButton in CustomizeMenu component. r=amy
This will allow us to encapsulate focus control for the menu's open and
close buttons.

Differential Revision: https://phabricator.services.mozilla.com/D113865
2021-05-07 16:36:52 +00:00
Ed Lee
9c5c9019bd Bug 1709805 - [win7] Render steps but visually hide to maintain desired spacing r=emcminn
Remove special check for total steps and just render to then visually hide with opacity in css.

Differential Revision: https://phabricator.services.mozilla.com/D114526
2021-05-06 19:45:56 +00:00
Ed Lee
c2efdbddfc Bug 1698204 - Animate proton about:welcome with fades and motion if not reduce-motion r=pdahiya
Allow transitions to be remotely configured. Use hooks to insert transition-{in,out} class when adding and removing screens. Specify desired in/out styles to transition from/to. Also flex/push buttons/steps to the bottom to be the same position on the latter screens.

Differential Revision: https://phabricator.services.mozilla.com/D114192
2021-05-05 13:53:03 +00:00
Sam Foster
03c240126f Bug 1700238 - Update download icon and animations. r=Gijs
* Replace the many-shapes icon with a new simple download icon svg and update its consumers
* New start and finish animations using svg filmstrip images
* Toolbarbutton progress "bar" is a pie-chart, using a conic-gradient and a variable updated from js
* Show toolbarbutton animations even when download panel is open

Differential Revision: https://phabricator.services.mozilla.com/D113204
2021-05-01 01:41:31 +00:00
emcminn
f86cb4a7cd Bug 1705825 - Update proton onboarding background image and caption r=fluent-reviewers,Mardak,flod
Differential Revision: https://phabricator.services.mozilla.com/D113886
2021-04-30 22:37:29 +00:00
emcminn
00ebde87f7 Bug 1708335 - Remove outline-L and yellow circle from welcome page of onboarding" r=pdahiya
Removes the outline-L and the yellow dot from the first page of onboarding.

Differential Revision: https://phabricator.services.mozilla.com/D113824
2021-04-30 22:11:40 +00:00
Punam Dahiya
185a506bdc Bug 1707749 - New user onboarding Import primary button label to use download source r=Mardak
Differential Revision: https://phabricator.services.mozilla.com/D113749
2021-04-30 20:27:48 +00:00
Shane Caraveo
c5324dde89 Bug 1707038 update manual rtamo test with recommended addon and correct content format r=Mardak
Differential Revision: https://phabricator.services.mozilla.com/D113878
2021-04-30 19:26:59 +00:00
julianwels
fd4df3bb31 Bug 1706360 - Adjust default background colors of new-tab. r=dao,Mardak
Differential Revision: https://phabricator.services.mozilla.com/D112744
2021-04-30 17:27:26 +00:00
Butkovits Atila
d1bfad928c Backed out changeset 77dc7ca6680f (bug 1707749) for causing failures at browser_aboutwelcome_multistage.js. CLOSED TREE 2021-04-30 11:37:41 +03:00
Punam Dahiya
0591691e73 Bug 1707749 - New user onboarding Import primary button label to use download source r=Mardak
Differential Revision: https://phabricator.services.mozilla.com/D113749
2021-04-30 07:33:17 +00:00
Ed Lee
a664a5abaa Bug 1706366 - Update builtin theme icons to reuse on about:welcome, customize and upgrade dialog r=emcminn
Switch about:welcome and upgrade dialog to use url(icon.svg) to avoid high contrast hiding gradients. Also adjusts customize mode styling to better match proton.

Differential Revision: https://phabricator.services.mozilla.com/D113701
2021-04-30 05:13:31 +00:00
Dorel Luca
82ab95e902 Backed out changeset 69811ad1a854 (bug 1706366) for Browser-chrome failures in browser/components/customizableui/test/browser_1007336_lwthemes_in_customize_mode.js. CLOSED TREE 2021-04-30 06:10:41 +03:00
Ed Lee
30d568996f Bug 1706366 - Update builtin theme icons to reuse on about:welcome, customize and upgrade dialog r=emcminn
Switch about:welcome and upgrade dialog to use url(icon.svg) to avoid high contrast hiding gradients. Also adjusts customize mode styling to better match proton.

Differential Revision: https://phabricator.services.mozilla.com/D113701
2021-04-30 00:42:33 +00:00
Scott
65ecf56870 Bug 1708553 - Fix newtab Pocket section in German is showing English topics r=amy
Differential Revision: https://phabricator.services.mozilla.com/D113864
2021-04-29 22:35:05 +00:00
Scott
e6f625d092 Bug 1708248 - Newtab Personalize menu high contrast fixes. r=amy
Differential Revision: https://phabricator.services.mozilla.com/D113847
2021-04-29 21:47:09 +00:00
amy churchwell
b082176d59 Bug 1703678 - Move Privacy Notice link to footer of Pocket section. r=thecount
Differential Revision: https://phabricator.services.mozilla.com/D111177
2021-04-29 20:39:08 +00:00
Scott
8639636dc8 Bug 1706800 - Fix newtab personalize menu button width. r=amy
Differential Revision: https://phabricator.services.mozilla.com/D113826
2021-04-29 17:54:04 +00:00
Cosmin Sabou
3a3d7ace0c Backed out changeset 1bfac0068a43 (bug 1706360) for bc failures on browser_ext_themes_ntp_colors_perwindow.js. CLOSED TREE 2021-04-29 19:10:53 +03:00