Commit Graph

1298 Commits

Author SHA1 Message Date
Amy Churchwell
16d64cfeb6 Bug 1767017 - Remove placeholder Colorways section from about:newtab's personalize panel. r=dao
Differential Revision: https://phabricator.services.mozilla.com/D145680
2022-05-06 08:02:07 +00:00
Barret Rennie
188cd9ed5c Bug 1767302 - Fix UpdateAction.schema.json, again r=emcminn
Differential Revision: https://phabricator.services.mozilla.com/D145239
2022-05-04 01:26:48 +00:00
Barret Rennie
bbdc3c3536 Bug 1767266 - Make ExtensionDoorhanger.schema.json more lenient r=Mardak
Differential Revision: https://phabricator.services.mozilla.com/D145241
2022-05-03 16:37:19 +00:00
Scott
010628155f Bug 1764098 - Pocket newtab save to Pocket context menu items don't turn off if Pocket is turned off. r=gvn
Differential Revision: https://phabricator.services.mozilla.com/D144178
2022-05-02 19:21:06 +00:00
Meg Viar
b6ce459405 Bug 1765145 - The “Sign in” button is hardly visible if the browser is vertically resized and the “Dark” theme is enabled r=Mardak,emcminn
Differential Revision: https://phabricator.services.mozilla.com/D144725
2022-05-02 15:16:21 +00:00
Meg Viar
3cfd9ed1aa Bug 1764626 - Differentiate between about:welcome and Spotlight context when sending event telemetry r=Mardak
Differential Revision: https://phabricator.services.mozilla.com/D143645
2022-04-27 15:12:41 +00:00
Norisz Fay
9250bc1d10 Backed out changeset 392ddb43da5b (bug 1764626) for causing bc failures on browser_multistage_spotlight_telemetry.js CLOSED TREE 2022-04-26 23:30:45 +03:00
Meg Viar
de6da2f0b5 Bug 1764626 - Differentiate between about:welcome and Spotlight context when sending event telemetry r=Mardak
Differential Revision: https://phabricator.services.mozilla.com/D143645
2022-04-26 19:11:27 +00:00
Barret Rennie
f726644db9 Bug 1766430 - Allow additional properties in Spotlight content r=Mardak
Differential Revision: https://phabricator.services.mozilla.com/D144722
2022-04-26 16:22:50 +00:00
Meg Viar
4ca1752455 Bug 1765823 - Clean up use of .corner class in AboutWelcome in favor of [pos] attribute r=pdahiya
Differential Revision: https://phabricator.services.mozilla.com/D144319
2022-04-25 21:03:33 +00:00
Barret Rennie
ad38c46862 Bug 1766091 - Fix UpdateAction.schema.json r=emcminn
Differential Revision: https://phabricator.services.mozilla.com/D144504
2022-04-25 18:34:03 +00:00
Ed Lee
d2a49d9482 Bug 1766051 - Replace some title styles with more configuration, e.g., font weight, line height, margin r=mviar
Differential Revision: https://phabricator.services.mozilla.com/D144474
2022-04-22 21:48:11 +00:00
Arjun Krishna Babu
e391b3f3df Bug 1765456 - Move the cancel icon used by about:newtab to the shared icon library in toolkit/themes/shared/icons r=sfoster,desktop-theme-reviewers
This was done because the existing cancel icon (browser/components/newtab/data/content/assets/glyph-cancel-16.svg) is a variation of the (/toolkit/themes/shared/icons/close.svg) in the toolkil icon library and it makes sense for the former to live alongside the latter.

Differential Revision: https://phabricator.services.mozilla.com/D144075
2022-04-22 16:12:42 +00:00
manisha27
3763dc503e Bug 1765459 - Remove glypg-edit-16.svg and use edit.svg. r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D144245
2022-04-22 16:04:50 +00:00
Cosmin Sabou
4f0b39c946 Backed out changeset 252f5225f556 (bug 1764626) for causing bc failures on browser_multistage_spotlight.js. CLOSED TREE 2022-04-22 00:15:02 +03:00
Meg Viar
1310ce21d4 Bug 1764626 - Differentiate between about:welcome and Spotlight context when sending event telemetry r=Mardak
Differential Revision: https://phabricator.services.mozilla.com/D143645
2022-04-21 20:25:20 +00:00
Punam Dahiya
9d4973a078 Bug 1763825 - Handle about:welcome and spotlight dialog display for shorter screen width r=Mardak,emcminn
Differential Revision: https://phabricator.services.mozilla.com/D143438
2022-04-21 17:43:56 +00:00
Csoregi Natalia
e02112b431 Backed out changeset 4610b9c86ea0 (bug 1763825) for causing node failures. CLOSED TREE 2022-04-21 19:58:24 +03:00
Punam Dahiya
1774f5ac97 Bug 1763825 - Handle about:welcome and spotlight dialog display for shorter screen width r=Mardak,emcminn
Differential Revision: https://phabricator.services.mozilla.com/D143438
2022-04-21 16:24:01 +00:00
manisha27
8a318457ed Bug 1739139 - Move and rename the topsite icon. r=sfoster,desktop-theme-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D144211
2022-04-21 00:38:31 +00:00
Meg Viar
597a2b032f Bug 1764890 - A scrollbar is displayed for a few seconds on the bottom-right part of the “about:welcome” page while a refresh action is performed r=emcminn
Differential Revision: https://phabricator.services.mozilla.com/D144058
2022-04-20 15:41:21 +00:00
Meg Viar
19b16d1f64 Bug 1764070 - Differentiate between auto advance and user click when sending Spotlight/AboutWelcome event telemetry r=Mardak
Differential Revision: https://phabricator.services.mozilla.com/D143767
2022-04-19 22:43:15 +00:00
Ed Lee
2404595768 Bug 1765130 - [Upgrade spotlight] The bottom part of the "g" letter from the "gracias" string is cut off on Firefox es-ES locale r=mviar
Differential Revision: https://phabricator.services.mozilla.com/D143922
2022-04-18 17:24:13 +00:00
Ed Lee
076d73d31f Bug 1764535 - The “about:welcome” page is broken on Firefox AR locale if the Central Kurdish OS language is set r=gregtatum
Differential Revision: https://phabricator.services.mozilla.com/D143646
2022-04-14 00:44:46 +00:00
Meg Viar
e3ec61e716 Bug 1762471 - For AboutWelcome screens, use screen index rather than setting screen order explicitly in the config r=Mardak
Differential Revision: https://phabricator.services.mozilla.com/D142860
2022-04-11 14:53:38 +00:00
Emily McMinn
b92444a2a1 Bug 1762433 - Fixes for Windows HCM r=mviar
Fixes for these points from the a11y review of Private Browsing:


   -the download button should have a border (color: ButtonText) when it is hovered so the text itself doesn’t bleed into the background

   -the border on the close button should use ButtonText

   -the google play and app store buttons in the dialog seem to be images, and the images already have borders so adding the button border like we’d normally makes it look fuzzy/visually indistinct. Ideally I’d remove the border from the image and rely on the CSS styling to add the (dynamic) border back in, but we could also remove the border in HCM since this content wont be adaptive anyway (and I think having the additional border here is actually harming the UX)

Differential Revision: https://phabricator.services.mozilla.com/D143092
2022-04-07 21:01:06 +00:00
Meg Viar
ca80b2c7d1 Bug 1763470 - Accessibility updates for FX100 upgrade dialog r=Mardak
Differential Revision: https://phabricator.services.mozilla.com/D143182
2022-04-07 19:22:30 +00:00
jaia
f2293a83dc Bug 1708511 Rename glyph-modal-delete32.sv to match actual size. r=amy
file name changed in:
browser/components/newtab/data/content/assets/
browser/components/newtab/content-src/styles/_icons.scss
browser/components/newtab/css/activity-stream-mac.css
browser/components/newtab/css/activity-stream-linux.css
browser/components/newtab/css/activity-stream-windows.css
obj-aarch64-apple-darwin20.6.0/faster/install_dist_bin_browser.track

Differential Revision: https://phabricator.services.mozilla.com/D142283
2022-04-04 21:14:44 +00:00
Meg Viar
9bf58262eb Bug 1762273 - Adjust thank you screen square-ish sizing with noodles, transitions, auto advance without showing Home r=Mardak
Differential Revision: https://phabricator.services.mozilla.com/D142839
2022-04-04 17:27:24 +00:00
Dan Mosedale
a31d8c10ce Bug 1762718 - Zap underline text overlap in welcome screen, r=Mardak
Differential Revision: https://phabricator.services.mozilla.com/D142755
2022-04-03 15:29:21 +00:00
Emily McMinn
e227837f58 Bug 1762680 - Widen Zap for about:welcome hero text, r=dmose
Differential Revision: https://phabricator.services.mozilla.com/D142744
2022-04-02 03:00:25 +00:00
Dan Mosedale
0db7b287ce Bug 1762285 - Update about:welcome for Fx 100 Thank You, r=Mardak
Differential Revision: https://phabricator.services.mozilla.com/D142736
2022-04-02 02:31:14 +00:00
Emily McMinn
5ddae5a328 Bug 1762290 - Update hero text styling with configuration r=mviar
Differential Revision: https://phabricator.services.mozilla.com/D142633
2022-04-01 23:08:57 +00:00
Greg Tatum
c31c806286 Bug 1762659 - Use MozIntl for stand-alone display names in LangPackMatcher.jsm; r=Mardak,nordzilla
Differential Revision: https://phabricator.services.mozilla.com/D142730
2022-04-01 21:39:17 +00:00
Greg Tatum
9b10feee4b Bug 1762297 - Ensure the AW decline button resets the app locale; r=Mardak,platform-i18n-reviewers,nordzilla
Differential Revision: https://phabricator.services.mozilla.com/D142601
2022-04-01 21:39:16 +00:00
Greg Tatum
b85acfa2cb Bug 1762297 - Change buttons on about:welcome language prompt; r=Mardak,platform-i18n-reviewers,nordzilla,fluent-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D142516
2022-04-01 21:39:16 +00:00
Ed Lee
c3868ecccc Bug 1762488 - Remove text configuration nesting with raw unlocalized text r=emcminn
Also allow configuring styles like zap and color. Clean up some unnecessary conditional rendering as Localized already handles that.

Differential Revision: https://phabricator.services.mozilla.com/D142673
2022-04-01 16:20:45 +00:00
Meg Viar
7af292471e Bug 1762291 - Allow body text for corner screen with wider/adjusted sizing and whitespace r=Mardak,emcminn
Differential Revision: https://phabricator.services.mozilla.com/D142618
2022-04-01 13:03:27 +00:00
Meg Viar
48fd34f067 Bug 1762242 - Conditionally show Private Browsing page Focus promo r=dmose
Differential Revision: https://phabricator.services.mozilla.com/D142551
2022-04-01 12:36:30 +00:00
Meg Viar
b7856c7762 Bug 1762052 - Multistage spotlight shows 1 fewer steps than expected r=emcminn
Differential Revision: https://phabricator.services.mozilla.com/D142378
2022-03-31 15:19:14 +00:00
Meg Viar
c1236a3d66 Bug 1762194 - Update schema in for mobile downloads in Spotlight/AboutWelcome r=Mardak
Differential Revision: https://phabricator.services.mozilla.com/D142456
2022-03-31 11:52:22 +00:00
Meg Viar
797fee1e4e Bug 1762180 - Fix typo in aboutwelcome.scss r=emcminn
Differential Revision: https://phabricator.services.mozilla.com/D142453
2022-03-30 22:08:52 +00:00
Meg Viar
b11c2e323c Bug 1760169 - Ensure proper RTL display in new Spotlight messaging surface r=dmose
Differential Revision: https://phabricator.services.mozilla.com/D141604
2022-03-30 15:36:18 +00:00
Meg Viar
939d051b6f Bug 1754247 - Add marketplace image icons inside spotlight modal for list of supported locales r=Mardak,Gijs
Depends on D141965

Differential Revision: https://phabricator.services.mozilla.com/D141022
2022-03-29 22:46:59 +00:00
Meg Viar
1db2a0f1c1 Bug 1761250 - Enable showing Klar QR to users with de locale in Focus promos using Spotlight in PBM r=Mardak
Differential Revision: https://phabricator.services.mozilla.com/D141965
2022-03-29 17:24:11 +00:00
Meg Viar
d58d6f81ba Bug 1761249 - The outline of the marketplace buttons from the “Get Firefox Focus” spotlight modal is not fully visible when the Dark theme is enable r=Mardak
Differential Revision: https://phabricator.services.mozilla.com/D142270
2022-03-29 14:48:52 +00:00
Barret Rennie
af694af439 Bug 1752665 - Make the Spotlight schema less strict with respect to images r=emcminn
The previous changes to the Spotlight schema made one of the logo.imageURL or
logo.imageId required. However, this is not backwards compatible with the older
Firefoxen, so we have to support the case where `logo` is present (e.g., for
`image.size`) without either of those properties, but `logoImageURL` *is*
present.

Differential Revision: https://phabricator.services.mozilla.com/D140761
2022-03-25 00:01:21 +00:00
Barret Rennie
4db190e51d Bug 1752665 - Rewrite PanelTestProvider test as xpcshell test with new json schema validator r=andreio
Differential Revision: https://phabricator.services.mozilla.com/D138927
2022-03-25 00:01:20 +00:00
Barret Rennie
570a0f103e Bug 1757809 - Provide a JsonSchema module that supports additional Mozilla-specific formats r=mossop,emcminn
In migrating from Ajv 6 to @cfworker/json-schema, some schemas will no longer
validate due to the `format: uri` annotation only being a suggestion for
strings in Ajv 6. Our URLs that use %PLACEHOLDERS% (e.g., `%LOCALE%`) will not
pass validation as URIs due to being interpreted as invalid URL encoding.

Here we add a facade in front of @cfworker/json-schema which defines a
`moz-url-format` format for strings, which runs them through
Services.urlFormatter.formatURL before attempting to validate them as URIs. We
don't simply find-replace all %PLACEHOLDERS% because the URL formatter service
only supports certain variables and will leave undefined variables as-is,
leading to a validation error (which is what we want).

Differential Revision: https://phabricator.services.mozilla.com/D138926
2022-03-25 00:01:18 +00:00
Meg Viar
9e6c3b20df Bug 1758028 - Implement PBM modal content as per finalized design r=pdahiya,preferences-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D140739
2022-03-23 14:03:18 +00:00