- removes `about:firefoxview-next` route
- `about:firefoxview` now points to `firefoxview-next.html` (until we rename)
- remove pref for `browser.tabs.firefox-view-next`
- preserve pref for `browser.tabs.firefox-view-newIcon` as part of firefoxViewNext feature manifest (until experiment is over)
- whitelist unreferenced files in `browser_all_files_referenced.js` as they will be removed in child Bug 1869833
Differential Revision: https://phabricator.services.mozilla.com/D196093
- removes `about:firefoxview-next` route
- `about:firefoxview` now points to `firefoxview-next.html` (until we rename)
- remove pref for `browser.tabs.firefox-view-next`
- preserve pref for `browser.tabs.firefox-view-newIcon` as part of firefoxViewNext feature manifest (until experiment is over)
- whitelist unreferenced files in `browser_all_files_referenced.js` as they will be removed in child Bug 1869833
Differential Revision: https://phabricator.services.mozilla.com/D196093
This patch removes all tests covering the old Firefox View whilst preserving those that cover Next.
- Removed tests that have been replaced/amended for the new incarnation of View can be found in browser/components/firefoxview/tests/browser/firefoxview-next/.
- Test coverage that still requires porting over to the new incarnation is documented in bug 1869643.
- `browser_sma_open_firefoxview.js` also removed as referenced in meta bug 1850501.
- Skip feature callout tests as tests reference legacy view elements which are removed in bug 1869833. Feature callout to be removed in bug 1870296
- Remove `browser_sma_click_element.js` as tests reference legacy view elements which are removed in bug 1869833
Ideally this patch will be landed alongside patches that:
- update the view pref
- update the about redirector
- remove all legacy Firefox View files and assets
Differential Revision: https://phabricator.services.mozilla.com/D196080
When the D195198 would be ready to land, there are a few tests that are going to be passing all a11y-checks or some of them, thus we need to update the manifest to remove `skip-if` notations when appropriate and update the comments in the remaining tests
Depends on D195198
Differential Revision: https://phabricator.services.mozilla.com/D195745
Several `show-all-link` controls lack interactive role - this would prevent users of speech-to-text/Voice Control from being able to send a click to it by calling its label and screen reader users and users of other assistive technology would not be able to get to this control via shortcuts like a list of controls, etc. Being focusable with keyboard does not guarantee that assistive technology could guess that this programmatically static text is, in fact, interactive.
While providing an explicit ARIA `role` to the element is going [against the First Rule of ARIA](https://www.w3.org/TR/using-aria/#rule1) while semantically appropriate HTML elements exist - `<a>` anchor (for the visual appearance of this control) or `<button>` (for the actual functionality that this control performs) - this patch would at least remove the barrier for assistive technology to be able to set interactivity expectations to this control appropriately.
No test manifests are being updated, because there are other elements in the updated test files that are failing a11y-checks, besides these `show-all-link` controls.
Differential Revision: https://phabricator.services.mozilla.com/D197349
- removes about:firefoxview-next route
- about:firefoxview now points to firefoxview-next.html (until we rename)
- remove pref for browser.tabs.firefox-view-next
- preserve pref for browser.tabs.firefox-view-newIcon as part of firefoxViewNext feature manifest (until experiment is over)
Depends on D196080
Differential Revision: https://phabricator.services.mozilla.com/D196093
This patch removes all tests covering the old Firefox View whilst preserving those that cover Next.
- Removed tests that have been replaced/amended for the new incarnation of View can be found in browser/components/firefoxview/tests/browser/firefoxview-next/.
- Test coverage that still requires porting over to the new incarnation is documented in bug 1869643.
- `browser_sma_open_firefoxview.js` also removed as referenced in meta bug 1850501.
Ideally this patch will be landed alongside patches that:
- update the view pref
- update the about redirector
- remove all legacy Firefox View files and assets
Differential Revision: https://phabricator.services.mozilla.com/D196080
This patch removes all tests covering the old Firefox View whilst preserving those that cover Next.
- Removed tests that have been replaced/amended for the new incarnation of View can be found in browser/components/firefoxview/tests/browser/firefoxview-next/.
- Test coverage that still requires porting over to the new incarnation is documented in bug 1869643.
- `browser_sma_open_firefoxview.js` also removed as referenced in meta bug 1850501.
Ideally this patch will be landed alongside patches that:
- update the view pref
- update the about redirector
- remove all legacy Firefox View files and assets
Differential Revision: https://phabricator.services.mozilla.com/D196080
Ensuring the `Enter` and `Space` keys are working to activate the Clear button in Firefox View and adding a few tests to prevent regressions.
Differential Revision: https://phabricator.services.mozilla.com/D196070
Slightly different from the previous search revisions. In this case, rather than having their own search boxes, the recent browsing components share a single search box located within the parent element. Thus, `fxview-search-textbox-query` event listeners are added/removed from the //parent// component rather than the components themselves.
Differential Revision: https://phabricator.services.mozilla.com/D195596
* Create a new OpenTabsContextMenu to replace the inlined menu content in the open tabs template
* Fetch the devices list when the menu opens, rather than updating it in the background
* Add a getLogger to the helpers module to easily create named loggers
Differential Revision: https://phabricator.services.mozilla.com/D193138
There are 2 tests that are related to the bug 1867170 changes to the AccessibilityUtils, and the general case of the `<fxview-category-button>` and other navigation sidebar-related focusability false-positive a11y-check fails. We are temporary add `skip-if` condition to these two failing tests while we continue working on the bug 1867378 work to fine-tune the AccessibilityUtils. The bug 1867378 patch would also include removing those temporary `skip-if`s from the Fx View manifest too.
Related Firefox View bugs:
- Disabling tests: meta bug 1854625
- Investigation and remediation for components with disabled tests: meta bugs 1854625 and 1858041
- Explore capturing click events for a11y_checks: bug 1692110
Differential Revision: https://phabricator.services.mozilla.com/D195461
- Moved "footer" to within sticky container above cards and renamed to "header".
- Update "Connect another device" button to use the `.small-button` styling
- Conditionally display `Recently closed tabs` `h2` on the corresponding view only (an existing bug revealed in this patch)
- Update `.sticky-container` to reflect upcoming styling with the inclusion of search and other secondary headers.
Please see link to bug for screenshot of intended appearance.
Differential Revision: https://phabricator.services.mozilla.com/D193930
- Increase vertical padding for card subheaders
- Updated device headers to font size 15px
- Decreased space between rows to 6px
- Fix vertical alightment of headers and rows
- Update device headers to fontweight 500
Differential Revision: https://phabricator.services.mozilla.com/D193848
Amending the `getRecentTabs` function eliminates one of the duplicate calls to `getTabClients`. I opted for this approach as opposed
to getting tabs from clients or vice versa because that involved a larger refactor that ended up adding unnecessary noise to the
`getRecentTabs` and `getTabClients` return values. Combined with a patch by @sfoster, we have reduced the number of calls from 9 to 1.
Differential Revision: https://phabricator.services.mozilla.com/D194656
Amending the `getRecentTabs` function eliminates one of the duplicate calls to `getTabClients`. I opted for this approach as opposed
to getting tabs from clients or vice versa because that involved a larger refactor that ended up adding unnecessary noise to the
`getRecentTabs` and `getTabClients` return values. Combined with a patch by @sfoster, we have reduced the number of calls from 9 to 1.
Differential Revision: https://phabricator.services.mozilla.com/D194656
