Commit Graph

959 Commits

Author SHA1 Message Date
Stanca Serban
e8c7c166cb Bug 1875877 - Fix typo error in disabling patch. CLOSED TREE 2024-10-31 03:34:09 +02:00
Stanca Serban
e1048de1cb Bug 1875877 - Disable browser_opentabs_recency.js on win opt and linux 18.04 x64 for causing frequent failures. r=intermittent-reviewers,fxview-reviewers,jmaher
Differential Revision: https://phabricator.services.mozilla.com/D227044
2024-10-31 01:19:13 +00:00
Sarah Clements
7d2061ccba Bug 1923753 - Update empty and error state assets for sidebar and firefox view r=sidebar-reviewers,fxview-reviewers,kcochrane,desktop-theme-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D226906
2024-10-30 18:27:18 +00:00
Adi
8c0ce350f4 Bug 1880113 - Adjust skip-if on Linux for frequent failures. r=intermittent-reviewers,fxview-reviewers,jmaher,nsharpley DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D227325
2024-10-30 14:56:08 +00:00
Stuart Colville
6bd05b9603 Bug 1926119: Remove 2nd empty-state string for don't remember history. r=sidebar-reviewers,fluent-reviewers,fxview-reviewers,sclements
Differential Revision: https://phabricator.services.mozilla.com/D226453
2024-10-23 10:31:29 +00:00
Stuart Colville
7f22a561de Bug 1911749 - Update History and Tabs from other devices strings shared with FxView. r=sidebar-reviewers,fluent-reviewers,bolsson,fxview-reviewers,nsharpley
Differential Revision: https://phabricator.services.mozilla.com/D225550
2024-10-17 17:43:08 +00:00
Cosmin Sabou
162894add1 Backed out changeset 290a68970e02 (bug 1911749) for causing bc failures on browser_history_firefoxview. 2024-10-17 00:50:02 +03:00
Stuart Colville
56b5279a66 Bug 1911749 - Update History and Tabs from other devices strings shared with FxView. r=sidebar-reviewers,fluent-reviewers,bolsson,fxview-reviewers,nsharpley
Differential Revision: https://phabricator.services.mozilla.com/D225550
2024-10-16 18:46:35 +00:00
Sammy Khamis
9b8c4c982e Bug 1920852: Add closing tabs remotely to Firefox View r=lina,fxview-reviewers,jsudiaman
Differential Revision: https://phabricator.services.mozilla.com/D223448
2024-10-01 21:08:02 +00:00
Florian Quèze
03b00e2a53 Bug 1918702 - Migrate telemetry events to use Glean APIs for firefoxview, r=chutten,fxview-reviewers,jsudiaman.
Differential Revision: https://phabricator.services.mozilla.com/D222416
2024-09-20 13:58:15 +00:00
Joel Maher
beccd9e33d Bug 1917222 - remove skip-if statements when the tests pass for browser-chrome browser/components/a-pref. r=aryx,extension-reviewers,settings-reviewers,credential-management-reviewers,fxview-reviewers,omc-reviewers,migration-reviewers,home-newtab-reviewers,robwu,mconley,dimi,nsharpley,thecount,pdahiya
Differential Revision: https://phabricator.services.mozilla.com/D221307
2024-09-19 02:52:04 +00:00
Dão Gottwald
5d7638a38d Bug 1917337 - Implement --text-color-disabled. r=desktop-theme-reviewers,reusable-components-reviewers,emilio,hjones
Differential Revision: https://phabricator.services.mozilla.com/D222503
2024-09-18 17:30:35 +00:00
Jonathan Sudiaman
15ad15eecf Bug 1898250 - Add telemetry to sidebar r=sidebar-reviewers,fxview-reviewers,sclements
Differential Revision: https://phabricator.services.mozilla.com/D220720
2024-09-16 15:42:48 +00:00
Sammy Khamis
664da6aa2d Bug 1911626: Add closing tabs remotely to sidebar right click menu r=lina,fluent-reviewers,desktop-theme-reviewers,fxview-reviewers,sidebar-reviewers,dao,sclements,sync-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D220653
2024-09-13 09:26:19 +00:00
Sammy Khamis
8978600c7e Bug 1911626: Add closing tabs remotely to sidebar r=markh,lina,fluent-reviewers,desktop-theme-reviewers,fxview-reviewers,sync-reviewers,sidebar-reviewers,dao,jsudiaman
Differential Revision: https://phabricator.services.mozilla.com/D218902
2024-09-13 09:26:19 +00:00
Tamas Szentpeteri
eba01497a5 Backed out 2 changesets (bug 1911626) for causing mochitest crashes on browser_view_sidebar_menu.js (finished). CLOSED TREE
Backed out changeset ed0f57c2d2af (bug 1911626)
Backed out changeset 2ee9263eea02 (bug 1911626)
2024-09-11 02:33:31 +03:00
Sammy Khamis
86ed2fd87f Bug 1911626: Add closing tabs remotely to sidebar right click menu r=lina,fluent-reviewers,desktop-theme-reviewers,fxview-reviewers,sidebar-reviewers,dao,sclements
Differential Revision: https://phabricator.services.mozilla.com/D220653
2024-09-10 20:25:48 +00:00
Sammy Khamis
adb6977d3c Bug 1911626: Add closing tabs remotely to sidebar r=markh,lina,fluent-reviewers,desktop-theme-reviewers,fxview-reviewers,sync-reviewers,sidebar-reviewers,dao,jsudiaman
Differential Revision: https://phabricator.services.mozilla.com/D218902
2024-09-10 20:25:47 +00:00
Eemeli Aro
b3031aa097 Bug 1889417 - Fix minor Fluent bugs in various tests. r=fluent-reviewers,credential-management-reviewers,fxview-reviewers,places-reviewers,omc-reviewers,backup-reviewers,urlbar-reviewers,dimi,Standard8,nsharpley,mconley,flod,emcminn
Issues revealed by adding a `MOZ_ASSERT(false)` in Fluent error reporting and trawling through the resulting logs.

Differential Revision: https://phabricator.services.mozilla.com/D221421
2024-09-10 19:03:18 +00:00
Cristina Horotan
642444af1a Backed out changeset d2fdb97d5f1c (bug 1911626) for causing bc failures at browser_firefoxview_search_telemetry.js 2024-09-04 05:32:22 +03:00
Sammy Khamis
918abfd86c Bug 1911626: Add closing tabs remotely to sidebar r=markh,lina,fluent-reviewers,desktop-theme-reviewers,fxview-reviewers,sync-reviewers,sidebar-reviewers,dao,jsudiaman
Differential Revision: https://phabricator.services.mozilla.com/D218902
2024-09-04 00:48:53 +00:00
Sam Foster
231863194c Bug 1913779 - Check if initial history cache entries are available before rendering the history sidebar. r=jsudiaman,sidebar-reviewers,fxview-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D220198
2024-08-27 17:14:30 +00:00
Stuart Colville
bd12dbfb2e Bug 1914330 - test non autofocus case of fxview-search-textbox explicitly r=fxview-reviewers,jsudiaman
Differential Revision: https://phabricator.services.mozilla.com/D219865
2024-08-22 18:28:32 +00:00
Jonathan Sudiaman
0091e139e7 Bug 1909704 - Add three-dot menu to history and right-click menu for history and synced tabs r=sidebar-reviewers,fluent-reviewers,fxview-reviewers,nsharpley,sclements
- Custom right-click menu for History and Synced Tabs.
- Three dot menu for changing sort option and clearing history.
- Tests for Synced Tabs and right-click menu in History.

Differential Revision: https://phabricator.services.mozilla.com/D218741
2024-08-22 15:19:02 +00:00
Stuart Colville
67cd79d978 Bug 1912562 - add autofocus to searchbox component and use in sidebar history and synctabs r=sidebar-reviewers,fxview-reviewers,nsharpley
Differential Revision: https://phabricator.services.mozilla.com/D219617
2024-08-21 12:33:17 +00:00
yanislgha
b4ad19f807 Bug 1912513 - Change delete from history button to trash icon. r=jsudiaman,fxview-reviewers,sidebar-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D219017
2024-08-12 19:27:28 +00:00
Nikki Sharpley
a441acbbaa Bug 1886847 - Styling and UI polish for sidebar r=sidebar-reviewers,desktop-theme-reviewers,fxview-reviewers,reusable-components-reviewers,dao,settings-reviewers,tgiles,mconley,jsudiaman,kcochrane
- styled synced tabs and history
- styled sidebar search
- styled customize settings
- added sidebar right icon to customize input

Differential Revision: https://phabricator.services.mozilla.com/D216748
2024-08-02 19:10:14 +00:00
Butkovits Atila
dd41b6e962 Backed out changeset 397b2df59338 (bug 1886847) for causing failures at browser-custom-colors.css. CLOSED TREE 2024-08-02 19:18:43 +03:00
Nikki Sharpley
54d0b76fd9 Bug 1886847 - Styling and UI polish for sidebar r=sidebar-reviewers,desktop-theme-reviewers,fxview-reviewers,reusable-components-reviewers,dao,settings-reviewers,tgiles,mconley,jsudiaman,kcochrane
- styled synced tabs and history
- styled sidebar search
- styled customize settings
- added sidebar right icon to customize input

Differential Revision: https://phabricator.services.mozilla.com/D216748
2024-08-02 15:26:00 +00:00
Sammy Khamis
994493e803 Bug 1909783: Synced tabs list should de-dupe r=markh,fxview-reviewers,sync-reviewers,tabbrowser-reviewers,firefox-desktop-core-reviewers ,dao
Differential Revision: https://phabricator.services.mozilla.com/D217700
2024-07-26 20:31:03 +00:00
Jonathan Sudiaman
4976e075f8 Bug 1886408 - History in sidebar: Remove row limit, fix empty state, add hover button. r=sidebar-reviewers,desktop-theme-reviewers,fxview-reviewers,fluent-reviewers,kcochrane,nsharpley
- max-history-rows pref set to 0 for Nightly only.
- Add the X button to close a tab on hover.
- Introduce an extension to `fxview-tab-list` which handles the differences between here and FxView.
- Reuse the empty state for when history is cleared (same as firefox view).
- Update the logic of `fxview-empty-state` to allow for opening prefs link in the parent window (instead of the sidebar browser).

Differential Revision: https://phabricator.services.mozilla.com/D217111
2024-07-25 16:03:17 +00:00
Sandor Molnar
94a8e09b3e Bug 1880113 - Disable browser_firefoxview_search_telemetry.js on linux for frequent failures. r=fxview-reviewers,nsharpley DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D216512
2024-07-17 13:25:05 +00:00
Jonathan Sudiaman
3fe0267737 Bug 1904868 - Fix leaks from PlacesQuery when closing during a fetch in progress r=sidebar-reviewers,fxview-reviewers,places-reviewers,Standard8
https://treeherder.mozilla.org/#/jobs?repo=try&revision=05328f734d54c873b30256da3cdf783a73abab50

Differential Revision: https://phabricator.services.mozilla.com/D215023
2024-07-01 16:53:41 +00:00
Sarah Clements
a8324c033d Bug 1905662 - Update firefoxview triage rotation r=fxview-reviewers,kcochrane
Differential Revision: https://phabricator.services.mozilla.com/D215362
2024-07-01 12:36:28 +00:00
Kelly Cochrane
e2fe9bf11e Bug 1899576 - Create a reusable sidebar header component with a close button r=desktop-theme-reviewers,fxview-reviewers,sidebar-reviewers,fluent-reviewers,nsharpley,Itiel
Differential Revision: https://phabricator.services.mozilla.com/D213278
2024-06-18 18:24:08 +00:00
pstanciu
e91ba02454 Backed out changeset ab055e5ace5e (bug 1899576) for causing bc failures on browser_all_files_referenced.js CLOSED TREE 2024-06-18 20:49:29 +03:00
Kelly Cochrane
c8bfc52deb Bug 1899576 - Create a reusable sidebar header component with a close button r=desktop-theme-reviewers,fxview-reviewers,sidebar-reviewers,fluent-reviewers,nsharpley,Itiel
Differential Revision: https://phabricator.services.mozilla.com/D213278
2024-06-18 16:03:11 +00:00
hanna alemu
d7c67f44bd Bug 1828508 - Clean up Firefox View Feature Tour + Notification r=omc-reviewers,fluent-reviewers,fxview-reviewers,nsharpley,bolsson,aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D209404
2024-06-11 18:24:35 +00:00
Sukhmeet
3ad327de7f Bug 1893013 - Remove browser.firefox-view.search.enabled preference r=kcochrane,fxview-reviewers,jsudiaman
Differential Revision: https://phabricator.services.mozilla.com/D211353
2024-06-03 15:12:53 +00:00
Jonathan Sudiaman
8dec778c2c Bug 1859774 - Add new Firefox View search component to Storybook r=kcochrane,fluent-reviewers,fxview-reviewers,reusable-components-reviewers,hjones
Simplified debouncing logic to avoid depending on DeferredTask. Add missing `aria-label` which is needed for the edge case of showing a search box without placeholder.

Differential Revision: https://phabricator.services.mozilla.com/D210701
2024-05-24 20:32:56 +00:00
Norisz Fay
f646873f96 Backed out changeset 223f467f78df (bug 1859774) for causing mochitest failures on test_fxview_search_textbox.html CLOSED TREE 2024-05-24 19:04:17 +03:00
Jonathan Sudiaman
dec03dc0a3 Bug 1859774 - Add new Firefox View search component to Storybook r=kcochrane,fluent-reviewers,fxview-reviewers,reusable-components-reviewers,hjones
Simplified debouncing logic to avoid depending on DeferredTask. Add missing `aria-label` which is needed for the edge case of showing a search box without placeholder.

Differential Revision: https://phabricator.services.mozilla.com/D210701
2024-05-24 15:16:26 +00:00
Sandor Molnar
a92ccd5e4d Backed out changeset 56007d13fdf6 (bug 1859774) for causing mochitest failures @ browser/components/firefoxview/tests/chrome/test_fxview_search_textbox.html CLOSED TREE 2024-05-24 00:46:06 +03:00
Jonathan Sudiaman
37a0386948 Bug 1859774 - Add new Firefox View search component to Storybook r=kcochrane,fluent-reviewers,fxview-reviewers,reusable-components-reviewers,hjones
Simplified debouncing logic to avoid depending on DeferredTask. Add missing `aria-label` which is needed for the edge case of showing a search box without placeholder.

Differential Revision: https://phabricator.services.mozilla.com/D210701
2024-05-23 20:20:03 +00:00
Jonathan Sudiaman
bc6869de58 Bug 1883231 - Don't update search results for a stale query in Firefox View. r=nsharpley,fxview-reviewers,places-reviewers,Standard8,sidebar-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D208946
2024-05-09 13:34:37 +00:00
Jules Simplicio
0f6dcad1df Bug 1894393 - Undo the Firefox View work that made tab attention dot color in Linux and lwt on hcm match between chrome and in-content r=desktop-theme-reviewers,fxview-reviewers,emilio,kcochrane
Per https://bugzilla.mozilla.org/show_bug.cgi?id=1884351 and after discussing with theme developers, and Amy Lee from UX, we decided to stick to Linux's existing theming pattern (use platform accent color for chrome accents, and design system colors for in-content), and undo the work that made Firefox's View attention dot color match between in-content and chrome.

Differential Revision: https://phabricator.services.mozilla.com/D209073
2024-05-01 03:58:09 +00:00
Jonathan Sudiaman
22ee9cc924 Bug 1887220 - Rework map computations in history r=fxview-reviewers,places-reviewers,sidebar-reviewers,nsharpley,sclements
- Consolidates `historyMapByDate`, `historyMapBySite`, and `searchResults` into one single `historyCache`, which represents all of the visits that should be rendered by the host and what options are currently in place.
- Converts `HistoryController` to a system level module.
- Adds preventative code to account for race conditions in cases during test verification.

Differential Revision: https://phabricator.services.mozilla.com/D207861
2024-04-30 20:03:14 +00:00
Jonathan Sudiaman
a1780ebc7d Bug 1867614 - fxview-tab-list story is broken, shows a "ChromeUtils is not defined" error r=fxview-reviewers,reusable-components-reviewers,hjones,nsharpley
Remove transitive dependency on `ChromeUtils` that is causing this error.

Differential Revision: https://phabricator.services.mozilla.com/D208380
2024-04-23 21:26:09 +00:00
dschomburg
9f03a40c4f Bug 1853818 - Remove toolkit/branding/accounts.ftl file r=flod,fluent-reviewers,settings-reviewers,credential-management-reviewers,fxview-reviewers,omc-reviewers,firefox-desktop-core-reviewers ,mconley,aminomancer,mak,sgalich,nsharpley,mkaply
Differential Revision: https://phabricator.services.mozilla.com/D190612
2024-04-22 16:24:30 +00:00
Nikki Sharpley
048795cc79 Bug 1887237 - Intermittent TV browser/components/firefoxview/tests/browser/browser_firefoxview_paused.js r=fxview-reviewers,kcochrane
- reduce number of tests in `browser_firefoxview_paused.js` to solve timeout issue

Differential Revision: https://phabricator.services.mozilla.com/D207453
2024-04-17 20:02:08 +00:00