corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
882,799 Commits 1 Branch 0 Tags
a712bf384008e5f845bdc0b30d2f261e83dfb51a
Commit Graph

959 Commits

Author SHA1 Message Date
Nikki Sharpley
b5e05a75af Bug 1883714 - Prioritise styling for attention class over bookmark and pinnedOnNewTab r=fxview-reviewers,desktop-theme-reviewers,kcochrane 
The bug report showed the tabs that were pinned and bookmarked shift the notification dot position.
This fix excludes `.attention` from positional styling applied to `.pinnedOnNewTab` and `.bookmark` classes

Differential Revision: https://phabricator.services.mozilla.com/D203923
 2024-03-07 20:58:38 +00:00
Kelly Cochrane
cd1bec4c24 Bug 1883890 - Ensure proper HCM styles are being applied to media button for pinned tabs in Fx View r=fxview-reviewers,ayeddi,nsharpley 
Differential Revision: https://phabricator.services.mozilla.com/D203827
 2024-03-07 18:32:21 +00:00
Kelly Cochrane
b530008ed4 Bug 1883628 - Wrap pinned tabs in Firefox View to a new line once there are more than one line's worth r=fxview-reviewers,nsharpley 
Differential Revision: https://phabricator.services.mozilla.com/D203635
 2024-03-07 14:47:57 +00:00
Cosmin Sabou
0e89801978 Bug 1877678 - Disable browser_opentabs_cards.js on linux and osx1100 opt for frequent failures. r=#intermittent-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D203861
 2024-03-07 00:19:37 +00:00
Kelly Cochrane
f9d8aa7f85 Bug 1883850 - Ensure selected moz-page-nav button remains selected upon page refresh of Fx View r=fxview-reviewers,jsudiaman 
Differential Revision: https://phabricator.services.mozilla.com/D203783
 2024-03-06 21:13:29 +00:00
Nikki Sharpley
0fed7c98ce Bug 1883610 - skip a11y tests for browser_history_firefoxview.js` temporarily r=ayeddi,fxview-reviewers 
Until we have a fix for the sidebar navigation component buttons, `moz-page-nav-button`, in bug 1850591, disable a11y tests referencing these buttons.

Differential Revision: https://phabricator.services.mozilla.com/D203617
 2024-03-06 21:05:26 +00:00
Hanna Jones
47bca262bf Bug 1880481 - Create a story for panel-list submenu r=reusable-components-reviewers,desktop-theme-reviewers,fxview-reviewers,emilio,sclements 
This patch adds a story for `panel-list` submenus to document how to create them. It also amends the README with a small code example, and moves the submenu slot creation out of the constructor to the connectedCallback, since we can't reliably read attribute values in custom element constructors.

Differential Revision: https://phabricator.services.mozilla.com/D202012
 2024-03-06 20:09:39 +00:00
Kelly Cochrane
bf4070efdc Bug 1883337 - Ensure focus is moved when mute/unmute button is removed in Fx View r=fxview-reviewers,nsharpley,jsudiaman 
Differential Revision: https://phabricator.services.mozilla.com/D203484
 2024-03-05 15:49:24 +00:00
Norisz Fay
81c5a0094d Backed out changeset c23d6a5f066e (bug 1883337) for causing bc failures on browser_opentabs_pinned_tabs.js CLOSED TREE 2024-03-05 17:10:15 +02:00
Kelly Cochrane
4a30e42b73 Bug 1883337 - Ensure focus is moved when mute/unmute button is removed in Fx View r=fxview-reviewers,nsharpley,jsudiaman 
Differential Revision: https://phabricator.services.mozilla.com/D203484
 2024-03-05 13:49:03 +00:00
Jonathan Sudiaman
79a9016c9f Bug 1883235 - [Firefox View] The search box cannot fully display CJK characters r=fxview-reviewers,sclements 
[Input size](https://searchfox.org/mozilla-central/source/browser/components/firefoxview/opentabs.mjs#216) of `30` approximately matches what's shown in [the spec](https://www.figma.com/file/wP9MY9KJn9xqPf140lTvTv/Fx-View-Specs-2023?type=design&node-id=6730-179702&mode=design&t=9DlykASuAzE3hP9S-0). Establish that as the minimum, and it will automatically expand for other locales as needed.

Differential Revision: https://phabricator.services.mozilla.com/D203477
 2024-03-04 20:33:13 +00:00
Nikki Sharpley
615a7e4a90 Bug 1876862 - Add extra logs and update waitForCondition to resolve browser_history_firefoxview.js timeouts r=fxview-reviewers,sclements,kcochrane 
- added extra log in for when `waitForCondition` `historyComponentReady` fails
- added extra `waitForCondition` for history component selection.
- added helper function for creating history entries

Try submission: https://treeherder.mozilla.org/jobs?repo=try&revision=4682e0db2e42e87278e9d6dd321c0174f67cfe49&selectedTaskRun=G8kefdugSt6U4J0VsfMsXQ.0

This seems to resolve bug 1877594 as well.

Differential Revision: https://phabricator.services.mozilla.com/D201223
 2024-03-04 17:55:35 +00:00
Jonathan Sudiaman
a85f5fcf62 Bug 1876165 - Create BookmarkList class that internally stays up-to-date to indicate bookmarked open tabs in Fx View r=mak,fxview-reviewers,places-reviewers,fluent-reviewers,bolsson,sfoster,desktop-theme-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D201759
 2024-03-04 13:02:16 +00:00
Nikki Sharpley
3d5f2a1927 Bug 1882605 - Fix intermittent browser_tab_list_keyboard_navigation failure due to reordering of tabs r=fxview-reviewers,kcochrane,jsudiaman 
This patch also disables `browser_tab_list_keyboard_navigation` a11y failing tests noted in Bug 1882597
until Bug 1850591 resolves a11y checks for the `moz-page-nav-button` button to be focusable.

Differential Revision: https://phabricator.services.mozilla.com/D203182
 2024-03-02 00:51:33 +00:00
Iulian Moraru
42888b21f8 Backed out changeset 901f008190e4 (bug 1882605) for causing bc failures on browser_tab_list_keyboard_navigation.js. CLOSED TREE 2024-03-01 19:44:29 +02:00
Nikki Sharpley
efe758b096 Bug 1882605 - Fix intermittent browser_tab_list_keyboard_navigation failure due to reordering of tabs r=fxview-reviewers,kcochrane,jsudiaman 
This patch also disables `browser_tab_list_keyboard_navigation` a11y failing tests noted in Bug 1882597
until Bug 1850591 resolves a11y checks for the `moz-page-nav-button` button to be focusable.

Differential Revision: https://phabricator.services.mozilla.com/D203182
 2024-03-01 16:50:59 +00:00
Iulian Moraru
26d2d56621 Backed out changeset bfb6942faf35 (bug 1876165) for causing multiple bc failures. CLOSED TREE 2024-03-01 16:20:18 +02:00
Jonathan Sudiaman
f4ce3f9847 Bug 1876165 - Create BookmarkList class that internally stays up-to-date to indicate bookmarked open tabs in Fx View r=mak,fxview-reviewers,places-reviewers,fluent-reviewers,bolsson,sfoster,desktop-theme-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D201759
 2024-03-01 13:34:08 +00:00
Nikki Sharpley
8dceebb0c7 Bug 1879609 - Add pinned indicator for urls pinned in New Tab r=fxview-reviewers,desktop-theme-reviewers,emilio 
- added pin icons to the tab row for tabs pinned in New Tab

Differential Revision: https://phabricator.services.mozilla.com/D201770
 2024-02-29 02:26:27 +00:00
Stanca Serban
c5104d8b31 Bug 1857298 - Fix lint failure in browser/components/firefoxview/tests/browser/browser_opentabs_pinned_tabs.js. a=lint-fix CLOSED TREE 2024-02-28 22:20:51 +02:00
Nikki Sharpley
487579b587 Bug 1857298 - Add close button to open tabs in view r=fxview-reviewers,fluent-reviewers,desktop-theme-reviewers,bolsson,sclements 
- created tertiary button option for tab rows, styled by a class prop
- added close button to open tabs rows
- removed close tab from open tab context menu
- updated tests to reflect removed panel item in open tab context menu
- added test for the new open tabs close button
- added telemetry for close open tab (requires data review)
- added test suite for keyboard navigation across tab row buttons

Depends on D201652

Differential Revision: https://phabricator.services.mozilla.com/D200689
 2024-02-28 19:37:22 +00:00
Stanca Serban
c67b0bdbfc Backed out 2 changesets (bug 1857298) for causing mochitests failures in browser_parsable_css.js. CLOSED TREE 
Backed out changeset 32ca524f7abf (bug 1857298)
Backed out changeset c4ed2e3e1ff2 (bug 1857298)
 2024-02-28 20:47:18 +02:00
Sandor Molnar
38ed31cc11 Bug 1857298 - Fix lint failure @ browser/components/firefoxview/tests/browser/browser_opentabs_pinned_tabs.js a=lint-fix CLOSED TREE 2024-02-28 19:52:12 +02:00
Nikki Sharpley
0fc9567678 Bug 1857298 - Add close button to open tabs in view r=fxview-reviewers,fluent-reviewers,desktop-theme-reviewers,bolsson,sclements 
- created tertiary button option for tab rows, styled by a class prop
- added close button to open tabs rows
- removed close tab from open tab context menu
- updated tests to reflect removed panel item in open tab context menu
- added test for the new open tabs close button
- added telemetry for close open tab (requires data review)
- added test suite for keyboard navigation across tab row buttons

Differential Revision: https://phabricator.services.mozilla.com/D200689
 2024-02-28 17:31:17 +00:00
Kelly Cochrane
32b2d59715 Bug 1849175 - Add pinned tabs to Open Tabs in Firefox View r=desktop-theme-reviewers,fxview-reviewers,fluent-reviewers,flod,sclements,nsharpley,dao 
Differential Revision: https://phabricator.services.mozilla.com/D201652
 2024-02-27 23:33:19 +00:00
Natalia Csoregi
20f1a3f6d6 Backed out 3 changesets (bug 1877678, bug 1849175) for causing failures on browser_opentabs_recency.js CLOSED TREE 
Backed out changeset 67fd66802500 (bug 1849175)
Backed out changeset da9aa1960b63 (bug 1877678)
Backed out changeset 8d9e1646bd6e (bug 1877678)
 2024-02-28 00:22:14 +02:00
Kelly Cochrane
4cd48be87c Bug 1849175 - Add pinned tabs to Open Tabs in Firefox View r=desktop-theme-reviewers,fxview-reviewers,fluent-reviewers,flod,sclements,nsharpley,dao 
Differential Revision: https://phabricator.services.mozilla.com/D201652
 2024-02-27 20:30:59 +00:00
Sam Foster
ae1907b174 Bug 1877678 - Improve window switching in the opentabs cards tests. r=fxview-reviewers,sclements 
* Adds a new switchToWindow helper and calls it in openFirefoxViewTab to ensure we wait until the window is active
* Fix some fallout from this change in the browser_opentabs_recency.js test

Differential Revision: https://phabricator.services.mozilla.com/D201861
 2024-02-27 18:26:18 +00:00
Sam Foster
a00823f347 Bug 1877678 - Split out the open tabs 'more' tests into their own file. r=fxview-reviewers,sclements 
Differential Revision: https://phabricator.services.mozilla.com/D202486
 2024-02-27 18:26:18 +00:00
Cristian Tuns
26a80e06db Backed out changeset f9c17890d242 (bug 1849175) for causing bc failures in browser_opentabs_firefoxview.js CLOSED TREE 2024-02-27 11:56:55 -05:00
Kelly Cochrane
11fb04203e Bug 1849175 - Add pinned tabs to Open Tabs in Firefox View r=desktop-theme-reviewers,fxview-reviewers,fluent-reviewers,flod,sclements,nsharpley,dao 
Differential Revision: https://phabricator.services.mozilla.com/D201652
 2024-02-27 16:27:20 +00:00
Cosmin Sabou
147a92b105 Bug 1875877 - Update disable syntax to unbust gecko decision task. a=bustage-fix CLOSED TREE 2024-02-23 12:26:42 +02:00
Iulian Moraru
3006e4401b Bug 1875877 - disable browser_opentabs_recency.js on linux for frequent failures. r=aryx 
Differential Revision: https://phabricator.services.mozilla.com/D202527
 2024-02-23 10:00:44 +00:00
Jonathan Sudiaman
b2cf584037 Bug 1880067 - Typing in Firefox View's history search causes flickering and loss of characters typed r=fxview-reviewers,sclements 
Differential Revision: https://phabricator.services.mozilla.com/D202248
 2024-02-20 19:51:09 +00:00
Kelly Cochrane
d5647a2076 Bug 1850591 - Convert Firefox View's domain-specific navigation component to a global component r=desktop-theme-reviewers,fxview-reviewers,reusable-components-reviewers,sclements,jules,hjones,fluent-reviewers,flod 
Differential Revision: https://phabricator.services.mozilla.com/D193593
 2024-02-20 18:58:04 +00:00
Iulian Moraru
3725609047 Backed out changeset 37ef0aa2d2b5 (bug 1857298) for causing bc failures on browser_recentlyclosed_firefoxview.js. 2024-02-20 18:06:25 +02:00
Nikki Sharpley
c6710ccaf5 Bug 1857298 - Add close button to open tabs in view r=fxview-reviewers,fluent-reviewers,desktop-theme-reviewers,bolsson,sclements 
- created tertiary button option for tab rows, styled by a class prop
- added close button to open tabs rows
- removed close tab from open tab context menu
- updated tests to reflect removed panel item in open tab context menu
- added test for the new open tabs close button
- added telemetry for close open tab (requires data review)
- added test suite for keyboard navigation across tab row buttons

Differential Revision: https://phabricator.services.mozilla.com/D200689
 2024-02-20 14:50:25 +00:00
Gijs Kruitbosch
2901dd36aa Bug 1780071 - turn on no-comparison-or-assignment-inside-ok for xpcshell and browser tests, r=mossop,devtools-reviewers,fxview-reviewers,sclements,ochameau 
I'll split up the autofix commits separately assuming we're all happy to go ahead with this.

Differential Revision: https://phabricator.services.mozilla.com/D198594
 2024-02-20 12:40:07 +00:00
Mike Conley
6227d37b2c Bug 1878731 - Convert ASRouter to an ESM. r=emcminn,pip-reviewers,fxview-reviewers,omc-reviewers,sfoster,kpatenio 
Differential Revision: https://phabricator.services.mozilla.com/D201138
 2024-02-12 18:49:38 +00:00
Narcis Beleuzu
e1050305cf Bug 1875877 - Skip browser_opentabs_recency.js on linux for freq failures. r=aryx 
Differential Revision: https://phabricator.services.mozilla.com/D201325
 2024-02-11 10:48:11 +00:00
Nikki Sharpley
15fa76bb44 Bug 1878746 - Wait for showAllButton to be visible before clicking r=ayeddi,fxview-reviewers,sclements 
A11y tests were failing due to the showAllButton node not being accessible.
This update ensures the node is not hidden before clicking.

Differential Revision: https://phabricator.services.mozilla.com/D201016
 2024-02-11 10:26:24 +00:00
Noemi Erli
8534246c91 Backed out changeset f19610ecbade (bug 1850591) for causing failures in browser_opentabs_tab_indicators.js CLOSED TREE 2024-02-10 01:07:49 +02:00
Kelly Cochrane
6b7daf459f Bug 1850591 - Convert Firefox View's domain-specific navigation component to a global component r=desktop-theme-reviewers,fxview-reviewers,reusable-components-reviewers,sclements,jules,hjones,fluent-reviewers,flod 
Differential Revision: https://phabricator.services.mozilla.com/D193593
 2024-02-09 22:01:30 +00:00
Jules Simplicio
dbf6341376 Bug 1877793 - Standardize headings 1-3 r=kcochrane,desktop-theme-reviewers,settings-reviewers,fxview-reviewers,dao,hjones,mstriemer 
Differential Revision: https://phabricator.services.mozilla.com/D200203
 2024-02-09 15:15:11 +00:00
Butkovits Atila
1b1bf5d507 Backed out changeset e97e98c4b7c2 (bug 1850591) for causing failures at browser_1856572_ensure_Fluent_works_in_customizeMode.js. CLOSED TREE 2024-02-09 17:05:14 +02:00
Kelly Cochrane
9e6e12965a Bug 1850591 - Convert Firefox View's domain-specific navigation component to a global component r=desktop-theme-reviewers,fxview-reviewers,reusable-components-reviewers,sclements,jules,hjones,fluent-reviewers,flod 
Differential Revision: https://phabricator.services.mozilla.com/D193593
 2024-02-09 13:43:18 +00:00
Stanca Serban
296d0a814f Backed out changeset 2443d0b3d17d (bug 1873025) for causing mochitests failures in browser_opentabs_recency.js. CLOSED TREE 2024-02-09 05:11:12 +02:00
Sam Foster
ee66131750 Bug 1873025 - Fix the displayed relative time for open tabs listing to match the recency sorting.r=jsudiaman,fxview-reviewers,tabbrowser-reviewers,dao 
* Carry over lastAccessed times from tabs that haven't been seen/active this session.
* Use the lastSeenActive rather than lastAccessed timestamp for labeling open tabs in firefox view.

Differential Revision: https://phabricator.services.mozilla.com/D198892
 2024-02-09 00:10:20 +00:00
Jules Simplicio
505582e133 Bug 1875396 - Avoid using font-weight: 300 and font-weight: lighter r=kcochrane,desktop-theme-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,translations-reviewers,dao,mtigley,hjones,nchevobbe 
Differential Revision: https://phabricator.services.mozilla.com/D199953
 2024-02-08 15:45:07 +00:00
Jonathan Sudiaman
fb35250f69 Bug 1855817 - Add the ability to sort tabs by recency in the (view all) Open tabs section of Firefox View r=fluent-reviewers,fxview-reviewers,sclements 
Differential Revision: https://phabricator.services.mozilla.com/D200464
 2024-02-07 11:16:40 +00:00