Commit Graph

268 Commits

Author SHA1 Message Date
Kris Maglione
a1876c600d Bug 1486130: Fix reporting of unhandled DOMException rejection values. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D4264
2018-08-23 14:01:04 -07:00
Matthew Noorenberghe
bba9406216 Bug 1485473 - Combine the borders of the name fields on the address form. r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D4031
2018-08-24 23:21:30 +00:00
Kris Maglione
f6a4413b4c Bug 1484496: Part 5a - Convert browser/ nsISimpleEnumerator users to use JS iteration. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D3729
2018-08-18 19:27:33 -07:00
Margareta Eliza Balazs
0fc8f9feae Backed out changeset 3fcc7597cd8d (bug 1429198) for ES lint failure in builds/worker/checkouts/gecko/browser/components/payments/res/paymentRequest.js. CLOSED TREE 2018-12-18 15:50:33 +02:00
Diego Pino Garcia
28e3196dab Bug 1429198 - Account for supportedNetworks in payment modifiers. r=MattN 2018-12-17 22:15:00 +02:00
Matthew Noorenberghe
7abe2e1b64 Bug 1482220 - Listen for the autofill edit forms being appended for localization. r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D3846
2018-08-22 02:58:38 +00:00
prathiksha
5b411643f7 Bug 1475760 - Take address-fields into account for payer/contact picker dropdown labels. r=MattN
Differential Revision: https://phabricator.services.mozilla.com/D2831
2018-08-20 13:23:43 -07:00
Matthew Noorenberghe
05b80bce31 Bug 1477100 - Scroll the country picker into view to fix browser_dropdowns.js. r=me
This new layout caused it to require scrolling to be clicked.
2018-08-17 20:27:33 -07:00
Matthew Noorenberghe
f05f773232 Bug 1478029 - Follow-up to fix test_address_form.html default country. r=me 2018-08-17 17:40:04 -07:00
Matthew Noorenberghe
dc50337285 Bug 1478029 - Don't select a shipping option by default for the user. r=sfoster
Honour the .selected value provided by the merchant.

Differential Revision: https://phabricator.services.mozilla.com/D3668
2018-08-17 17:03:29 -07:00
Jared Wein
96dfeffbdd Bug 1477100 - Show the labels as placeholders inside of the fields. r=MattN
Show the labels as placeholders inside of the fields.

Differential Revision: https://phabricator.services.mozilla.com/D2955
2018-08-17 16:25:46 -07:00
Matthew Noorenberghe
989cf42294 Bug 1483425 - Don't mark form fields as invalid/dirty on load in an 'add' form. r=sfoster
When editing an existing record, invalid fields should be indicated on load.

Differential Revision: https://phabricator.services.mozilla.com/D3397

MozReview-Commit-ID: CbrqEyCUoyC
2018-08-17 16:27:21 -07:00
Matthew Noorenberghe
983071a66b Bug 1465673 - Disable browser_card_edit.js on linux debug builds. r=me 2018-08-15 14:21:18 -07:00
Matthew Noorenberghe
740d3ceb28 Bug 1476345 - Only enable relevant fields in address forms and update tests. r=jaws
MozReview-Commit-ID: KuPMHrF6jaM
2018-08-15 12:19:55 -07:00
Matthew Noorenberghe
070b80faab Bug 1476345 - Disable the address form save button when the form is invalid. r=jaws
Tests for this are in the next commit (e.g. test_address_form.html) because this can't be tested properly due to existing tests not filling fields in ways that fire input/change events.

MozReview-Commit-ID: 62CckFP6Ou3
2018-08-15 12:07:55 -07:00
Matthew Noorenberghe
89fcaa7f8f Bug 1476345 - Fix console listener to not spew when .message doesn't exist. r=jaws
Sometimes .errorMessage exists without .message

MozReview-Commit-ID: D4zBJKxfJba
2018-08-14 16:26:36 -07:00
Jared Wein
46b7ce906e Bug 1476348 - Show missing field validation errors on the summary page. r=MattN
MozReview-Commit-ID: 5dOzxWH0pWp
2018-08-03 18:51:31 -04:00
Sam Foster
b1db4c8170 Bug 1480023 - Ensure input event is handled in the correct order by waiting for EditAutofillForm constructor before adding BasicCardForm's input & change handlers. r=MattN
MozReview-Commit-ID: F9hzp54hZxX
2018-08-02 17:46:56 -07:00
Jared Wein
97ca8b6dd2 Bug 1477699 - Show a generic error message when a merchant-supplied error message isn't present. r=MattN
MozReview-Commit-ID: Dn4mnvzunVd
2018-07-31 15:09:58 -04:00
Bogdan Tara
ed871660f1 Merge inbound to mozilla-central. a=merge 2018-08-03 13:16:27 +03:00
Jared Wein
f7aa111f10 Bug 1472278 - Localize the required form asterisk on the address-form, basic-card-form, and CVV entry field. r=MattN
MozReview-Commit-ID: 7VN1VY7QziT
2018-07-30 21:13:36 -04:00
prathiksha
a46aaa0259 Bug 1463547 - Hide the edit link in the pickers when no options are selected. r=MattN
MozReview-Commit-ID: DcTcmV2v6N1
2018-08-02 17:21:44 -04:00
Jared Wein
133cd95906 Bug 1477114 - Add an asterisk to the required fields of the credit card form as well as the CVV placeholder. r=sfoster
MozReview-Commit-ID: 2zg5HOZVtxN
2018-07-30 17:52:24 -04:00
Brindusan Cristian
46820164b1 Backed out changeset d402c7b803c6 (bug 1477114) as requested by jaws. 2018-08-02 23:18:53 +03:00
Jared Wein
704b82dea4 Bug 1477114 - Add an asterisk to the required fields of the credit card form as well as the CVV placeholder. r=sfoster
MozReview-Commit-ID: 2zg5HOZVtxN
2018-07-30 17:52:24 -04:00
Sam Foster
16895060f1 Bug 1477106 - Use a pref to set default checkedness for "Save card to Firefox" and "Save address to Firefox" checkboxes. r=jaws
* Get default checkedness for the card persist checkbox from a new pref: dom.payments.defaults.saveCreditCard
* Get default checkedness for the address persist checkbox from a new pref: dom.payments.defaults.saveAddress
* Remember checked state from card page (only) so it doesnt change back when returning from add/edit address page
* Fix up card form tests to verify behavior in private/not-private windows, pref value, user opt-in for persisting the card
* Fix up address form tests to not conflate private/not-private windows with expected address persisting behaviour

MozReview-Commit-ID: GXMjqStlnlu
2018-07-26 15:36:07 -07:00
Andreea Pavel
9639ad59da Backed out changeset d69e19bad6c1 (bug 1477106) for eslint failure at builds/worker/checkouts/gecko/browser/components/payments/content/paymentDialogFrameScript.js 2018-08-02 02:11:57 +03:00
Sam Foster
b82c918c0f Bug 1477106 - Use a pref to set default checkedness for "Save card to Firefox" and "Save address to Firefox" checkboxes. r=jaws
* Get default checkedness for the card persist checkbox from a new pref: dom.payments.defaults.saveCreditCard
* Get default checkedness for the address persist checkbox from a new pref: dom.payments.defaults.saveAddress
* Remember checked state from card page (only) so it doesnt change back when returning from add/edit address page
* Fix up card form tests to verify behavior in private/not-private windows, pref value, user opt-in for persisting the card
* Fix up address form tests to not conflate private/not-private windows with expected address persisting behaviour

MozReview-Commit-ID: GXMjqStlnlu
2018-07-26 15:36:07 -07:00
Jared Wein
f91a633c7e Bug 1468153 - Update the edit strings (Add/Update) and the failure strings to use the hostname. r=sfoster
MozReview-Commit-ID: HcOMsP5zWBg
2018-07-30 14:22:52 -04:00
Sam Foster
257d2156ac Bug 1470584 - Send PAYMENT_REJECTED response if window is unexpectedly closed. r=MattN
* Use onWindowClose to spot closing windows associated with live payment requests and send a reject response
* Test to verify expected show() promise rejection behavior when closing the PR dialog

MozReview-Commit-ID: 2TJYN5NMrE6
2018-07-16 17:21:51 -07:00
Jared Wein
e0c3e5b688 Bug 1475521 - Payments shouldn't be processed without selecting a shipping address. r=MattN
MozReview-Commit-ID: CXxqYB3iOy
2018-07-27 12:03:46 -04:00
Matthew Noorenberghe
7165681397 Bug 1478321 - Fix the 'TypeError: docShell is null' exception to the Payments console listener. r=sfoster
`errorMessage` only contains 'TypeError: docShell is null' whereas `message` contains the file path and line.

MozReview-Commit-ID: 7Tuqph1b3lV
2018-07-26 16:11:24 -07:00
Matthew Noorenberghe
ef8f325b1c Bug 1476204 - Handle autofill record update state changes in the unpriv. PR forms. r=jaws
This is easier to understand as we don't have to round-trip the whole success and error states to the privileged wrapper which could potentially lead to stale state changes.
This is also much simpler for the basic-card-form as it doesn't need a lot of the complexity of the previous implementation.

* Move selectedStateKey from page to address-page since it doesn't apply to basic-card-page

MozReview-Commit-ID: B4kiZNWElGI
2018-07-25 12:37:51 -07:00
Matthew Noorenberghe
8ef03fea38 Bug 1476204 - Implement the payment summary error bar. r=jaws
MozReview-Commit-ID: 3Rc9ljfMCW3
2018-07-23 21:49:05 -07:00
Matthew Noorenberghe
730a3a6580 Bug 1476204 - Replace duplicate #error-text with .page-error. r=jaws
MozReview-Commit-ID: 2FOx9dpTpAs
2018-07-23 20:34:40 -07:00
Matthew Noorenberghe
5df3a9f472 Bug 1476204 - Check Luhn algorithm in the basic-card-form and in storage and disable save button when invalid. r=jaws
* Provide an cc-exp-year option to match cc-exp-month
* Make cc-number and cc-name required in the basic-card-form
* Disable the basic-card-page save button when the form is invalid.

MozReview-Commit-ID: LjzsnAKJp6R
2018-07-26 13:40:22 -07:00
prathiksha
df8bfa39dd Bug 1476571 - Auto-select selectedShippingAddress as billing address when it is not null. r=MattN
MozReview-Commit-ID: 8qPIbHn7cKk
2018-07-24 15:50:54 -07:00
Cosmin Sabou
4d1b71eee6 Backed out 5 changesets (bug 1476204) for browser chrome failures on browser_editCreditCardDialog. CLOSED TREE
Backed out changeset 10f3d1014592 (bug 1476204)
Backed out changeset a88879ea32e8 (bug 1476204)
Backed out changeset 001f13f2dd21 (bug 1476204)
Backed out changeset f0f464e3c27c (bug 1476204)
Backed out changeset ed92000eca20 (bug 1476204)
2018-07-26 04:12:56 +03:00
Matthew Noorenberghe
9e3276d213 Bug 1476204 - Handle autofill record update state changes in the unpriv. PR forms. r=jaws
This is easier to understand as we don't have to round-trip the whole success and error states to the privileged wrapper which could potentially lead to stale state changes.
This is also much simpler for the basic-card-form as it doesn't need a lot of the complexity of the previous implementation.

* Move selectedStateKey from page to address-page since it doesn't apply to basic-card-page

MozReview-Commit-ID: B4kiZNWElGI
2018-07-25 12:37:51 -07:00
Matthew Noorenberghe
8e85abc48e Bug 1476204 - Implement the payment summary error bar. r=jaws
MozReview-Commit-ID: 3Rc9ljfMCW3
2018-07-23 21:49:05 -07:00
Matthew Noorenberghe
5ef6fd17d6 Bug 1476204 - Replace duplicate #error-text with .page-error. r=jaws
MozReview-Commit-ID: 2FOx9dpTpAs
2018-07-23 20:34:40 -07:00
Matthew Noorenberghe
1ba778c9a8 Bug 1476204 - Check Luhn algorithm in the basic-card-form and in storage and disable save button when invalid. r=jaws
* Provide an cc-exp-year option to match cc-exp-month
* Make cc-number and cc-name required in the basic-card-form
* Disable the basic-card-page save button when the form is invalid.

MozReview-Commit-ID: LjzsnAKJp6R
2018-07-25 16:38:25 -07:00
Sebastian Hengst
b4efb2668b Merge mozilla-inbound to mozilla-central. a=merge 2018-07-25 17:16:53 +03:00
Matthew Noorenberghe
1405f1081f Bug 1463538 - Fix previously uncaught errors in PaymentReqest UI tests. r=jaws
MozReview-Commit-ID: JUu3ljLLDLO
2018-07-23 11:38:47 -07:00
Matthew Noorenberghe
7e19a51fdf Bug 1463538 - Fail PaymentRequest UI tests upon console errors. r=jaws
MozReview-Commit-ID: 2IzUaENZjfl
2018-07-24 19:24:29 -07:00
Matthew Noorenberghe
b5efc53363 Bug 1463538 - Make all <input> in the PaymentRequest debug panel live. r=sfoster
MozReview-Commit-ID: 4nutxHpmnlc
2018-07-23 20:01:19 -07:00
Boris Zbarsky
e98236cf07 Bug 1476145 part 3. Stop using getInterface(nsIDOMWindowUtils) in browser/. r=gijs 2018-07-24 19:47:41 -04:00
Sam Foster
b0eaf62f75 Bug 1447777 - Add completion fail and timeout error pages. r=MattN
* A new CompletionErrorPage / completion-error-page element which represents the content of the completion error
* Leave the dialog open when complete() results in a 'fail' or 'timeout'.
* The 'done' button on the fail & timeout error page closes the dialog by sending a message up to the paymentDialogWrapper.
* Rewrite the pay button rendering logic to ensure it is disabled when it should be
* Retry handling and UI not addressed here. Will need a new bug when the DOM support has landed.
* Extend completeStatus support in debugging.html and group like actions to tidy up a bit

MozReview-Commit-ID: GDhJqrj14uT

* Add tests to verify that the dialog stays open when completion fails or times out
* Add tests to verify that complete() throws after the timeout
* Rework completeStatus mochitest for PaymentDialog

MozReview-Commit-ID: 4ZNVEYMp7h5
2018-07-20 15:51:52 -07:00
Sam Foster
e1130d7c9a Bug 1447777 - Move state.completionState to state.request.completeStatus. r=MattN
* Spot-fix order details test to clone request before modifying it

MozReview-Commit-ID: AXjI1veRSk9
2018-07-19 19:45:58 -07:00
Cosmin Sabou
94d7df46ab Merge mozilla-inbound to mozilla-central. a=merge 2018-07-21 00:42:01 +03:00