Commit Graph

268 Commits

Author SHA1 Message Date
Csoregi Natalia
367f2a6c44 Backed out changeset 081704356a93 (bug 1495122) for bc failures on browser_shippingaddresschange_error.js. CLOSED TREE 2018-11-16 00:13:55 +02:00
Jared Wein
1e1b4a817a Bug 1495122 - Support regionCode and dependentLocality for merchant errors. r=MattN
Differential Revision: https://phabricator.services.mozilla.com/D11844
2018-11-15 21:19:43 +00:00
shindli
e3e5e91546 Backed out changeset 3df92480890e (bug 1495122) as it was requested by the dev on irc 2018-11-15 23:13:12 +02:00
Jared Wein
91d024d18a Bug 1495122 - Support regionCode and dependentLocality for merchant errors. r=MattN
Differential Revision: https://phabricator.services.mozilla.com/D11844
2018-11-15 21:08:07 +00:00
Matthew Noorenberghe
967da6d08e Bug 1435880 - Handle moving/detaching tabs between windows when a Payment Request is showing. r=jaws
Depends on D10180

Differential Revision: https://phabricator.services.mozilla.com/D10183
2018-11-15 15:06:21 +00:00
Matthew Noorenberghe
84983d3068 Bug 1435880 - Put the payment dialog <browser> directly in the ChromeWindow. r=jaws
Remove the intermediate <html:iframe> as it makes support of detaching impossible since we would need
to swap both the <browser> and <html:iframe> contents during a tab detach.
Since a docshell swap requires both docshells to have a frame and document loaded and the move of the
tab won't wait on payments code to do async work to get frames and documents ready for swapping, I
couldn't see a way to get detaching to work with the nested frames.

* Swapping the docshell of only the outer <html:iframe> still caused a reload of the inner <browser>.

Differential Revision: https://phabricator.services.mozilla.com/D10180
2018-11-15 15:05:12 +00:00
Jared Wein
439896c5e6 Bug 1501170 - Render the defaultValue in the CSC input if one has been provided. r=MattN
Differential Revision: https://phabricator.services.mozilla.com/D11541
2018-11-13 17:45:23 +00:00
Marcos Cáceres
2e3d3f3d23 Bug 1504032 - Remove concept of card types, supportedTypes, BasicCardType enum r=MattN,baku
The concept of card types, supportedTypes, BasicCardType enum, were removed from the Basic Card spec.

Differential Revision: https://phabricator.services.mozilla.com/D10646
2018-11-10 06:59:26 +00:00
Matthew Noorenberghe
2db438197e Bug 1505707 - Sandbox the template frame for payment mochitests to prevent JS execution errors. r=jaws
We only want the frame to be able to share markup, we don't need JS to execute and the JS was causing an unhandled rejection error.

Differential Revision: https://phabricator.services.mozilla.com/D11330
2018-11-09 20:11:46 +00:00
Sam Foster
32127d7674 Bug 1492399 - honor preserveFieldValues when generating billing address options. r=MattN
Differential Revision: https://phabricator.services.mozilla.com/D11129
2018-11-07 18:41:37 +00:00
Sam Foster
d756aa22ef Bug 1482689 - Use AddressPicker for the card billing address UI. r=MattN
* New BillingAddressPicker subclass of AddressPicker which just overrides some of the state-related behavior that
* Allow the RichSelect's popupBox (<select>) to be assigned after the constructor
* A couple new mochitests for the new/different behavior
* Update the test to expect 'edit' to be hidden when the empty option is selected

Differential Revision: https://phabricator.services.mozilla.com/D9321
2018-11-06 00:28:46 +00:00
Brindusan Cristian
074281f389 Backed out changeset ea5d6df24de0 (bug 1482689) as requested by sfoster. 2018-11-06 02:20:51 +02:00
Sam Foster
3e6f95011e Bug 1482689 - Use AddressPicker for the card billing address UI. r=MattN
* New BillingAddressPicker subclass of AddressPicker which just overrides some of the state-related behavior that
* Allow the RichSelect's popupBox (<select>) to be assigned after the constructor
* A couple new mochitests for the new/different behavior
* Update the test to expect 'edit' to be hidden when the empty option is selected

Differential Revision: https://phabricator.services.mozilla.com/D9321
2018-11-06 00:04:42 +00:00
Cosmin Sabou
a752eeafc6 Backed out 2 changesets (bug 1482689) for browser chrome failures on browser_address_edit.js
Backed out changeset 61b49da4b9cb (bug 1482689)
Backed out changeset c810cab5dbdb (bug 1482689)
2018-11-05 18:28:15 +02:00
Sam Foster
f2be145084 Bug 1482689 - Use AddressPicker for the card billing address UI. r=MattN
* New BillingAddressPicker subclass of AddressPicker which just overrides some of the state-related behavior that isn't applicable to billing addresses.
* A couple new mochitests for the new/different behavior

Differential Revision: https://phabricator.services.mozilla.com/D9321
2018-11-05 15:16:02 +00:00
Jared Wein
4352b2c326 Bug 1497225 - Update the required asterisk display when changing countries. r=sfoster,MattN
Differential Revision: https://phabricator.services.mozilla.com/D10637
2018-11-02 20:53:12 +00:00
Noemi Erli
fcd2bd3c71 Backed out changeset 8cd7b1c3737a (bug 1497225) for failures in browser_editAddressDialog.js 2018-11-02 22:11:24 +02:00
Jared Wein
eee98e1b3e Bug 1497225 - Update the required asterisk display when changing countries. r=sfoster,MattN
Differential Revision: https://phabricator.services.mozilla.com/D10637
2018-11-02 19:03:39 +00:00
Jared Wein
ca3c6a0324 Bug 1483412 - Make the telephone number field required on the payer form if requestPayerPhone is true. r=MattN
Differential Revision: https://phabricator.services.mozilla.com/D10597
2018-11-01 22:38:03 +00:00
Timothy Guan-tin Chien
7d2eeba32a Bug 1429265 - Re-authenticate the user on Windows and macOS before decryption r=MattN
This patch restores the re-auth test pref previously comment out,
and redirect the re-auth to nsIOSReauthenticator on Windows and macOS.

Noted that nsIOSReauthenticator is never called during tests because we can't automate that dialog.

Differential Revision: https://phabricator.services.mozilla.com/D9853
2018-10-31 23:18:54 +00:00
Eden Chuang
e90829472b Bug 1497215 - Refactor the IPC structure for PaymentResponse.details r=baku
In original design, payment method response data is passed between processes
    through a simple nsString. It means a special encoder/decoder is needed for
    special response data, ex. BasicCardResponse, to serialize/deserialize
    into/from the nsString. However, when a token spliter, ':', ';' and '@', is
    used in response data, it makes the encoder/decoder can not work normally.
    It is hard to define a suitable token spliter set for encoder/decoder.
    So instead of using an error-prone encoder/decoder, this patch defining a new
    IPC structure for response data.
2018-10-29 13:56:32 +01:00
Diego Pino Garcia
079a1050f5 Bug 1509147 - Rename payer and paymentMethod on nsIPaymentDetails to payerErrors and paymentMethodErrors respectively r=baku 2018-11-26 03:08:00 +02:00
Matthew Noorenberghe
a7745f11f8 Bug 1465673 - Disable browser_card_edit.js in macOS debug builds due to high failure rates. r=me 2018-10-23 15:14:11 -07:00
Margareta Eliza Balazs
5ea2aaf2c6 Merge mozilla-central to autoland. a=merge CLOSED TREE 2018-10-23 12:31:53 +03:00
Matthew Noorenberghe
2f8c38bb48 Bug 1486954 - Fix browser/components/payments/test/browser/head.js eslint issue. r=me 2018-10-22 23:13:54 -07:00
Julian Descottes
07720a1de0 Bug 1499096 - Use ok() with 2 arguments instead of 3 when possible;r=Standard8
Depends on D8740.
This changeset replaces calls to ok with 3 arguments to calls with 2 arguments
in situations where the switch does not have a significant impact on the assert.

Differential Revision: https://phabricator.services.mozilla.com/D8741
2018-10-23 07:13:35 +00:00
Julian Descottes
15aaadb6c7 Bug 1499096 - Update tests using ok() to is();r=Standard8
This changeset updates all the test that were wrongly using ok() and wanted to
use is() AND for which the assert is still passing without any modification
required.

Differential Revision: https://phabricator.services.mozilla.com/D8739
2018-10-23 07:12:23 +00:00
Timothy Guan-tin Chien
c17de18925 Bug 1486954 - Part V, Prevent credit card record from being accessed if not initialize r=MattN
This patch changed the initialization of records so that we don't call into credit card
AutofillRecords class if it is pref-off.

Differential Revision: https://phabricator.services.mozilla.com/D9158
2018-10-18 22:10:25 +00:00
Timothy Guan-tin Chien
8bca3c3a1a Bug 1486954 - Part I, Encrypt credit card numbers with OS key store. r=MattN
This patch morphs MasterPassword.jsm to OSKeyStore.jsm while keeping the same
API, as an adaptor between the API and the native API exposed as nsIOSKeyStore.idl.

Noted that OS Key Store has the concept of "recovery phrase" that we won't
be adopting here. The recovery phrase, together with our label, allow
the user to re-create the same key in OS key store.

Test case changes are needed because we have started asking for login in
places where we'll only do previously when "master password is enabled".
This also made some "when master password is enabled" tests invalid because
it is always considered enabled.

Some more test changes are needed simply because they previously rely on the
stable order of microtask resolutions (and the stable # of promises for a
specific operation). That has certainly changed with OSKeyStore.

The credit card form autofill is only enabled on Nightly.

Differential Revision: https://phabricator.services.mozilla.com/D4498
2018-10-17 02:31:04 +00:00
Matthew Noorenberghe
07253e67b6 Bug 1435871 - Open prefs from Payment Request in a tab. r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D8497
2018-10-20 03:40:05 +00:00
Matthew Noorenberghe
a163a3d254 Bug 1435871 - Implement a basic tab-modal dialog container for Payment Request. r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D7934
2018-10-20 03:39:32 +00:00
Matthew Noorenberghe
fd1477f32d Bug 1435871 - Back out changeset 3f6664786e85 (Bug 1470584) since it's for a windowed dialog. r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D8272
2018-10-20 03:38:53 +00:00
Gurzau Raul
85dbd96c60 Merge mozilla-central to autoland. a=merge CLOSED TREE 2018-10-20 01:09:52 +03:00
Diego Pino Garcia
342c880959 Bug 1497514 - Initialize BasicCardPage selectedStateKey to 'selectPaymentCard'. r=MattN
Also require basicCardPage has a selectedStateKey
2018-10-18 23:56:00 +03:00
Noemi Erli
4114fb4906 Backed out changeset 8b3b53341da2 (bug 1497514) for failures in browser/components/payments/test/mochitest/test_basic_card_form.html 2018-10-19 03:50:32 +03:00
Diego Pino Garcia
edba6d8e8e Bug 1497514 - Initialize BasicCardPage selectedStateKey to 'selectPaymentCard'. r=MattN
Also require basicCardPage has a selectedStateKey
2018-10-18 15:25:49 -07:00
Jared Wein
d99da117e9 Bug 1494551 - Sort the formautofill data by the last used time. r=MattN
Differential Revision: https://phabricator.services.mozilla.com/D9174
2018-10-19 17:00:31 +00:00
Jared Wein
b1d56aadc5 Bug 1420853 - Ensure only fields valid for the given country are saved. r=MattN
Differential Revision: https://phabricator.services.mozilla.com/D9034
2018-10-19 16:36:45 +00:00
Brindusan Cristian
09c63cca65 Backed out changeset 8641e30ebaf4 (bug 1435871) for multiple browser-chrome failures on payments. CLOSED TREE 2018-10-19 14:58:11 +03:00
Brindusan Cristian
9d31304003 Backed out 2 changesets (bug 1435871) for multiple browser-chrome failures on payments. CLOSED TREE
Backed out changeset 0f7592b662e2 (bug 1435871)
Backed out changeset 039f6d65036e (bug 1435871)
2018-10-19 12:36:13 +03:00
Matthew Noorenberghe
448fa69c0b Bug 1435871 - Open prefs from Payment Request in a tab. r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D8497
2018-10-19 05:06:30 +00:00
Matthew Noorenberghe
ec5cf1bb78 Bug 1435871 - Implement a basic tab-modal dialog container for Payment Request. r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D7934
2018-10-19 05:06:22 +00:00
Matthew Noorenberghe
d84d66e803 Bug 1435871 - Back out changeset 3f6664786e85 (Bug 1470584) since it's for a windowed dialog. r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D8272
2018-10-19 05:06:20 +00:00
Dorel Luca
4d4a327178 Backed out 3 changesets (bug 1435871) for mochitest crashes. CLOSED TREE
Backed out changeset 8eab3320b8c5 (bug 1435871)
Backed out changeset 29777ddd9def (bug 1435871)
Backed out changeset afdc3066f12c (bug 1435871)
2018-10-17 23:06:14 +03:00
Matthew Noorenberghe
7946315170 Bug 1435871 - Open prefs from Payment Request in a tab. r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D8497
2018-10-17 18:46:12 +00:00
Matthew Noorenberghe
a92837e447 Bug 1435871 - Implement a basic tab-modal dialog container for Payment Request. r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D7934
2018-10-17 18:46:27 +00:00
Matthew Noorenberghe
7a1869d51d Bug 1435871 - Back out changeset 3f6664786e85 (Bug 1470584) since it's for a windowed dialog. r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D8272
2018-10-17 18:46:25 +00:00
Andrei Oprea
11b790e2b1 Bug 1492671 - Disable screenshot capturing for triggering network requests in payments mochitests r=MattN
Differential Revision: https://phabricator.services.mozilla.com/D8877
2018-10-17 15:08:50 +00:00
Jared Wein
fc09272194 Bug 1470199 - Add a tooltip for the CVV input. r=MattN
Differential Revision: https://phabricator.services.mozilla.com/D7473
2018-10-13 00:39:02 +00:00
Matthew Noorenberghe
8ca582d7b8 Bug 1496698 - Remove Custom Elements polyfill from Web Payments UI. r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D7863
2018-10-05 15:37:25 +00:00