Commit Graph

268 Commits

Author SHA1 Message Date
Matthew Noorenberghe
b20e0893c9 Bug 1435163 - Show merchant address errors on the summary screen. r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D7160
2018-09-29 00:17:52 +00:00
Matthew Noorenberghe
6e28c07425 Bug 1435163 - Show the summary page after the processing page when retry() is called. r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D7159
2018-09-29 00:17:50 +00:00
Matthew Noorenberghe
62d03accc3 Bug 1435163 - Show merchant address errors on billing and payer screens. r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D7149
2018-09-29 00:17:42 +00:00
Sam Foster
140c17314a Bug 1473662 - Save button should be labelled 'Next' when adding a new address or card. r=MattN
Differential Revision: https://phabricator.services.mozilla.com/D7209
2018-09-28 20:00:03 +00:00
Sam Foster
fef72bdc39 Bug 1477102 - Toggle accepted cards list on add/edit cards. Add stub for using AppConstants.MOZILLA_OFFICIAL to fallback for non-branded builds. r=MattN
Differential Revision: https://phabricator.services.mozilla.com/D7025
2018-09-28 16:53:37 +00:00
Matthew Noorenberghe
cc38c1b150 Bug 1490805 - Add a required CSC/CVV field to the add card page. r=jaws
Depends on D6882

Differential Revision: https://phabricator.services.mozilla.com/D6883
2018-09-27 17:26:24 +00:00
Matthew Noorenberghe
4c0db4ddf6 Bug 1490805 - Include temporary basic cards in validity check for supportedNetworks. r=sfoster
Depends on D6848

Differential Revision: https://phabricator.services.mozilla.com/D6882
2018-09-27 05:57:40 +00:00
Matthew Noorenberghe
efc226688c Bug 1490805 - Make the CVV field required on the payment-summary screen. r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D6848
2018-09-27 05:40:35 +00:00
Ciure Andrei
db0244a411 Merge mozilla-central to mozilla-inbound. a=merge CLOSED TREE 2018-09-26 00:53:40 +03:00
Matthew Noorenberghe
3b00cb1745 Bug 1432939 - Link to Firefox Options/Preferences from the PaymentRequest dialog. r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D6724
2018-09-25 17:26:38 +00:00
Matthew Noorenberghe
de06f9627d Bug 1493349 - Disable intermittent test_basic_card_form.html on debug/ASAN builds. r=test-only 2018-09-25 12:35:08 -07:00
Matthew Noorenberghe
931bf2f995 Bug 1493216 - Disable intermittent test_address_option.html on Windows. r=test-only 2018-09-25 12:34:12 -07:00
Margareta Eliza Balazs
1290c58f68 Merge inbound to mozilla-central. a=merge 2018-09-25 12:42:09 +03:00
Christoph Kerschbaumer
027fdf5373 Bug 1490874: Update tests to comply with new script error logging mechanism. r=MattN 2018-09-25 07:52:30 +02:00
Matthew Noorenberghe
67c5f5ea91 Bug 1480717 - Fix credit card form billing address and persist checkbox layout. r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D4175
2018-09-24 19:51:39 +00:00
Jared Wein
3ec633199f Bug 1481972 - Add remaining countries to address autofill countries list. r=MattN
Saving and filling the countries via Form Autofill will still be limited to certain countries
but this allows the storage to be useful for Web Payments in other countries.

Differential Revision: https://phabricator.services.mozilla.com/D5194
2018-09-23 23:50:03 -07:00
shindli
23c0be1304 Backed out changeset 510e95767aeb (bug 1490874) for security failures in browser/components/payments/test/mochitest/test_basic_card_form.html CLOSED TREE 2018-09-24 11:43:30 +03:00
Christoph Kerschbaumer
72e1ad4898 Bug 1490874: Log Principal based Security Errors to the Security pane in the console. r=smaug 2018-09-24 09:34:04 +02:00
Matthew Noorenberghe
8510ad9978 Bug 1493157 - requestLongerTimeout(2) on browser_card_edit.js. r=trivial 2018-09-21 08:42:50 -07:00
Jared Wein
7b7b57e0c9 Bug 1490077 - Reflect DOM validation messages on the error popup on the address and basic-card form. r=MattN
Contributions by Matthew Noorenberghe <mozilla@noorenberghe.ca>

Differential Revision: https://phabricator.services.mozilla.com/D6420
2018-09-21 00:15:56 -07:00
Noemi Erli
996dfb6f56 Backed out 2 changesets (bug 1490077) for failures in browser/components/payments/test/mochitest/test_address_option.html on a CLOSED TREE
Backed out changeset 9b038cd736cf (bug 1490077)
Backed out changeset 29f6f86fb9cd (bug 1490077)
2018-09-21 11:01:46 +03:00
Jared Wein
728adc0e4d Bug 1490077 - Reflect DOM validation messages on the error popup on the address and basic-card form. r=MattN
Contributions by Matthew Noorenberghe <mozilla@noorenberghe.ca>

Differential Revision: https://phabricator.services.mozilla.com/D6420
2018-09-21 00:15:56 -07:00
Gurzau Raul
ea96f77588 Merge mozilla-central to inbound. a=merge CLOSED TREE 2018-09-21 07:17:03 +03:00
Jared Wein
ab1ea5cf55 Bug 1478880 - payments/test/browser/head.js: fillInCardForm reliability fixes. r=MattN
* Blur before focus to reset timer for filtering <select>
* Wait for field to get focus before sending keys to it.
* Compare unpadded strings

Differential Revision: https://phabricator.services.mozilla.com/D6338
2018-09-20 20:44:03 -07:00
Matthew Noorenberghe
1b007d8fd1 Bug 1463545 - Use text-overflow:ellipsis; on <shipping-option>. r=sfoster
Depends on D5186

Differential Revision: https://phabricator.services.mozilla.com/D6332
2018-09-20 21:07:28 +00:00
Matthew Noorenberghe
538c456013 Bug 1463545 - Replace grid layout of <address-option> with a new two line design. r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D5186
2018-09-20 21:07:20 +00:00
Matthew Noorenberghe
b6446774ef Bug 1463545 - Update the <basic-card-option> layout to match the UI spec. r=sfoster
Depends on D6330

Differential Revision: https://phabricator.services.mozilla.com/D6331
2018-09-20 21:07:18 +00:00
Matthew Noorenberghe
d295d0a46a Bug 1463545 - Overlay the selected <rich-option> on top of the native <select>. r=sfoster
* We get the shared colours (including hover) and dropmarker.
* Makes it harder to regress the clickable area of the <rich-select> since the problem will be visible.
* Hides the text for the closed state of the <select> so the <rich-option> text can be presented.

Differential Revision: https://phabricator.services.mozilla.com/D6330
2018-09-20 21:07:09 +00:00
Matthew Noorenberghe
d4a84fcc29 Bug 1463545 - Copy stylesheets from the payment dialog into mochitests. r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D6233
2018-09-20 21:07:07 +00:00
Jared Wein
27234ecc8b Bug 1491791 - Update the Save button state after the 'change' event. r=MattN
The validity of the cc-number field is only updated to a failure state after the 'change' event in the EditCreditCard class, but there was no code within basic-card-form.js to update the Save button enabled state after the 'change' event had been handled by EditCreditCard.

Differential Revision: https://phabricator.services.mozilla.com/D6282
2018-09-20 17:13:26 +00:00
Sam Foster
6ddf9e9404 Bug 1491065 - Use 'Next' as label for the save buttons during onboarding. r=MattN
Differential Revision: https://phabricator.services.mozilla.com/D6318
2018-09-19 22:10:50 +00:00
Sam Foster
97e02f994e Bug 1470183 - Add 3rd suggestion to failure page directing users to merchant for more info. r=MattN
Differential Revision: https://phabricator.services.mozilla.com/D6322
2018-09-19 20:57:26 +00:00
Matthew Noorenberghe
6641bc6bef Bug 1429181 - Make test_payment_method_picker.html work with cc-type. r=sfoster
synthesizeKey requires the prefix of the label which would be whitespace without cc-type so add a cc-type

Depends on D6231

Differential Revision: https://phabricator.services.mozilla.com/D6232
2018-09-19 17:06:47 +00:00
Matthew Noorenberghe
59ccc3632f Bug 1429181 - Fix test_payment_dialog_required_top_level_items.html with cc-type. r=sfoster
a) We have two names starting with the same prefix: "Mrs." which causes problem when typing on a <select> to filter, especially if the desired option is already selected.
b) The prefix of the payment method option would start with whitespace if cc-type is "".
c) There would be no state change for the shipping option picker when we're requesting to select the option that's already selected.

Depends on D6230

Differential Revision: https://phabricator.services.mozilla.com/D6231
2018-09-19 17:12:18 +00:00
Matthew Noorenberghe
492a4ff3c6 Bug 1429181 - Fix PaymentTestUtil.DialogContentTasks.select* to work with repeated calls. r=sfoster
Also fix test_basic_card_form.html and browser_show_dialog.js

Differential Revision: https://phabricator.services.mozilla.com/D6230
2018-09-19 17:05:09 +00:00
Sam Foster
4b5fb70b7e Bug 1429181 - Consider supportedNetworks when determining if payment method is valid. r=MattN
* A new accepted-cards element to represent the labeled list of card icons
* Add the accepted cards section to the summary and card add/edit page
* mochitest for the accepted-cards element
* Make cc-type a required field and validate it against the list of supported networks
* Add verification of the pay button disabling when card network is not supported

Depends on D5823

Differential Revision: https://phabricator.services.mozilla.com/D5824
2018-09-19 18:15:11 +00:00
Bogdan Tara
c104128b3d Backed out changeset 7351a4c8d1a1 (bug 1429181) for multiple payment-related failures CLOSED TREE 2018-09-15 00:58:48 +03:00
Sam Foster
579931d05b Bug 1429181 - Consider supportedNetworks when determining if payment method is valid. r=MattN
* A new accepted-cards element to represent the labeled list of card icons
* Add the accepted cards section to the summary and card add/edit page
* mochitest for the accepted-cards element
* Make cc-type a required field and validate it against the list of supported networks
* Add verification of the pay button disabling when card network is not supported

Depends on D5823

Differential Revision: https://phabricator.services.mozilla.com/D5824
2018-09-14 20:28:41 +00:00
Sam Foster
7906b3732a Bug 1429181 - Fix serialization of payment method data. r=MattN
* Includes a workaround to explicitly cloneInto the paymentMethods data when we create the PaymentRequest object in the content window in tests.

MozReview-Commit-ID: LFy0h3fIXXA

Differential Revision: https://phabricator.services.mozilla.com/D5823
2018-09-14 20:24:08 +00:00
Jared Wein
dc4a70252a Bug 1489629 - Adjust the size of the error images, sizing and position of text, and add footer branding to the error pages. r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D5320
2018-09-10 18:16:55 +00:00
Jared Wein
243b5fdc36 Bug 1482808 - Clear the field-specific merchant error invalid state when the field has been edited. r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D5081
2018-09-07 23:15:09 +00:00
Jared Wein
5ce5be7ff8 Bug 1487395 - Update strings on error pages, as well as convert apostrophes to use 'smart-quotes'. r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D5068
2018-09-06 19:43:19 +00:00
Timothy Guan-tin Chien
67e3dcd7aa Bug 1399367 - Remove MasterPassword.{encrypt|decrypt}Sync() methods r=MattN
This also makes various AutofillRecords methods async, with the exception of
remove() and removeAll().

Noted that I didn't implement any kind of "lock" for FormAutofillStorage --
please do not call these methods concurrently -- if you must please |await|
for the last call to resolve. This most likely would happen in tests, and
shouldn't happen in the real world, given that all user actions happen on
macrotasks, and probably not at the next tick, unless Quicksilver is a
Firefox user.

FormAutofillStorage can be improved if there are complex use cases for it.

Differential Revision: https://phabricator.services.mozilla.com/D4420
2018-09-05 17:54:48 +00:00
Csoregi Natalia
a34cf6da92 Backed out changeset 56aa054d4cc0 (bug 1399367) for browser/extensions/formautofill/test/unit/test_activeStatus.js failures. CLOSED TREE 2018-09-05 05:47:21 +03:00
Timothy Guan-tin Chien
6071bf1543 Bug 1399367 - Remove MasterPassword.{encrypt|decrypt}Sync() methods r=MattN
This also makes various AutofillRecords methods async, with the exception of
remove() and removeAll().

Noted that I didn't implement any kind of "lock" for FormAutofillStorage --
please do not call these methods concurrently -- if you must please |await|
for the last call to resolve. This most likely would happen in tests, and
shouldn't happen in the real world, given that all user actions happen on
macrotasks, and probably not at the next tick, unless Quicksilver is a
Firefox user.

FormAutofillStorage can be improved if there are complex use cases for it.

Differential Revision: https://phabricator.services.mozilla.com/D4420
2018-09-05 00:32:57 +00:00
Ciure Andrei
83a0320124 Merge inbound to mozilla-central. a=merge 2018-09-01 01:40:48 +03:00
Jared Wein
face3aae9c Bug 1484721 - Update the save button disabled state after changing the country select dropdown in the address-form. r=MattN
Differential Revision: https://phabricator.services.mozilla.com/D4470
2018-08-31 16:15:51 +00:00
Jared Wein
ac0511b6cc Bug 1480719 - Require credit card expiration month and year before saving credit cards. r=MattN
Differential Revision: https://phabricator.services.mozilla.com/D4485
2018-08-31 16:36:34 +00:00
Marcos Cáceres
3a73997f97 Bug 1485881 - Drop support for PaymentAddress.languageCode r=smaug 2018-08-27 16:30:00 +03:00
Sam Foster
0366c879b7 Bug 1477105 - Support cc-type as valid field for credit cards in form autofill. r=MattN
* Add cc-type as a valid field for credit card forms
* Add a select menu and new string for designating a card type in the add/edit form
* Enforce matching of cc-type to one of the list of supported network ids for Basic Card
* Expose the network ids list as CreditCard.SUPPORTED_TYPES
* Populate the cc-type options using a getCreditCardTypes util method passed into the EditCreditCard constructor

* Web Payment tests: verify cc-type picker is presented, populated as expected and selections received in the response

MozReview-Commit-ID: 9QyU1UwTRay

Differential Revision: https://phabricator.services.mozilla.com/D3830
2018-08-28 15:59:57 -07:00