corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
766,165 Commits 1 Branch 0 Tags
739b51aee122798f1d049575ff9f0747ca1fdea5
Commit Graph

392 Commits

Author SHA1 Message Date
Gijs Kruitbosch
2a1088e2f8 Bug 1787565 - update recently closed tab entries in Firefox View based on delayed tab navigation information from session history, r=sclements 
I don't love this solution but it appears to work and I can't think of anything better.

Differential Revision: https://phabricator.services.mozilla.com/D155920
 2022-09-02 12:32:45 +00:00
Sarah Clements
636bc451f1 Bug 1764137 - Add correct aria-roles to named-deck in firefoxview r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D156085
 2022-09-02 10:59:13 +00:00
Noemi Erli
ec9494988d Backed out changeset 59536058a947 (bug 1784902) for causing failures in browser_setup_state.js 2022-09-02 04:42:49 +03:00
Sam Foster
fe2b36be03 Bug 1784902 - Implement the collapsible fx-view sections as details/summary elements. r=Gijs 
* Both CEs now extend HTMLDetailsElement
* Keep the title string on the twisty/toggle element
* The whole summary element gets the focus highlight, and is clickable to collapse/expand the associated content
* Ensure the summary focus outline doesnt get clipped by the zap-card border below it
* Maintain the hover behavior on the twisty button to provide a visual cue for collapsibility
* The setup cards will be collapsible in all states, bug 1779384 will ensure we ignore a persisted closed state during sync setup so this content is always initially visible in a new session

Differential Revision: https://phabricator.services.mozilla.com/D155508
 2022-09-01 22:30:42 +00:00
Narcis Beleuzu
d2e96de8c9 Backed out changeset aa77f15a38d9 (bug 1779427) for assertion failure on DOMJSProxyHandler.cpp . CLOSED TREE 2022-09-02 00:34:30 +03:00
Emily McMinn
456f4168e4 Bug 1779427 - Turn on Firefox View feature tour by default r=mviar 
Differential Revision: https://phabricator.services.mozilla.com/D155482
 2022-09-01 19:15:01 +00:00
Sam Foster
c99a8022bb Bug 1788735 - Fix fallback/default value for the services.sync.lastTabFetch pref getters. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D156218
 2022-09-01 18:42:09 +00:00
Sam Foster
bb5d2ac9ca Bug 1785868 - Allow items in the fx-view main column to move up into empty vertical space. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D156217
 2022-09-01 18:41:17 +00:00
Meg Viar
27b13cf2f2 Bug 1787563 - Second Feature Callout screen is positioned too low r=Mardak 
Differential Revision: https://phabricator.services.mozilla.com/D155881
 2022-09-01 14:48:40 +00:00
Niklas Baumgardner
712e8dd8c0 Bug 1784294 - Sync tabs when Firefox View tab is selected. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D154825
 2022-09-01 13:06:50 +00:00
Iulian Moraru
a5b6c2be53 Backed out changeset c739e6f1b109 (bug 1779427) for causing mochitest failures. CLOSED TREE 2022-08-31 22:29:06 +03:00
Emily McMinn
959884abac Bug 1779427 - Turn on Firefox View feature tour by default r=mviar 
Differential Revision: https://phabricator.services.mozilla.com/D155482
 2022-08-31 18:39:16 +00:00
Shane Hughes
b8cc95cfc5 Bug 1787461 - Change Feature Callout's overlap of parent elements to 17px. r=mviar 
Feature Callouts are absolute positioned, but their coordinates are calculated
from those of the parent element given by a selector property on the message.
They were originally adjusted to overlap by 15px, but that was changed to
0.15x - y, where x is the parent width/height and y is the callout's arrow size
(12px). But using a scaling factor may cause unexpected results where parent
elements are unusually large, so this patch switches the overlap amount to 17px.
In the future, we could consider adding a property to the schema so that each
feature tour screen can specify an overlap amount to override the default 17px.

Differential Revision: https://phabricator.services.mozilla.com/D155750
 2022-08-31 17:53:34 +00:00
Meg Viar
248755e275 Bug 1786647 - Split up Feature Callout messages and fetch from ASRouter on page load, focus, and screen advance r=Mardak 
Differential Revision: https://phabricator.services.mozilla.com/D155524
 2022-08-31 16:09:26 +00:00
Daniel Holbert
32e1997212 Bug 1787871 - fix line clamping in the title of the Firefox View tab pickup hero tab card, r=sclements 
Differential Revision: https://phabricator.services.mozilla.com/D155964
 2022-08-31 11:16:32 +00:00
Meg Viar
f608e67d28 Bug 1787387 - No feature callout tour shown if tab sync is already set up r=Mardak 
Differential Revision: https://phabricator.services.mozilla.com/D155743
 2022-08-30 15:00:26 +00:00
Gijs Kruitbosch
4ef04e9049 Bug 1784085 - correct sync finishing topic identifier used in Firefox View so errors clear correctly, r=markh 
Differential Revision: https://phabricator.services.mozilla.com/D155922
 2022-08-30 09:32:56 +00:00
Gijs Kruitbosch
63a87376ea Bug 1784244 - do not surface sync errors in Firefox View if we previously synced successfully, r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D155845
 2022-08-30 08:52:54 +00:00
Daniel Holbert
62a59b16fd Bug 1787964: Improve content-based-sizing and vertical centering of Firefox View's "Last Active" badge. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D155917
 2022-08-30 06:23:17 +00:00
Sandor Molnar
8aaea79f98 Backed out changeset 225b8bbe0912 (bug 1786647) for causing browser-chrome failures in toolkit/components/messaging-system/schemas/TriggerActionSchemas/test/browser/browser_asrouter_trigger_docs.js CLOSED TREE 2022-08-30 01:43:39 +03:00
Meg Viar
91ba440ce8 Bug 1786647 - Split up Feature Callout messages and fetch from ASRouter on page load, focus, and screen advance r=Mardak 
Differential Revision: https://phabricator.services.mozilla.com/D155524
 2022-08-29 20:19:16 +00:00
Csoregi Natalia
591eeff1af Backed out changeset ba0784c1646a (bug 1786647) for fxms failures. CLOSED TREE 2022-08-29 19:51:17 +03:00
Meg Viar
4f744927cf Bug 1786647 - Split up Feature Callout messages and fetch from ASRouter on page load, focus, and screen advance r=Mardak 
Differential Revision: https://phabricator.services.mozilla.com/D155524
 2022-08-29 16:18:42 +00:00
Gijs Kruitbosch
93e3e2e766 Bug 1787253 - fix domains getting wrapped unnecessarily in Firefox View tab pickup section, r=niklas 
Differential Revision: https://phabricator.services.mozilla.com/D155768
 2022-08-29 15:59:49 +00:00
criss
351bc28d66 Backed out changeset 56ba242e0732 (bug 1786647) for causing python fxms failures . CLOSED TREE 2022-08-29 17:14:11 +03:00
Meg Viar
605bbe0b26 Bug 1786647 - Split up Feature Callout messages and fetch from ASRouter on page load, focus, and screen advance r=Mardak 
Differential Revision: https://phabricator.services.mozilla.com/D155524
 2022-08-29 13:29:31 +00:00
Gijs Kruitbosch
56c436dc5c Bug 1783276 - use min-content for timestamps and more space for the domain in the recently closed tabs grid, r=niklas 
The request from UX is for 16px column gaps but 8px between the URL and timestamp.
CSS grid doesn't support individual columns having different gaps, so I've made
the gap 8px and filled in the other 8px by incrementing inline start padding on
the title and URL.

Differential Revision: https://phabricator.services.mozilla.com/D155704
 2022-08-26 21:58:10 +00:00
Shane Hughes
16d1998b3f Bug 1783070 - Use safe navigators for About Welcome window functions. r=mviar 
Update About Welcome's invocations of window functions to use optional
chaining to avoid errors when they are undefined. Then, the surfaces
that load the About Welcome bundle will no longer need to define those
references as empty functions.

Differential Revision: https://phabricator.services.mozilla.com/D155011
 2022-08-26 21:43:54 +00:00
Katherine Patenio
377e9d145e Bug 1747229 - implement telemetry probes for colorway closet r=bigiri,dao,rpl 
Differential Revision: https://phabricator.services.mozilla.com/D151771
 2022-08-26 17:05:58 +00:00
Gijs Kruitbosch
5b4922b83b Bug 1787009 - ensure timestamps do not wrap in Firefox View in either tab pickup or recently closed tabs list, r=niklas 
Differential Revision: https://phabricator.services.mozilla.com/D155703
 2022-08-26 16:25:55 +00:00
Gijs Kruitbosch
a50a0a7200 Bug 1785234 - use abbreviated timestamps in Firefox View for both recently closed tab list and tab pickup, r=niklas 
Differential Revision: https://phabricator.services.mozilla.com/D155700
 2022-08-26 16:25:55 +00:00
Meg Viar
c114df74a0 Bug 1786356 - Create Firefox View open Tracker r=niklas,jprickett 
Differential Revision: https://phabricator.services.mozilla.com/D155432
 2022-08-26 16:16:17 +00:00
Cristian Tuns
a7c8ce5b60 Backed out changeset 44c1ce2f6854 (bug 1779427) for causing mochitest failures on browser_setup_state.js CLOSED TREE 2022-08-26 11:25:42 -04:00
Emily McMinn
4c96951e8e Bug 1779427 - Turn on Firefox View feature tour by default r=mviar 
Differential Revision: https://phabricator.services.mozilla.com/D155482
 2022-08-26 14:30:11 +00:00
Dão Gottwald
2595d2f756 Bug 1786627 - Let contentTheme.js set the color scheme so common-shared.css can honor it. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D155477
 2022-08-26 11:26:21 +00:00
Cristian Tuns
ebb501eec5 Backed out changeset 01a6e9812b8c (bug 1786627) for causing mochitest failures on browser_ext_themes_ntp_colors.js CLOSED TREE 2022-08-26 04:52:03 -04:00
Dão Gottwald
b4a515db76 Bug 1786627 - Let contentTheme.js set the color scheme so common-shared.css can honor it. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D155477
 2022-08-26 08:14:24 +00:00
Sam Foster
1eecd465c0 Bug 1784130 - Hide mobile promo when signed out. r=niklas 
* Only show the mobile promo when tab syncing is enabled
* Toggle the promo & confirmation visibility in all setup states to ensure it gets hidden when we re-enter the sign-in to FxA state
* Add test coverage for signing out
* Ensure we always restore the mocks

Depends on D155427

Differential Revision: https://phabricator.services.mozilla.com/D154850
 2022-08-26 05:37:49 +00:00
Butkovits Atila
acc81a64dd Backed out changeset d4db9e3554d5 (bug 1784130) for causing failures at browser_setup_state.js. 2022-08-25 23:07:58 +03:00
Sam Foster
c0c5dc6cc6 Bug 1784130 - Hide mobile promo when signed out. r=niklas 
* Only show the mobile promo when tab syncing is enabled
* Toggle the promo & confirmation visibility in all setup states to ensure it gets hidden when we re-enter the sign-in to FxA state
* Add test coverage for signing out

Differential Revision: https://phabricator.services.mozilla.com/D154850
 2022-08-25 19:12:39 +00:00
Sam Foster
9695132afd Bug 1786615 - Only show an error when sync isnt connected/enabled if we're currently signed in. r=markh 
Differential Revision: https://phabricator.services.mozilla.com/D155427
 2022-08-24 22:48:12 +00:00
Meg Viar
e53110046b Bug 1782524 - Reposition Feature Callout if it overlaps parent element by more than 15% r=Mardak 
Differential Revision: https://phabricator.services.mozilla.com/D154649
 2022-08-24 18:24:15 +00:00
Dão Gottwald
c8e65627ce Bug 1786293 - Move Firefox View button from CustomizableWidgets to markup. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D155356
 2022-08-24 15:51:44 +00:00
Norisz Fay
4c9cbdf45f Backed out changeset ebba7740ac81 (bug 1784294) for causing bc failures on browser_setup_state.js CLOSED TREE 2022-08-24 09:33:55 +03:00
Niklas Baumgardner
c2ee1cbc9d Bug 1784294 - Sync tabs when Firefox View tab is selected. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D154825
 2022-08-24 02:43:35 +00:00
Niklas Baumgardner
69a062bf44 Bug 1784969 - Force sync on Firefox View sync error or network offline action. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D154828
 2022-08-23 13:49:07 +00:00
Dão Gottwald
d32e73692a Bug 1774435 - Remove NIGHTLY_BUILD conditions for Firefox View. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D154398
 2022-08-23 09:50:42 +00:00
Cosmin Sabou
f1791db946 Bug 1784343 - temporarily disable browser_feature_callout.js for frequent failures until it's fixed. r=mviar DONTBUILD 
Differential Revision: https://phabricator.services.mozilla.com/D155207
 2022-08-22 13:15:33 +00:00
Csoregi Natalia
72f77aa504 Backed out changeset 50e2770d7b30 (bug 1782524) for causing failures on browser_feature_callout.js. 2022-08-22 03:40:54 +03:00
Marian-Vasile Laza
37011bfaa3 Backed out changeset 50e2770d7b30,1d022fd2c075 (Bug 1782524) for causing bc failures on browser_feature_callout.js CLOSED TREE 2022-08-20 15:38:14 +03:00