corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
766,165 Commits 1 Branch 0 Tags
739b51aee122798f1d049575ff9f0747ca1fdea5
Commit Graph

392 Commits

Author SHA1 Message Date
Stanca Serban
fb83fffbb8 Backed out changeset 6c9b61f0bdaf (bug 1803763) for causing bc failures on browser_recently_closed_tabs.js. CLOSED TREE 2022-12-02 19:34:20 +02:00
Kelly Cochrane
085abb39b4 Bug 1803763 - Add title attribute to recently closed tab dismiss button r=dao,fluent-reviewers,flod 
Differential Revision: https://phabricator.services.mozilla.com/D163719
 2022-12-02 16:06:53 +00:00
Anna Yeddi
cc13332459 Bug 1800982 - Improve HCM support on macOS for Last Active badge background in Fx View. r=sfoster,desktop-theme-reviewers 
Ensuring that on macOS users of `Increase Contrast` mode get high contrast combination of the text and background for the `Last active` badge.

Differential Revision: https://phabricator.services.mozilla.com/D163014
 2022-12-01 22:51:52 +00:00
Greg Tatum
b9cd5fa6a0 Bug 1685180 - Ensure tests all properly set fluent args; r=nordzilla,settings-reviewers,Gijs 
Either provide the dynamic data correctly in tests, or provide empty
strings when it doesn't exist.

Differential Revision: https://phabricator.services.mozilla.com/D162336
 2022-12-01 21:40:57 +00:00
Shane Hughes
db26095c40 Bug 1795288 - Feature Callouts: add dismiss telemetry. r=mviar 
Differential Revision: https://phabricator.services.mozilla.com/D163531
 2022-12-01 16:42:18 +00:00
Hanna Jones
c238132e26 Bug 1788800 - run colorways card tests in the same window take two r=sfoster 
This patch completes what I tried to do in D162617. Poking around at this again I realized (embarassingly) that I forgot to change one test to run in the same window, and it was the test that failed consistently on try when run in isolation.

Based on the profile Florian helped me look at it seemed like we had a window leak and were possibly still trying to run animations in a window that had been closed. It  feels plausible that going back to what we were doing before my initial change - running all the tests in the same window and only closing that window once they had all finished - might still be the fix for this intermittent.

Recent try push looked good: https://treeherder.mozilla.org/jobs?repo=try&revision=3836fc6ceeb2f9c522a2d2a0126f6bdc9aea1bb6&selectedTaskRun=arwidi8RROCcJkUY-hMg1g.0

Compared to running similar jobs without this one change: https://treeherder.mozilla.org/jobs?repo=try&revision=8c2345419537e5465104edfd29c270496db90cef

Differential Revision: https://phabricator.services.mozilla.com/D163476
 2022-11-30 21:24:16 +00:00
Kelly Cochrane
bacaafe92b Bug 1787945 - Add dismiss functionality to recently closed tabs list items in Fx View r=ayeddi,sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D161848
 2022-11-30 16:24:15 +00:00
Gijs Kruitbosch
3fd7180951 Bug 1789043 - use existing NOTIFY_BROWSER_SHUTDOWN_FLUSH on firefox view to be told about closing tabs, r=sclements 
Differential Revision: https://phabricator.services.mozilla.com/D163216
 2022-11-30 14:13:41 +00:00
Kelly Cochrane
5e7f8ca3a2 Bug 1796659 - Add padding to synced tabs error content area in Fx View r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D163245
 2022-11-30 12:41:50 +00:00
Meg Viar
18abc909b1 Bug 1795894 - Enable triggering Feature Callouts in chrome by content location r=jprickett 
Differential Revision: https://phabricator.services.mozilla.com/D160503
 2022-11-30 01:47:23 +00:00
Meg Viar
5d6cd66915 Bug 1802918 - Update Firefox View Feature Callout tests to work after Colorways expire r=aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D163241
 2022-11-29 15:43:49 +00:00
Shane Hughes
129615901b Bug 1799195 - Disable feature callout resize test. r=mviar 
We can re-enable this test as part of bug 1795973 when the patch for
that is rebased and fully passing.

Differential Revision: https://phabricator.services.mozilla.com/D162446
 2022-11-28 15:48:39 +00:00
Sandor Molnar
61f05197c3 Backed out changeset 28484915dc1b (bug 1795894) for causing mochitest failures. CLOSED TREE 2022-11-28 04:33:07 +02:00
Meg Viar
3633b07781 Bug 1795894 - Enable triggering Feature Callouts in chrome by content location r=jprickett 
Differential Revision: https://phabricator.services.mozilla.com/D160503
 2022-11-28 00:54:14 +00:00
Hanna Jones
dbf0f29e8a Bug 1788800 - fix new colorways card intermittent r=sfoster 
From what I can tell switching to `withFirefoxView` and opening a new window to run these tests in + closing that window before disabling the theme messed with the timing of these tests in such a way that we started getting that vsync error shown in the logs. I've switched to running all these tests in the same window, which looks good from a couple of try pushes:

https://treeherder.mozilla.org/jobs?repo=try&revision=9a5f379ecc48bda08eab67210278b547f558f856

https://treeherder.mozilla.org/jobs?repo=try&revision=76b909924455fda54165ffeaa00b3654b4decd09

I'll file a follow up bug to change the default behaviour of `withFirefoxView` is to run tests in the same window, as this has come up before.

Also worth noting that even if this patch lands and fixes the new frequent intermittent we will likely still see the less frequent intermittents that happened prior to the change for Bug 1780441.

Differential Revision: https://phabricator.services.mozilla.com/D162617
 2022-11-24 14:40:36 +00:00
Butkovits Atila
732bdfaac1 Backed out 2 changesets (bug 1685180) for causing Xpcshell failures at test_l10nCache.js. CLOSED TREE 
Backed out changeset c05d7c567c19 (bug 1685180)
Backed out changeset be4603eff17c (bug 1685180)
 2022-11-21 19:51:30 +02:00
Greg Tatum
3395329186 Bug 1685180 - Ensure tests all properly set fluent args; r=nordzilla,settings-reviewers,Gijs 
Either provide the dynamic data correctly in tests, or provide empty
strings when it doesn't exist.

Differential Revision: https://phabricator.services.mozilla.com/D162336
 2022-11-21 16:14:06 +00:00
Hanna Jones
d6f904e4a2 Bug 1800478 - fix intermittent failure in fx view accessibility tests r=tgiles 
The switch to using `withFirefoxView` caused another onboarding prompt to show. After the fx view tabstrip button has been clicked for the 3rd time we display a new message. This wasn't happening before because the pref that controls this is tied to that button click, so didn't get incremented when we were opening about:firefoxview in a new tab.

Differential Revision: https://phabricator.services.mozilla.com/D162427
 2022-11-21 15:56:49 +00:00
Hanna Jones
c7f85ea5bb Bug 1801328 - remove duplicate keyboard focus test r=tgiles 
Differential Revision: https://phabricator.services.mozilla.com/D162411
 2022-11-18 16:05:04 +00:00
Dão Gottwald
cfc7cc8b18 Bug 1801037 - Remove "New colorways are on the way" message from Firefox View. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D162264
 2022-11-18 06:25:41 +00:00
Tim Giles
e65dbcf363 Bug 1800689 - Remove colorways null state. r=sclements 
Differential Revision: https://phabricator.services.mozilla.com/D162154
 2022-11-17 17:05:27 +00:00
Norisz Fay
4966c7af4a Backed out changeset 3811dbb4b859 (bug 1800689) for causing bc failures on browser_colorways_card.js CLOSED TREE 2022-11-16 19:53:33 +02:00
Tim Giles
29d474c25c Bug 1800689 - Remove colorways null state. r=sclements 
Differential Revision: https://phabricator.services.mozilla.com/D162154
 2022-11-16 17:12:28 +00:00
Hanna Jones
6b7f672eaf Bug 1780441 - standardize tests to use withFirefoxView r=sfoster 
There are a handful of callout tests still opening `about:firefoxview` in a new tab. [Bug 1797815](https://bugzilla.mozilla.org/show_bug.cgi?id=1797815) will cover updating those tests.

Differential Revision: https://phabricator.services.mozilla.com/D160557
 2022-11-14 14:16:14 +00:00
Marian-Vasile Laza
cb5a3644d1 Backed out changeset de61491bc549 (bug 1795894) for causing bc failures on browser_protocol_ask_dialog.js. CLOSED TREE 2022-11-11 01:14:04 +02:00
Sammy Khamis
01a28f937c Bug 1799255: Revert the SyncedTabs lastUsed change and any changes from consumers r=markh,sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D161661
 2022-11-10 21:28:42 +00:00
Meg Viar
9e1c9a7613 Bug 1795894 - Enable triggering Feature Callouts in chrome by content location r=jprickett 
Differential Revision: https://phabricator.services.mozilla.com/D160503
 2022-11-10 21:01:22 +00:00
Tim Giles
59a018b7f8 Bug 1798350 - Fix tab pickup text and border colors in HCM. r=cmkm 
Prevent the synced tab anchor element and its children from using
the inherited `VisitedText` system color in HCM. This helps bring the
tab pickup list into alignment with the Firefox View "Stepping Stone"
design spec.

Differential Revision: https://phabricator.services.mozilla.com/D161739
 2022-11-10 19:30:44 +00:00
Marian-Vasile Laza
4582bdf7cb Backed out changeset 2023e8659017 (bug 1795894) for causing multiple bc failures on featureCallout.mjs. CLOSED TREE 2022-11-10 21:42:43 +02:00
Tim Giles
9c31a0c2b4 Bug 1794435 - Fix intermittent tab pickup test. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D161474
 2022-11-10 19:18:25 +00:00
Meg Viar
ed1f5ee2a9 Bug 1795894 - Enable triggering Feature Callouts in chrome by content location r=jprickett 
Differential Revision: https://phabricator.services.mozilla.com/D160503
 2022-11-10 18:47:04 +00:00
Kelly Cochrane
dda30fdb6b Bug 1799671 - Add --fxvew-text-primary-color variable for use with new empty state illustrations r=sclements 
Differential Revision: https://phabricator.services.mozilla.com/D161596
 2022-11-08 17:34:46 +00:00
Meg Viar
94b9dcae12 Bug 1797963 - Only count feature callout message impressions and don't allow load config to be called again until first call resolves r=Mardak,hanna_a 
Differential Revision: https://phabricator.services.mozilla.com/D161073
 2022-11-08 17:03:24 +00:00
Katherine Patenio
17a4ba821d Bug 1794624: add test for drop and drag fix for RTL builds after opening FxView tab r=dao 
Differential Revision: https://phabricator.services.mozilla.com/D158888
 2022-11-07 18:34:20 +00:00
Kelly Cochrane
3500b25829 Bug 1788152 - Update presentation of Recently Closed and Tab Pickup empty states r=flod,fluent-reviewers,desktop-theme-reviewers,sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D160545
 2022-11-07 14:07:52 +00:00
Bernard Igiri
4b27d1890a Bug 1785272 - Fix Fx View Button VO Announcement r=Gijs 
Changed the aria role from tab to button to fix the VO announcement so that it correctly reports when the Fx View tab is actually selected.

Differential Revision: https://phabricator.services.mozilla.com/D159887
 2022-11-07 07:07:20 +00:00
Tim Giles
4d7e252046 Bug 1792505 - Move test_keyboard_accessibility into separate a11y file. r=sfoster 
This commit moves the test_keyboard_accessibility task into the
firefoxview_accessibility test file.
Additionally, a shared variable and a cleanup function are moved to
head.js.
The cleanup function is renamed for clarity.

Differential Revision: https://phabricator.services.mozilla.com/D160961
 2022-11-04 14:55:16 +00:00
Tim Giles
994ec689ac Bug 1792505 - Clean up duplicated variables in recently closed tests. r=sfoster 
This commit moves some duplicated variables and functions
into the head.js file.

Differential Revision: https://phabricator.services.mozilla.com/D160959
 2022-11-04 14:55:15 +00:00
Tim Giles
d54ecc3525 Bug 1792505 - Move browser_feature_callout_resize a11y test to separate file. r=sfoster 
This commit moves the "feature_callout_is_accessible" task to the
"browser_firefoxview_feature_callout_a11y" test.
This change required some additional refactoring as well, moving some
shared selectors and functions to head.js.
The waitForCalloutScreen function was refactored to take full string IDs
as there were multiple implementations of this function that conflicted
with each other.
This waitForCalloutScreen change also caused these tests to use an
explicit ID such as "FEATURE_CALLOUT_1" or
"FIREFOX_VIEW_COLORWAYS_REMINDER".

Differential Revision: https://phabricator.services.mozilla.com/D160957
 2022-11-04 14:55:15 +00:00
Tim Giles
454e12c6ed Bug 1792505 - Move browser_setup_state a11y test to separate file. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D160956
 2022-11-04 14:55:14 +00:00
Bernard Igiri
511d17c548 Bug 1790971 - Prevent Firefox View Tab from being autoselected on tab closing r=dao 
Prevent pinned Firefox View Tab from being autoselected on tab closing.

Differential Revision: https://phabricator.services.mozilla.com/D161218
 2022-11-04 13:35:13 +00:00
yozhangmozilla
4cb5b243e0 Bug 1790133 Adjust Feature Callout Container vertical positioning depending on target's height r=jprickett 
Differential Revision: https://phabricator.services.mozilla.com/D158170
 2022-11-03 16:08:40 +00:00
Sarah Clements
12a28bcf6b Bug 1798692 - Fix timestamp used in Tab Pickup list r=sfoster 
* Remove multiplication of lastUsed by 1000 due to changes in bug 1791851

Differential Revision: https://phabricator.services.mozilla.com/D161039
 2022-11-03 11:28:27 +00:00
Jason Prickett
b79b303d74 Bug 1794651 - Adding custom position override to feature callout r=mviar 
Differential Revision: https://phabricator.services.mozilla.com/D159556
 2022-11-02 17:32:08 +00:00
Kelly Cochrane
e104d4b35c Bug 1787063 - Adjust color-mix for secondary text to better align with design spec r=dao 
Differential Revision: https://phabricator.services.mozilla.com/D160687
 2022-11-01 17:56:49 +00:00
Kelly Cochrane
68b7ec47c7 Bug 1793088 - Make first available tab focusable when Fx View is open r=dao 
Differential Revision: https://phabricator.services.mozilla.com/D159766
 2022-11-01 15:45:45 +00:00
Bernard Igiri
88c38f79b6 Bug 1796004 - Updated disclosure arrow direction and positioning in Fx View r=sclements 
Updated disclosure arrow direction and positioning in Fx View, to match Figma, for both LTR an RTL presentations.

Differential Revision: https://phabricator.services.mozilla.com/D160134
 2022-11-01 15:24:13 +00:00
Stanca Serban
4081bf7eca Backed out changeset c37b2558862b (bug 1787063) for causing new failures on _theme.scss. CLOSED TREE 2022-11-01 16:25:28 +02:00
Kelly Cochrane
c1d28465a5 Bug 1787063 - Adjust color-mix for secondary text to better align with design spec r=dao 
Differential Revision: https://phabricator.services.mozilla.com/D160687
 2022-11-01 13:26:20 +00:00
Tim Giles
a5a829f7ec Bug 1789875 - Move recently closed keyboard test to separate file. r=sclements 
Differential Revision: https://phabricator.services.mozilla.com/D160539
 2022-10-31 13:54:33 +00:00