Commit Graph

392 Commits

Author SHA1 Message Date
Jared Hirsch
0ca0f19c16 Bug 1779384 - Persist collapsed state of Firefox View lists r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D156754
2022-09-14 17:18:35 +00:00
Sarah Clements
e04c7ffb66 Bug 1787979 - keyboard shortcut navigates to the wrong tab from Firefox View tab r=dao
* Remove index: 0 in FirefoxViewHandler.openTab
* Add condition in tabbrowser _selectNextTab for FirefoxView tab
* Fix tests

Differential Revision: https://phabricator.services.mozilla.com/D156688
2022-09-14 15:20:01 +00:00
Marian-Vasile Laza
2e7d3531bc Backed out changeset 9bf0a16672ec (bug 1787979) for causing bc failures on browser_sma_click_element.js. CLOSED TREE 2022-09-14 16:45:04 +03:00
Sarah Clements
26d455d485 Bug 1787979 - keyboard shortcut navigates to the wrong tab from Firefox View tab r=dao
* Remove index: 0 in FirefoxViewHandler.openTab
* Add condition in tabbrowser _selectNextTab for FirefoxView tab
* Fix tests

Differential Revision: https://phabricator.services.mozilla.com/D156688
2022-09-14 11:24:58 +00:00
Gijs Kruitbosch
d4092a7277 Bug 1790074 - default to showing warning logs only for fxview tabs-setup-manager, r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D157255
2022-09-14 09:50:59 +00:00
Sandor Molnar
e5de5b30e6 Backed out changeset dd71b6e79551 (bug 1779384) for causing browser-chrome failures in browser/components/firefoxview/tests/browser/browser_recently_closed_tabs.js CLOSED TREE 2022-09-14 04:59:04 +03:00
Jared Hirsch
e2d8d3f927 Bug 1779384 - Persist collapsed state of Firefox View lists r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D156754
2022-09-13 23:18:34 +00:00
Dão Gottwald
662ecc18a6 Bug 1788257 - Hide collection expiry date when a colorway is selected. r=bigiri
Differential Revision: https://phabricator.services.mozilla.com/D157208
2022-09-13 19:51:56 +00:00
Tim Giles
9e19362b07 Bug 1786397 - Fix Windows HCM issues in Firefox View. r=dao
Differential Revision: https://phabricator.services.mozilla.com/D156866
2022-09-13 14:40:41 +00:00
Dão Gottwald
52f305cd6c Bug 1790409 - Fix zap gradient border scaling. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D157205
2022-09-13 12:50:30 +00:00
Niklas Baumgardner
64af4bc4a1 Bug 1790407 - Close button for mobile pick up card should be clickable. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D157156
2022-09-13 09:11:46 +00:00
Niklas Baumgardner
6d0b8eb558 Bug 1789641 - Telemetry enchancements for Firefox View. r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D156728
2022-09-12 20:37:52 +00:00
Gijs Kruitbosch
d8a1297f7c Bug 1787559 - update recently closed tabs description in Firefox View, r=flod,fluent-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D157123
2022-09-12 15:58:17 +00:00
Sarah Clements
395367fdea WIP Bug 1784363 - Update the fxa entrypoint to use fx-view r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D156081
2022-09-12 09:30:11 +00:00
Emily McMinn
5cf7cfb2e6 Bug 1779427 - Turn on Firefox View feature tour by default r=mviar
Split out position tests to simplify re-enabling bulk of tests. Fix preference getter leak with weakDoc.

Differential Revision: https://phabricator.services.mozilla.com/D155482
2022-09-11 15:59:15 +00:00
Shane Hughes
7deb89ce64 Bug 1788764 - Suppress Feature Callouts when feature recommendations are disabled by pref. r=mviar
Only show Feature Callout messages when the user preference
`browser.newtabpage.activity-stream.asrouter.userprefs.cfr.features`
is enabled (it's enabled by default). This corresponds to the setting
labeled "Recommend features as you browse" in about:preferences.

Differential Revision: https://phabricator.services.mozilla.com/D156357
2022-09-10 20:35:12 +00:00
negin
07953d5d61 Bug 1786341 - Continous Onboarding - Firefox View: Tab pick up r=mviar,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D155994
2022-09-09 22:52:53 +00:00
Jason Prickett
d76e44a172 Bug 1786347 - Adding continuous onboarding colorways reminder to firefox view feature callout r=mviar,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D156700
2022-09-09 22:38:11 +00:00
Kelly Cochrane
5f30b66795 Bug 1786966 - Make sure Fx View logo text doesn't wrap and sidebar width is automatically adjusted to accomodate it r=dao
Differential Revision: https://phabricator.services.mozilla.com/D156976
2022-09-09 18:05:47 +00:00
Niklas Baumgardner
aa28bcc786 Bug 1789226 - Show zap gradient border for tab pickup cards. r=sclements
Differential Revision: https://phabricator.services.mozilla.com/D156597
2022-09-09 16:09:26 +00:00
Kelly Cochrane
b382e80b07 Bug 1786966 - Increase Fx View logo font size r=dao
Differential Revision: https://phabricator.services.mozilla.com/D156965
2022-09-09 15:10:54 +00:00
Mike Conley
ae11f3c9d0 Bug 1785282 - Open 'Choose what to sync' dialog when users click 'Turn sync on in settings' in Firefox View. r=sclements
Differential Revision: https://phabricator.services.mozilla.com/D156578
2022-09-09 14:26:50 +00:00
Mike Conley
17a6c46e36 Bug 1787128 - Explicitly define TabPickupContainer's error message IDs rather than composing them. r=sclements
While this introduces some redundancy, the advantage to spelling out the error message IDs like
this explicitly is that if the string ever needs to be updated (which requires a message ID
change), then we have a single place to remap the error code strings to the message IDs.

Differential Revision: https://phabricator.services.mozilla.com/D156553
2022-09-09 14:00:51 +00:00
Kelly Cochrane
2986c474df Bug 1789318 - Resolving grid row spacing issues when collapsing accordions in Fx View r=hjones
Differential Revision: https://phabricator.services.mozilla.com/D156882
2022-09-09 12:55:21 +00:00
Meg Viar
2a8638fb36 Bug 1788231 - Add ability to trigger a button on parent page from Feature Callout CTA and implement for Firefox View: Tab pick up message r=emcminn
Differential Revision: https://phabricator.services.mozilla.com/D156203
2022-09-08 21:50:37 +00:00
Sam Foster
6f44add480 Bug 1784676 - Extract the setup error and sync-disabled tests into their own test files. r=niklas,sclements
Differential Revision: https://phabricator.services.mozilla.com/D156730
2022-09-08 19:40:42 +00:00
Hanna Jones
817aaeb8da Bug 1785868 - Give tab pickup a more explicit height to remove vertical space r=Gijs
This is the same as using `minmax(0, max-content)`. Using this for the first track seems to get the height to more accurately reflect the content and removes some of the extra whitespace/jumpiness on the page.

Differential Revision: https://phabricator.services.mozilla.com/D156880
2022-09-08 19:13:50 +00:00
Cieara Meador
1b545e24e9 Bug 1787003 - Adjust font size of tab pickup timestamp r=niklas
Differential Revision: https://phabricator.services.mozilla.com/D156868
2022-09-08 16:49:27 +00:00
Kelly Cochrane
d3383882e5 Bug 1786966 - Update Fx View logo font weight to match h1s r=dao
Differential Revision: https://phabricator.services.mozilla.com/D156839
2022-09-08 15:12:59 +00:00
Kelly Cochrane
8417c12ebd Bug 1787262 - Update h1 font size and weight in Fx View to match Figma spec r=dao
Differential Revision: https://phabricator.services.mozilla.com/D156594
2022-09-07 14:23:52 +00:00
Mike Conley
8fb10b7edb Bug 1787441 - Use the browser brand icon as the favicon for about:firefoxview. r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D156585
2022-09-07 13:35:35 +00:00
Mike Conley
1b1c5a94b2 Bug 1786565 - Re-enable testNotificationDotOnMultipleWindows test in browser_notification_dot.js. r=dao
Differential Revision: https://phabricator.services.mozilla.com/D156579
2022-09-07 12:58:40 +00:00
Dão Gottwald
5709bd7bd4 Bug 1787797 - Let the Firefox View menu item re-add the button to the tabs toolbar if it got previously removed. r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D156412
2022-09-07 12:21:25 +00:00
Marian-Vasile Laza
dec9aef2c5 Backed out changeset 8c4f4626a3e6 (bug 1788231) for causing bc failures on browser_sma_click_element.js. CLOSED TREE 2022-09-07 00:04:24 +03:00
Meg Viar
6bc9091c7b Bug 1788231 - Add ability to trigger a button on parent page from Feature Callout CTA and implement for Firefox View: Tab pick up message r=emcminn
Differential Revision: https://phabricator.services.mozilla.com/D156203
2022-09-06 20:09:44 +00:00
Sam Foster
7379129193 Bug 1783277 - Use --fxview-text-secondary-color for placeholder content in both Tab Pickup and Recently Closed Tabs. r=sclements
Differential Revision: https://phabricator.services.mozilla.com/D156351
2022-09-06 16:13:46 +00:00
Andreea Pavel
eb1398daa7 Bug 1784343 - disable browser_feature_callout.js to reduce failure rate r=intermittent-reviewers,MasterWayZ DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D156496
2022-09-06 00:45:30 +00:00
Gijs Kruitbosch
d38c0659ad Bug 1788813 - do not report spurious telemetry events for the toggling of the recently closed or tab pickup lists as a result of pageload, r=sclements
Differential Revision: https://phabricator.services.mozilla.com/D156370
2022-09-05 10:39:07 +00:00
Gijs Kruitbosch
6e20818109 Bug 1787565 - update recently closed tab entries in Firefox View based on delayed tab navigation information from session history, r=sclements
I don't love this solution but it appears to work and I can't think of anything better.

Differential Revision: https://phabricator.services.mozilla.com/D155920
2022-09-04 08:04:09 +00:00
Sandor Molnar
ed37cce0b5 Backed out changeset 08105e2d612c (bug 1785734) for causing browser-chrome failures in browser_keyboard_focus.js CLOSED TREE 2022-09-04 02:27:23 +03:00
Niklas Baumgardner
3141273c56 Bug 1785734 - Add test for keyboard focus in Firefox View. r=ayeddi,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D155253
2022-09-03 21:42:02 +00:00
Iulian Moraru
5282da4259 Backed out changeset b63ab5a39b53 (bug 1787565) for causing bc failures on browser_recently_closed_tabs.js. CLOSED TREE 2022-09-03 14:09:15 +03:00
Gijs Kruitbosch
8f8fa020b4 Bug 1787565 - update recently closed tab entries in Firefox View based on delayed tab navigation information from session history, r=sclements
I don't love this solution but it appears to work and I can't think of anything better.

Differential Revision: https://phabricator.services.mozilla.com/D155920
2022-09-03 09:53:55 +00:00
Cristian Tuns
5f5728da34 Backed out changeset 179824908d2d (bug 1788231) for causing mochitest failures on browser_sma_click_element.js CLOSED TREE 2022-09-02 16:59:41 -04:00
Meg Viar
59445898aa Bug 1788231 - Add ability to trigger a button on parent page from Feature Callout CTA and implement for Firefox View: Tab pick up message r=emcminn
Differential Revision: https://phabricator.services.mozilla.com/D156203
2022-09-02 20:17:49 +00:00
Sam Foster
1bbdf0032f Bug 1784902 - Implement the collapsible fx-view sections as details/summary elements. r=Gijs
* Both CEs now extend HTMLDetailsElement
* Keep the title string on the twisty/toggle element
* The whole summary element gets the focus highlight, and is clickable to collapse/expand the associated content
* Maintain the hover behavior on the twisty button to provide a visual cue for collapsibility
* The setup cards will be collapsible in all states, bug 1779384 will ensure we ignore a persisted closed state during sync setup so this content is always initially visible in a new session

Differential Revision: https://phabricator.services.mozilla.com/D155508
2022-09-02 18:53:21 +00:00
Butkovits Atila
a1fa5a8368 Backed out changeset 5a064ed3c5dc (bug 1785868) as per request by Sam. 2022-09-02 18:57:57 +03:00
Dão Gottwald
02c7a85d0a Bug 1787973 - Colorway closet entrypoint in Firefox View should show the "new colorways soon" null state if colorway closet nimbus variable is disabled. r=bigiri
Differential Revision: https://phabricator.services.mozilla.com/D156188
2022-09-02 14:39:24 +00:00
Butkovits Atila
dd9a633a7c Backed out changeset df6d4e6e452c (bug 1787565) for causing failures at browser_ext_browserAction_popup_resize_bottom.js. 2022-09-02 16:26:14 +03:00
Gijs Kruitbosch
40bbc1905a Bug 1787437 - close the Firefox View tab when removing the FxView toolbar item completely, r=dao
Differential Revision: https://phabricator.services.mozilla.com/D155921
2022-09-02 12:49:54 +00:00