We've made a few changes to this "Top pick" checkbox recently based on shifting
Product requirements, and the problem here is that the checkbox used to be
inside the Firefox Suggest container, but we recently moved it outside the
container. The Firefox Suggest container is properly hidden or shown depending
on whether the Suggest feature is enabled, so when the checkbox was inside the
container and Suggest was disabled, the checkbox properly got hidden too. Now
that the checkbox is outside that container, its visibility needs to entirely
depend on whether the best match feature is enabled.
So all this revision does is move the checkbox's `hidden` assignment from inside
the "is Suggest enabled" if-block to outside the if-block. It also sets
`hidden=true` on the checkbox in the markup for good measure.
I also improved the test so it checks every combination of enabled statuses
between the Suggest and best match features.
Depends on D138987
Differential Revision: https://phabricator.services.mozilla.com/D139161
We've made a few changes to this "Top pick" checkbox recently based on shifting
Product requirements, and the problem here is that the checkbox used to be
inside the Firefox Suggest container, but we recently moved it outside the
container. The Firefox Suggest container is properly hidden or shown depending
on whether the Suggest feature is enabled, so when the checkbox was inside the
container and Suggest was disabled, the checkbox properly got hidden too. Now
that the checkbox is outside that container, its visibility needs to entirely
depend on whether the best match feature is enabled.
So all this revision does is move the checkbox's `hidden` assignment from inside
the "is Suggest enabled" if-block to outside the if-block. It also sets
`hidden=true` on the checkbox in the markup for good measure.
I also improved the test so it checks every combination of enabled statuses
between the Suggest and best match features.
Depends on D138987
Differential Revision: https://phabricator.services.mozilla.com/D139161
We've made a few changes to this "Top pick" checkbox recently based on shifting
Product requirements, and the problem here is that the checkbox used to be
inside the Firefox Suggest container, but we recently moved it outside the
container. The Firefox Suggest container is properly hidden or shown depending
on whether the Suggest feature is enabled, so when the checkbox was inside the
container and Suggest was disabled, the checkbox properly got hidden too. Now
that the checkbox is outside that container, its visibility needs to entirely
depend on whether the best match feature is enabled.
So all this revision does is move the checkbox's `hidden` assignment from inside
the "is Suggest enabled" if-block to outside the if-block. It also sets
`hidden=true` on the checkbox in the markup for good measure.
I also improved the test so it checks every combination of enabled statuses
between the Suggest and best match features.
Depends on D138987
Differential Revision: https://phabricator.services.mozilla.com/D139161
This is based on part 1 in D138583. It hides the best match toggle switch when
the best match feature is disabled. The best match feature is a sub-feature of
Firefox Suggest, so the toggle is also hidden if Suggest is disabled, along with
all the other Suggest UI.
Depends on D138583
Differential Revision: https://phabricator.services.mozilla.com/D138584
- Show data collection section in about:preferences#privacy when privacy segmentation
section is enabled.
This is to ensure we can always show the privacy segmentation checkbox, even if data
reporting is disabled.
- Add checkbox and learnMore label for privacy segmentation pref.
- Add pref for section visibility and learnMore link suffix.
- Provisional copy, final copy to be added in Bug 1752172.
Differential Revision: https://phabricator.services.mozilla.com/D136650
- Show data collection section in about:preferences#privacy when privacy segmentation
section is enabled.
This is to ensure we can always show the privacy segmentation checkbox, even if data
reporting is disabled.
- Add checkbox and learnMore label for privacy segmentation pref.
- Add pref for section visibility and learnMore link suffix.
- Provisional copy, final copy to be added in Bug 1752172.
Differential Revision: https://phabricator.services.mozilla.com/D136650
These were all areas that were confusing me when I was onboarding on to
this code, so I tried to make the terminology less ambiguous and more
precise.
The default language is now the primary language.
UI is now appended to words that are dealing with DOM elements rather
than data stores.
Differential Revision: https://phabricator.services.mozilla.com/D136019
