Commit Graph

662 Commits

Author SHA1 Message Date
Hannah Peuckmann
f858c80de9 Bug 1785825 - Add ETP exceptions from about:preferences#privacy. r=fluent-reviewers,pbz,flod,settings-reviewers,hjones
Differential Revision: https://phabricator.services.mozilla.com/D158116
2022-12-05 19:19:01 +00:00
James Teow
a7c0bdc10b Bug 1802564 - Toggle showSearchTerms to true on Nightly - r=adw
Differential Revision: https://phabricator.services.mozilla.com/D163221
2022-12-03 02:24:49 +00:00
Cristian Tuns
9796804d31 Backed out changeset b4f24df08c5a (bug 1802564) for causing bc failures on browser_glean_telemetry_engagement_interaction.js CLOSED TREE 2022-12-01 20:24:11 -05:00
James Teow
c0621f6f3d Bug 1802564 - Toggle showSearchTerms to true on Nightly - r=adw
Differential Revision: https://phabricator.services.mozilla.com/D163221
2022-12-01 23:06:14 +00:00
James Teow
14f7ec50f1 Bug 1800851 - showSearchTerms checkbox should listen to search bar changes - r=adw,settings-reviewers
While trying to simplify the test code prior to landing the initial preference
panel update, I removed some checks in the test that ensured the checkbox
was actually being checked if the user enabled the search bar while the search
panel was opened. Hence how the tests passed despite the fact that I neglected
to include a listener.

Differential Revision: https://phabricator.services.mozilla.com/D162583
2022-11-22 18:20:22 +00:00
scott
35e4f02b0f Bug 1798956 - Pocket newtab ensure we clear spocs in cases where sponsored topsites applies to Pocket data. r=nanj
Differential Revision: https://phabricator.services.mozilla.com/D162028
2022-11-21 20:24:29 +00:00
Mark Banner
11b4005c4f Bug 1791974 - Use setAsDefault* parameters where appropriate for consumers of SearchTestUtils.installSearchExtension. r=mcheang
Differential Revision: https://phabricator.services.mozilla.com/D161045
2022-11-18 14:30:27 +00:00
Mark Banner
5d1820b074 Bug 1799314 - Convert consumers of testing modules to import ES modules direct (browser/). r=Gijs,settings-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D161914
2022-11-17 12:00:30 +00:00
Mark Banner
19c189e131 Bug 1798212 - Convert consumers of downloads code to ES modules. r=mak,geckoview-reviewers,extension-reviewers,settings-reviewers,credential-management-reviewers,sgalich,mconley,m_kato
Differential Revision: https://phabricator.services.mozilla.com/D161013
2022-11-07 17:56:10 +00:00
James Teow
cc3a7abd51 Bug 1779470 - Part 2: Add show search terms in url bar feature to about:preferences#search - r=adw,flod
See https://www.figma.com/file/Ock0cYjzi7I1GmcctqOr9K/Search-settings-updates?node-id=2%3A112 for mockup.

Depends on D159462

Differential Revision: https://phabricator.services.mozilla.com/D155866
2022-11-05 02:13:29 +00:00
Paul Zuehlcke
5dff2bab6e Bug 1796397 - Remove privacy_segmentation.status telemetry. r=bvandersloot,settings-reviewers,mconley
Differential Revision: https://phabricator.services.mozilla.com/D161131
2022-11-03 19:45:13 +00:00
William Durand
12a393c465 Bug 1797050 - Part 6 - Use browser_specific_settings instead of applications in test manifests. r=rpl,perftest-reviewers,sparky
We want to encourage extension developers to use `browser_specific_settings` instead of `applications`, which will be unsupported in Manifest Version 3+. This patch makes sure test manifests in m-c won't cause any issues in the future.

Depends on D160541

Differential Revision: https://phabricator.services.mozilla.com/D160668
2022-11-03 16:23:03 +00:00
Drew Willcoxon
209873a1d6 Bug 1798595 - Refactor quick suggest [Part 4]: Move help URL from UrlbarProviderQuickSuggest to QuickSuggest and change how the test utils are initialized. r=daisuke
This moves the help URL const out of UrlbarProviderQuickSuggest in order to make
UrlbarProviderQuickSuggest focused on being a urlbar provider.

It also changes how QuickSuggestTestUtils is initialized to be more similar to
MerinoTestUtils. There's no need for a separate `init()` method when the
constructor will do. I'd like to make this change in a different revision but I
did it here because I want to include all changes to about:preferences in one
revision for easier review.

Please see bug 1798595 for details.

Depends on D160984

Differential Revision: https://phabricator.services.mozilla.com/D160985
2022-11-02 06:50:14 +00:00
Neil Deakin
6cc6947dde Bug 1676492, show the bookmarks toolbar when a new window is opened when the preference is set to show a blank page, r=Mardak,settings-reviewers
w

Differential Revision: https://phabricator.services.mozilla.com/D155003
2022-11-01 20:43:02 +00:00
Mark Banner
0008510845 Bug 1798018 - Convert consumers of toolkit/modules/tests to import ES modules direct. r=Gijs,webdriver-reviewers,extension-reviewers,settings-reviewers,credential-management-reviewers,sgalich
Differential Revision: https://phabricator.services.mozilla.com/D160664
2022-11-01 13:26:38 +00:00
William Durand
646444ad1e Bug 1797050 - Part 4 - Use browser_specific_settings instead of applications in remaining tests. r=rpl,application-update-reviewers,bytesized
Differential Revision: https://phabricator.services.mozilla.com/D160060
2022-10-28 09:53:10 +00:00
Joel Maher
7ba743bfbb Bug 1797751 - carry over skip-if conditions from win10 to win11. r=bxbrenden,necko-reviewers,settings-reviewers,credential-management-reviewers,valentin,sgalich
Differential Revision: https://phabricator.services.mozilla.com/D160529
2022-10-28 00:00:40 +00:00
Mark Banner
452d7aa6a7 Bug 1797689 - Clean up strict violations in browser/ r=mossop,settings-reviewers
Depends on D160490

Differential Revision: https://phabricator.services.mozilla.com/D160491
2022-10-27 15:58:25 +00:00
Sandor Molnar
9fbee3a9f1 Backed out changeset 53ce60b1b515 (bug 1797050) for causing bc failures in browser/components/preferences/tests/browser_extension_controlled.js CLOSED TREE 2022-10-26 15:01:23 +03:00
William Durand
00c4a3becb Bug 1797050 - Part 4 - Use browser_specific_settings instead of applications in remaining tests. r=rpl,application-update-reviewers,bytesized
Differential Revision: https://phabricator.services.mozilla.com/D160060
2022-10-26 11:15:12 +00:00
Mark Banner
433fff5bca Bug 1795322 - Update toolkit modules references in browser/ code. r=mossop,Gijs,preferences-reviewers,desktop-theme-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D160031
2022-10-26 08:06:35 +00:00
Csoregi Natalia
5edbe31601 Backed out 12 changesets (bug 1795322) for causing multiple failures e.g. test_deletion_request_ping.py. CLOSED TREE
Backed out changeset aba25cbcda51 (bug 1795322)
Backed out changeset a4a35005ada9 (bug 1795322)
Backed out changeset 8e8d790eb0f4 (bug 1795322)
Backed out changeset db8903454bd3 (bug 1795322)
Backed out changeset 60cc71c61cad (bug 1795322)
Backed out changeset bc6a674994ad (bug 1795322)
Backed out changeset 6ac8a611f8c7 (bug 1795322)
Backed out changeset 9fb873ecfb31 (bug 1795322)
Backed out changeset c8a7a40c2a2f (bug 1795322)
Backed out changeset f2c118b6c6ce (bug 1795322)
Backed out changeset 38df43b4a70f (bug 1795322)
Backed out changeset 89aea8373411 (bug 1795322)
2022-10-25 23:47:58 +03:00
Mark Banner
6bff0ab996 Bug 1795322 - Update toolkit modules references in browser/ code. r=mossop,Gijs,preferences-reviewers,desktop-theme-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D160031
2022-10-25 19:49:26 +00:00
Mike Conley
38730598bb Bug 1795188 - Migrate all uriloader/exthandler JSMs to ESMs. r=kpatenio
Differential Revision: https://phabricator.services.mozilla.com/D159345
2022-10-19 18:34:02 +00:00
Mark Banner
5407bdffa8 Bug 1792341 - Migrate more toolkit/modules consumers to use direct ES module import. r=Gijs,webdriver-reviewers,perftest-reviewers,necko-reviewers,geckoview-reviewers,preferences-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,sgalich,owlish,bytesized,AlexandruIonescu,whimboo,mconley,mixedpuppy
Mainly automated changes. Some manual ESLint fixes and whitespace cleanup.

Differential Revision: https://phabricator.services.mozilla.com/D158452
2022-10-18 11:21:26 +00:00
Shane Hughes
f356408a0a Bug 1793078 - Explicitly set early beta linked quick actions prefs in tests. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D158428
2022-10-10 10:36:04 +00:00
Mark Banner
a49b8ef78f Bug 1792365 - Convert toolkit/modules consumers to use ES module imports directly. r=webdriver-reviewers,perftest-reviewers,geckoview-reviewers,extension-reviewers,preferences-reviewers,desktop-theme-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,robwu,Gijs,sgalich,bytesized,AlexandruIonescu,dao,m_kato
Differential Revision: https://phabricator.services.mozilla.com/D158094
2022-09-29 06:52:34 +00:00
Mark Banner
c34ea601d2 Bug 1634555 - Send event telemetry for search default engine changes. r=daleharvey
Differential Revision: https://phabricator.services.mozilla.com/D157471
2022-09-28 09:40:36 +00:00
Emilio Cobos Álvarez
4ab80589c9 Bug 1689816 - Implement <tabpanels> and <deck> without XUL layout. r=Gijs,Jamie,morgan,preferences-reviewers,mconley,TYLin
Gijs for front-end bits, layout for the new CSS properties and the
removal of nsDeckFrame / nsStackLayout, Jamie and Morgan for the a11y
changes.

As discussed in the bug, the main tricky part here is handling a11y
correctly. For <deck>, that's trivial (just use `visibility: hidden` to
hide the panels visually, while removing the unselected panels from the
a11y tree).

For <tabpanels> however we need to do something special. We do want to
hide stuff visually, but we want to preserve the contents in the a11y
tree.

For that, the easiest fix is introducing a new privileged CSS property
(-moz-subtree-hidden-only-visually), which takes care of not painting
the frame, but marks stuff offscreen in the accessibility tree. This is
not intended to be a property used widely.

Other than that, the changes are relatively straight-forward, though
some of the accessible/mac changes I could get a sanity-check on.

Differential Revision: https://phabricator.services.mozilla.com/D157875
2022-09-27 04:18:16 +00:00
Marian-Vasile Laza
338fc0a451 Backed out changeset 2f74f8f2ed19 (bug 1689816) for causing reftest failures on skip-ink-multiline-position.html. 2022-09-26 23:24:03 +03:00
Emilio Cobos Álvarez
ba878e30c1 Bug 1689816 - Implement <tabpanels> and <deck> without XUL layout. r=Gijs,Jamie,morgan,preferences-reviewers,mconley,TYLin
Gijs for front-end bits, layout for the new CSS properties and the
removal of nsDeckFrame / nsStackLayout, Jamie and Morgan for the a11y
changes.

As discussed in the bug, the main tricky part here is handling a11y
correctly. For <deck>, that's trivial (just use `visibility: hidden` to
hide the panels visually, while removing the unselected panels from the
a11y tree).

For <tabpanels> however we need to do something special. We do want to
hide stuff visually, but we want to preserve the contents in the a11y
tree.

For that, the easiest fix is introducing a new privileged CSS property
(-moz-subtree-hidden-only-visually), which takes care of not painting
the frame, but marks stuff offscreen in the accessibility tree. This is
not intended to be a property used widely.

Other than that, the changes are relatively straight-forward, though
some of the accessible/mac changes I could get a sanity-check on.

Differential Revision: https://phabricator.services.mozilla.com/D157875
2022-09-26 17:40:30 +00:00
Mathew Hodson
f84488ba91 Bug 1776578 - Replace init tasks with add_setup in mochitests. r=application-update-reviewers,Standard8
Differential Revision: https://phabricator.services.mozilla.com/D149486
2022-09-26 13:58:49 +00:00
Jonathan Sudiaman
febfadf50b Bug 1790758 - Convert Region.jsm and IgnoreLists.jsm JSM modules to ESMs r=Standard8,preferences-reviewers,credential-management-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D157337
2022-09-20 12:21:45 +00:00
Francesco Lodolo (:flod)
16a2555acd Bug 1692653 - Fall back to locale code without region when resolving language names in Accept-Languages, r=Gijs,preferences-reviewers
If a locale code with region (e.g. it-IT) is not defined in language.properties, we display an empty language name.
In this dialog, we can still show a language name if it matches a known locale code without the region (e.g. it).

Differential Revision: https://phabricator.services.mozilla.com/D157113
2022-09-12 13:02:25 +00:00
Andreea Pavel
a39ad691e0 Bug 1775910 - update disabling condition to include mac r=intermittent-reviewers,preferences-reviewers,MasterWayZ DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D156502
2022-09-12 11:10:57 +00:00
Mike Conley
ae11f3c9d0 Bug 1785282 - Open 'Choose what to sync' dialog when users click 'Turn sync on in settings' in Firefox View. r=sclements
Differential Revision: https://phabricator.services.mozilla.com/D156578
2022-09-09 14:26:50 +00:00
Mark Banner
73631b4520 Bug 1789254 - Migrate enterprisepolicies consumers to use ESM imports directly. r=mkaply,necko-reviewers,application-update-reviewers,nalexander
Differential Revision: https://phabricator.services.mozilla.com/D156464
2022-09-08 14:40:07 +00:00
Norisz Fay
6008f8d423 Backed out 3 changesets (bug 1789254) for causing bc failures on browser_xpcom_graph_wait.js CLOSED TREE
Backed out changeset bea1e1ba4a14 (bug 1789254)
Backed out changeset 4086aaa5f3d0 (bug 1789254)
Backed out changeset 131cac1d1146 (bug 1789254)
2022-09-08 17:14:00 +03:00
Mark Banner
e8c3c1e5b4 Bug 1789254 - Migrate enterprisepolicies consumers to use ESM imports directly. r=mkaply,necko-reviewers,application-update-reviewers,nalexander
Differential Revision: https://phabricator.services.mozilla.com/D156464
2022-09-08 12:43:32 +00:00
Paul Zuehlcke
adc21c4e40 Bug 1788697 - Rename browser.privacySegmentation.enabled pref. r=pdahiya,timhuang,preferences-reviewers,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D156194
2022-09-02 10:46:46 +00:00
Butkovits Atila
8594347f5a Backed out 2 changesets (bug 1676492) for causing failures at test_navigation.py. CLOSED TREE
Backed out changeset 09fd88048f35 (bug 1676492)
Backed out changeset bc76e6966ec9 (bug 1676492)
2022-08-30 20:56:51 +03:00
Neil Deakin
7f8f002700 Bug 1676492, show the bookmarks toolbar when a new window is opened when the preference is set to show a blank page, r=Mardak,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D155003
2022-08-30 14:02:02 +00:00
Mark Banner
24d0fe0f57 Bug 1786899 - Remove unused BrowserSearch.loadAddEngines and remove formatURL. r=jteow,preferences-reviewers
formatURL is only used in one other place - nsContextMenu.js, so we don't really need that when we can call the necessary function direct.

Also moves `searchEnginesURL` into SearchUIUtils, as that seems a reasonable place to start storing things like that.

Differential Revision: https://phabricator.services.mozilla.com/D155496
2022-08-26 07:55:44 +00:00
Paul Zuehlcke
dc5a54f3fd Bug 1752172 - Updated privacy segmentation preferences section for final UX. r=preferences-reviewers,fluent-reviewers,flod,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D155013
2022-08-25 11:17:38 +00:00
Dale Harvey
a599b2e8c6 Bug 1783452 - Add section in preferences to enable/disable QuickActions. r=adw,fluent-reviewers,preferences-reviewers,flod,mstriemer
Differential Revision: https://phabricator.services.mozilla.com/D154795
2022-08-17 22:47:54 +00:00
Dão Gottwald
a4c5f3de37 Bug 1784488 - Fix up SubDialog sizing with em values. r=pbz
Differential Revision: https://phabricator.services.mozilla.com/D154646
2022-08-15 21:33:36 +00:00
Barret Rennie
154dcafbb4 Bug 1776303 - Port osfile.jsm usage to IOUtils in browser/components/preferences r=Gijs,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D150202
2022-08-04 03:53:05 +00:00
Mark Banner
1e3410cbdd Bug 1782008 - Remove now unnecessary .eslintrc.js files. r=webcompat-reviewers,extension-reviewers,media-playback-reviewers,pip-reviewers,denschub,rpl,alwu,mossop
Differential Revision: https://phabricator.services.mozilla.com/D152736
2022-08-03 11:16:20 +00:00
Paul Zuehlcke
3d1cb51da2 Bug 1781982 - Remove privacy.dfpi_rollout_enabledByDefault scalar. r=anti-tracking-reviewers,timhuang
Differential Revision: https://phabricator.services.mozilla.com/D153343
2022-08-01 13:40:41 +00:00
Mark Banner
cd9bed2e7a Bug 1780017 - Migrate urlbar consumers to use ESM imports directly. r=adw,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D152057
2022-07-26 15:11:30 +00:00