Commit Graph

662 Commits

Author SHA1 Message Date
Karandeep
d41e533454 Bug 1852045 - Hide the "Show search suggestions in address bar results" checkbox when the search bar isn't in the toolbar. r=dao,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D192571
2023-12-05 11:04:39 +00:00
Michael Hughes
5ea9a03802 Bug 1863980 - [msix] Make ShellService.setDefaultBrowser async. r=nalexander,mconley,dmose,omc-reviewers
This commit includes the changes to call into the new asynchronous code to set the browser as default, using powershell.

While here, we add more logging to this interaction to allow easier
debugging with QA.

Differential Revision: https://phabricator.services.mozilla.com/D194949
2023-12-01 20:07:08 +00:00
Cosmin Sabou
e276c6b6b9 Backed out 2 changesets (bug 1801954, bug 1863980) for bc failures on browser_setDefaultBrowser.js. CLOSED TREE
Backed out changeset b96506a6d950 (bug 1801954)
Backed out changeset 306a649fcc00 (bug 1863980)
2023-12-01 02:34:26 +02:00
Michael Hughes
9cc9c079f5 Bug 1863980 - [msix] Make ShellService.setDefaultBrowser async. r=nalexander,mconley,dmose,omc-reviewers
This commit includes the changes to call into the new asynchronous code to set the browser as default, using powershell.

While here, we add more logging to this interaction to allow easier
debugging with QA.

Differential Revision: https://phabricator.services.mozilla.com/D194949
2023-11-30 22:22:16 +00:00
Karandeep
ce4416a490 Bug 1852044 - Remove the Search Bar section. r=dao,fluent-reviewers,desktop-theme-reviewers,bolsson,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D192722
2023-11-21 05:09:08 +00:00
Karandeep
499e1c4a7e Bug 1852046 - Convert "Suggestions from the web" and "Suggestions from sponsors" toggles to checkboxes on privacy prefs page r=dao,fluent-reviewers,desktop-theme-reviewers,hjones,bolsson
Differential Revision: https://phabricator.services.mozilla.com/D191641
2023-11-16 07:19:42 +00:00
Natalia Csoregi
ab3b33ee93 Backed out changeset 555c786396f8 (bug 1852046) as requested. CLOSED TREE 2023-11-09 20:53:42 +02:00
Karandeep
e2ba36560e Bug 1852042 - Move checkbox from search bar section to the default search engine section in search pref page. r=dao,desktop-theme-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D191978
2023-11-01 11:21:14 +00:00
Karandeep
9ec67c7d3d Bug 1852046 - Convert all toggles to checkboxes on privacy prefs page r=dao,fluent-reviewers,desktop-theme-reviewers,hjones,bolsson
Differential Revision: https://phabricator.services.mozilla.com/D191641
2023-10-25 15:30:14 +00:00
Emilio Cobos Álvarez
8024655b1a Bug 1860346 - Fix browser_permissions_dialog.js.
MANUAL PUSH: Trivial orange fix CLOSED TREE
2023-10-25 14:13:14 +02:00
Nipun Shukla
59a0285adf Bug 1858223 - Disable Firefox launch on login when no starting profile is set r=nalexander,settings-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D190613
2023-10-18 01:37:26 +00:00
Cristian Tuns
4db9c28d5a Backed out changeset 71746bb87230 (bug 1858223) for causing marionette in test_no_errors_clean_profile.py CLOSED TREE 2023-10-17 13:42:36 -04:00
Nipun Shukla
5a10da6487 Bug 1858223 - Disable Firefox launch on login when no starting profile is set r=nalexander,settings-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D190613
2023-10-17 14:21:58 +00:00
Mike Conley
3c473874e4 Bug 1855280 - Remove the ability to switch to the old migration wizard. r=kpatenio,omc-reviewers,settings-reviewers,credential-management-reviewers,negin,aminomancer,mtigley
This removes the pref to re-enable the legacy wizard, and all of the things that used
to read from it.

It also disables the ability to use the legacy wizard from about:welcome with the
aboutWelcomeBehavior feature.

It also removes the closeMigrationWizard utility from BrowserTestUtils, since that
effectively became a thin-wrapper around BrowserTestUtils.removeTab.

Finally, this patch also removes some documentation about the legacy migration wizard,
and tests that specifically check the legacy dialog behaviour.

Differential Revision: https://phabricator.services.mozilla.com/D190716
2023-10-16 18:24:42 +00:00
DJ
d9ef55d8a5 Bug 1857968 - adjust cookiebanner prefs for PBM-only behavior. r=pbz,fluent-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D190493
2023-10-14 17:14:32 +00:00
Noemi Erli
b9d80ca968 Backed out changeset 0bffbf41279d (bug 1857968) for causing failures in browser_search_subdialogs_within_preferences_site_data.js 2023-10-13 00:22:48 +03:00
DJ
6358e1abb9 Bug 1857968 - adjust cookiebanner prefs for PBM-only behavior. r=pbz,fluent-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D190493
2023-10-12 18:20:33 +00:00
Dave Townsend
153dc47e7f Bug 1857999: SubDialog should insert stylesheets as link elements. r=Gijs,settings-reviewers
Attempt to find other link elements in the document and insert the injected
stylesheets after those. Strictly speaking we could probably just insert them
at the end of the document but this at least keeps them together with other
link elements to aid in inspecting. Falls back to using the XML processing
instruction in hte unlikely case that no other link elements are present.

Differential Revision: https://phabricator.services.mozilla.com/D190679
2023-10-12 09:44:11 +00:00
Drew Willcoxon
234916db20 Bug 1857391 - Remove Firefox Suggest "best match" as its own separate feature. r=daisuke,settings-reviewers
This removes "best match" as its own separate Firefox Suggest feature. In the
future, whether or not a suggestion is a best match (a.k.a. top pick) will be
determined by relevant product requirements. I've confirmed this with Nive.

Here's a summary of changes:

* Removes prefs and Nimbus variables related to best match
* Removes the "Top pick" checkbox in about:preferences
* Removes support for the `best_match` quick suggest config property. This
  property was removed from the config in remote settings a while ago.
* Removes legacy telemetry scalars related to best match. These scalars were
  added years ago for the original best match experiment and before we started
  using Glean. In the case of non-sponsored suggestions, the scalars have not
  been recorded at all for some time. In the case of sponsored suggestions, they
  can now be recorded again due to the recent addition of sponsored priority
  suggestions, but they are superseded by Glean.

Differential Revision: https://phabricator.services.mozilla.com/D190516
2023-10-11 17:17:06 +00:00
Anna Yeddi
ad33444b2e Bug 1854636 - Temporarily fail-if some Tier 2 a11y_checks for Settings UI. r=Jamie,Gijs,settings-reviewers
We are working on [enabling Tier 2 a11y-checks to ensure our products have basic accessibility built-in (bug 1692110)](https://bugzilla.mozilla.org/show_bug.cgi?id=1692110) and before that, we need to prepare the existing code base. While we triage and investigate existent tests that would fail once the a11y-checks are enabled in the CI, we are going to fail-if the failing tests altogether and then handle each one of them individually.

This task is to add `fail-if` condition of the failing tests while we continue investigation into the reasons these tests failed and to be able to backtrack these tests once they're resolved.

Related bugs:
- Disabling tests: meta bug 1848402
- Investigation and remediation for components with disabled tests: meta bugs 1848394 and 1854227, Settings UI-specific meta bug 1854637
- Explore capturing click events for a11y_checks: bug 1692110

Depends on D188990

Differential Revision: https://phabricator.services.mozilla.com/D188991
2023-10-09 18:20:21 +00:00
Cristian Tuns
896197e59e Backed out 30 changesets (bug 1854447, bug 1855491, bug 1854646, bug 1854520, bug 1854528, bug 1854506, bug 1854502, bug 1854443, bug 1854538, bug 1854525, bug 1854660, bug 1854514, bug 1854460, bug 1854625, bug 1854228, bug 1854517, bug 1854533, bug 1692110, bug 1854636, bug 1849021, bug 1854512, bug 1854522, bug 1854509, bug 1854452, bug 1854536, bug 1854531) for causing multiple tier 2 failures on a11y-checks. CLOSED TREE
Backed out changeset 5714b7239b70 (bug 1849021)
Backed out changeset 91e5d7de3484 (bug 1849021)
Backed out changeset cc3142b909f6 (bug 1854660)
Backed out changeset 76d2a8ae9c19 (bug 1854646)
Backed out changeset 36460a147684 (bug 1854636)
Backed out changeset c7529a962a8c (bug 1854625)
Backed out changeset 791f9b03ea96 (bug 1854538)
Backed out changeset bd3f3cb434a5 (bug 1854536)
Backed out changeset 16f4f5bdcaa7 (bug 1855491)
Backed out changeset 6258bab20196 (bug 1854533)
Backed out changeset 29dca16eee2e (bug 1854531)
Backed out changeset 3a69d2c3f562 (bug 1854528)
Backed out changeset 0c63a9ea8b34 (bug 1854525)
Backed out changeset 5795bb6187a5 (bug 1854522)
Backed out changeset 7d4a123a432f (bug 1854520)
Backed out changeset ec95287bd702 (bug 1854517)
Backed out changeset 9914c1481f0d (bug 1854514)
Backed out changeset 25d85e656905 (bug 1854512)
Backed out changeset 828657f2ab73 (bug 1854509)
Backed out changeset 9d8b2e14c375 (bug 1854506)
Backed out changeset 1b3ee1e46e12 (bug 1854502)
Backed out changeset 37c2ec0851dc (bug 1854460)
Backed out changeset c2a60a8fc2d3 (bug 1854452)
Backed out changeset 744a163f2bd1 (bug 1854447)
Backed out changeset 1a9629dae7d5 (bug 1854443)
Backed out changeset c3d5c1ba2a84 (bug 1854228)
Backed out changeset dcd05518b004 (bug 1692110)
Backed out changeset 1c65a4cb618c (bug 1692110)
Backed out changeset 603b891147bd (bug 1692110)
Backed out changeset 53e2fac79d84 (bug 1692110)
2023-10-07 14:43:05 -04:00
Anna Yeddi
9e15580be8 Bug 1854636 - Temporarily disable some Tier 2 a11y_checks for Settings UI. r=Jamie,Gijs,settings-reviewers
We are working on [enabling Tier 2 a11y-checks to ensure our products have basic accessibility built-in (bug 1692110)](https://bugzilla.mozilla.org/show_bug.cgi?id=1692110) and before that, we need to prepare the existing code base. While we triage and investigate existent tests that would fail once the a11y-checks are enabled in the CI, we are going to skip the failing tests altogether and then handle each one of them individually.

This task is to skip with `fail-if` condition of the failing tests while we continue investigation into the reasons these tests failed and to be able to backtrack these tests once they're resolved.

Related bugs:
- Disabling tests: meta bug 1848402
- Investigation and remediation for components with disabled tests: meta bugs 1848394 and 1854227, Settings UI-specific meta bug 1854637
- Explore capturing click events for a11y_checks: bug 1692110

Differential Revision: https://phabricator.services.mozilla.com/D188991
2023-10-06 18:11:39 +00:00
Nipun Shukla
f6d280a4d2 Bug 1843202 - Added Nimbus experiment to Windows autostart on login r=nalexander,mconley
Depends on D183504

Differential Revision: https://phabricator.services.mozilla.com/D184437
2023-10-06 15:30:23 +00:00
Nipun Shukla
2b8001fe0a Bug 1843202 - Added automatic launch on Windows login based on registry key r=nalexander,settings-reviewers,flod,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D183504
2023-10-06 15:30:23 +00:00
Jan Varga
ad471d5a69 Bug 1733107 - Replace some nsIQuotaManagerService::ClearStoragesForPrincipal calls with nsIQuotaManagerService::ClearStoragesForOriginPrefix; r=dom-storage-reviewers,pbz,asuth
There's now a dedicated nsIQuotaManagerService::ClearStoragesForOriginPrefix
method for clearing storages for origin prefix. All callers of
nsIQuotaManagerService::ClearStoragesForPrincipal which want to clear all
storages for given origin prefix can be now converted to call the new method.

Changed done in this patch:
- replaced some nsIQuotaManagerService::ClearStoragesForPrincipal calls with
  nsIQuotaManagerService::ClearStoragesForOriginPrefix

Differential Revision: https://phabricator.services.mozilla.com/D186778
2023-09-25 16:28:38 +00:00
Tom Marble
ad50861ef9 Bug 1853243 - convert .ini manifests to .toml: batch 5 browser/**/browser.ini r=jmaher,mossop,webcompat-reviewers,twisniewski,search-reviewers,Standard8
Differential Revision: https://phabricator.services.mozilla.com/D188427
2023-09-21 22:47:07 +00:00
Paul Zuehlcke
2bfd7c338f Bug 1839918 - Update tests for nsICookieNotification. r=cookie-reviewers,sessionstore-reviewers,bvandersloot,valentin
Depends on D185301

Differential Revision: https://phabricator.services.mozilla.com/D185302
2023-09-18 11:55:09 +00:00
Emilio Cobos Álvarez
4eb43ef123 Bug 1853323 - Remove browser.underline_anchors. r=settings-reviewers,mconley
This is weirdly placed in the colors dialog, and adds a global selector
to the UA sheet for no great reason.

This sub-setting doesn't really make a lot of sense. We don't let you
force underlines in any way, so any site CSS will override it (unlike
colors, where you can actually override the site).

Just move this to the UA sheet properly.

Differential Revision: https://phabricator.services.mozilla.com/D188326
2023-09-15 15:37:15 +00:00
Marco Bonardo
6874dffc71 Bug 1852963 - Rename BrowserTestUtils.loadURIString() to .startLoadingURIString(). r=dao
This should make a bit clearer that it is only starting the load, not waiting
for its completion.

Differential Revision: https://phabricator.services.mozilla.com/D188213
2023-09-15 09:16:34 +00:00
Tim Huang
66e67a5beb Bug 1841116 - Add a RFP warning banner in about:preferences#privacy page. r=pbz,fluent-reviewers,settings-reviewers,mconley,flod
This patch adds a RFP warning banner shown when there is a RFP pref
enabled. Firefox has two prefs for RFP, one for normal windows and
another for private windows.

The warning banner contains a learn more linke for users to learn more
about the warning.

Differential Revision: https://phabricator.services.mozilla.com/D187451
2023-09-14 19:18:15 +00:00
Sandor Molnar
5d8dd001ad Backed out 3 changesets (bug 1852963) for causing remote failures on remote/shared/messagehandler/test/browser/browser_session_data.js CLOSED TREE
Backed out changeset 98de7bc404c3 (bug 1852963)
Backed out changeset edf1527c9a99 (bug 1852963)
Backed out changeset 34357750f69c (bug 1852963)
2023-09-14 20:29:06 +03:00
Marco Bonardo
c5fb3dbb49 Bug 1852963 - Rename BrowserTestUtils.loadURIString() to .startLoadingURIString(). r=dao
This should make a bit clearer that it is only starting the load, not waiting
for its completion.

Differential Revision: https://phabricator.services.mozilla.com/D188213
2023-09-14 16:33:13 +00:00
Cosmin Sabou
ba8a89ba9e Backed out 9 changesets (bug 1839918) for causing a top crash as in Bug 1852357. a=backout
Backed out changeset 1c438df525c7 (bug 1839918)
Backed out changeset 6e3d7fdfda3f (bug 1839918)
Backed out changeset 087b27593538 (bug 1839918)
Backed out changeset 302d12c12083 (bug 1839918)
Backed out changeset 750e0796c1ad (bug 1839918)
Backed out changeset 3949d9b400d4 (bug 1839918)
Backed out changeset 707021ebfd23 (bug 1839918)
Backed out changeset fa9a6af80526 (bug 1839918)
Backed out changeset 5aa3b2f1b5ec (bug 1839918)
2023-09-11 16:42:08 +03:00
Tim Huang
e5ec99d984 Bug 1841104 - Add fingerprinting protection to ETP Strict. r=pbz,settings-reviewers,mconley
Differential Revision: https://phabricator.services.mozilla.com/D187383
2023-09-07 12:11:18 +00:00
Paul Zuehlcke
a6d147de42 Bug 1839918 - Update tests for nsICookieNotification. r=cookie-reviewers,sessionstore-reviewers,bvandersloot,valentin
Differential Revision: https://phabricator.services.mozilla.com/D185302
2023-09-07 08:25:55 +00:00
Dale Harvey
aea5f8d8f6 Bug 1851449 - Ensure trending checkbox is disabled correctly. r=Gijs,settings-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D187488
2023-09-06 19:19:20 +00:00
Tim Huang
64095ce047 Bug 1849887 - Fix the perma failure of the browser_contentblocking.js. r=anti-tracking-reviewers,pbz
Differential Revision: https://phabricator.services.mozilla.com/D186784
2023-08-24 13:07:40 +00:00
Benjamin VanderSloot
e2ac7731c2 Bug 1830623, part 3 - Update DNT UI to match GPC UI - r=anti-tracking-reviewers,mconley,timhuang,emilio
Differential Revision: https://phabricator.services.mozilla.com/D184585
2023-08-23 16:52:48 +00:00
Mike Kaply
9960dc5945 Bug 1844615 - Allow relay checkbox to be locked. r=sgalich,settings-reviewers,mconley
Differential Revision: https://phabricator.services.mozilla.com/D186457
2023-08-23 03:22:18 +00:00
Tim Huang
54518f3d80 Bug 1841097 - Add telemetry for the fingerprinting protection checkbox and prefs. r=chutten,anti-tracking-reviewers,settings-reviewers,mstriemer,bvandersloot
This patch adds an event telemetry for fingerprinting protection
checkbox and fingerprinting protection prefs into the telemetry environment prefs.

Differential Revision: https://phabricator.services.mozilla.com/D186024
2023-08-22 12:38:00 +00:00
Tim Huang
58ee6ef3cc Bug 1841097 - Implement a checkbox in ETP Custom subpanel for the configuration of the fingerprinting protection. r=anti-tracking-reviewers,fluent-reviewers,flod,bvandersloot,mstriemer
This patch implements a checkbox in ETP Custom usbpanel. It's for the
configuration of the fingerprinting protection. Similar to the tracking
protection checkbox, it has a dropdown list to select which window to
enable the protection, private windows or all windows.

In addition, we update the existing copy for fingerprinters to reflect
the newly added fingerprinting protectoin checkbox.

Differential Revision: https://phabricator.services.mozilla.com/D186023
2023-08-22 12:38:00 +00:00
Narcis Beleuzu
cd73fe3888 Backed out 3 changesets (bug 1830623) for mochitest failures on test_navigator.html . CLOSED TREE
Backed out changeset e62ba02af50f (bug 1830623)
Backed out changeset 2667feba3922 (bug 1830623)
Backed out changeset 320a740f003c (bug 1830623)
2023-08-18 03:44:07 +03:00
Benjamin VanderSloot
492abaf933 Bug 1830623, part 3 - Update DNT UI to match GPC UI - r=anti-tracking-reviewers,mconley,timhuang,emilio
Differential Revision: https://phabricator.services.mozilla.com/D184585
2023-08-17 23:20:16 +00:00
Iulian Moraru
cc8a2dab6f Backed out 3 changesets (bug 1830623) for causing mochitest-plain failures on test_navigator_secureContext.html. CLOSED TREE
Backed out changeset 9ee80b5bdc57 (bug 1830623)
Backed out changeset 669560330b96 (bug 1830623)
Backed out changeset 5d5a5853a04e (bug 1830623)
2023-08-14 18:56:30 +03:00
Benjamin VanderSloot
f8503e1378 Bug 1830623, part 3 - Update DNT UI to match GPC UI - r=anti-tracking-reviewers,mconley,timhuang
Differential Revision: https://phabricator.services.mozilla.com/D184585
2023-08-14 13:56:23 +00:00
Malte Juergens
60c41e84f9 Bug 1844978 - Discard permission dialog inputs which start with a http(s) scheme and can't be turned into a principal r=settings-reviewers,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D184800
2023-08-08 09:12:14 +00:00
Gregory Pappas
a57c4f9405 Bug 1845311 - [Part 2] Use ChromeUtils.defineLazyGetter in more places r=arai,webcompat-reviewers,necko-reviewers,extension-reviewers,settings-reviewers,application-update-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,sync-reviewers,anti-tracking-reviewers,tabbrowser-reviewers,bytesized,twisniewski,sgalich,mak,kershaw,sclements,pbz,robwu,geckoview-reviewers,amejiamarmol
Differential Revision: https://phabricator.services.mozilla.com/D184623
2023-08-01 23:01:02 +00:00
Malte Juergens
36733ae0a2 Bug 1720458: Do not isolate https-only-load-insecure by origin attributes r=fluent-reviewers,settings-reviewers,flod,ckerschb,Gijs
Do not isolate `https-only-load-insecure` by origin attributes. This way the HTTPS-Only exceptions will behave similar to the `cookie` permission. This means that exceptions set in the system settings will also apply to private windows, but exceptions set in private windows via the identity pane will be reset after closing the browser.

Depends on D182761

Differential Revision: https://phabricator.services.mozilla.com/D183745
2023-07-24 13:31:19 +00:00
Malte Juergens
72bf8c2b4e Bug 1757297: Only work with http scheme for HTTPS-Only exceptions r=freddyb,settings-reviewers,Gijs
- Update the HTTPS-Only dropdown in the site identity pane to always set exceptions for the http version of the current origin.
- Add new parameter `forcedHTTP` to `gPermissionManager`, in order to only allow origins with a http scheme to be added in the HTTPS-Only section of the settings. This means when a https URL is added as an exeption, it will automatically be converted into a http one.
- Add a migration to convert all existing HTTPS-Only exceptions with a https scheme to a http scheme.
- Update `browser_https_only_exceptions.js` and `browser_identityPopup_HttpsOnlyMode.js` to account for this new behaviour.

Differential Revision: https://phabricator.services.mozilla.com/D182761
2023-07-24 13:31:19 +00:00
Morgan Rae Reschenberg
03a38d4eac Bug 1628476: Add keyboard navigation pref to allow focus mode changes on macOS r=Jamie,fluent-reviewers,settings-reviewers,flod,mconley
Differential Revision: https://phabricator.services.mozilla.com/D182266
2023-07-17 23:11:41 +00:00