corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
757,788 Commits 1 Branch 0 Tags
0b327f09742f901b4f101935d59abc362b00acb9
Commit Graph

1027 Commits

Author SHA1 Message Date
Meg Viar
1a6506744f Bug 1784138 - Show the correct number of steps in the Feature Callout step indicator r=Mardak 
Differential Revision: https://phabricator.services.mozilla.com/D154301
 2022-08-12 17:24:49 +00:00
Cosmin Sabou
911e8b9969 Backed out changeset 0306b5b024ee (bug 1781084) bc failures on browser_feature_callout.js. 2022-08-12 16:50:42 +03:00
Meg Viar
1a64511fc4 Bug 1781084 - Add CSS transitions when moving Feature Callout from one element to the next r=Mardak 
Differential Revision: https://phabricator.services.mozilla.com/D154275
 2022-08-12 11:02:30 +00:00
Meg Viar
b6de2b22f9 Bug 1758506 - Enable configuration of dark mode graphics in AboutWelcome r=Mardak 
Differential Revision: https://phabricator.services.mozilla.com/D153758
 2022-08-11 13:32:48 +00:00
Norisz Fay
1b3d7354e1 Backed out changeset a0344c152f07 (bug 1781429) for causing node newtab failures on _feature-callout.scss CLOSED TREE 2022-08-11 02:40:30 +03:00
Jason Prickett
d7d107a9fa Bug 1781429 - Add arrow pointer to Feature Callout surface r=mviar 
Differential Revision: https://phabricator.services.mozilla.com/D154173
 2022-08-10 23:02:14 +00:00
Norisz Fay
5e2d4a718d Backed out changeset 8048378aaae9 (bug 1781084) for causing node newtab failures on _feature-callout.scss CLOSED TREE 2022-08-11 00:45:35 +03:00
Meg Viar
a4e829df02 Bug 1781084 - Add CSS transitions when moving Feature Callout from one element to the next r=Mardak 
Differential Revision: https://phabricator.services.mozilla.com/D154275
 2022-08-10 20:54:08 +00:00
Jason Prickett
e348f90055 Bug 1774067 - Adding about welcome mobile download screen in MR onboarding. r=pdahiya,mviar 
Differential Revision: https://phabricator.services.mozilla.com/D152295
 2022-08-10 18:16:53 +00:00
Meg Viar
906aa8e0c5 Bug 1779480 - Sync the UI feature tour callout state across instances of Firefox View r=Mardak 
Differential Revision: https://phabricator.services.mozilla.com/D153497
 2022-08-10 11:35:34 +00:00
Punam Dahiya
8d176b3894 Bug 1774066 - Add colorways screen in MR onboarding r=mviar 
Differential Revision: https://phabricator.services.mozilla.com/D153223
 2022-08-09 15:41:45 +00:00
scott
854c0a9536 Bug 1782319 - Pocket newtab fix issue if recent saves is paired with save to Pocket card r=gvn 
Differential Revision: https://phabricator.services.mozilla.com/D153292
 2022-08-04 21:35:39 +00:00
Meg Viar
1717fd75c8 Bug 1779024 - Create Feature Callout message surface using aboutwelcome r=pdahiya,Gijs,Mardak 
Differential Revision: https://phabricator.services.mozilla.com/D152449
 2022-08-04 11:47:01 +00:00
Gavin Suntop
c0d548aa47 Bug 1780849 - refactoring pref drawer animation r=thecount 
Differential Revision: https://phabricator.services.mozilla.com/D152793
 2022-08-03 17:18:12 +00:00
Barret Rennie
917e4a8282 Bug 1782113 - Add type field to message-group.schema.json r=pdahiya 
The type field is present in the schema in messaging-system-inflight-assets and
all the message group definitions deployed have this field.

While I was here, I simplified the definition of `frequency.custom.period`
since it was using a `oneOf` subschema with a list containing one item.

Differential Revision: https://phabricator.services.mozilla.com/D153118
 2022-08-03 15:35:58 +00:00
Emily McMinn
4e76e0e087 Bug 1778601 - Add SignIn link to MR new user onboarding template r=mviar,pdahiya 
Differential Revision: https://phabricator.services.mozilla.com/D151931
 2022-07-30 01:14:39 +00:00
scott
87bfee2269 Bug 1779636 - Pocket newtab login state to events pings r=nanj 
Differential Revision: https://phabricator.services.mozilla.com/D152121
 2022-07-29 20:46:40 +00:00
Barret Rennie
6d670c7a89 Bug 1782116 - Only support integer periods for frequencies in FxMS messages r=pdahiya 
Bug 1652513 removed support for "daily" periods so we should remove support for
them from the schemas.

Some tests for ASRouter that were testing frequency normalization (that weren't
actually testing it because frequency normalization was removed) have been
removed.

Differential Revision: https://phabricator.services.mozilla.com/D153117
 2022-07-29 04:38:06 +00:00
Meg Viar
0ae81533c1 Bug 1779430 - For Feature Callout telemetry, set 'page' value to current page URL r=pdahiya 
Differential Revision: https://phabricator.services.mozilla.com/D152761
 2022-07-27 17:01:02 +00:00
scott
9528bf357e Bug 1774471 - Pocket newtab refactor dscard props r=gvn 
Differential Revision: https://phabricator.services.mozilla.com/D152599
 2022-07-26 22:51:57 +00:00
negin
b7c6a3dfed Bug 1779625 - Assign appropriate roles to about:welcome step indicator to make it more accessible for screen readers r=emcminn,mviar,flod 
Differential Revision: https://phabricator.services.mozilla.com/D152425
 2022-07-26 20:03:37 +00:00
Butkovits Atila
8d5010e96e Backed out changeset a12870608bdf (bug 1780849) for causing failures at browser_contentSearchUI_default.js. CLOSED TREE 2022-07-26 23:10:06 +03:00
Gavin Suntop
1d5b1fa522 Bug 1780849 - refactoring pref drawer animation r=thecount 
Differential Revision: https://phabricator.services.mozilla.com/D152793
 2022-07-26 19:15:24 +00:00
Butkovits Atila
85598a987f Backed out changeset a8042638bf0a (bug 1779625) for causing failure at browser_aboutwelcome_multistage_primary.js. CLOSED TREE 2022-07-26 22:10:47 +03:00
negin
5dd43e28eb Bug 1779625 - Assign appropriate roles to about:welcome step indicator to make it more accessible for screen readers r=emcminn,mviar,flod 
Differential Revision: https://phabricator.services.mozilla.com/D152425
 2022-07-26 18:28:25 +00:00
Punam Dahiya
b2f2aae83c Bug 1774071 - Existing User MR 2022 onboarding Screens r=mviar 
Differential Revision: https://phabricator.services.mozilla.com/D152221
 2022-07-26 15:35:04 +00:00
Tooru Fujisawa
15758870e7 Bug 1780543 - Part 4: Add mozilla/remote-page environment. r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D152429
 2022-07-26 02:46:30 +00:00
scott
902f2f21c4 Bug 1780832 - Pocket newtab fixing collection and recent saves grid conflict. r=gvn 
Differential Revision: https://phabricator.services.mozilla.com/D152540
 2022-07-22 23:56:53 +00:00
Meg Viar
9eb6f24939 Bug 1780015 - Add targeting for users who prefer reduced motion in AboutWelcome message surfaces r=pdahiya 
Differential Revision: https://phabricator.services.mozilla.com/D152174
 2022-07-22 17:10:26 +00:00
Meg Viar
f894cbcfc5 Bug 1779422 - Make push state updates configurable in aboutWelcome r=pdahiya 
Differential Revision: https://phabricator.services.mozilla.com/D152061
 2022-07-22 17:09:17 +00:00
Csoregi Natalia
52f52b1095 Backed out changeset 1a66d46b4b28 (bug 1779422) for causing fxms failures. CLOSED TREE 2022-07-22 18:39:58 +03:00
Meg Viar
a2828e0a11 Bug 1779422 - Make push state updates configurable in aboutWelcome r=pdahiya 
Differential Revision: https://phabricator.services.mozilla.com/D152061
 2022-07-22 14:34:00 +00:00
Dão Gottwald
e514aabc62 Bug 1780568 - --newtab-element-hover-color needs more contrast, especially on dark backgrounds. r=sclements 
Differential Revision: https://phabricator.services.mozilla.com/D152403
 2022-07-22 13:36:12 +00:00
scott
0bbeca25d3 Bug 1779643 - Pocket newtab remove old border and hero css and options r=gvn 
Differential Revision: https://phabricator.services.mozilla.com/D151872
 2022-07-22 04:31:45 +00:00
Barret Rennie
a8e3bb32ff Bug 1779950 - Keep FxMS test corpus up-to-date for make-schemas.py r=nalexander 
The fxms schema job has been updated with a script that writes out the test
corpus for the test. This means we no longer need to keep these JSON files in
tree, since the test will automatically generate them.

Differential Revision: https://phabricator.services.mozilla.com/D151985
 2022-07-21 00:47:46 +00:00
Barret Rennie
d99b4d74d4 Bug 1779142 - Support generating multiple schemas in make-schemas.py r=nalexander 
Differential Revision: https://phabricator.services.mozilla.com/D151568
 2022-07-21 00:47:45 +00:00
Barret Rennie
6c9a4ed36a Bug 1775187 - Refactor out common elements of FxMS schema r=Mardak 
The following propertie have been refactored out into the top-level message
schema so that they don't have to be repeated in each template's schema:

- `frequency`
- `groups`
- `id`
- `priority`

A definition for the `trigger` property has been added to the common schemas as
`MessageTrigger` so that messages that require triggering can reference this
definition.

Each template schema now requires only its template (as a const value or enum)
and its content, as well as any additional top-level properties that are
message specific (e.g., `order` for `WhatsNewMessage`).

`id`, `content`, and `template` properties are required for all messages.
Individual template schemas do not need to mark `content` and `template` as
required since they are required by the top-level schema. Messages that
require triggering or targeting must define those properties.

Differential Revision: https://phabricator.services.mozilla.com/D150705
 2022-07-21 00:47:45 +00:00
Barret Rennie
e30f98e555 Bug 1779109 - Add a schema for protections_panel template r=Mardak 
Differential Revision: https://phabricator.services.mozilla.com/D151560
 2022-07-21 00:47:44 +00:00
Barret Rennie
8fbde5b119 Bug 1775187 - Refactor out localizableText and localizedText from FxMS schemas r=nalexander,dmose 
Several kinds of FxMS messages support a common pattern of taking either a
string or an object containing a string ID, allowing for both raw strings and
translated string IDs to be used in messages. This patch refactors that pattern
out into a common definition (localizedText and localizableText) in a common
schema which other schemas can then reference.

Our schema bundling script has been updated to bundle these definitions from
the common schema as top-level definitions (and subsequently rewrite the
references from FxMSCOmmon.schema.json to the generated schema) because Nimbus
and Experimenter only support a single schema file per feature.

To ensure compatability with Experimenter, all our in-tree messages have been
extracted into a test corpus that is validated with the Experimenter JSON
Schema validator. A future patch in this series will clean this up so we don't
need to have separate copies of messages in the tree.

We are now also validating all messages from the CFRMessageProvider with our
in-tree JSON Schema validator that Nimbus uses. The OnboardingMessageProvider
and PanelTestProvider tests have also been updated so that all three are using
the same testing infrastructure.

Differential Revision: https://phabricator.services.mozilla.com/D150704
 2022-07-21 00:47:44 +00:00
Nick Alexander
232384a3e0 Bug 1780299 - Add isBackgroundTaskMode and backgroundTaskName to ASRouterTargeting. r=barret 
These will allow targeting Nimbus experiments and Firefox Messaging
System messages only to background tasks.

Differential Revision: https://phabricator.services.mozilla.com/D152289
 2022-07-20 19:15:18 +00:00
Nick Alexander
6e9303448d Bug 1775128 - Add toast_notification message template for displaying (native) toast notifications. r=Mardak 
Differential Revision: https://phabricator.services.mozilla.com/D150073
 2022-07-20 02:58:42 +00:00
scott
acb6544ac6 Bug 1778351 - Removing some old Pocket newtab experiment code. r=gvn 
Differential Revision: https://phabricator.services.mozilla.com/D151666
 2022-07-19 17:32:56 +00:00
Gavin Suntop
22efb6479f Bug 1776768 - fixing option expand collapse animation r=thecount 
Differential Revision: https://phabricator.services.mozilla.com/D152126
 2022-07-18 21:29:05 +00:00
Jason Prickett
e31905c4cb Bug 1779048 - Adding PIN and OTHER as promo types in PbNewTab message schema r=pdahiya,barret 
Differential Revision: https://phabricator.services.mozilla.com/D151664
 2022-07-15 15:52:04 +00:00
negin
9ab72cd40c Bug 1754471 - Remove Whats New Panel from devtools r=emcminn 
Differential Revision: https://phabricator.services.mozilla.com/D151392
 2022-07-13 20:57:04 +00:00
scott
9d63b57239 Bug 1779459 - Pocket newtab update "more topics" link in topics widget r=gvn 
Differential Revision: https://phabricator.services.mozilla.com/D151752
 2022-07-13 18:23:08 +00:00
scott
e21d9b5651 Bug 1779008 - Pocket newtab recent saves section, handle edge cases for certain props on certain stories. r=gvn 
Differential Revision: https://phabricator.services.mozilla.com/D151513
 2022-07-12 20:02:08 +00:00
Barret Rennie
3b75183455 Bug 1776478 - Support empty messages in the FxMS experiment schema r=emcminn 
Differential Revision: https://phabricator.services.mozilla.com/D150691
 2022-07-12 00:27:18 +00:00
Meg Viar
48c38db878 Bug 1777507 - Adjust Multistage Spotlight container style to handle new MR 50-50 template designs r=pdahiya 
Differential Revision: https://phabricator.services.mozilla.com/D151170
 2022-07-11 20:35:52 +00:00
Butkovits Atila
5d193db1cf Backed out changeset 8fe694b12df5 (bug 1776478) as requested by Barret. CLOSED TREE 2022-07-11 23:16:02 +03:00