I'll wait to land this until next week, so that we're not putting in new strings right at the end of Nightly.
I've tested this with MacOS VoiceOver & NVDA on windows and the behaviour is pretty good. VoiceOver will repeat the colorway group & name a few times which is annoying, but it's an existing problem we haven't found a tidy solution for yet.
Differential Revision: https://phabricator.services.mozilla.com/D157369
Add a list of screen initials to the message ID strings sent with
AboutWelcomeTelemetry impression pings. Each screen's message ID will
include a string representing the screen ID of each screen in the
message, in addition to information about the screen itself (for
example, `PLSICMG` represents AW_PIN_FIREFOX, AW_LANGUAGE_MISMATCH,
etc). This will support, for example, comparisons of user engagement
between messages with many screens versus messages with few screens.
Also change the screen ID for one screen that was adjacent to another
screen with the same initial, in order to disambiguate them (since both
screens can potentially be removed, currently).
Differential Revision: https://phabricator.services.mozilla.com/D157581
Remove image_overrides custom replacing the QR code for FOCUS message and instead use a separate message for de locale that also configures the links correctly like the KLAR message.
Differential Revision: https://phabricator.services.mozilla.com/D157518
Fix a bug where a rule for about:welcome was causing the background for
the multistage spotlight dialog to be white in HCM.
Differential Revision: https://phabricator.services.mozilla.com/D157367
Just remove the import of normalize.scss from aboutwelcome.scss, without
removing the file itself. Add styles needed to maintain the current
appearance and remove styles that were only necessary because of
normalize.scss.
Differential Revision: https://phabricator.services.mozilla.com/D157224
Make the dialog frame for Spotlight modal dialogs cover the full window,
prevent the fixed sizing in SubDialog for these dialogs, and vertically
center the dialog relative to its frame. Make the scrollport accommodate
the full Spotlight so it can be scrolled, without wasting any scroll
distance on margins. So, the top margin will shrink with the window,
like the other margins do.
Differential Revision: https://phabricator.services.mozilla.com/D156127
Make the dialog frame for Spotlight modal dialogs cover the full window,
prevent the fixed sizing in SubDialog for these dialogs, and vertically
center the dialog relative to its frame. Make the scrollport accommodate
the full Spotlight so it can be scrolled, without wasting any scroll
distance on margins. So, the top margin will shrink with the window,
like the other margins do.
Differential Revision: https://phabricator.services.mozilla.com/D156127
The secondary CTA in Spotlight and AboutWelcome lacks a rule to set a
hover color (probably because outside of HCM, the hover color should be
the same as the base color). This patch adds the needed styles.
Differential Revision: https://phabricator.services.mozilla.com/D156223
Everything here is Windows-only for now, since that's the immediate
use case and these implementation details are specific to Windows
native notifications relaunching Firefox when it is not running --
functionality not supported by the other system alert backends at this
time.
This commit adds a `launch_url` parameter to `ToastNotification`.
This should be viewed as the simplest possible "action" that a toast
notification can take when it is clicked, namely navigating to the
given URL. In the future, we might generalize this to describe more
of the existing actions (like opening settings, snoozing or dismissing
the toast, etc), but for now, this handles my use case.
In addition, this uses `content.tag` as the alert `name`, allowing to
replace existing toast notifications.
Differential Revision: https://phabricator.services.mozilla.com/D155912
Update About Welcome's invocations of window functions to use optional
chaining to avoid errors when they are undefined. Then, the surfaces
that load the About Welcome bundle will no longer need to define those
references as empty functions.
Differential Revision: https://phabricator.services.mozilla.com/D155011
