corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
757,788 Commits 1 Branch 0 Tags
0b327f09742f901b4f101935d59abc362b00acb9
Commit Graph

1027 Commits

Author SHA1 Message Date
Barret Rennie
c6fa8e2893 Bug 1776478 - Support empty messages in the FxMS experiment schema r=emcminn 
Differential Revision: https://phabricator.services.mozilla.com/D150691
 2022-07-11 19:36:17 +00:00
Barret Rennie
acd1cb8603 Bug 1778422 - Fix secondary buttons in ExtensionDoorhanger.schema.json r=emcminn 
Additionally, the secondary property is actually an array of objects, not an object.

Differential Revision: https://phabricator.services.mozilla.com/D151194
 2022-07-09 01:17:05 +00:00
Barret Rennie
7b181b5725 Bug 1778592 - Fix template uniqueness check in make-schemas.py r=emcminn 
Differential Revision: https://phabricator.services.mozilla.com/D151338
 2022-07-09 01:17:05 +00:00
Barret Rennie
a91de82338 Bug 1778368 - Add Python jsonschema tests for FxMS schema r=dmose 
To ensure that we don't ship a schema that breaks Experimenter, we now have
in-tree tests that validate FxMS messages against our schema using the same
JSON Schema evaluator (python-jsonchema).

Our test corpus is the same as test_PanelTestProvider.js. We cannot have
PanelTestProvider.jsm fetch the messages from the JSON due to fetch() not being
supported in the newtab npm tests.

Differential Revision: https://phabricator.services.mozilla.com/D151169
 2022-07-09 01:17:05 +00:00
scott
abd0669b17 Bug 1776237 - Pocket newtab recent saves hide last item if on last row. r=gvn 
Differential Revision: https://phabricator.services.mozilla.com/D150809
 2022-07-07 01:27:33 +00:00
Meg Viar
5435e7b1c9 Bug 1776686 - Add progress bar style to step indicator for MR new user onboarding r=emcminn 
Differential Revision: https://phabricator.services.mozilla.com/D150399
 2022-07-06 20:05:42 +00:00
Barret Rennie
66549c9869 Bug 1778368 - Patch relative refs into absolute refs in the FxMS mega schema r=dmose 
Differential Revision: https://phabricator.services.mozilla.com/D151159
 2022-07-06 19:54:39 +00:00
Meg Viar
f0d0a750b5 Bug 1774061 - MR new user onboarding to have 50-50 split template r=pdahiya 
Differential Revision: https://phabricator.services.mozilla.com/D150185
 2022-07-06 14:48:57 +00:00
scott
75329af4b9 Bug 1777539 - Pocket newtab remove load more button and last card features r=gvn 
Differential Revision: https://phabricator.services.mozilla.com/D150789
 2022-07-05 19:57:22 +00:00
scott
905f931ec2 Bug 1776202 - Pocket newtab recent saves adding my list link to top right of section r=gvn 
Differential Revision: https://phabricator.services.mozilla.com/D150500
 2022-07-01 16:20:38 +00:00
scott
af929cc0de Bug 1776770 - Pocket newtab recent saves pref work r=gvn 
Differential Revision: https://phabricator.services.mozilla.com/D150579
 2022-06-30 03:29:13 +00:00
Barret Rennie
ad911a3922 Bug 1771073 - Make make-schemas.py executable r=dmose 
Depends on D147332

Differential Revision: https://phabricator.services.mozilla.com/D150398
 2022-06-29 23:01:37 +00:00
Barret Rennie
b3e2605f2b Bug 1771073 - Correct FxMS features and keep them up to date with tests r=dmose,pdahiya 
The Nimbus Features corresponding to FxMS messaging surfaces are actually
intended to map to FxMS message groups, which can accept *any* FxMS message.
The features have been updated with schemas that accept any FxMS message.

As part of this, all FxMS schemas have been updated with an `$id` so that they
can be bundled into feature schemas and have their internal `$ref`s work.
(Otherwise, a `$ref` would be relative to the top-level schema instead of the
sub-schema).

Schemas for individual message types are no longer exposed as resource:// URIs,
except in tests, as indivual schemas are no longer required at runtime.

Additionally, each FxMS schema has had its `template` field become required and
requires a constant value for that schema (e.g., Spotlight requires a template
value of "spotlight").

A test has been added to ensure that if any of the messaging surfaces schemas
change that the feature schemas are also updated. The feature schemas can be
regenerated via:

```
cd ./browser/components/newtab/content-src/asrouter/schemas
../../../../../../mach make-schemas.py
```

Differential Revision: https://phabricator.services.mozilla.com/D147332
 2022-06-29 23:01:37 +00:00
Gavin Suntop
f474ac4942 Bug 1774484 - Add controls for recent article visibility r=thecount,fluent-reviewers,flod 
Differential Revision: https://phabricator.services.mozilla.com/D150165
 2022-06-27 16:08:38 +00:00
scott
309d065815 Bug 1774473 - Pocket newtab recent saves section. r=gvn 
Differential Revision: https://phabricator.services.mozilla.com/D150196
 2022-06-24 20:41:32 +00:00
scott
cc4ab52a2b Bug 1774472 - Pocket newtab split cardgrid into sections. r=gvn 
Differential Revision: https://phabricator.services.mozilla.com/D149700
 2022-06-23 23:49:55 +00:00
Marian-Vasile Laza
c52db672e4 Backed out changeset 4d1df2afaf99 (bug 1774472) for causing newtab failures. 2022-06-23 22:06:41 +03:00
scott
36e61de688 Bug 1774472 - Pocket newtab split cardgrid into sections. r=gvn 
Differential Revision: https://phabricator.services.mozilla.com/D149700
 2022-06-23 18:11:22 +00:00
Meg Viar
4c527f9886 Bug 1772025 - Add targeting for users who have private Firefox browser pinned r=pdahiya,barret 
Differential Revision: https://phabricator.services.mozilla.com/D148446
 2022-06-22 18:30:03 +00:00
Scott
3e691f1733 Bug 1771546 - Pocket newtab colletion/topics card. r=gvn 
Differential Revision: https://phabricator.services.mozilla.com/D147548
 2022-06-10 23:44:31 +00:00
Meg Viar
18b8999d5a Bug 1771899 - Spotlight's fancy/gradient title is not visible when selected if the Dark theme is enabled r=pdahiya 
Differential Revision: https://phabricator.services.mozilla.com/D148435
 2022-06-08 12:28:49 +00:00
Meg Viar
18fbb156c1 Bug 1762189 - Include localized app marketplace Icons in langpacks r=barret,glandium 
Differential Revision: https://phabricator.services.mozilla.com/D143540
 2022-06-07 23:23:33 +00:00
Dão Gottwald
4d7d917a57 Bug 1772364 - Rename monochromatic/ to colorways/. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D148135
 2022-06-03 06:33:14 +00:00
Dão Gottwald
9b95430d59 Bug 1771961 - Align preexisting colorways with new directory structure r=kpatenio 
Differential Revision: https://phabricator.services.mozilla.com/D147784
 2022-06-02 07:51:34 +00:00
Scott
73a592ea16 Bug 1767445 - Pocket newtab topics widget r=gvn 
Differential Revision: https://phabricator.services.mozilla.com/D146327
 2022-05-20 22:04:46 +00:00
Barret Rennie
f86903b198 Bug 1768727 - Make messaging systems more backwards compatible and update schemas to match in-flight messages r=emcminn 
Differential Revision: https://phabricator.services.mozilla.com/D146028
 2022-05-12 21:39:18 +00:00
Punam Dahiya
f8991ed533 Bug 1767618 - Adjust about:welcome background container minimum width r=emcminn 
Differential Revision: https://phabricator.services.mozilla.com/D145811
 2022-05-11 02:06:55 +00:00
Scott
81040cee89 Bug 1767448 - Pocket newtab available screen height and width for card pings. r=nanj 
Differential Revision: https://phabricator.services.mozilla.com/D145334
 2022-05-10 21:03:36 +00:00
manisha27
d5457eeb7d Bug 1765452 - Move and Rename the trending icon. r=desktop-theme-reviewers,sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D144251
 2022-05-09 22:33:03 +00:00
Amy Churchwell
16d64cfeb6 Bug 1767017 - Remove placeholder Colorways section from about:newtab's personalize panel. r=dao 
Differential Revision: https://phabricator.services.mozilla.com/D145680
 2022-05-06 08:02:07 +00:00
Barret Rennie
188cd9ed5c Bug 1767302 - Fix UpdateAction.schema.json, again r=emcminn 
Differential Revision: https://phabricator.services.mozilla.com/D145239
 2022-05-04 01:26:48 +00:00
Barret Rennie
bbdc3c3536 Bug 1767266 - Make ExtensionDoorhanger.schema.json more lenient r=Mardak 
Differential Revision: https://phabricator.services.mozilla.com/D145241
 2022-05-03 16:37:19 +00:00
Scott
010628155f Bug 1764098 - Pocket newtab save to Pocket context menu items don't turn off if Pocket is turned off. r=gvn 
Differential Revision: https://phabricator.services.mozilla.com/D144178
 2022-05-02 19:21:06 +00:00
Meg Viar
b6ce459405 Bug 1765145 - The “Sign in” button is hardly visible if the browser is vertically resized and the “Dark” theme is enabled r=Mardak,emcminn 
Differential Revision: https://phabricator.services.mozilla.com/D144725
 2022-05-02 15:16:21 +00:00
Meg Viar
3cfd9ed1aa Bug 1764626 - Differentiate between about:welcome and Spotlight context when sending event telemetry r=Mardak 
Differential Revision: https://phabricator.services.mozilla.com/D143645
 2022-04-27 15:12:41 +00:00
Norisz Fay
9250bc1d10 Backed out changeset 392ddb43da5b (bug 1764626) for causing bc failures on browser_multistage_spotlight_telemetry.js CLOSED TREE 2022-04-26 23:30:45 +03:00
Meg Viar
de6da2f0b5 Bug 1764626 - Differentiate between about:welcome and Spotlight context when sending event telemetry r=Mardak 
Differential Revision: https://phabricator.services.mozilla.com/D143645
 2022-04-26 19:11:27 +00:00
Barret Rennie
f726644db9 Bug 1766430 - Allow additional properties in Spotlight content r=Mardak 
Differential Revision: https://phabricator.services.mozilla.com/D144722
 2022-04-26 16:22:50 +00:00
Meg Viar
4ca1752455 Bug 1765823 - Clean up use of .corner class in AboutWelcome in favor of [pos] attribute r=pdahiya 
Differential Revision: https://phabricator.services.mozilla.com/D144319
 2022-04-25 21:03:33 +00:00
Barret Rennie
ad38c46862 Bug 1766091 - Fix UpdateAction.schema.json r=emcminn 
Differential Revision: https://phabricator.services.mozilla.com/D144504
 2022-04-25 18:34:03 +00:00
Ed Lee
d2a49d9482 Bug 1766051 - Replace some title styles with more configuration, e.g., font weight, line height, margin r=mviar 
Differential Revision: https://phabricator.services.mozilla.com/D144474
 2022-04-22 21:48:11 +00:00
Arjun Krishna Babu
e391b3f3df Bug 1765456 - Move the cancel icon used by about:newtab to the shared icon library in toolkit/themes/shared/icons r=sfoster,desktop-theme-reviewers 
This was done because the existing cancel icon (browser/components/newtab/data/content/assets/glyph-cancel-16.svg) is a variation of the (/toolkit/themes/shared/icons/close.svg) in the toolkil icon library and it makes sense for the former to live alongside the latter.

Differential Revision: https://phabricator.services.mozilla.com/D144075
 2022-04-22 16:12:42 +00:00
manisha27
3763dc503e Bug 1765459 - Remove glypg-edit-16.svg and use edit.svg. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D144245
 2022-04-22 16:04:50 +00:00
Cosmin Sabou
4f0b39c946 Backed out changeset 252f5225f556 (bug 1764626) for causing bc failures on browser_multistage_spotlight.js. CLOSED TREE 2022-04-22 00:15:02 +03:00
Meg Viar
1310ce21d4 Bug 1764626 - Differentiate between about:welcome and Spotlight context when sending event telemetry r=Mardak 
Differential Revision: https://phabricator.services.mozilla.com/D143645
 2022-04-21 20:25:20 +00:00
Punam Dahiya
9d4973a078 Bug 1763825 - Handle about:welcome and spotlight dialog display for shorter screen width r=Mardak,emcminn 
Differential Revision: https://phabricator.services.mozilla.com/D143438
 2022-04-21 17:43:56 +00:00
Csoregi Natalia
e02112b431 Backed out changeset 4610b9c86ea0 (bug 1763825) for causing node failures. CLOSED TREE 2022-04-21 19:58:24 +03:00
Punam Dahiya
1774f5ac97 Bug 1763825 - Handle about:welcome and spotlight dialog display for shorter screen width r=Mardak,emcminn 
Differential Revision: https://phabricator.services.mozilla.com/D143438
 2022-04-21 16:24:01 +00:00
manisha27
8a318457ed Bug 1739139 - Move and rename the topsite icon. r=sfoster,desktop-theme-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D144211
 2022-04-21 00:38:31 +00:00
Meg Viar
597a2b032f Bug 1764890 - A scrollbar is displayed for a few seconds on the bottom-right part of the “about:welcome” page while a refresh action is performed r=emcminn 
Differential Revision: https://phabricator.services.mozilla.com/D144058
 2022-04-20 15:41:21 +00:00