This goes through the previous changes in the dependencies of bug 877389, and does two things:
1) Remove instances of \n
2) Change reporting of exceptions so that they are passed as separate arguments. This should result
in an improved display of the exception in the browser console, should it occur.
Differential Revision: https://phabricator.services.mozilla.com/D180843
After bug 1809084, the popup positioning code became more sound,
including reliably positioning once after opening.
This code was asynchronously reducing the size of the popup, sometimes
after popup positioning.
Which means that if the popup had to slide (due to having many one-off
buttons), and we then shrunk it, the popup would be mispositioned.
There's no reason the getBoundsWithoutFlushing call has to be async
afaict, so just size the popup up-front.
Differential Revision: https://phabricator.services.mozilla.com/D172928
Modern flexbox increased the macOS compact mode toolbar height by 2px due to a line-height rule from bug 1402368. The issue from that bug no longer reproduces on current Nightly, even without the added rule, so it seems safe to remove.
There was also some extra spacing introduced with Proton that should have been only applied to the search "go" button, so I scoped that more tightly and also fixed the alignment of that button while at it.
Differential Revision: https://phabricator.services.mozilla.com/D159975
`nsIEditor.undo` and `nsIEditor.redo` are called with `1` except by the search
bar, and search bar wants to undo everything to reset the value. Therefore,
search bar needs an API to undo all, and the others do not need the number of
undoing/redoing transactions. Therefore, this patch adds `nsIEditor.undoAll`
for search bar, and remove the arguments from `nsIEditor.undo` and
`nsIEditor.redo`.
Differential Revision: https://phabricator.services.mozilla.com/D158338
`nsIEditor.transactionManager` is used only for some simple purposes, however,
`nsIEditor` exposes the rich API. That makes it harder to maintain internal
code around transactions. Instead, `nsIEditor` exposes only simple and
necessary APIs.
This patch creates a new API to clear undo/redo history and make the users in
mozilla-central use it instead of using `nsITransactionManager.clear()`.
Differential Revision: https://phabricator.services.mozilla.com/D158336
Fix bug, now escape in the search box (if the popup is disimissed) will select all the content and will revert to the last search.
Differential Revision: https://phabricator.services.mozilla.com/D120137
Share the concept of a panel content with all other menupopups / panels.
This avoids importing global.css in the shadow tree, and renames the
arrowcontent part to just "content", since we want to introduce a
"content" part for other panels.
This shouldn't change behavior but makes bug 1708136 a matter of
tweaking a couple CSS rules and fixing up test failures.
Differential Revision: https://phabricator.services.mozilla.com/D113990
Share the concept of a panel content with all other menupopups / panels.
This avoids importing global.css in the shadow tree, and renames the
arrowcontent part to just "content", since we want to introduce a
"content" part for other panels.
This shouldn't change behavior but makes bug 1708136 a matter of
tweaking a couple CSS rules and fixing up test failures.
Differential Revision: https://phabricator.services.mozilla.com/D113990
This simplifies recording of the search telemetry by dropping the seperate logging of one-off button clicks, and combining the flows in recordSearch into one.
With the previous simplifications the calls in search bar and url bar, the remaining parts were two flows through recordSearch for the one-off buttons, and one for everything else. The two flows for one-off buttons each stopped at various times or skipped parts to continue to the rest.
This means we can combine those into one, have the flow governed by `details.isOneOff`, and change `maybeRecordTelemetry` into a function that simply determines if a one-off button was selected.
Differential Revision: https://phabricator.services.mozilla.com/D100053
'header' and 'paste' sources are unknown, so they don't get logged for search counts, and they just get skipped.
Additionally, the target check for 'paste' is wrong so that would not have been recorded in recent releases anyway.
Differential Revision: https://phabricator.services.mozilla.com/D100051
