corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 1757376: Continue post processing of Enter key when any keyup event is detected on search bar. r=adw

Browse Source 
Depends on D140908

Differential Revision: https://phabricator.services.mozilla.com/D141058
This commit is contained in:
Daisuke Akatsuka
2022-03-15 02:16:41 +00:00
parent f304388b1c
commit ffcce5d700
2 changed files with 40 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
browser/components/search/content/searchbar.js
View File

@@ -813,10 +813,11 @@
};
this.textbox.onkeyup = event => {
if (
event.keyCode === KeyEvent.DOM_VK_RETURN &&
this._needBrowserFocusAtEnterKeyUp
) {
// Pressing Enter key while pressing Meta key, and next, even when
// releasing Enter key before releasing Meta key, the keyup event is not
// fired. Therefore, if Enter keydown is detecting, continue the post
// processing for Enter key when any keyup event is detected.
if (this._needBrowserFocusAtEnterKeyUp) {
this._needBrowserFocusAtEnterKeyUp = false;
gBrowser.selectedBrowser.focus();
}

35
browser/components/search/test/browser/browser_searchbar_enter.js
View File

@@ -119,3 +119,38 @@ add_task(async function typeCharWhileProcessingEnter() {
// Cleanup.
await BrowserTestUtils.closeWindow(win);
});
add_task(async function keyupEnterWhilePressingMeta() {
const win = await BrowserTestUtils.openNewBrowserWindow();
const browser = win.gBrowser.selectedBrowser;
const searchBar = win.BrowserSearch.searchBar;
info("Keydown Meta+Enter");
searchBar.textbox.focus();
searchBar.textbox.value = "";
EventUtils.synthesizeKey(
"KEY_Enter",
{ type: "keydown", metaKey: true },
win
);
// Pressing Enter key while pressing Meta key, and next, even when releasing
// Enter key before releasing Meta key, the keyup event is not fired.
// Therefor, we fire Meta keyup event only.
info("Keyup Meta");
EventUtils.synthesizeKey("KEY_Meta", { type: "keyup" }, win);
await TestUtils.waitForCondition(
() => browser.ownerDocument.activeElement === browser,
"Wait for focus to be moved to the browser"
);
info("The focus is moved to the browser");
info("Check whether we can input on the search bar");
searchBar.textbox.focus();
EventUtils.synthesizeKey("a", {}, win);
is(searchBar.textbox.value, "a", "Can input a char");
// Cleanup.
await BrowserTestUtils.closeWindow(win);
});