corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
796,093 Commits 1 Branch 0 Tags
f4139c1440af43fae4bc901b40e80d1028d2738c
Commit Graph

1682 Commits

Author SHA1 Message Date
Chris H-C
295f36c5f0 Bug 1834764 - Allow DISMISS ping to arrive out of order r=perry.mcmanis,omc-reviewers,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D179447
 2023-06-07 18:28:51 +00:00
Marc Seibert
288359ceb2 Bug 1833091 - Replacing all get refs of UrlbarInput 'inputField.value' with '.value'.r=dao 
Differential Revision: https://phabricator.services.mozilla.com/D180085
 2023-06-07 14:59:13 +00:00
Narcis Beleuzu
ec23d338d8 Backed out changeset 862bd1ab18fd (bug 1833091) for bc failure on browser_ext_webNavigation_urlbar_transitions.js . CLOSED TREE 2023-06-06 19:05:07 +03:00
Marc Seibert
7d202de3f8 Bug 1833091 - Replacing all get refs of UrlbarInput 'inputField.value' with '.value'.r=dao 
Differential Revision: https://phabricator.services.mozilla.com/D180085
 2023-06-06 13:46:55 +00:00
Yoen Zhang
1f518c7563 Bug 1831647 - Add Nimbus MS Rollout messages in tree r=pdahiya 
Differential Revision: https://phabricator.services.mozilla.com/D178195
 2023-06-05 20:45:08 +00:00
Gijs Kruitbosch
60d3dd8df9 Bug 1775854 - make browser_customize_menu_content.js wait for sections to appear explicitly, r=aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D179972
 2023-06-05 17:15:59 +00:00
Rob Wu
bad812f243 Bug 1836482 - Replace AddonManager.jsm imports with AddonManager.sys.mjs r=Standard8,webcompat-reviewers,twisniewski 
This patch was generated as follows:

Run:
`./mach esmify --imports . --prefix=toolkit/mozapps/extensions/AddonManager`
In the output there are linter/prettifier errors due to unused
XPCOMUtils or separate importESModule calls. These have been fixed
manually and verified with `./mach lint --outgoing`.

The `esmify` script also inserts many unwanted newlines around imports
that are broken on two lines due to length. Due to the number of these,
I fixed them programatically.

1. Create patch from the changes so far.
2. From the patch, delete all lines that consist of "+" (i.e. added blank line).
3. Reset the working dir and apply the revised patch.
4. Verify that the diff between step 1 and 3 looks reasonable.
5. Verify that this patch as a whole looks reasonable.

Commands:

```
git diff > rename.diff
:%g/^+$/d
git commit -va -m WIP-rename
git revert HEAD
git apply --recount rename.diff
git diff HEAD^  # and verify that the removed lines are ok.
git commit -va  # one last review to verify correctness of whole patch.
git rebase -i HEAD~3  # drop the WIP + reverted commit, pick only the last.
```

`git apply` has the `--recount` option to force it to ignore mismatches
in line counts, which happens because we deleted added lines (^+$)
without fixing up the line counts in the file headers.

Differential Revision: https://phabricator.services.mozilla.com/D179874
 2023-06-04 13:44:45 +00:00
Dan Mosedale
e9b7c4c749 Bug 1835656 - messaging_system.invalid_nested_data is on the wrong ping, r=chutten 
Differential Revision: https://phabricator.services.mozilla.com/D179851
 2023-06-02 20:09:40 +00:00
Mark Banner
232facd440 Bug 1824613 - Convert consumers of toolkit/mozapps/extensions/ to import ES modules directly. r=extension-reviewers,settings-reviewers,application-update-reviewers,credential-management-reviewers,devtools-reviewers,sync-reviewers,sgalich,bytesized,robwu,skhamis 
Depends on D179819

Differential Revision: https://phabricator.services.mozilla.com/D179820
 2023-06-02 20:00:35 +00:00
Malte Juergens
5dc79f6329 Bug 1835983: Update browser/components/newtab/test/browser/browser_topsites_annotation.js to work with https-first enabled r=freddyb 
Differential Revision: https://phabricator.services.mozilla.com/D179520
 2023-05-31 09:53:13 +00:00
Katherine Patenio
a408bb9d46 Bug 1834115 - migrate newtab/lib JSMs that do not import modules to ESMs r=Standard8,fxview-reviewers,omc-reviewers,aminomancer,sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D178568
 2023-05-30 22:44:42 +00:00
Mark Striemer
44dc08eca6 Bug 1236916 - Part 2: Test Safari history migration r=mconley 
Depends on D179104

Differential Revision: https://phabricator.services.mozilla.com/D179170
 2023-05-30 17:06:53 +00:00
Norisz Fay
6b675bf3ee Backed out 2 changesets (bug 1236916) for causing xpcshell failures on test_Safari_bookmarks.js 
Backed out changeset 539dfe08bec7 (bug 1236916)
Backed out changeset a0b5a7ade705 (bug 1236916)
 2023-05-30 19:20:17 +03:00
Mark Striemer
35c661e687 Bug 1236916 - Part 2: Test Safari history migration r=mconley 
Depends on D179104

Differential Revision: https://phabricator.services.mozilla.com/D179170
 2023-05-30 14:27:50 +00:00
Nan Jiang
9ad8b6e8e1 Bug 1834795 - Implement Share-of-Voice for sponsored tiles r=thecount,ttran 
Differential Revision: https://phabricator.services.mozilla.com/D179149
 2023-05-29 20:44:25 +00:00
Mark Banner
5151ae0708 Bug 1824591 - Convert toolkit/components/promiseworker to ES modules. r=kpatenio 
Differential Revision: https://phabricator.services.mozilla.com/D179202
 2023-05-28 07:58:37 +00:00
Mark Banner
81c86b200c Bug 1834204 - Update more consumers to import ES modules directly. r=kpatenio,geckoview-reviewers,whimboo,m_kato 
Differential Revision: https://phabricator.services.mozilla.com/D178590
 2023-05-26 11:36:33 +00:00
Perry McManis
5487344d67 Bug 1825863 - Add a Glean version of onboarding and ASRouter telemetry r=dmose,perry.mcmanis,omc-reviewers 
We consolidate all the "messaging-system"-namespace pings into a single Glean
ping to provide a holistic view of all events in that system.

Differential Revision: https://phabricator.services.mozilla.com/D178477
 2023-05-24 02:39:34 +00:00
Tif Tran
ef8ecfc6a8 Bug 1833691 - Implement the Fallback protocol for Sponsored Tiles. r=nanj 
Differential Revision: https://phabricator.services.mozilla.com/D178352
 2023-05-22 04:26:30 +00:00
Mark Banner
0666077666 Bug 1826062 - Automatic fixes for upgrading Prettier to 2.8.8. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,calu 
Differential Revision: https://phabricator.services.mozilla.com/D177027
 2023-05-20 12:26:53 +00:00
Mark Banner
91fde42f7b Bug 1826062 - Automatic fixes for Prettier 2.0.5 upgrade. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,owlish 
Differential Revision: https://phabricator.services.mozilla.com/D177025
 2023-05-20 12:26:49 +00:00
Nan Jiang
e9b7045c95 Bug 1833898 - Use additional sponsored tiles by default r=ttran 
Differential Revision: https://phabricator.services.mozilla.com/D178486
 2023-05-19 00:15:07 +00:00
Neil Deakin
2cea21c177 Bug 1830911, update the current tab details when the SwapDocShells event occurs so links work when dragging a new tab into a window,r=Mardak 
Differential Revision: https://phabricator.services.mozilla.com/D177112
 2023-05-18 23:03:34 +00:00
Shane Hughes
d779f112c6 Bug 1818249 - Add a message property to allow CFRs in Private Browsing. r=omc-reviewers,pdahiya 
Also, because the data collection policy now allows Category 1 and 2
data collection in Private Browsing Mode, these CFRs will record
telemetry in PBM according to the existing CFR policy, which allows
Cat1-3 data for pre-release builds and experiments, and Cat1-2 data for
release builds. PBM windows will be treated in the same way that release
builds treat normal windows. When not enrolled in a CFR experiment, the
PBM window will only collect Cat1-2 data. When enrolled in a CFR
experiment, the PBM window may collect Cat3 data. This patch also adds a
new option to PopupNotifications that allows its usual interaction
probes to be recorded in PBM. That means, outside of an experiment,
pings from a PBM window will look just like pings from a release build
non-PBM window. And inside an experiment, pings from a PBM window will
look just like pings from a non-PBM window in any build. This ensures
that the PBM pings do not intrinsically confer any identifying
information, since their privateness cannot be known with certainty.

Differential Revision: https://phabricator.services.mozilla.com/D174200
 2023-05-18 16:26:49 +00:00
Cristian Tuns
a6fcbe72f7 Backed out changeset 8813323684b7 (bug 1830911) for causing bc failures in browser_topsites_contextMenu_options.js CLOSED TREE 2023-05-18 11:36:20 -04:00
Neil Deakin
9bb07d7fd2 Bug 1830911, update the current tab details when the SwapDocShells event occurs so links work when dragging a new tab into a window,r=Mardak 
Differential Revision: https://phabricator.services.mozilla.com/D177112
 2023-05-18 14:38:27 +00:00
scottdowne
272067742c Bug 1832507 - Pocket newtab fixng new markets onboarding dialog telemetry from firing in offscreen preloaded tabs r=gvn 
Differential Revision: https://phabricator.services.mozilla.com/D177935
 2023-05-15 13:46:01 +00:00
negin
ba615fe519 Bug 1829039 - Updates embedded migration wizard styles to match figma r=aminomancer,mconley 
Differential Revision: https://phabricator.services.mozilla.com/D176352
 2023-05-10 13:08:59 +00:00
Narcis Beleuzu
6d06f48e1a Backed out changeset 86f74f61adc0 (bug 1829039) for newtab failure on aboutwelcome.scss 2023-05-10 00:43:26 +03:00
negin
4ca699875e Bug 1829039 - Updates embedded migration wizard styles to match figma r=aminomancer 
This patch fixes the font size inconsistencies, extra whitespace above title, and introduces simplified animations for [Embedded Migration Wizard](https://www.figma.com/file/c83OEio9DhCQKuabx2tIEl/NUO-Experiments-2023?node-id=976-31535) screen. Other feedback from the initial bug has been broken down into other bugs:

* [Position relative feedback bug](https://bugzilla.mozilla.org/show_bug.cgi?id=1829272)
* [Checkbox spacing](https://bugzilla.mozilla.org/show_bug.cgi?id=1829733)
* Logo feedback - syncing up with Gabrielle and will file a follow-up bug depending on what we want to do (figma does not include the logo)

Differential Revision: https://phabricator.services.mozilla.com/D176352
 2023-05-09 20:22:09 +00:00
Cosmin Sabou
191135a322 Backed out changeset f1e19e0fa144 (bug 1829039) as requested by aminomancer. CLOSED TREE 2023-05-09 20:05:34 +03:00
negin
952dfbc88c Bug 1829039 - Updates embedded migration wizard styles to match figma r=aminomancer 
This patch fixes the font size inconsistencies, extra whitespace above title, and introduces simplified animations for [Embedded Migration Wizard](https://www.figma.com/file/c83OEio9DhCQKuabx2tIEl/NUO-Experiments-2023?node-id=976-31535) screen. Other feedback from the initial bug has been broken down into other bugs:

* [Position relative feedback bug](https://bugzilla.mozilla.org/show_bug.cgi?id=1829272)
* [Checkbox spacing](https://bugzilla.mozilla.org/show_bug.cgi?id=1829733)
* Logo feedback - syncing up with Gabrielle and will file a follow-up bug depending on what we want to do (figma does not include the logo)

Differential Revision: https://phabricator.services.mozilla.com/D176352
 2023-05-09 16:41:53 +00:00
Mark Banner
0fadbc1ec4 Bug 1829618 - Enable Prettier on json files (automatic fixes). r=perftest-reviewers,webcompat-reviewers,extension-reviewers,andi,desktop-theme-reviewers,pip-reviewers,devtools-reviewers,sync-reviewers,mossop,denschub,dao,sparky,robwu,geckoview-reviewers,owlish 
Differential Revision: https://phabricator.services.mozilla.com/D176336
 2023-05-09 16:14:51 +00:00
Norisz Fay
32ae2d7897 Backed out changeset 67d785ab3cb3 (bug 1829039) for causing node-newtab failure on aboutwelcome.scss CLOSED TREE 2023-05-09 17:35:44 +03:00
negin
dd6b50d41e Bug 1829039 - Updates embedded migration wizard styles to match figma r=aminomancer 
This patch fixes the font size inconsistencies, extra whitespace above title, and introduces simplified animations for [Embedded Migration Wizard](https://www.figma.com/file/c83OEio9DhCQKuabx2tIEl/NUO-Experiments-2023?node-id=976-31535) screen. Other feedback from the initial bug has been broken down into other bugs:

* [Position relative feedback bug](https://bugzilla.mozilla.org/show_bug.cgi?id=1829272)
* [Checkbox spacing](https://bugzilla.mozilla.org/show_bug.cgi?id=1829733)
* Logo feedback - syncing up with Gabrielle and will file a follow-up bug depending on what we want to do (figma does not include the logo)

Differential Revision: https://phabricator.services.mozilla.com/D176352
 2023-05-09 13:46:13 +00:00
Shane Hughes
2c1e31da7b Bug 1829043 - Add actions for AboutWelcome embedded migration wizard. r=pdahiya,mconley 
Add some properties to the migration wizard screen JSON to specify what
action to perform when CTAs inside the embedded migration wizard are
clicked. This lets us advance screens when the cancel or finish button
is clicked, and send telemetry when the start button is clicked. In
theory we could perform any special message actions too, but for now we
only need telemetry and screen navigation.

Differential Revision: https://phabricator.services.mozilla.com/D176358
 2023-05-08 18:23:47 +00:00
Itiel
1d45b69b81 Bug 1830953 - Fix the toast milestone popup alignment to the shield icon on the urlbar r=anti-tracking-reviewers,timhuang 
Differential Revision: https://phabricator.services.mozilla.com/D176941
 2023-05-08 18:07:50 +00:00
Hector Zhao
e110dd136c Bug 1831498 - Stop hardcoding the actor name in ActivityStreamMessageChannel. r=mconley 
Differential Revision: https://phabricator.services.mozilla.com/D177233
 2023-05-08 01:11:07 +00:00
Cristian Tuns
faf8700d34 Backed out changeset 18480aae2752 (bug 1831498) for causing bc failures in ActivityStreamMessageChannel.jsm CLOSED TREE 2023-05-05 23:06:17 -04:00
Hector Zhao
c7f700d141 Bug 1831498 - Stop hardcoding the actor name in ActivityStreamMessageChannel. r=mconley 
Differential Revision: https://phabricator.services.mozilla.com/D177233
 2023-05-06 02:10:54 +00:00
Cristian Tuns
05c7ba7f52 Backed out changeset 743c4f059b79 (bug 1829039) for causing bc failures in browser_aboutwelcome_multistage_mr.js CLOSED TREE 2023-05-05 19:50:02 -04:00
negin
087c181c62 Bug 1829039 - Updates embedded migration wizard styles to match figma r=aminomancer,mconley 
Differential Revision: https://phabricator.services.mozilla.com/D176352
 2023-05-05 19:30:31 +00:00
Stanca Serban
8fc4f98984 Backed out changeset 72f882230f63 (bug 1829039) for causing mochitests failures in browser_aboutwelcome_multistage_mr.js. CLOSED TREE 2023-05-05 04:28:52 +03:00
negin
c514f3673d Bug 1829039 - Updates embedded migration wizard styles to match figma r=aminomancer,mconley 
This patch fixes the font size inconsistencies, extra whitespace above title, and lack of transition animations for [Embedded Migration Wizard](https://www.figma.com/file/c83OEio9DhCQKuabx2tIEl/NUO-Experiments-2023?node-id=976-31535) screen. Other feedback from the initial bug has been broken down into other bugs:

* [Position relative feedback bug](https://bugzilla.mozilla.org/show_bug.cgi?id=1829272)
* [Checkbox spacing](https://bugzilla.mozilla.org/show_bug.cgi?id=1829733)
* Logo feedback - syncing up with Gabrielle and will file a follow-up bug depending on what we want to do (figma does not include the logo)

Differential Revision: https://phabricator.services.mozilla.com/D176352
 2023-05-04 23:32:12 +00:00
Mike Conley
99c30e6674 Bug 1828154 - Ensure new cache entry exists after clearing old one in browser_locale_change.js. r=amy 
This doesn't seem to absolutely fix the intermittent test failure here,
but does seem to reduce the frequency.

Differential Revision: https://phabricator.services.mozilla.com/D177158
 2023-05-04 16:12:10 +00:00
Mike Conley
ce09a57db6 Bug 1830901 - Only check the campaign attribution code when checking isDeviceMigration for ASRouter targeting. r=Mardak 
Differential Revision: https://phabricator.services.mozilla.com/D176937
 2023-05-03 14:03:55 +00:00
Mike Conley
60a2d9d4bf Bug 1830916 - Add UTM parameters for the FxA sign-in flow from AW_WELCOME_BACK. r=Mardak 
Differential Revision: https://phabricator.services.mozilla.com/D176946
 2023-05-03 14:03:55 +00:00
Cosmin Sabou
a95453aaa1 Backed out 2 changesets (bug 1830916, bug 1830901) for causing bc failures on browser_aboutwelcome_multistage_mr.js. CLOSED TREE 
Backed out changeset 8fdb1a2a02c9 (bug 1830916)
Backed out changeset d9554af08d87 (bug 1830901)
 2023-05-03 18:45:48 +03:00
Marco Bonardo
bb8a97cdaa Bug 1829571 - Fix awaits in browser_topsites_annotation.js. r=jteow 
The new helper was not properly awaiting, while some assignments are awaiting
when they should not.

Differential Revision: https://phabricator.services.mozilla.com/D176903
 2023-05-03 14:50:30 +00:00
Mike Conley
6fbc06be22 Bug 1830916 - Add UTM parameters for the FxA sign-in flow from AW_WELCOME_BACK. r=Mardak 
Differential Revision: https://phabricator.services.mozilla.com/D176946
 2023-05-03 14:03:55 +00:00