corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
796,093 Commits 1 Branch 0 Tags
f4139c1440af43fae4bc901b40e80d1028d2738c
Commit Graph

1682 Commits

Author SHA1 Message Date
Emily McMinn
47d4b9ac59 Bug 1846342 - Add supplemental info_text to shopping sidebar template r=desktop-theme-reviewers,pdahiya,aminomancer,dao 
Differential Revision: https://phabricator.services.mozilla.com/D185074
 2023-08-08 15:07:44 +00:00
Cristina Horotan
23c64f3bf9 Bug 1804804 - updated disable syntax for browser_aboutwelcome_upgrade_multistage_mr.js a=test-only 2023-08-04 22:59:51 +03:00
Natalia Csoregi
9c324e0c4c Bug 1804804 - Disable browser/components/newtab/test/browser/browser_aboutwelcome_upgrade_multistage_mr.js on Linux and Win 11 debug for having an extremely high failure rate. r=intermittent-reviewers,jmaher DONTBUILD 
Differential Revision: https://phabricator.services.mozilla.com/D185376
 2023-08-04 01:06:22 +00:00
Jason Prickett
b8dea0fc38 Bug 1846108 - Add styles for feature callout survey confirmation screen r=aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D184876
 2023-07-29 03:42:06 +00:00
hanna alemu
032131cd81 Bug 1838288 - Create Feature Callout layout to support smaller image r=omc-reviewers,aminomancer,jprickett 
Differential Revision: https://phabricator.services.mozilla.com/D184859
 2023-07-28 23:43:05 +00:00
scottdowne
dc1aa95c58 Bug 1845624 - Pocket newtab adding back read time to Pocket stories from new api. r=gvn 
Differential Revision: https://phabricator.services.mozilla.com/D184642
 2023-07-28 22:53:51 +00:00
Shane Hughes
0f4e587520 Bug 1845862 - Support primary buttons in Feature Callout. r=jprickett 
Differential Revision: https://phabricator.services.mozilla.com/D184788
 2023-07-28 20:51:17 +00:00
Jason Prickett
f43226a1f2 Bug 1845421 - Add ability to disable primary button until multiselect option is selected r=aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D184670
 2023-07-27 18:39:29 +00:00
Emily McMinn
eb39cc9a65 Bug 1840517 - Render addons screen & tiles, and allow addons to be intalled from addonspicker component r=desktop-theme-reviewers,omc-reviewers,dao,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D182128
 2023-07-24 18:59:03 +00:00
Jason Prickett
d444ae7d62 Bug 1844212 - Implement ability to hide steps indicator in about welcome r=aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D184346
 2023-07-24 07:28:48 +00:00
Shane Hughes
0e39523d2a Bug 1838295 - Feature Callout fallback anchor system. r=jprickett 
Differential Revision: https://phabricator.services.mozilla.com/D184067
 2023-07-23 02:57:02 +00:00
Cristian Tuns
f0bbf8faa6 Backed out changeset 6f0a2e1e42f5 (bug 1838295) for causing bc failures in browser_feature_callout_in_chrome.js CLOSED TREE 2023-07-22 01:40:06 -04:00
Shane Hughes
6ca5aa7977 Bug 1833193 - Avoid anchoring CFRs to widgets in customize mode. r=omc-reviewers,jprickett 
Differential Revision: https://phabricator.services.mozilla.com/D184069
 2023-07-22 04:17:51 +00:00
Shane Hughes
ab73a1849d Bug 1838295 - Feature Callout fallback anchor system. r=jprickett 
Differential Revision: https://phabricator.services.mozilla.com/D184067
 2023-07-22 03:47:34 +00:00
Emily McMinn
6f4e6300be Bug 1796699 - Allow for a configurable alt-tag on the about:welcome/Spotlight logo element r=omc-reviewers,aminomancer 
Allows a localized alt tag to be added to the logo element (for ex. in Spotlights where the logo is replaced by an image.)

Implemented similarly to the alt-tag for the onboarding illustrations; localization requires a `string_id` with an associated `.aria-label` prop.

Differential Revision: https://phabricator.services.mozilla.com/D184139
 2023-07-20 20:10:11 +00:00
Tiaan Louw
6920ea8289 Bug 1836557 - The result of a color-mix() is always in the modern color syntax r=emilio 
We convert the resulting colors of a color-mix() to srgb modern syntax.
This allows the result of a color-mix to be out of gamut, which is now
what the spec requires.

Discussion here: https://github.com/w3c/csswg-drafts/issues/8444

Differential Revision: https://phabricator.services.mozilla.com/D183647
 2023-07-20 17:41:48 +00:00
Shane Hughes
40fabcfcf3 Bug 1833193 - Allow CFRs to use alt_anchor_id in more situations where anchor_id is not available. r=omc-reviewers,hanna_a 
Differential Revision: https://phabricator.services.mozilla.com/D178099
 2023-07-19 20:25:15 +00:00
Tooru Fujisawa
ce5ebcc064 Bug 1843789 - Part 3: Rewrite testing/mochitest/BrowserTestUtils/BrowserTestUtils.sys.mjs consumers in html/xhtml to use ChromeUtils.importESModule. r=ahal,fxview-reviewers,sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D183659
 2023-07-18 23:06:30 +00:00
Shane Hughes
dc77a4b351 Bug 1835950 - Make images in Spotlight modals load lazily. r=omc-reviewers,dmose 
Make the main Spotlight image always lazy load, and make other
Spotlight/about:welcome images lazy load if the configured src is an
http or https URL. This is to fix a bug where slow image loading due to
network issues could cause Spotlight modals to hang while blocking
interaction with the rest of the browser.

Differential Revision: https://phabricator.services.mozilla.com/D180483
 2023-07-18 00:52:33 +00:00
Nick Alexander
bd3b0949b0 Bug 1805514 - Part 1: Support launch_action in Windows native toast notifications. r=barret 
`launch_action` is both top-level (when the toast is clicked) and
per-action (when a button is clicked).

Differential Revision: https://phabricator.services.mozilla.com/D182312
 2023-07-15 02:34:05 +00:00
Narcis Beleuzu
b3557244ea Backed out changeset 949ab6d791cd (bug 1840517) for bc failure on browser_aboutwelcome_multistage_mr.js 2023-07-14 01:37:54 +03:00
Emily McMinn
c4e12e1095 Bug 1840517 - Render addons screen & tiles, and allow addons to be intalled from addonspicker component r=desktop-theme-reviewers,omc-reviewers,dao,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D182128
 2023-07-13 21:30:07 +00:00
Jason Prickett
dcf79e6ec3 Bug 1826588 - add newtab feature callout trigger and prefs r=aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D182405
 2023-07-13 06:38:52 +00:00
Iulian Moraru
f191451a5a Backed out changeset 1ae88f81ac4a (bug 1840517) for causing newtab failures. CLOSED TREE 2023-07-12 23:56:57 +03:00
Emily McMinn
824a92e3ed Bug 1840517 - Render addons screen & tiles, and allow addons to be intalled from addonspicker component r=desktop-theme-reviewers,omc-reviewers,dao,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D182128
 2023-07-12 18:44:29 +00:00
Mark Banner
544ecba3af Bug 1837176 - Convert imports of httpd.js to consume the ES module directly. r=necko-reviewers,webcompat-reviewers,extension-reviewers,settings-reviewers,application-update-reviewers,credential-management-reviewers,devtools-reviewers,cookie-reviewers,twisniewski,robwu,issammani,bytesized,pbz,valentin 
Differential Revision: https://phabricator.services.mozilla.com/D181159
 2023-07-12 13:38:34 +00:00
Mark Banner
88e658c23d Bug 1792824 - Convert ObjectUtils.jsm to an ES module. r=barret,necko-reviewers,devtools-reviewers,kershaw 
Depends on D183308

Differential Revision: https://phabricator.services.mozilla.com/D183309
 2023-07-12 08:07:23 +00:00
Mark Banner
2eda629a6d Bug 1842869 - Simplify and fix newtab's ESLint configuration. r=aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D183285
 2023-07-11 20:29:19 +00:00
Shane Hughes
a9e75d53ce Bug 1825069 - Refactor AboutWelcome MultiSelect component to support sentiment collection. r=jprickett 
Differential Revision: https://phabricator.services.mozilla.com/D182275
 2023-07-11 17:55:56 +00:00
Shane Hughes
99e82b0f08 Bug 1821826 - Refactor FeatureCallout to support generic triggers. r=omc-reviewers,fxview-reviewers,tabbrowser-reviewers,dao,jprickett,sclements 
Also disable the Firefox View feature tour to avoid any risk of
regressions. The feature tour code will be removed in a later patch.
It's still present for now for testing purposes.

Differential Revision: https://phabricator.services.mozilla.com/D180927
 2023-07-11 16:00:40 +00:00
negin
bda9ac3eda Bug 1839431 - [about:welcome] Make Embedded Migration wizard default in Fx117 r=omc-reviewers,pdahiya 
Differential Revision: https://phabricator.services.mozilla.com/D181788
 2023-07-11 14:08:21 +00:00
Mike Conley
f2f2869242 Bug 1823489 - Have the migration-wizard element create the panel-list in its shadow root. r=kpatenio,negin,desktop-theme-reviewers,dao 
This involves opening the shadow root of the migration wizard, as the panel-list
really isn't designed to handle being embedded within a closed shadow root.

Differential Revision: https://phabricator.services.mozilla.com/D182484
 2023-07-10 18:31:19 +00:00
Cristina Horotan
90490ed96b Backed out 2 changesets (bug 1823489) for causing bc failures at browser_multistage_spotlight.js 
Backed out changeset 684648252672 (bug 1823489)
Backed out changeset 15437d29bacc (bug 1823489)
 2023-07-10 17:47:20 +03:00
Mike Conley
55bee439b7 Bug 1823489 - Have the migration-wizard element create the panel-list in its shadow root. r=kpatenio,negin,desktop-theme-reviewers,dao 
This involves opening the shadow root of the migration wizard, as the panel-list
really isn't designed to handle being embedded within a closed shadow root.

Differential Revision: https://phabricator.services.mozilla.com/D182484
 2023-07-10 13:34:04 +00:00
Mike Conley
904146f26b Bug 1831974 - Wait for history to update with back/forward state before continuing in browser_aboutwelcome_multistage_mr test. r=negin 
Differential Revision: https://phabricator.services.mozilla.com/D182730
 2023-07-06 19:00:02 +00:00
Nan Jiang
446a55a336 Bug 1841056 - Fix a dismissal regression for SOV r=ttran 
Differential Revision: https://phabricator.services.mozilla.com/D182473
 2023-06-29 16:49:15 +00:00
Tif Tran
44e44e642f Bug 1840311 - Record SOV (Share of Voice) partner assignment r=nanj 
Differential Revision: https://phabricator.services.mozilla.com/D181954
 2023-06-28 07:34:30 +00:00
Mike Conley
9c74548aa6 Bug 1839727 - Allow MigrationWizardChild to bind to a new <migration-wizard>. r=kpatenio,pdahiya 
This is because about:welcome creates a new <migration-wizard> every time
the import card is navigated to. The change to MigrationWizardChild allows
it to re-bind to the most recently <migration-wizard> to fire one of its
events.

Differential Revision: https://phabricator.services.mozilla.com/D181903
 2023-06-27 16:22:36 +00:00
Chris H-C
eca601ffd9 Bug 1836283 - Reinstrument contextual services PingCentre pings in parallel with Glean r=perry.mcmanis,nanj,wstuckey 
Covers topsites and quicksuggest impressions, clicks, and blocks.

Removes unused and not-to-be-used topsites-in-urlbar pingcentre instrumentation
rather than reinstrumenting it.

Differential Revision: https://phabricator.services.mozilla.com/D179856
 2023-06-26 19:02:46 +00:00
negin
b882e48890 Bug 1837051 - Add Embedded Migration Wizard support for spotlight dialog r=omc-reviewers,pdahiya,mconley 
Differential Revision: https://phabricator.services.mozilla.com/D180713
 2023-06-23 19:23:51 +00:00
Mike Conley
e8864ee16f Bug 1838926 - Add ASRouter targeting for whether or not the user has ever used the migration wizard to import passwords from a CSV file. r=emcminn 
Differential Revision: https://phabricator.services.mozilla.com/D181287
 2023-06-23 14:14:26 +00:00
Katherine Patenio
ce9d8a5dad Bug 1834831 - update imports of browser/modules JSMs r=webdriver-reviewers,perftest-reviewers,zeid,extension-reviewers,settings-reviewers,pip-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,sessionstore-reviewers,tabbrowser-reviewers,whimboo,mhowell,sgalich,robwu,sparky,Standard8,mconley,dao,sclements 
Differential Revision: https://phabricator.services.mozilla.com/D179169
 2023-06-19 18:44:48 +00:00
Cristian Tuns
f826f1b621 Backed out 2 changesets (bug 1834831) for causing node failures with checkBundles CLOSED TREE 
Backed out changeset 58b351a155c8 (bug 1834831)
Backed out changeset 1acbb5231d14 (bug 1834831)
 2023-06-19 13:22:35 -04:00
Katherine Patenio
333197cd22 Bug 1834831 - update imports of browser/modules JSMs r=webdriver-reviewers,perftest-reviewers,zeid,extension-reviewers,settings-reviewers,pip-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,sessionstore-reviewers,tabbrowser-reviewers,whimboo,mhowell,sgalich,robwu,sparky,Standard8,mconley,dao,sclements 
Differential Revision: https://phabricator.services.mozilla.com/D179169
 2023-06-19 16:46:18 +00:00
Mike Conley
fededa4b9c Bug 1838507 - Default the about:welcome migration behaviour to the legacy XUL dialog. r=Mardak 
This adds a new behaviour that opens the legacy migration wizard from about:welcome,
and sets the pref to default to that behaviour.

This also adds the behaviour to the FeatureManifest.yaml file so that it can be
instrumented remotely via Nimbus.

Differential Revision: https://phabricator.services.mozilla.com/D181105
 2023-06-15 16:33:43 +00:00
Tif Tran
0cc31ffcb7 Bug 1838051 - Add Nimbus variable to use 3 Contile tiles r=nanj 
Differential Revision: https://phabricator.services.mozilla.com/D180716
 2023-06-14 17:45:10 +00:00
Marco Castelluccio
860f602d4e Bug 1837741 - Remove Preferences.sys.mjs usage from the ToolbarPanelHub module. r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D180538
 2023-06-13 10:20:00 +00:00
Perry McManis
95a287d465 Bug 1835151 - Improve the usefullness of Event Context Parse Errors in glean r=omc-reviewers,aminomancer 
This patch is a potential improvement to handling of event_context parse errors.

At the point of instrumentation we have the Event Context as a `String`. When we created this error metric, our expectation was that we would get only (or at least primarily) JavaScript `Object`s that we would want to parse, check for fields, etc. Failure to parse via `JSON.parse()` was then expected to be mostly for cases where fields were malformed, contained illegal data, etc. In practice, it turned out that we mainly receive things that look like they ought to be `String`s after all.

This change imposes two small requirements that make it much more likely that when we see a parse error that the resulting increment is actually giving us valuable information.

Differential Revision: https://phabricator.services.mozilla.com/D179612
 2023-06-09 17:38:47 +00:00
Shane Hughes
075092d296 Bug 1832715 - Allow multistage spotlight OPEN_URL actions to include UTM params. r=omc-reviewers,negin 
Differential Revision: https://phabricator.services.mozilla.com/D177848
 2023-06-08 19:20:07 +00:00
Natalia Csoregi
64cf294e7c Backed out changeset e44f4d43b823 (bug 1833091) for causing permafailures on browser_topsites_annotation.js. CLOSED TREE 2023-06-08 03:17:53 +03:00