corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
796,093 Commits 1 Branch 0 Tags
f4139c1440af43fae4bc901b40e80d1028d2738c
Commit Graph

1473 Commits

Author SHA1 Message Date
Nick Alexander
6e9303448d Bug 1775128 - Add toast_notification message template for displaying (native) toast notifications. r=Mardak 
Differential Revision: https://phabricator.services.mozilla.com/D150073
 2022-07-20 02:58:42 +00:00
Nick Alexander
04fa028f51 Bug 1775128 - Pre: Add RemoteL10n.formatLocalizableText helper. r=barret,Mardak 
Differential Revision: https://phabricator.services.mozilla.com/D151657
 2022-07-20 02:58:42 +00:00
Punam Dahiya
86153c8869 Bug 1779654- Add SpecialMessageAction BLOCK_MESSAGE that allows to block message r=jprickett 
To be used in about:privatebrowsing Pin Private Window promo message. BLOCK_MESSAGE will be used in a multi action call after user clicks 'Pin To taskbar'. This will help in hiding Pin promo message on current and preloaded tabs

Differential Revision: https://phabricator.services.mozilla.com/D151888
 2022-07-19 23:11:31 +00:00
scott
acb6544ac6 Bug 1778351 - Removing some old Pocket newtab experiment code. r=gvn 
Differential Revision: https://phabricator.services.mozilla.com/D151666
 2022-07-19 17:32:56 +00:00
Jason Prickett
e31905c4cb Bug 1779048 - Adding PIN and OTHER as promo types in PbNewTab message schema r=pdahiya,barret 
Differential Revision: https://phabricator.services.mozilla.com/D151664
 2022-07-15 15:52:04 +00:00
scott
778f6d2ae9 Bug 1778163 - Pocket newtab about pref recent saves checkbox r=gvn,fluent-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D151413
 2022-07-12 20:01:40 +00:00
Tooru Fujisawa
328d63ce7f Bug 1777486 - Part 2: Migrate XPCOMUtils.jsm consumers with automatic migration. r=webdriver-reviewers,geckoview-reviewers,preferences-reviewers,application-update-reviewers,pip-reviewers,kmag,owlish,whimboo 
Differential Revision: https://phabricator.services.mozilla.com/D151214
 2022-07-12 04:21:34 +00:00
Andreea Pavel
f009ba2983 Backed out 11 changesets (Bug 1777486) for failing bc at browser_startup.js on a CLOSED TREE 
Backed out changeset b6c4c386f1a6 (Bug 1777486)
Backed out changeset 195cc2de8433 (Bug 1777486)
Backed out changeset 20c746fb1648 (Bug 1777486)
Backed out changeset d5fd8173d62d (Bug 1777486)
Backed out changeset 6d758fab5a3e (Bug 1777486)
Backed out changeset e938b601ba15 (Bug 1777486)
Backed out changeset 0c4ea0b9416b (Bug 1777486)
Backed out changeset 0559c53cc668 (Bug 1777486)
Backed out changeset eea573d3a9f9 (Bug 1777486)
Backed out changeset 9ce3a6496a49 (bug 1777486)
Backed out changeset b0867652fc48 (bug 1777486)
 2022-07-11 22:24:40 +03:00
Tooru Fujisawa
bf0a8b781b Bug 1777486 - Part 2: Migrate XPCOMUtils.jsm consumers with automatic migration. r=webdriver-reviewers,geckoview-reviewers,preferences-reviewers,application-update-reviewers,pip-reviewers,kmag,owlish,whimboo 
Differential Revision: https://phabricator.services.mozilla.com/D151214
 2022-07-11 15:09:13 +00:00
Tooru Fujisawa
fdfbf02edd Bug 1667455 - Part 20: Remove Services.jsm from comments. r=kmag 
Differential Revision: https://phabricator.services.mozilla.com/D150911
 2022-07-11 12:41:56 +00:00
Tooru Fujisawa
b10d0289af Bug 1667455 - Part 4: Stop importing Services.jsm from JSM. r=kmag,webdriver-reviewers,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,application-update-reviewers,pip-reviewers,twisniewski,devtools-reviewers,m_kato,jdescottes,ochameau,mconley,sfoster,AlexandruIonescu 
Differential Revision: https://phabricator.services.mozilla.com/D150893
 2022-07-11 12:41:50 +00:00
Nick Alexander
6395b2359f Bug 1775138 - Part 2: Ensure ASRouterTargeting.Environment can be used in background tasks. r=barret 
We take a simple approach:

1.  We add a test to verify that all getters succeed in background
    task mode (save for an exclusion list of getters that access
    non-local hosts).
2.  We make certain getters background task-aware: for example,
    because they require the `AddonsManager` or legacy Telemetry.

This will allow background tasks to access their own targeting as well
as a snapshot of the default profile's targeting.

Differential Revision: https://phabricator.services.mozilla.com/D151089
 2022-07-08 20:36:09 +00:00
Nick Alexander
cc142c7dff Bug 1775138 - Part 1: Snapshot Firefox Messaging System targeting configuration periodically. r=barret 
This commit arranges to write `targeting.snapshot.json` to the local
profile directory every 30 minutes, and just before shutdown.  For
simplicity, it uses the existing `JSONFile.jsm` implementation.

Differential Revision: https://phabricator.services.mozilla.com/D151057
 2022-07-08 20:36:08 +00:00
scott
018d97dd25 Bug 1778183 - Pocket newtab fixing utm params r=gvn 
Differential Revision: https://phabricator.services.mozilla.com/D151045
 2022-07-07 01:27:48 +00:00
Meg Viar
5435e7b1c9 Bug 1776686 - Add progress bar style to step indicator for MR new user onboarding r=emcminn 
Differential Revision: https://phabricator.services.mozilla.com/D150399
 2022-07-06 20:05:42 +00:00
scott
75329af4b9 Bug 1777539 - Pocket newtab remove load more button and last card features r=gvn 
Differential Revision: https://phabricator.services.mozilla.com/D150789
 2022-07-05 19:57:22 +00:00
scott
af929cc0de Bug 1776770 - Pocket newtab recent saves pref work r=gvn 
Differential Revision: https://phabricator.services.mozilla.com/D150579
 2022-06-30 03:29:13 +00:00
Barret Rennie
b3e2605f2b Bug 1771073 - Correct FxMS features and keep them up to date with tests r=dmose,pdahiya 
The Nimbus Features corresponding to FxMS messaging surfaces are actually
intended to map to FxMS message groups, which can accept *any* FxMS message.
The features have been updated with schemas that accept any FxMS message.

As part of this, all FxMS schemas have been updated with an `$id` so that they
can be bundled into feature schemas and have their internal `$ref`s work.
(Otherwise, a `$ref` would be relative to the top-level schema instead of the
sub-schema).

Schemas for individual message types are no longer exposed as resource:// URIs,
except in tests, as indivual schemas are no longer required at runtime.

Additionally, each FxMS schema has had its `template` field become required and
requires a constant value for that schema (e.g., Spotlight requires a template
value of "spotlight").

A test has been added to ensure that if any of the messaging surfaces schemas
change that the feature schemas are also updated. The feature schemas can be
regenerated via:

```
cd ./browser/components/newtab/content-src/asrouter/schemas
../../../../../../mach make-schemas.py
```

Differential Revision: https://phabricator.services.mozilla.com/D147332
 2022-06-29 23:01:37 +00:00
Gavin Suntop
f474ac4942 Bug 1774484 - Add controls for recent article visibility r=thecount,fluent-reviewers,flod 
Differential Revision: https://phabricator.services.mozilla.com/D150165
 2022-06-27 16:08:38 +00:00
Ed Lee
073938556e Bug 1775758 - Thank you message for TCP early adopters r=pdahiya,fluent-reviewers,flod 
Replace early adopter spotlight with thank you cfr.

Differential Revision: https://phabricator.services.mozilla.com/D150186
 2022-06-24 23:07:44 +00:00
scott
309d065815 Bug 1774473 - Pocket newtab recent saves section. r=gvn 
Differential Revision: https://phabricator.services.mozilla.com/D150196
 2022-06-24 20:41:32 +00:00
Meg Viar
4c527f9886 Bug 1772025 - Add targeting for users who have private Firefox browser pinned r=pdahiya,barret 
Differential Revision: https://phabricator.services.mozilla.com/D148446
 2022-06-22 18:30:03 +00:00
scott
cd739bc301 Bug 1774813 - Pocket newtab removing old layout that's not needed. r=gvn 
Differential Revision: https://phabricator.services.mozilla.com/D149645
 2022-06-22 16:59:57 +00:00
Barret Rennie
5efc329c4d Bug 1772398 - Sync RemoteImages when attachments are updated r=thecount 
Differential Revision: https://phabricator.services.mozilla.com/D148170
 2022-06-21 18:41:47 +00:00
Chris H-C
ed9b7fb559 Bug 1766887 - Call it newtab_visit_id instead of newtab_session_id for data collection r=Standard8 
This better reflects the concept at the level data analysis is performed.
Each newtab can then be considered a "visit" in the way that web analytics
consider page visits.

Doesn't change the id's contents from being the internal newtab session id.
But names have power.

Differential Revision: https://phabricator.services.mozilla.com/D149445
 2022-06-17 20:21:51 +00:00
Chris H-C
b16d177a8c Bug 1766887 - Decorate handoff searches with newtab session ids r=nanj,Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D146225
 2022-06-17 20:21:50 +00:00
Chris H-C
dbda5399ca Bug 1766887 - Gate 'newtab' ping submission behind Nimbus feature variable r=TravisLong 
Differential Revision: https://phabricator.services.mozilla.com/D146847
 2022-06-17 20:21:50 +00:00
Chris H-C
69a594ce29 Bug 1766887 - Introduce a minimal "newtab" ping for holistic data collection r=nanj,Dexter 
It doesn't actually collect anything new, but by collecting it all in one place
we should make analysis easier.

Can be shut off by setting `browser.newtabpage.ping.enabled` to `false`.

Differential Revision: https://phabricator.services.mozilla.com/D146224
 2022-06-17 20:21:49 +00:00
Cristian Tuns
b967cfd2bb Backed out 8 changesets (bug 1766887) for causing mochitest failures on browser_newtab_ping.js CLOSED TREE 
Backed out changeset a6b01c1e8823 (bug 1766887)
Backed out changeset 1ef2dd2b779e (bug 1766887)
Backed out changeset f248baea014a (bug 1766887)
Backed out changeset 3f3066906403 (bug 1766887)
Backed out changeset 3ad63b0fa7b8 (bug 1766887)
Backed out changeset 06a0a6ef295a (bug 1766887)
Backed out changeset abe659b175cb (bug 1766887)
Backed out changeset f90e9e70f6d4 (bug 1766887)
 2022-06-17 10:49:00 -04:00
Chris H-C
c1a96b3dcd Bug 1766887 - Call it newtab_visit_id instead of newtab_session_id for data collection r=Standard8 
This better reflects the concept at the level data analysis is performed.
Each newtab can then be considered a "visit" in the way that web analytics
consider page visits.

Doesn't change the id's contents from being the internal newtab session id.
But names have power.

Differential Revision: https://phabricator.services.mozilla.com/D149445
 2022-06-17 13:47:06 +00:00
Chris H-C
86f5e18f2f Bug 1766887 - Decorate handoff searches with newtab session ids r=nanj,Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D146225
 2022-06-17 13:47:05 +00:00
Chris H-C
522825441b Bug 1766887 - Gate 'newtab' ping submission behind Nimbus feature variable r=TravisLong 
Differential Revision: https://phabricator.services.mozilla.com/D146847
 2022-06-17 13:47:04 +00:00
Chris H-C
3e21f3e2ba Bug 1766887 - Introduce a minimal "newtab" ping for holistic data collection r=nanj,Dexter 
It doesn't actually collect anything new, but by collecting it all in one place
we should make analysis easier.

Can be shut off by setting `browser.newtabpage.ping.enabled` to `false`.

Differential Revision: https://phabricator.services.mozilla.com/D146224
 2022-06-17 13:47:04 +00:00
Tooru Fujisawa
62aa93946a Bug 1608282 - Part 4: Remove Cu.defineLazyGlobalGetters from JSM. r=webdriver-reviewers,extension-reviewers,jdescottes,kmag 
Depends on D149196

Differential Revision: https://phabricator.services.mozilla.com/D149197
 2022-06-16 00:19:54 +00:00
Butkovits Atila
0642580e74 Backed out 4 changesets (bug 1608282) for causing hazard failures. CLOSED TREE 
Backed out changeset 32aebc8be201 (bug 1608282)
Backed out changeset 37c970364269 (bug 1608282)
Backed out changeset ced8d82cc2d2 (bug 1608282)
Backed out changeset e26e480c7dd6 (bug 1608282)
 2022-06-16 03:10:02 +03:00
Tooru Fujisawa
8cfc991c17 Bug 1773829 - Part 2: Stop using lazy getter unnecessarily in browser/components/newtab/. r=thecount 
Depends on D149010

Differential Revision: https://phabricator.services.mozilla.com/D149011
 2022-06-15 20:56:22 +00:00
Tooru Fujisawa
b3d40a272f Bug 1608282 - Part 4: Remove Cu.defineLazyGlobalGetters from JSM. r=webdriver-reviewers,extension-reviewers,jdescottes,kmag 
Depends on D149196

Differential Revision: https://phabricator.services.mozilla.com/D149197
 2022-06-15 20:34:35 +00:00
Barret Rennie
319c1379c5 Bug 1772397 - Load multiple images at once in Remote Images r=Mardak 
Differential Revision: https://phabricator.services.mozilla.com/D148169
 2022-06-15 17:21:39 +00:00
Tooru Fujisawa
242d4f679f Bug 1607331 - Part 2: Do not use global this in browser/components/newtab/lib/DiscoveryStreamFeed.jsm. r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D149311
 2022-06-14 21:56:54 +00:00
Scott
3e691f1733 Bug 1771546 - Pocket newtab colletion/topics card. r=gvn 
Differential Revision: https://phabricator.services.mozilla.com/D147548
 2022-06-10 23:44:31 +00:00
Dan Mosedale
b2502351c9 Bug 1753915 - Add logging to ASRouter, r=barret 
Differential Revision: https://phabricator.services.mozilla.com/D137968
 2022-06-10 14:16:24 +00:00
Tooru Fujisawa
ff679ae78e Bug 1772100 - Part 10: Use plain object for lazy getter in browser/components/newtab/. r=Mardak 
Differential Revision: https://phabricator.services.mozilla.com/D148020
 2022-06-06 22:46:23 +00:00
Tooru Fujisawa
ebcb6dfd9c Bug 1772360 - Remove unnecessary call for XPCOMUtils.defineLazyGlobalGetters. r=florian,webdriver-reviewers,webcompat-reviewers,denschub,whimboo 
Differential Revision: https://phabricator.services.mozilla.com/D148168
 2022-06-06 04:42:10 +00:00
Tooru Fujisawa
f947410342 Bug 1772351 - Part 3: Stop calling XPCOMUtils.defineLazyModuleGetters for AppConstants. r=florian,webdriver-reviewers,whimboo,robwu 
Differential Revision: https://phabricator.services.mozilla.com/D148166
 2022-06-06 04:42:09 +00:00
Tooru Fujisawa
bf94464e91 Bug 1772351 - Part 1: Stop calling ChromeUtils.defineModuleGetter for AppConstants. r=florian 
Differential Revision: https://phabricator.services.mozilla.com/D148164
 2022-06-06 04:42:08 +00:00
Tooru Fujisawa
3e483c26e8 Bug 1772313 - Part 7: Stop calling XPCOMUtils.defineLazyModuleGetters for Services. r=kmag,webdriver-reviewers,whimboo 
Differential Revision: https://phabricator.services.mozilla.com/D148160
 2022-06-06 04:42:06 +00:00
Tooru Fujisawa
c56eb55371 Bug 1772313 - Part 5: Stop calling ChromeUtils.defineModuleGetter for Services. r=kmag,webcompat-reviewers,pip-reviewers,denschub,mhowell 
Differential Revision: https://phabricator.services.mozilla.com/D148158
 2022-06-06 04:42:06 +00:00
Molnar Sandor
4c2b06df41 Backed out 15 changesets (bug 1772313, bug 1772351, bug 1772360) for causing xpc failures in telemetry/tests/unit/test_SocketScalars.js CLOSED TREE 
Backed out changeset c8b0a2ed239e (bug 1772360)
Backed out changeset 1922adad6abe (bug 1772351)
Backed out changeset 6d3634cce489 (bug 1772351)
Backed out changeset f03968a9d053 (bug 1772351)
Backed out changeset e7a38ef90fe4 (bug 1772351)
Backed out changeset b389e7654771 (bug 1772313)
Backed out changeset 59a33598ff51 (bug 1772313)
Backed out changeset ab60885a8a93 (bug 1772313)
Backed out changeset aad8efac9d05 (bug 1772313)
Backed out changeset 4378e519a8e7 (bug 1772313)
Backed out changeset 302ac54741f8 (bug 1772313)
Backed out changeset 74c59f9fd51c (bug 1772313)
Backed out changeset 575fb877c56c (bug 1772313)
Backed out changeset 2eaa68f10b19 (bug 1772313)
Backed out changeset 4a8b3ba193dc (bug 1772313)
 2022-06-06 07:04:25 +03:00
Tooru Fujisawa
81758ebac5 Bug 1772360 - Remove unnecessary call for XPCOMUtils.defineLazyGlobalGetters. r=florian,webdriver-reviewers,webcompat-reviewers,denschub,whimboo 
Differential Revision: https://phabricator.services.mozilla.com/D148168
 2022-06-06 02:49:14 +00:00
Tooru Fujisawa
b580e51d8f Bug 1772351 - Part 3: Stop calling XPCOMUtils.defineLazyModuleGetters for AppConstants. r=florian,webdriver-reviewers,whimboo,robwu 
Differential Revision: https://phabricator.services.mozilla.com/D148166
 2022-06-06 02:49:13 +00:00