Commit Graph

1473 Commits

Author SHA1 Message Date
Tif Tran
bf6fe84f0f Bug 1826403 - Fill blocked sponsored tiles with additional ones r=nanj
Differential Revision: https://phabricator.services.mozilla.com/D174669
2023-04-04 21:48:02 +00:00
hanna alemu
eb668b4356 Bug 1825577 - Fix shadow of the stars for the add-on rating in addon-recommendation CFR template r=jprickett
Differential Revision: https://phabricator.services.mozilla.com/D174148
2023-04-04 16:40:20 +00:00
Mike Conley
f0a43e9d62 Bug 1794617 - Add ASRouter targeting for whether or not the user has ever migrated bookmarks, history, or passwords. r=dmose,omc-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D173579
2023-04-03 20:47:12 +00:00
Cristian Tuns
b217c2ae83 Backed out changeset 4e2dd5c6bcb7 (bug 1825577) for causing newtab failures in CFRPageActions CLOSED TREE 2023-03-31 21:10:38 -04:00
hanna alemu
4df9b1e4a7 Bug 1825577 - Fix shadow of the stars for the add-on rating in addon-recommendation CFR template r=jprickett
Fixes the wonky rating stars and a bug where if rating > 5 it shows more than 5 stars.

Differential Revision: https://phabricator.services.mozilla.com/D174148
2023-04-01 00:36:18 +00:00
Lina Butler
0ea22d21eb Bug 1821556 - Collect the tile position and number of tile rows in newtab pings. r=nanj
This commit:

* Adds a `position` key to the `topsites.{impression, click}` events.
  This position is zero-based, to align with `pocket_position`.
* Refactors the impression stats actions in `TelemetryFeed` to receive
  the zero-based tile position, and adds one to the structured
  ingestion payloads and scalar values.
* Adds a new Glean metric, `topsites.rows`, to record the number of
  rows shown on the New Tab page.

Differential Revision: https://phabricator.services.mozilla.com/D172292
2023-03-31 05:21:20 +00:00
Barret Rennie
f7a4fadf48 Bug 1788954 - Convert toolkit/components/nimbus to ES modules r=Standard8,pip-reviewers,credential-management-reviewers,sgalich
Differential Revision: https://phabricator.services.mozilla.com/D172850
2023-03-30 20:51:58 +00:00
Shane Hughes
3301924585 Bug 1822893 - Add formAutofill trigger and targeting attributes creditCardsSaved and addressesSaved. r=omc-reviewers,jprickett
Differential Revision: https://phabricator.services.mozilla.com/D172842
2023-03-29 07:07:42 +00:00
Travis Long
e5e92088ef Bug 1822726 - Remove expiring metric used for Server Knobs Validation. r=chutten
Differential Revision: https://phabricator.services.mozilla.com/D173474
2023-03-27 13:46:32 +00:00
scottdowne
1155a62e05 Bug 1822503 - Pocket newtab fixing startup reset from happening during experiment load. r=nanj,mconley,barret
Differential Revision: https://phabricator.services.mozilla.com/D173342
2023-03-22 21:41:50 +00:00
Nan Jiang
11e928239e Bug 1823949 - Fix an edge case for adding custom topsites r=thecount
Differential Revision: https://phabricator.services.mozilla.com/D173301
2023-03-22 18:06:26 +00:00
hanna alemu
92599868f8 Bug 1813809 - Implement safeguard for Feature Callout pref getter function r=omc-reviewers,aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D171925
2023-03-22 16:17:13 +00:00
Florian Quèze
2bc70af0d2 Bug 1821490 - New tab page updates should pause when the user is away and resume immediately when the user is back, r=thecount.
Differential Revision: https://phabricator.services.mozilla.com/D172172
2023-03-22 08:41:45 +00:00
Nan Jiang
13b8c7bc9a Bug 1822327 - Add hostname for SPOC topsites r=thecount
Differential Revision: https://phabricator.services.mozilla.com/D173186
2023-03-21 19:06:00 +00:00
Nan Jiang
9c9c1c1086 Bug 1822604 - Fix an edge case for spoc topsites injection r=thecount
Differential Revision: https://phabricator.services.mozilla.com/D173094
2023-03-21 01:29:31 +00:00
Nan Jiang
d3d184c501 Bug 1822027 - Do not show SPOC topsites in the URLbar r=thecount
Differential Revision: https://phabricator.services.mozilla.com/D173025
2023-03-20 15:31:02 +00:00
Barret Rennie
0604905647 Bug 1818738 - Make the feature update event API more ergonomic r=aminomancer,settings-reviewers,search-reviewers,Gijs,daleharvey
Differential Revision: https://phabricator.services.mozilla.com/D172035
2023-03-16 22:20:14 +00:00
Abhishek Tiwari
496a43cc06 Bug 1821624 - Convert toolkit/components/messaging-system to ES modules r=Standard8,fxview-reviewers,omc-reviewers,aminomancer,sclements
Differential Revision: https://phabricator.services.mozilla.com/D172406
2023-03-15 18:44:02 +00:00
Francesco Lodolo (:flod)
fa28bcb157 Bug 1822388 - Move brandings.ftl from browser to toolkit, r=eemeli,settings-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,sgalich,Mardak
Differential Revision: https://phabricator.services.mozilla.com/D172643
2023-03-15 17:00:48 +00:00
Shane Hughes
3d2d5cd25f Bug 1819456 - Update ASRouter messages when experiment recipes are updated. r=omc-reviewers,barret
Differential Revision: https://phabricator.services.mozilla.com/D171939
2023-03-14 02:53:27 +00:00
Norisz Fay
daed151636 Backed out changeset 8d5e4dfff15e (bug 1819456) for causing xpcshell failures on test_RemoteSettingsExperimentLoader.js 2023-03-14 04:15:21 +02:00
Shane Hughes
6721e45b2a Bug 1819456 - Update ASRouter messages when experiment recipes are updated. r=omc-reviewers,barret
Differential Revision: https://phabricator.services.mozilla.com/D171939
2023-03-14 00:45:52 +00:00
Lata
86dbcea07e Bug 1821897 - convert toolkit/components/remotepagemanager to ES modules. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D172385
2023-03-13 12:26:10 +00:00
Dan Mosedale
6113925a22 Bug 1821816 - Remove unneeded placeholder features, r=omc-reviewers,aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D172345
2023-03-11 17:56:05 +00:00
Lina Butler
d78454e018 Bug 1820707 - Record impressions and clicks for organic tiles. r=nanj
Currently, the Glean `newtab` ping and legacy scalars collect
impressions and clicks for sponsored (Pocket and Contile) tiles, but
not organic tiles from Places.

This commit adds:

* Support for recording organic impressions to the
  `TopSiteImpressionWrapper` component.
* Support for recording organic clicks to the `TopSiteLink`
  component.
* Instrumentation for recording organic impressions and clicks,
  separate from sponsored ones, to `TelemetryFeed`.

Differential Revision: https://phabricator.services.mozilla.com/D171830
2023-03-11 05:24:03 +00:00
DJ
f23a3273d3 Bug 1816980 - remove copy experiment code and implement finalize copy. r=fluent-reviewers,omc-reviewers,flod,aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D172158
2023-03-10 14:24:32 +00:00
Dan Mosedale
95029f0901 Bug 1821242 - add placeholder FxMS features for 112+, r=omc-reviewers,aminomancer
Adding placeholder feature ids expected to be needed for 112+ deployments to a couple of static lists.

Differential Revision: https://phabricator.services.mozilla.com/D172087
2023-03-10 04:37:41 +00:00
Iulian Moraru
8d761a26a2 Backed out changeset eed7574265d1 (bug 1816980) for causing bc failures on browser_sma_enable_cbh.js. CLOSED TREE 2023-03-09 23:18:28 +02:00
Shane Hughes
b5b861e02c Bug 1817319 - Add messagesLoaded trigger. r=omc-reviewers,jprickett
Differential Revision: https://phabricator.services.mozilla.com/D170263
2023-03-09 20:47:02 +00:00
DJ
1bfe5d8ee6 Bug 1816980 - remove copy experiment code and implement finalize copy. r=fluent-reviewers,omc-reviewers,flod,aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D172158
2023-03-09 18:58:28 +00:00
scottdowne
bcc875f7a0 Bug 1820926 - Pocket newtab fixing Discovery Stream topsite images. r=nanj
Differential Revision: https://phabricator.services.mozilla.com/D171945
2023-03-08 18:29:59 +00:00
Barret Rennie
db39ad4910 Bug 1820918 - Remove RemoteImages.jsm r=aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D171942
2023-03-08 02:44:46 +00:00
Cosmin Sabou
346961f7f2 Backed out changeset e8e4b29af858 (bug 1817319) for causing bc failures on browser_newtab_trigger.js. CLOSED TREE 2023-03-08 02:24:59 +02:00
Jason Prickett
60c0c22447 Bug 1790424 - Fixed screen targeting for mobile download onboarding string r=pdahiya
Differential Revision: https://phabricator.services.mozilla.com/D171609
2023-03-07 23:20:01 +00:00
Shane Hughes
a91b2414aa Bug 1817319 - Add messagesLoaded trigger. r=omc-reviewers,jprickett
Differential Revision: https://phabricator.services.mozilla.com/D170263
2023-03-07 22:32:43 +00:00
Sandor Molnar
6b4fef59f0 Backed out changeset f14393afa5c8 (bug 1790424) for causing bc failures in browser/components/newtab/test/browser/browser_aboutwelcome_multistage_default.js CLOSED TREE 2023-03-07 20:19:52 +02:00
Nan Jiang
14cdcb9343 Bug 1817010 - Add a nimbus variable to cap sponsored top sites r=thecount
Differential Revision: https://phabricator.services.mozilla.com/D171789
2023-03-07 17:29:15 +00:00
Jason Prickett
997b1c8c1a Bug 1790424 - Fixed screen targeting for mobile download onboarding string r=pdahiya
Differential Revision: https://phabricator.services.mozilla.com/D171609
2023-03-07 16:08:11 +00:00
Dão Gottwald
1057069b47 Bug 1820475 - Remove colorways-card.mjs and related code. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D171696
2023-03-07 12:35:52 +00:00
Csoregi Natalia
0350da18d5 Backed out changeset d59fe9707337 (bug 1820475) for failures on browser_multistage_spotlight.js. CLOSED TREE 2023-03-07 12:35:33 +02:00
Dão Gottwald
4bf57c85ea Bug 1820475 - Remove colorways-card.mjs and related code. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D171696
2023-03-07 09:24:21 +00:00
Barret Rennie
975ae348dd Bug 1805511 - Add targeting for default PDF and HTML handlers r=nalexander,omc-reviewers,emcminn
This also fixes a bug in ASRouter devtools that prevented evaluation of
expressions containing nested promises. Objects containing promises are now
correctly serialized to the ASRouter devtools and expressions evaluate
correctly.

Differential Revision: https://phabricator.services.mozilla.com/D169408
2023-03-06 20:10:55 +00:00
scott
173e73bfcf Bug 1805589 - Pocket newtab add Discovery Stream topsites to topsites list earlier.
Differential Revision: https://phabricator.services.mozilla.com/D164625
2023-03-03 21:54:36 +00:00
Stanca Serban
ba2c013d86 Backed out changeset 51080108cc0d (bug 1805589) for causing mochitests failures in browser/components/newtab/test/browser/abouthomecache/browser_no_startup_actions.js. CLOSED TREE 2023-03-03 21:29:55 +02:00
scott
89b0078202 Bug 1805589 - Pocket newtab add Discovery Stream topsites to topsites list earlier. r=nanj
Differential Revision: https://phabricator.services.mozilla.com/D164625
2023-03-03 18:22:34 +00:00
Jason Prickett
3e83df4f60 Bug 1790424 - Adding functionality for onboarding and about welcome messages to be filtered with targeting r=omc-reviewers,barret,pdahiya
Differential Revision: https://phabricator.services.mozilla.com/D170719
2023-03-03 00:26:26 +00:00
Sandor Molnar
ffa80a3221 Backed out 4 changesets (bug 1805511, bug 1805509) for causing bc and xpc failures. CLOSED TREE
Backed out changeset 31a8dcad0d88 (bug 1805509)
Backed out changeset 3dd1735b85fa (bug 1805509)
Backed out changeset 87641a6eee2b (bug 1805509)
Backed out changeset e5bd4ad558f2 (bug 1805511)
2023-03-02 23:26:06 +02:00
Barret Rennie
716e5614da Bug 1805511 - Add targeting for default PDF and HTML handlers r=nalexander,omc-reviewers,emcminn
This also fixes a bug in ASRouter devtools that prevented evaluation of
expressions containing nested promises. Objects containing promises are now
correctly serialized to the ASRouter devtools and expressions evaluate
correctly.

Differential Revision: https://phabricator.services.mozilla.com/D169408
2023-03-02 20:33:21 +00:00
Sandor Molnar
5ace18f79f Backed out 4 changesets (bug 1805509, bug 1805511) for causing node newtab failures. CLOSED TREE
Backed out changeset 1c1d335d4ef5 (bug 1805509)
Backed out changeset 0bf2579bccd7 (bug 1805509)
Backed out changeset a87f459f2caa (bug 1805509)
Backed out changeset ae16a9890f22 (bug 1805511)
2023-03-02 21:03:45 +02:00
Barret Rennie
7d6f95873a Bug 1805511 - Add targeting for default PDF and HTML handlers r=nalexander,omc-reviewers,emcminn
This also fixes a bug in ASRouter devtools that prevented evaluation of
expressions containing nested promises. Objects containing promises are now
correctly serialized to the ASRouter devtools and expressions evaluate
correctly.

Differential Revision: https://phabricator.services.mozilla.com/D169408
2023-03-02 18:27:13 +00:00