Commit Graph

1473 Commits

Author SHA1 Message Date
Saira Abdulla
cac3d1f236 Bug 1824612 - Convert consumers of toolkit/components/extensions to ES modules. r=robwu,webcompat-reviewers,geckoview-reviewers,settings-reviewers,application-update-reviewers,credential-management-reviewers,devtools-reviewers,cookie-reviewers,twisniewski,sgalich,valentin,nalexander,mconley,m_kato
Depends on D175553

Differential Revision: https://phabricator.services.mozilla.com/D176005
2023-05-31 10:21:37 +00:00
Katherine Patenio
a408bb9d46 Bug 1834115 - migrate newtab/lib JSMs that do not import modules to ESMs r=Standard8,fxview-reviewers,omc-reviewers,aminomancer,sfoster
Differential Revision: https://phabricator.services.mozilla.com/D178568
2023-05-30 22:44:42 +00:00
Nan Jiang
9ad8b6e8e1 Bug 1834795 - Implement Share-of-Voice for sponsored tiles r=thecount,ttran
Differential Revision: https://phabricator.services.mozilla.com/D179149
2023-05-29 20:44:25 +00:00
Mark Banner
5151ae0708 Bug 1824591 - Convert toolkit/components/promiseworker to ES modules. r=kpatenio
Differential Revision: https://phabricator.services.mozilla.com/D179202
2023-05-28 07:58:37 +00:00
Mark Banner
81c86b200c Bug 1834204 - Update more consumers to import ES modules directly. r=kpatenio,geckoview-reviewers,whimboo,m_kato
Differential Revision: https://phabricator.services.mozilla.com/D178590
2023-05-26 11:36:33 +00:00
Katherine Patenio
99d830d71b Bug 1830418 - Convert browser/components/customizableui/CustomizableUI.jsm to ESM r=Standard8,devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D177423
2023-05-24 15:52:34 +00:00
Perry McManis
5487344d67 Bug 1825863 - Add a Glean version of onboarding and ASRouter telemetry r=dmose,perry.mcmanis,omc-reviewers
We consolidate all the "messaging-system"-namespace pings into a single Glean
ping to provide a holistic view of all events in that system.

Differential Revision: https://phabricator.services.mozilla.com/D178477
2023-05-24 02:39:34 +00:00
scottdowne
40b0113078 Bug 1834544 - Pocket newtab sponsored topsites ensure we have a faviconSize for Kevel topsites. r=nanj
Differential Revision: https://phabricator.services.mozilla.com/D178796
2023-05-23 16:47:39 +00:00
Tif Tran
ef8ecfc6a8 Bug 1833691 - Implement the Fallback protocol for Sponsored Tiles. r=nanj
Differential Revision: https://phabricator.services.mozilla.com/D178352
2023-05-22 04:26:30 +00:00
Mark Banner
0f2402949a Bug 1826062 - Manual fixes for Prettier 2.8.8 upgrade. r=mossop,webdriver-reviewers,extension-reviewers,devtools-reviewers,robwu
Differential Revision: https://phabricator.services.mozilla.com/D177908
2023-05-20 12:26:55 +00:00
Mark Banner
0666077666 Bug 1826062 - Automatic fixes for upgrading Prettier to 2.8.8. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,calu
Differential Revision: https://phabricator.services.mozilla.com/D177027
2023-05-20 12:26:53 +00:00
Mark Banner
91fde42f7b Bug 1826062 - Automatic fixes for Prettier 2.0.5 upgrade. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,owlish
Differential Revision: https://phabricator.services.mozilla.com/D177025
2023-05-20 12:26:49 +00:00
Nan Jiang
e9b7045c95 Bug 1833898 - Use additional sponsored tiles by default r=ttran
Differential Revision: https://phabricator.services.mozilla.com/D178486
2023-05-19 00:15:07 +00:00
Katherine Patenio
2e593c5af4 Bug 1830419 - Convert PanelMutiView.jsm and CustomizableUITestUtils.jsm in browser/components/customizableui to ESMs r=search-reviewers,Standard8,devtools-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D178362
2023-05-18 18:34:51 +00:00
Shane Hughes
d779f112c6 Bug 1818249 - Add a message property to allow CFRs in Private Browsing. r=omc-reviewers,pdahiya
Also, because the data collection policy now allows Category 1 and 2
data collection in Private Browsing Mode, these CFRs will record
telemetry in PBM according to the existing CFR policy, which allows
Cat1-3 data for pre-release builds and experiments, and Cat1-2 data for
release builds. PBM windows will be treated in the same way that release
builds treat normal windows. When not enrolled in a CFR experiment, the
PBM window will only collect Cat1-2 data. When enrolled in a CFR
experiment, the PBM window may collect Cat3 data. This patch also adds a
new option to PopupNotifications that allows its usual interaction
probes to be recorded in PBM. That means, outside of an experiment,
pings from a PBM window will look just like pings from a release build
non-PBM window. And inside an experiment, pings from a PBM window will
look just like pings from a non-PBM window in any build. This ensures
that the PBM pings do not intrinsically confer any identifying
information, since their privateness cannot be known with certainty.

Differential Revision: https://phabricator.services.mozilla.com/D174200
2023-05-18 16:26:49 +00:00
Karandeep
b4c779e1c3 Bug 1824609 convert consumers of toolkit/components/thumbnails/ to import ES modules directly. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D177197
2023-05-10 20:00:58 +00:00
Itiel
1d45b69b81 Bug 1830953 - Fix the toast milestone popup alignment to the shield icon on the urlbar r=anti-tracking-reviewers,timhuang
Differential Revision: https://phabricator.services.mozilla.com/D176941
2023-05-08 18:07:50 +00:00
Hector Zhao
e110dd136c Bug 1831498 - Stop hardcoding the actor name in ActivityStreamMessageChannel. r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D177233
2023-05-08 01:11:07 +00:00
Cristian Tuns
faf8700d34 Backed out changeset 18480aae2752 (bug 1831498) for causing bc failures in ActivityStreamMessageChannel.jsm CLOSED TREE 2023-05-05 23:06:17 -04:00
Hector Zhao
c7f700d141 Bug 1831498 - Stop hardcoding the actor name in ActivityStreamMessageChannel. r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D177233
2023-05-06 02:10:54 +00:00
Shane Hughes
aa7d407c55 Bug 1830422 - Add 5 placeholder FxMS features for 114+, r=aminomancer
One from the JIRA Roadmap, and 4 more, so the total buffer size is 5.

Differential Revision: https://phabricator.services.mozilla.com/D176725
2023-05-05 16:44:30 +00:00
Mike Conley
ce09a57db6 Bug 1830901 - Only check the campaign attribution code when checking isDeviceMigration for ASRouter targeting. r=Mardak
Differential Revision: https://phabricator.services.mozilla.com/D176937
2023-05-03 14:03:55 +00:00
Cosmin Sabou
a95453aaa1 Backed out 2 changesets (bug 1830916, bug 1830901) for causing bc failures on browser_aboutwelcome_multistage_mr.js. CLOSED TREE
Backed out changeset 8fdb1a2a02c9 (bug 1830916)
Backed out changeset d9554af08d87 (bug 1830901)
2023-05-03 18:45:48 +03:00
Mike Conley
6d514ac543 Bug 1830901 - Only check the campaign attribution code when checking isDeviceMigration for ASRouter targeting. r=Mardak
Differential Revision: https://phabricator.services.mozilla.com/D176937
2023-05-03 14:03:55 +00:00
hanna alemu
2ac6135d00 Bug 1816511 - Allow messaging about:welcome users by screen usage r=omc-reviewers,pdahiya,jprickett,aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D172836
2023-05-02 13:53:07 +00:00
Tif Tran
eca0af9a97 Bug 1828234 - Collect blocked advertisers in Glean New Tab metrics r=lina
Differential Revision: https://phabricator.services.mozilla.com/D176499
2023-04-27 22:37:10 +00:00
scottdowne
fd0eddef2b Bug 1829907 - Pocket newtab fixing locale list region issue in nightly. r=gvn
Differential Revision: https://phabricator.services.mozilla.com/D176449
2023-04-25 18:19:22 +00:00
scottdowne
4b486920aa Bug 1812690 - Pocket newtab enabling onboarding experience for new users seeing the Pocket section for the first time. r=gvn,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D174710
2023-04-25 16:49:25 +00:00
Neil Deakin
044b5f4c4c Bug 1814210, switch ActivityStreamMessageChannel to use actor-based Remote Page Manager, r=Mardak
Differential Revision: https://phabricator.services.mozilla.com/D171604
2023-04-25 12:26:24 +00:00
Mike Conley
b0e076cb45 Bug 1828117 - Add a convenient ASRouterTargeting attribute for clients installed via guided device migration from SUMO. r=Mardak
Differential Revision: https://phabricator.services.mozilla.com/D176185
2023-04-24 15:38:41 +00:00
Sandor Molnar
33f254d746 Backed out changeset 3ae01032459a (bug 1814210) for causing bc failures in browser/base/content/test/static/browser_all_files_referenced.js CLOSED TREE 2023-04-24 18:27:23 +03:00
Neil Deakin
f5cd08a0f6 Bug 1814210, switch ActivityStreamMessageChannel to use actor-based Remote Page Manager, r=Mardak
Differential Revision: https://phabricator.services.mozilla.com/D171604
2023-04-24 14:27:58 +00:00
Mathew Hodson
5a881a3345 Bug 1828563 - Update consumers to use FeatureManifest ESM. r=barret
Differential Revision: https://phabricator.services.mozilla.com/D175725
2023-04-24 09:54:19 +00:00
scottdowne
de18d8fccf Bug 1812689 - Pocket newtab new regions implementation r=gvn
Differential Revision: https://phabricator.services.mozilla.com/D173853
2023-04-21 17:57:28 +00:00
Mike Conley
711b1c4d9a Bug 1820640 - Add a card to about:welcome that embeds the Migration Wizard if configured to do so. r=pdahiya,omc-reviewers
This adds a card to the about:welcome defaults that embeds the new Migration Wizard
if  browser.migrate.content-modal.about-welcome-behavior is set to "embedded".

This requires adding a useEmbeddedMigrationWizard targeting attribute to
ASRouterTargeting.

Differential Revision: https://phabricator.services.mozilla.com/D175945
2023-04-21 03:18:12 +00:00
Tif Tran
e8110668ee Bug 1824842 - Record the advertiser name and tile ID for sponsored tile impressions and clicks r=lina
Differential Revision: https://phabricator.services.mozilla.com/D174678
2023-04-19 21:38:12 +00:00
Bilal
f49ad16881 Bug 1817002 - ESMified browser/components/pocket/content. r=kpatenio
Differential Revision: https://phabricator.services.mozilla.com/D175700
2023-04-19 19:18:57 +00:00
scottdowne
397b03d023 Bug 1828810 - Pocket newtab Discovery Stream topsite image scaling issue fix. r=nanj
Differential Revision: https://phabricator.services.mozilla.com/D175840
2023-04-19 13:45:21 +00:00
Dão Gottwald
995349acbb Bug 1828440 - BuiltInThemes cleanup: remove obsolete findActiveColorwayCollection, isColorwayFromCurrentCollection, isMonochromaticTheme, monochromaticSortIndices. r=amy,willdurand
Differential Revision: https://phabricator.services.mozilla.com/D175647
2023-04-19 11:05:28 +00:00
Mathew Hodson
c060b32e7d Bug 1824906 - Update consumers to use normandy ESM. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D175026
2023-04-16 18:01:55 +00:00
Bilal
34ec496fc7 Bug 1816999 - ESMified browser/components/shell. r=kpatenio
Differential Revision: https://phabricator.services.mozilla.com/D175274
2023-04-14 16:59:15 +00:00
hanna alemu
306343134d Bug 1825658 - Modify "addon_recommendation" CFR template to support Facebook container experiment r=jprickett,barret
Differential Revision: https://phabricator.services.mozilla.com/D174844
2023-04-14 15:36:39 +00:00
William Durand
ad508fc1aa Bug 1828074 - Add new targeting attribute for RTAMO in ASRouter. r=omc-reviewers,aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D175463
2023-04-14 14:11:36 +00:00
Barret Rennie
06caa2cfbd Bug 1827718 - Serialize arrays correctly in ASRouter targeting r=nalexander,omc-reviewers,aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D175287
2023-04-13 19:11:06 +00:00
anwar
c8fd3502e2 Bug 1816938 - Convert services/settings/utils.jsm to ES modules. r=Standard8,robwu
Differential Revision: https://phabricator.services.mozilla.com/D173134
2023-04-13 16:22:54 +00:00
Noemi Erli
100160f533 Backed out changeset e054b7d5f984 (bug 1825658) for causing newtab failures CLOSED TREE 2023-04-13 18:36:23 +03:00
hanna alemu
f004fa7c10 Bug 1825658 - Modify "addon_recommendation" CFR template to support Facebook container experiment r=jprickett,barret
Differential Revision: https://phabricator.services.mozilla.com/D174844
2023-04-13 15:03:33 +00:00
Francesco Lodolo (:flod)
1dfecb77f0 Bug 1826755 - Move Firefox account Fluent term to toolkit, r=fluent-reviewers,settings-reviewers,credential-management-reviewers,fxview-reviewers,mconley,sclements,sgalich,eemeli
Differential Revision: https://phabricator.services.mozilla.com/D175097
2023-04-12 15:51:42 +00:00
William Durand
24e0c2ceb0 Bug 1826763 - Remove unused observer of the "webextension-install-notify" topic. r=omc-reviewers,aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D174890
2023-04-11 07:24:21 +00:00
Shane Hughes
2ccefd0eaa Bug 1826046 - Fix a targeting error when form autofill is unsupported. r=omc-reviewers,jprickett
The new form autofill targeting attributes use an actor that may not be
registered in regions where neither credit card nor address autofill is
supported. In that case, the actor never gets registered, and requesting
an unrecognized JSActor throws an exception, which causes JEXL
evaluation to fail, ultimately causing message requests to fail. The
simplest fix is to just catch the exception and report 0 for targeting.
Using an actor externally isn't ideal, but in this case it's
conventional and the alternative - importing the storage object - isn't
great either.

Differential Revision: https://phabricator.services.mozilla.com/D174447
2023-04-05 17:06:09 +00:00