corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
796,093 Commits 1 Branch 0 Tags
f4139c1440af43fae4bc901b40e80d1028d2738c
Commit Graph

1424 Commits

Author SHA1 Message Date
Mike Conley
cd18f710fc Bug 1821187 - Add infrastructure for file migrators in the new Migration Wizard. r=fluent-reviewers,kpatenio,flod 
This also includes our first file migrator, which imports passwords from CSV/TSV files.

Differential Revision: https://phabricator.services.mozilla.com/D173033
 2023-04-13 01:28:38 +00:00
Mike Conley
40cfbea3c0 Bug 1827431 - Make sure to select the appropriate profile when choosing what resource data is available for migration. r=niklas 
We weren't passing the appropriate profile object to getMigrateData, and thanks to mocking,
we didn't catch this in automated testing.

This patch fixes the issue, and updates our mocking helpers to ensure that the expected
profile object gets passed to the `getResources` calls during mochitest-browser tests.

Differential Revision: https://phabricator.services.mozilla.com/D175144
 2023-04-12 16:01:41 +00:00
Mike Conley
a1a329e69b Bug 1827206 - Focus the Done button after migration completes in the new wizard. r=kpatenio 
Differential Revision: https://phabricator.services.mozilla.com/D175050
 2023-04-11 20:53:23 +00:00
Mike Conley
02d9100424 Bug 1827205 - Make sure browser / profile selector is focused when showing the selection page in the new migration wizard. r=kpatenio 
Differential Revision: https://phabricator.services.mozilla.com/D175049
 2023-04-11 20:53:22 +00:00
Ebilite Uchenna
ed5dc481d8 Bug 1824611 - Convert consumers of toolkit/components/passwordmgr to import ES modules directly. r=Standard8,credential-management-reviewers,settings-reviewers,fxview-reviewers,sclements,sgalich,geckoview-reviewers,owlish 
Differential Revision: https://phabricator.services.mozilla.com/D174446
 2023-04-11 19:06:24 +00:00
Nolan Ishii
26618c8cf1 Bug 1822133 Write a test that checks that disabled migrators do not appear in the new Migration Wizard. r=mconley 
Differential Revision: https://phabricator.services.mozilla.com/D173854
 2023-04-11 17:46:16 +00:00
Tooru Fujisawa
18d749f6ff Bug 1821308 - Part 2: Convert ctypes.jsm consumers to use ESM. r=Standard8,geckoview-reviewers,application-update-reviewers,credential-management-reviewers,sgalich,bytesized,m_kato 
Differential Revision: https://phabricator.services.mozilla.com/D173811
 2023-04-11 01:25:15 +00:00
elephanteatsapple
fb792f5335 Bug 1822314 - Fix NS_ERROR_FILE_UNRECOGNIZED_PATH errors when opening the migration wizard.r=mconley 
Differential Revision: https://phabricator.services.mozilla.com/D175020
 2023-04-10 16:57:31 +00:00
Ed Lee
c4de037d86 Bug 1826439 - Support running new migration wizard Fx113 experiment r=pdahiya,settings-reviewers,mconley 
Additionally check for the new content modal and standalone version for WAIT_FOR_MIGRATION_CLOSE by using observer notifications from preferences dialog close, new wizard actor, old wizard uninit.

Differential Revision: https://phabricator.services.mozilla.com/D174692
 2023-04-07 05:12:31 +00:00
elephanteatsapple
9674321f7e Bug 1825070 - Make the Migration Wizard panel / panel-list closer to the width of the selector button. r=mconley 
Differential Revision: https://phabricator.services.mozilla.com/D174801
 2023-04-05 21:42:35 +00:00
Mike Conley
2075b4ef54 Bug 1825854 - Add a preference to control the behavior of the migration wizard when opened from about:welcome. r=settings-reviewers,mstriemer 
This is controlled by the migrationWizard.aboutWelcomeBehavior Nimbus feature variable.

Differential Revision: https://phabricator.services.mozilla.com/D174326
 2023-04-05 21:40:46 +00:00
Angel_V129
d4af15e01a Bug 1819423 - Add support for importing synced bookmarks for Chrome-based browsers. r=kpatenio. 
Differential Revision: https://phabricator.services.mozilla.com/D173391
 2023-04-05 15:34:01 +00:00
elephanteatsapple
bf129f986c Bug 1824870 - Fix Sinon usage in browser_safari_permissions.js. r=mconley,kpatenio 
This makes it so that we properly use and restore a Sinon sandbox when stubbing out things
on the SafariProfileMigrator, whereas before we were merely stubbing and not restoring.

Differential Revision: https://phabricator.services.mozilla.com/D174647
 2023-04-04 17:08:37 +00:00
Gijs Kruitbosch
870cdb1043 Bug 1825218 - stop trying to offer Opera GX import on Linux where it isn't supported, r=mconley 
Differential Revision: https://phabricator.services.mozilla.com/D174613
 2023-04-04 16:05:32 +00:00
Mike Conley
7c224745be Bug 1825655 - Record keyed scalars for each browser/profile pair found when discovering browsers to migrate from. data-review=jhirsch, r=niklas 
Differential Revision: https://phabricator.services.mozilla.com/D174185
 2023-04-03 20:47:13 +00:00
Mike Conley
3dcc43bd41 Bug 1824786 - Add event telemetry for the migration wizards. data-review=jhirsch, r=niklas 
Differential Revision: https://phabricator.services.mozilla.com/D174184
 2023-04-03 20:47:13 +00:00
Mike Conley
e893ea3c9b Bug 1825632 - Collect migration interaction telemetry for each resource type, not just the last one migrated. r=dmose 
Differential Revision: https://phabricator.services.mozilla.com/D174165
 2023-04-03 20:47:12 +00:00
Mike Conley
d2ac8a1acd Bug 1821779 - Move migrationWizard.ftl out from locales-preview into the locales folder. r=flod,fluent-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D174482
 2023-04-03 17:25:18 +00:00
elephanteatsapple
617cd2fcfa Bug 1825814 -Brave brand asset is squished. r=mconley 
Differential Revision: https://phabricator.services.mozilla.com/D174319
 2023-03-31 18:39:57 +00:00
steven wang
f6145d6708 Bug 1819334 - Display an error message when no importable resources can be found for a browser / profile pair. r=mconley,fluent-reviewers. 
Differential Revision: https://phabricator.services.mozilla.com/D173544
 2023-03-31 15:17:19 +00:00
Mike Conley
77137ac6ce Bug 1801981 - Use the word "favorites" instead of "bookmarks" when importing from IE / Edge. r=niklas,fluent-reviewers,flod 
Differential Revision: https://phabricator.services.mozilla.com/D173567
 2023-03-29 17:58:22 +00:00
CanadaHonk
de0de3489c Bug 1801379 - Migrate Sinon.jsm to an ES module r=extension-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,fxview-reviewers,devtools-reviewers,Standard8,nchevobbe,sclements,dimi,mconley,bytesized,robwu 
Migrated `testing/modules/Sinon.sys.mjs` to an ES module.

`testing` should now be 100% ESM 🎉

Differential Revision: https://phabricator.services.mozilla.com/D173643
 2023-03-29 07:34:10 +00:00
elephanteatsapple
ad08437d43 Bug 1822312 - Send brand images from each browser migrator class down to the Migration Wizard, and set the images in the panel-list / selector button. r=mconley 
Differential Revision: https://phabricator.services.mozilla.com/D173537
 2023-03-29 03:43:37 +00:00
elephanteatsapple
8b6cc15e4c Bug 1825110 - Add branding asset for Brave migrator. r=mconley 
Differential Revision: https://phabricator.services.mozilla.com/D173879
 2023-03-28 20:35:31 +00:00
Mike Conley
4c8c666841 Bug 1825024 - Make sure that the Select All checkbox is checked if all visible resources are checked, and unchecked otherwise. r=kpatenio 
Differential Revision: https://phabricator.services.mozilla.com/D173851
 2023-03-28 19:26:26 +00:00
Mike Conley
8df981ea97 Bug 1825009 - Make sure that Select All only checks resources that are visible. r=kpatenio 
This also adds some belt-and-suspenders checks here so that even if the Migration Wizard
somehow gets confused and sends resource types that the migrator can't import from, they'll
just get ignored rather than having a forever-progress-spinner for that resource type.

Differential Revision: https://phabricator.services.mozilla.com/D173848
 2023-03-28 19:26:26 +00:00
Norisz Fay
6c27e66d65 Backed out changeset 073659e911d4 (bug 1822133) for causing bc failures on browser_disabled_migrator.js 2023-03-28 21:24:46 +03:00
Nolan Ishii
eb01bd1b81 Bug 1822133 Write a test that checks that disabled migrators do not appear in the new Migration Wizard. r=mconley 
Differential Revision: https://phabricator.services.mozilla.com/D173854
 2023-03-28 17:02:49 +00:00
Mike Conley
eccb282189 Bug 1822676 - Have the new Migration Wizard request permissions if necessary for Safari import. r=NeilDeakin 
Differential Revision: https://phabricator.services.mozilla.com/D172840
 2023-03-27 20:08:54 +00:00
Cosmin Sabou
4b7311ed63 Backed out changeset fe5dd9d4dcbb (bug 1822676) for causing macOS shippable bc failures on browser_safari_permissions.js. 2023-03-27 21:21:39 +03:00
Mike Conley
034a782282 Bug 1794617 - Record interaction preferences when bookmarks, history, or passwords are imported. data-review=jhirsch,r=Gijs 
These preferences are sent via Telemetry through TelemetryEnvironment.

For the FirefoxProfileMigrator, which is used for profile resets, we don't
set these prefs during the migration of those resources. Instead, during
OTHERDATA, we examine the prefs.js of the old profile for the prefs and
attempt to migrate them to a new prefs file in the new profile.

Differential Revision: https://phabricator.services.mozilla.com/D173481
 2023-03-27 17:25:26 +00:00
Mike Conley
bd4fe113d7 Bug 1822676 - Have the new Migration Wizard request permissions if necessary for Safari import. r=NeilDeakin 
Differential Revision: https://phabricator.services.mozilla.com/D172840
 2023-03-27 16:51:12 +00:00
Iulian Moraru
16af5615b7 Backed out changeset 518a61189274 (bug 1822676) for causing doc-generate failures. CLOSED TREE 2023-03-27 19:12:29 +03:00
Mike Conley
5919c6fa99 Bug 1822676 - Have the new Migration Wizard request permissions if necessary for Safari import. r=NeilDeakin 
Differential Revision: https://phabricator.services.mozilla.com/D172840
 2023-03-27 14:48:39 +00:00
Alvin Lew
f8d7001c7d Bug 1818789 - Implement Safari / macOS permission wizard page for Passwords. r=mconley,fluent-reviewers,flod 
Differential Revision: https://phabricator.services.mozilla.com/D173540
 2023-03-27 13:15:12 +00:00
brian
f926608072 Bug 1820208 - Have MigrationWizardChild move the associated MigrationWizard to the No Browsers error page if no valid migrators are found after requesting them. r=mconley. 
Differential Revision: https://phabricator.services.mozilla.com/D173649
 2023-03-27 01:47:46 +00:00
Mark Banner
e8daad195d Bug 1824173 - Enable ESLint configuration valid-jsdocs across the tree, disabling for currently failing locations. r=mossop,webcompat-reviewers,extension-reviewers,credential-management-reviewers,denschub,dimi,robwu 
Depends on D173450

Differential Revision: https://phabricator.services.mozilla.com/D173451
 2023-03-24 19:35:25 +00:00
Mike Conley
3f1dad74c9 Bug 1823965 - Update success strings for HISTORY and FORMDATA resource imports in the new migration wizard. r=niklas,fluent-reviewers,flod 
Differential Revision: https://phabricator.services.mozilla.com/D173319
 2023-03-23 20:42:20 +00:00
Nolan Ishii
ed95067087 Bug 1822309 - Disable the 'Import' button in the selection page of the new Migration Wizard if no resource types are selected. r=mconley 
Differential Revision: https://phabricator.services.mozilla.com/D172810
 2023-03-22 15:55:01 +00:00
Mike Conley
e802dcf6c3 Bug 1823495 - Bring the panel-list dropdown in the new Migration Wizard closer to the spec. r=kpatenio 
Some of this styling requires us to hack around with inline styles from JS since
the <panel-list>, <panel-item>'s and <xul:panel> are slotted. Bug 1823489 has been
filed to investigate not using slotted items to make it easier to style using the
migration-wizard.css stylesheet instead.

Differential Revision: https://phabricator.services.mozilla.com/D173064
 2023-03-21 19:41:39 +00:00
Mike Conley
9aaa821f97 Bug 1823438 - Have Migration Wizard panel-list assume the selector button width as minimum. r=kpatenio 
Differential Revision: https://phabricator.services.mozilla.com/D173059
 2023-03-21 19:41:39 +00:00
Mike Conley
212e196f93 Bug 1823536 - Use the legacy migration wizard dialog for showing startup migration state after a profile refresh. r=NeilDeakin 
Differential Revision: https://phabricator.services.mozilla.com/D173084
 2023-03-21 15:29:01 +00:00
Mike Conley
e8af8e6305 Bug 1820790 - Generalize the 180 day history import limit, and apply it to IE and Edge (EdgeHTML) migrators. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D172718
 2023-03-21 15:18:34 +00:00
Mike Conley
c3739b9d73 Bug 1814278 - Align the spacing and layout of the new Migration Wizard more closely to the spec. r=kpatenio,fluent-reviewers,flod,settings-reviewers 
Along with bringing us closer to the layout and spacing from Figma, this does the following:

1. Changes the header element to an <h1> and uses CSS to get the expected font size. This should
   make the organization of the wizard make more sense to screenreaders.
2. Handles the "single resource" case for Variant 2, where we hide "Select All" and align the
   resource list to the left if there's only a single resource to import.
3. Fixes a string to match the spec.

Differential Revision: https://phabricator.services.mozilla.com/D173054
 2023-03-21 12:35:19 +00:00
Mike Conley
6efbf62ca8 Bug 1822692 - Add tests for migration wizard entrypoint telemetry. r=Gijs 
Depends on D172735

Differential Revision: https://phabricator.services.mozilla.com/D172815
 2023-03-20 21:55:15 +00:00
Mike Conley
3cbe4e6b38 Bug 1822692 - Introduce a categorical histogram for recording the Migration Wizard entrypoint. data-review=jhirsch, r=Gijs 
We're intentionally keeping the old FX_MIGRATION_ENTRY_POINT histogram around and
written to in order to have a smooth cutover to the new categorical histogram.

Differential Revision: https://phabricator.services.mozilla.com/D172735
 2023-03-20 19:45:34 +00:00
Mike Conley
0d347f3bbf Bug 1822686 - Add a browser profile selector button to the new Migration Wizard more closely aligned with the specification. r=kpatenio 
Differential Revision: https://phabricator.services.mozilla.com/D172832
 2023-03-20 16:42:26 +00:00
elephanteatsapple
2f039e6f10 Bug 1811933 -Replace placeholder <select> and <options> in MigrationWizard with a <button> and a <panel-list>. r=mconley,settings-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D170420
 2023-03-20 14:56:41 +00:00
steven wang
410aed13c6 Bug 1819167 - Put a message above the resource checkboxes in Variant 1 of the MigrationWizard. r=mconley,fluent-reviewers,flod. 
Differential Revision: https://phabricator.services.mozilla.com/D172524
 2023-03-16 14:14:07 +00:00
Angel_V129
df90d47fcf Bug 1814941 - Chrome - Don't list resources for import when those resources won't actually bring things over. r=kpatenio. 
Differential Revision: https://phabricator.services.mozilla.com/D169034
 2023-03-16 14:07:52 +00:00