Commit Graph

1424 Commits

Author SHA1 Message Date
Sandor Molnar
2899c1f4da Backed out changeset b463b9cd8aef (bug 1846036) for causing failures in toolkit/components/passwordmgr/test/mochitest/test_prompt.html CLOSED TREE 2023-08-05 02:15:47 +03:00
Neil Deakin
5e36a94898 Bug 1846036, replace usage of findLogins with searchLoginsAsync, r=credential-management-reviewers,sync-reviewers,joschmidt,markh
One caller in modifyLogin is switched to synchronous searchLogins, we can switch this later to add an asyncronous version of modifyLogin

Differential Revision: https://phabricator.services.mozilla.com/D184840
2023-08-04 18:36:03 +00:00
Natalia Csoregi
d056914a5b Bug 1840718 - Disabled browser_extension_migration.js for having a high failure rate almost exclusively on Windows 11. r=intermittent-reviewers,jmaher DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D185378
2023-08-04 01:06:17 +00:00
Gregory Pappas
e6625835b6 Bug 1846934 - Remove IE7FormPasswords migrator r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D185267
2023-08-03 19:07:06 +00:00
Gregory Pappas
cbc509b483 Bug 1846843 - Remove Windows 8 checks from WindowsVaultFormPasswords migrator r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D185209
2023-08-03 19:06:41 +00:00
Mike Conley
e0e8f038f1 Bug 1807023 - Record successfully matched and failed-to-match extension ids during import. data-review=chutten. r=willdurand
Differential Revision: https://phabricator.services.mozilla.com/D184512
2023-08-03 13:13:43 +00:00
Gregory Pappas
e9950eccfd Bug 1845311 - Use ChromeUtils.defineLazyGetter in more places r=arai,webdriver-reviewers,geckoview-reviewers,extension-reviewers,application-update-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,anti-tracking-reviewers,sessionstore-reviewers,pbz,joschmidt,robwu,issammani,bytesized,owlish,dao
Differential Revision: https://phabricator.services.mozilla.com/D184481
2023-07-26 16:28:11 +00:00
Mike Conley
86bb6d0916 Bug 1838432 - Only check for read permissions on Safari files when the files exist. r=mstriemer
Differential Revision: https://phabricator.services.mozilla.com/D183538
2023-07-25 13:26:22 +00:00
Mark Banner
d3d891e3d7 Bug 1845079 - Update more consumers to import ES modules directly. r=arai,settings-reviewers,credential-management-reviewers,sync-reviewers,sgalich
Differential Revision: https://phabricator.services.mozilla.com/D184371
2023-07-24 15:32:45 +00:00
Kelly Cochrane
ab66bdc5e6 Bug 1826604 - Add History empty states and banner in about:firefoxview-next r=mkaply,fxview-reviewers,sclements,bolsson
Differential Revision: https://phabricator.services.mozilla.com/D183197
2023-07-18 13:42:11 +00:00
Neil Deakin
8b3a54ba0f Bug 1807618, replace all usage of getAllLogins with the asynchronous version, removing the syncronous version, r=credential-management-reviewers,sync-reviewers,sgalich,skhamis
Differential Revision: https://phabricator.services.mozilla.com/D178406
2023-07-16 20:15:31 +00:00
Mike Conley
6ac3614ea7 Bug 1842605 - Handle errors in loading passwords from Safari CSV files. r=kpatenio,fluent-reviewers,bolsson
This also fixes some incorrect inline documentation I found in some of our tests,
and fixes a case where we were showing the warning state for importing bookmarks
in browser_safari_passwords.js.

Differential Revision: https://phabricator.services.mozilla.com/D183506
2023-07-13 20:55:05 +00:00
Mathew Hodson
3aa1fc98c1 Bug 1832733 - Unexpose sizeToContent() in Nightly. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D177867
2023-07-11 14:39:29 +00:00
Mike Conley
f2f2869242 Bug 1823489 - Have the migration-wizard element create the panel-list in its shadow root. r=kpatenio,negin,desktop-theme-reviewers,dao
This involves opening the shadow root of the migration wizard, as the panel-list
really isn't designed to handle being embedded within a closed shadow root.

Differential Revision: https://phabricator.services.mozilla.com/D182484
2023-07-10 18:31:19 +00:00
Cristina Horotan
90490ed96b Backed out 2 changesets (bug 1823489) for causing bc failures at browser_multistage_spotlight.js
Backed out changeset 684648252672 (bug 1823489)
Backed out changeset 15437d29bacc (bug 1823489)
2023-07-10 17:47:20 +03:00
Mike Conley
55bee439b7 Bug 1823489 - Have the migration-wizard element create the panel-list in its shadow root. r=kpatenio,negin,desktop-theme-reviewers,dao
This involves opening the shadow root of the migration wizard, as the panel-list
really isn't designed to handle being embedded within a closed shadow root.

Differential Revision: https://phabricator.services.mozilla.com/D182484
2023-07-10 13:34:04 +00:00
Stanca Serban
ecb95f5427 Backed out 2 changesets (bug 1823489) for causing multiple bc failures.
Backed out changeset da128472125a (bug 1823489)
Backed out changeset dd5996a4e7d2 (bug 1823489)
2023-07-08 21:11:49 +03:00
Mike Conley
3bccb141ec Bug 1823489 - Have the migration-wizard element create the panel-list in its shadow root. r=kpatenio,negin,desktop-theme-reviewers,dao
This involves opening the shadow root of the migration wizard, as the panel-list
really isn't designed to handle being embedded within a closed shadow root.

Differential Revision: https://phabricator.services.mozilla.com/D182484
2023-07-08 16:18:01 +00:00
Noemi Erli
043702d68b Backed out 2 changesets (bug 1823489) for causing failures in test_panel_list_min_width_from_anchor.html
Backed out changeset abe4ae7a4c01 (bug 1823489)
Backed out changeset ccb73c7c777a (bug 1823489)
2023-07-07 19:05:56 +03:00
Mike Conley
1d3fdc07d8 Bug 1823489 - Have the migration-wizard element create the panel-list in its shadow root. r=kpatenio,negin,desktop-theme-reviewers,dao
This involves opening the shadow root of the migration wizard, as the panel-list
really isn't designed to handle being embedded within a closed shadow root.

Differential Revision: https://phabricator.services.mozilla.com/D182484
2023-07-07 15:19:49 +00:00
Stanca Serban
edc8457447 Backed out 2 changesets (bug 1807618) for autocomplete related failures. CLOSED TREE
Backed out changeset 548365f1d102 (bug 1807618)
Backed out changeset 149b536f4fed (bug 1807618)
2023-07-06 01:27:55 +03:00
Neil Deakin
0688cd6017 Bug 1807618, replace all usage of getAllLogins with the asynchronous version, removing the syncronous version, r=credential-management-reviewers,sync-reviewers,sgalich,skhamis
Differential Revision: https://phabricator.services.mozilla.com/D178406
2023-07-05 19:24:40 +00:00
Mike Conley
55ce4f172e Bug 1840489 - Rename success-text class to message-text to reflect that non-success states can use that class. r=tgiles
Differential Revision: https://phabricator.services.mozilla.com/D182391
2023-07-05 14:35:15 +00:00
Mike Conley
2ca930cc08 Bug 1840792 - Be more resilient and timely when dealing with database corruption during Chrome browser import. r=kpatenio
This patch does two things:

1. It makes it so that a corrupt database doesn't result in several retries to
   requery the database, as it's extremely unlikely that a corrupt database is
   going to somehow get repaired in the interim.
2. It makes it so that if any Chrome-based browser resource fails to be acquired
   properly, it still allows other resources from the same (and other!) profiles
   to be imported.

Differential Revision: https://phabricator.services.mozilla.com/D182737
2023-07-04 20:43:09 +00:00
Mike Conley
73f229a967 Bug 1841506 - Make sure to run MigrationUtils.finishMigration when tearing down the migration wizard. r=kpatenio
This is needed in order to clear the gProfileStartup state after a startup
migration from a profile reset.

Differential Revision: https://phabricator.services.mozilla.com/D182733
2023-07-04 19:18:57 +00:00
Mike Conley
bf24e238c7 Bug 1840917 - Add a probe to measure how long it takes to show both the legacy and new migration wizard. data-review=jhirsch,r=tgiles
Differential Revision: https://phabricator.services.mozilla.com/D182389
2023-07-04 15:36:56 +00:00
Sandor Molnar
baa557ca94 Backed out changeset d4e89e0e7e9b (bug 1840917) for causing bc failures in browser/components/migration/tests/browser/browser_entrypoint_telemetry.js CLOSED TREE 2023-06-30 04:48:41 +03:00
Mike Conley
cd4dc3db2f Bug 1840917 - Add a probe to measure how long it takes to show both the legacy and new migration wizard. data-review=jhirsch,r=tgiles
Differential Revision: https://phabricator.services.mozilla.com/D182389
2023-06-29 23:57:26 +00:00
William Durand
daf67c6f7a Bug 1840843 - Handle Chrome extensions without a description in their manifest. r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D182353
2023-06-28 19:18:01 +00:00
Tim Giles
b55509e50c Bug 1839416 - Add SUMO link on how Firefox matches extensions. r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D182361
2023-06-28 18:20:58 +00:00
Mike Conley
875b2b901a Bug 1840488 - Change from classes to a state attribute for the migration wizard progress icon. r=tgiles,desktop-theme-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D182274
2023-06-28 16:46:19 +00:00
Mike Conley
a984381bf2 Bug 1840393 - Test that only Chrome (for now) offers extension importing. r=tgiles
Differential Revision: https://phabricator.services.mozilla.com/D182277
2023-06-28 14:15:46 +00:00
Mike Conley
81021b0f18 Bug 1839650 - Add more extension migration tests. r=niklas a=reland CLOSED TREE
Depends on D182116

Differential Revision: https://phabricator.services.mozilla.com/D182117
2023-06-27 16:14:04 +00:00
Mike Conley
ebf4a103b5 Bug 1839650 - Update browser_do_migration test to test extensions resource migration. r=niklas
Differential Revision: https://phabricator.services.mozilla.com/D182116
2023-06-27 16:14:04 +00:00
Iulian Moraru
35e017d832 Backed out 2 changesets (bug 1839650) for causing mochitest-chrome failures on test_history.html. CLOSED TREE
Backed out changeset da38525a017e (bug 1839650)
Backed out changeset 397a3150e68c (bug 1839650)
2023-06-27 22:28:09 +03:00
Mike Conley
78cb8a2b30 Bug 1840389 - Make sure to pass migrator key to GetExtensionsResource in ChromeProfileMigrator. r=kpatenio
Tests for this to be written in bug 1840393.

Differential Revision: https://phabricator.services.mozilla.com/D182018
2023-06-27 16:45:59 +00:00
Mike Conley
9c74548aa6 Bug 1839727 - Allow MigrationWizardChild to bind to a new <migration-wizard>. r=kpatenio,pdahiya
This is because about:welcome creates a new <migration-wizard> every time
the import card is navigated to. The change to MigrationWizardChild allows
it to re-bind to the most recently <migration-wizard> to fire one of its
events.

Differential Revision: https://phabricator.services.mozilla.com/D181903
2023-06-27 16:22:36 +00:00
Mike Conley
1c50fdedba Bug 1839650 - Add more extension migration tests. r=niklas
Depends on D182116

Differential Revision: https://phabricator.services.mozilla.com/D182117
2023-06-27 16:14:04 +00:00
Mike Conley
63f241d695 Bug 1839650 - Update browser_do_migration test to test extensions resource migration. r=niklas
Differential Revision: https://phabricator.services.mozilla.com/D182116
2023-06-27 16:14:04 +00:00
Mike Conley
e9bfd02ff6 Bug 1840108 - Fix InternalTestingProfileMigrator to work with extension migration. r=kpatenio
Differential Revision: https://phabricator.services.mozilla.com/D181896
2023-06-23 20:21:05 +00:00
negin
b882e48890 Bug 1837051 - Add Embedded Migration Wizard support for spotlight dialog r=omc-reviewers,pdahiya,mconley
Differential Revision: https://phabricator.services.mozilla.com/D180713
2023-06-23 19:23:51 +00:00
Mike Conley
22d6bfe4bf Bug 1838926 - Record interaction preference when CSV passwords are imported from the migration wizard. data-review=jhirssch,r=tgiles
Differential Revision: https://phabricator.services.mozilla.com/D181286
2023-06-23 14:14:26 +00:00
William Durand
409e3fa522 Bug 1839830 - Integrate AMBrowserExtensionsImport with the migration wizard UI. r=mconley,mixedpuppy
Depends on D181465

Differential Revision: https://phabricator.services.mozilla.com/D181747
2023-06-23 12:25:55 +00:00
Mike Conley
a049470152 Bug 1839827 - Display a generic error message for password and bookmark file migrations despite the exception. r=kpatenio,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D181801
2023-06-23 00:00:52 +00:00
Mike Conley
3f3eff7779 Bug 1839872 - Fix progress and success states for file migrators. r=kpatenio
In bug 1836555, we changed the progress update messages from MigrationWizardParent
from being a binary "in progress" and "not in progress" to a series of possible
values defined under MigrationWizardConstants.PROGRESS_VALUE.

We forgot to update the file migrators to use this, and they were still using
the old `inProgress` flag. This means that the migration occurred, but progress
updates weren't properly displayed.

We had a test for this, but the test was actually broken - it was querying for
the progress groups using a broken query selector. I've fixed the test, added
an additional check to ensure that the progress icons are in the completed
state, and confirmed that the test fails without the fix, and passes with it.

Differential Revision: https://phabricator.services.mozilla.com/D181783
2023-06-22 23:00:48 +00:00
Mike Conley
172ab2a94f Bug 1839462 - Add keyed histogram to record the number of matched extensions during migration. data-review=jhirsch, r=tgiles
Depends on D181566

Differential Revision: https://phabricator.services.mozilla.com/D181567
2023-06-22 13:48:51 +00:00
Mike Conley
669193a9a3 Bug 1839462 - Modify migration event telemetry for extensions migration. data-review=jhirsch, r=tgiles
Depends on D181298

Differential Revision: https://phabricator.services.mozilla.com/D181566
2023-06-22 13:48:51 +00:00
Norisz Fay
de0f4e32f7 Backed out 2 changesets (bug 1839462) as requested by dev CLOSED TREE
Backed out changeset a61155e9121f (bug 1839462)
Backed out changeset 99d02fe665aa (bug 1839462)
2023-06-21 23:42:10 +03:00
Mike Conley
b20bf5018f Bug 1839462 - Add keyed histogram to record the number of matched extensions during migration. data-review=jhirsch, r=tgiles
Depends on D181566

Differential Revision: https://phabricator.services.mozilla.com/D181567
2023-06-21 20:24:57 +00:00
Mike Conley
b02bff5657 Bug 1839462 - Modify migration event telemetry for extensions migration. data-review=jhirsch, r=tgiles
Depends on D181298

Differential Revision: https://phabricator.services.mozilla.com/D181566
2023-06-21 20:24:57 +00:00