Commit Graph

585 Commits

Author SHA1 Message Date
Niklas Baumgardner
db3d0dcc12 Bug 1774397 - Add notification dot to Firefox View button. r=Gijs,sfoster,desktop-theme-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D151401
2022-08-01 14:00:16 +00:00
Sam Foster
469917ce66 Bug 1776779 - Add mobile promo and success confirmation banner. r=Gijs,markh
* Add mobile promo element to the Fxa/sync setup flow, and logic to show/hide it
* Add success confirmation for the mobile sync connection with logic to show/hide it
* Watch a new pref 'browser.tabs.firefox-view.mobilePromo.dismissed' for the promo
* Add a new notification in FxAccountsDevice when the devicelist cache is updated
* Use the devicelist updated notification drive the state changes in the setup flow manager
* Add test coverage for the mobile promo

Differential Revision: https://phabricator.services.mozilla.com/D151895
2022-07-30 01:30:15 +00:00
Sam Foster
dc2bd1d8d0 Bug 1779328 - Use currentColor for favicons which support context-fill. r=sclements
Differential Revision: https://phabricator.services.mozilla.com/D153129
2022-07-29 15:05:54 +00:00
Butkovits Atila
315341ad55 Backed out changeset 698658fc606b (bug 1774397) for causing multiple mochitest failures. CLOSED TREE 2022-07-29 17:19:40 +03:00
Niklas Baumgardner
77492223d4 Bug 1774397 - Add notification dot to Firefox View button. r=Gijs,sfoster,desktop-theme-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D151401
2022-07-29 12:56:45 +00:00
Sarah Clements
1e419131ff Bug 1761782 - Firefox View colors update in response to theme changes r=dao
* Use contentTheme.js to dynamically update text and background colors in response to
theme changes, including from colorways modal

Differential Revision: https://phabricator.services.mozilla.com/D151043
2022-07-28 12:19:02 +00:00
Gijs Kruitbosch
6bc0ec0cd5 Bug 1780855 - update empty state strings and padding, r=sclements,flod
Differential Revision: https://phabricator.services.mozilla.com/D152573
2022-07-26 16:22:54 +00:00
Tooru Fujisawa
15758870e7 Bug 1780543 - Part 4: Add mozilla/remote-page environment. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D152429
2022-07-26 02:46:30 +00:00
Amy Churchwell
12b39c0b43 Bug 1780456 - Illustrations that are not square are distorted. r=dao
Differential Revision: https://phabricator.services.mozilla.com/D152317
2022-07-22 22:18:22 +00:00
Bernard Igiri
fda7bc00a6 Bug 1780047 - Make Colorway CTA in Fx View responsive r=dao
Added dynamic layout adjustments to Colorway CTA in Firefox View according to both S and L sizing as described in Figma.

Differential Revision: https://phabricator.services.mozilla.com/D152215
2022-07-22 15:14:13 +00:00
Dão Gottwald
59386d48fc Bug 1778556 - [Colorway Closet] Move colorway l10n from preview/ to browser/. r=flod,fluent-reviewers,extension-reviewers,rpl
Differential Revision: https://phabricator.services.mozilla.com/D152512
2022-07-22 15:05:44 +00:00
Sarah Clements
de861b6798 Bug 1779995 - Fix a bug in the dynamic timestamp feature and update tests r=sfoster
* arrow function is added back in for Tab Pickup and Recently Closed Tabs
* pref added to both files to make testing this feature possible

Differential Revision: https://phabricator.services.mozilla.com/D152010
2022-07-22 12:43:56 +00:00
Sam Foster
617a3d5b9c Bug 1780168 - Rename TabsPickupContainer to TabPickupContainer for consistency. r=sclements
Differential Revision: https://phabricator.services.mozilla.com/D152220
2022-07-21 22:47:35 +00:00
Sam Foster
e0acecab85 Bug 1780168 - Extract tabsSetupFlowManager to be a system ESM. r=Gijs
* Move the tabsSetupFlowManager into its own system ESM. This allows multiple about:firefoxview instances to have a single manager and syncronize state without duplication
* The first call to tabSetupFlowManager.initialize() will do any necessary setup to wait for sync & fxa services to be ready
* tabSetupFlowManager handles its own uninit
* Move TabsPickupContainer to match file naming convention for our other custom element modules
* TabsPickupContainer instances observe tabSetupFlowManager's notifications for state changes, and can request the current uiStateIndex directly.
* The utility openFxaSignup and openSyncPreferences functions now need know which window to open the URL in

Differential Revision: https://phabricator.services.mozilla.com/D152151
2022-07-21 22:47:35 +00:00
Dão Gottwald
436f2bb942 Bug 1780525 - [Colorway Closet] Port expiry pill layout adjustments to Firefox View and about:addons. r=amy
Differential Revision: https://phabricator.services.mozilla.com/D152363
2022-07-21 21:42:49 +00:00
Dão Gottwald
e4dbb93c18 Bug 1776546 - Rename "colorway-collection-expiry-date-span" l10n id. r=fluent-reviewers,extension-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D152364
2022-07-21 14:19:02 +00:00
Mark Banner
d026f430f6 Bug 1779982 - Migrate places consumers to use ESM imports directly. r=mak,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D152005
2022-07-20 22:34:21 +00:00
smolnar
ee079d37e2 Backed out 8 changesets (bug 1779982, bug 1780017, bug 1780347) for causing doc generate failures. CLOSED TREE
Backed out changeset 3f22c0f99cf1 (bug 1780347)
Backed out changeset 6f20b7e4b21b (bug 1780017)
Backed out changeset ae6062c69aeb (bug 1780017)
Backed out changeset e668d7778d97 (bug 1780017)
Backed out changeset e158fc41594b (bug 1780017)
Backed out changeset d4c69c956271 (bug 1779982)
Backed out changeset 145212fd826d (bug 1779982)
Backed out changeset 54079aaa1857 (bug 1779982)
2022-07-20 22:43:53 +03:00
Mark Banner
8715b062f5 Bug 1779982 - Migrate places consumers to use ESM imports directly. r=mak,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D152005
2022-07-20 15:50:40 +00:00
Iulian Moraru
bc13570de5 Backed out 7 changesets (bug 1779982, bug 1780017) for causing multiple failures. CLOSED TREE
Backed out changeset f33a58aa2f3f (bug 1780017)
Backed out changeset e21c85d61b91 (bug 1780017)
Backed out changeset 213ee5578e7c (bug 1780017)
Backed out changeset ea9b3bf42ea1 (bug 1780017)
Backed out changeset d2d8530f3c4d (bug 1779982)
Backed out changeset 088e5148c307 (bug 1779982)
Backed out changeset 267e08f3868a (bug 1779982)
2022-07-20 15:44:53 +03:00
Mark Banner
2bd76952c1 Bug 1779982 - Migrate places consumers to use ESM imports directly. r=mak,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D152005
2022-07-20 10:36:49 +00:00
Bernard Igiri
a1b720ac62 Bug 1779210 - Block outdated Colorways from showing in Firefox View r=Gijs
Added check to block outdated Colorways from showing in Firefox View.

Differential Revision: https://phabricator.services.mozilla.com/D151970
2022-07-18 11:21:56 +00:00
Bernard Igiri
cbd7df1750 Bug 1776221 - Added auto update of Colorway CTA on theme change r=sfoster
With this fix changing the Colorway theme should automatically update the Colorway CTA in Firefox View. Additionally, the Colorways portion of firefoxview.mjs has been migrated to colorways-card.mjs and restructured to match the style of the rest of the Firefox View codebase.

Differential Revision: https://phabricator.services.mozilla.com/D150878
2022-07-15 21:36:56 +00:00
Gijs Kruitbosch
5418a144d3 Bug 1764816 - handle esoteric URLs in Firefox View (blob/file/data/ip addresses), r=sfoster,sclements,fluent-reviewers,jaws
Differential Revision: https://phabricator.services.mozilla.com/D151718
2022-07-14 17:38:45 +00:00
Sam Foster
62ff6578b7 Bug 1779204 - Fix what is shown/hidden when synced tabs data is loading. r=Gijs,sclements
* Add some additional steps and assertions in the test that would catch the case where synced tabs are already showing and we sync again

Differential Revision: https://phabricator.services.mozilla.com/D151678
2022-07-13 19:24:54 +00:00
Norisz Fay
d9002d885b Backed out changeset 4ad72b0c451f (bug 1776221) for causing bc failures on browser_colorways_card.js CLOSED TREE 2022-07-13 20:17:42 +03:00
Sarah Clements
3ca9669ab1 Bug 1774793 - Firefox view list timestamps should automatically update r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D151363
2022-07-13 16:30:56 +00:00
Bernard Igiri
cb1b4cc87f Bug 1776221 - Added auto update of Colorway CTA on theme change r=dao
With this fix changing the Colorway theme should automatically update the Colorway CTA in Firefox View. Additionally, the Colorways portion of firefoxview.mjs has been migrated to colorways-card.mjs and restructured to match the style of the rest of the Firefox View codebase.

Differential Revision: https://phabricator.services.mozilla.com/D150878
2022-07-13 14:12:04 +00:00
Tooru Fujisawa
328d63ce7f Bug 1777486 - Part 2: Migrate XPCOMUtils.jsm consumers with automatic migration. r=webdriver-reviewers,geckoview-reviewers,preferences-reviewers,application-update-reviewers,pip-reviewers,kmag,owlish,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D151214
2022-07-12 04:21:34 +00:00
Andreea Pavel
f009ba2983 Backed out 11 changesets (Bug 1777486) for failing bc at browser_startup.js on a CLOSED TREE
Backed out changeset b6c4c386f1a6 (Bug 1777486)
Backed out changeset 195cc2de8433 (Bug 1777486)
Backed out changeset 20c746fb1648 (Bug 1777486)
Backed out changeset d5fd8173d62d (Bug 1777486)
Backed out changeset 6d758fab5a3e (Bug 1777486)
Backed out changeset e938b601ba15 (Bug 1777486)
Backed out changeset 0c4ea0b9416b (Bug 1777486)
Backed out changeset 0559c53cc668 (Bug 1777486)
Backed out changeset eea573d3a9f9 (Bug 1777486)
Backed out changeset 9ce3a6496a49 (bug 1777486)
Backed out changeset b0867652fc48 (bug 1777486)
2022-07-11 22:24:40 +03:00
Tooru Fujisawa
bf0a8b781b Bug 1777486 - Part 2: Migrate XPCOMUtils.jsm consumers with automatic migration. r=webdriver-reviewers,geckoview-reviewers,preferences-reviewers,application-update-reviewers,pip-reviewers,kmag,owlish,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D151214
2022-07-11 15:09:13 +00:00
Tooru Fujisawa
0cdb4cc2a8 Bug 1667455 - Part 7: Stop importing Services.jsm from chrome-priv JS code, lazy cases. r=kmag
Differential Revision: https://phabricator.services.mozilla.com/D150896
2022-07-11 12:41:51 +00:00
Tooru Fujisawa
48c568867c Bug 1667455 - Part 5: Stop importing Services.jsm from chrome-priv JS code, top-level single-line cases. r=kmag,webdriver-reviewers,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,extension-reviewers,application-update-reviewers,pip-reviewers,twisniewski,m_kato,jdescottes,mconley,AlexandruIonescu,mossop
Differential Revision: https://phabricator.services.mozilla.com/D150894
2022-07-11 12:41:50 +00:00
Sarah Clements
46ee65f0ff Bug 1774168 - Add empty list placeholder and collapsible container to Tab Pickup r=sfoster,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D150738
2022-07-07 16:08:07 +00:00
Bernard Igiri
958a0d0bb4 Bug 1776682 - Localize Colorway CTA in Firefox View r=dao,fluent-reviewers,flod
Applied Colorway localization from Bug 1770030 to Colorway CTA in Firefox View.

Differential Revision: https://phabricator.services.mozilla.com/D150862
2022-07-07 12:30:17 +00:00
Mark Banner
76af8b0f69 Bug 1777451 - Add a rule to prevent/recommend against using globalThis or window in non-system modules for lazy getters. r=arai
Differential Revision: https://phabricator.services.mozilla.com/D151083
2022-07-06 08:35:59 +00:00
Bernard Igiri
8e5ef31e52 Bug 1777466 - Added image display for selected colorway to FX View r=dao
Added image display for selected colorway to FX View

Differential Revision: https://phabricator.services.mozilla.com/D150748
2022-07-01 17:00:30 +00:00
Dão Gottwald
39b4efcb2d Bug 1770030 - [Colorway Closet] Localize colorway names and descriptions. r=kpatenio,extension-reviewers,flod,rpl,mixedpuppy
Differential Revision: https://phabricator.services.mozilla.com/D150510
2022-06-30 19:44:31 +00:00
Mark Banner
92e99fe0ba Bug 1777445 - Move firefoxview to use mjs files, rather than defining sourceType for ESLint. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D150734
2022-06-30 10:13:01 +00:00
Bernard Igiri
bb020f651c Bug 1777310 - Added Colorway CTA image to FX View r=dao
Added Colorway CTA image to FX View

Differential Revision: https://phabricator.services.mozilla.com/D150677
2022-06-30 04:00:40 +00:00
Sarah Clements
1f2c71a667 Bug 1775469 - Add empty list item placeholder for Tab Pickup Section r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D150234
2022-06-29 15:42:49 +00:00
Bernard Igiri
79a2241a83 Bug 1773322 - Implement Colorways CTA for active Colorway r=dao,fluent-reviewers,Gijs
Implemented Colorway CTA in Firefox View for when a Colorway is active.

Differential Revision: https://phabricator.services.mozilla.com/D149175
2022-06-28 13:30:03 +00:00
smolnar
be43be4024 Backed out changeset 7300b86fba9e (bug 1775469) for causing browser-chrome failures in browser/components/firefoxview/tests/browser/browser_tab_pickup_list.js CLOSED TREE 2022-06-28 14:23:27 +03:00
Sarah Clements
c9b94fdcb2 Bug 1775469 - Add empty list item placeholder for Tab Pickup Section r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D150234
2022-06-28 10:00:40 +00:00
Sam Foster
fff37f0fd0 Bug 1772278 - Add the sumo URLs for the 'learn more' links in the FxA/sync setup flow. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D150293
2022-06-27 18:55:10 +00:00
Sam Foster
8687fa107b Bug 1774013 - Apply the right min-width so buttons in the fx-view setup flow don't get clipped. r=Gijs,sclements
Differential Revision: https://phabricator.services.mozilla.com/D150048
2022-06-23 18:32:10 +00:00
Sarah Clements
07b6165b84 Bug 1774169 - Add observer, keyboard nav & tests to Tab Pickup list r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D149991
2022-06-23 14:31:35 +00:00
Sam Foster
a324dbf2a8 Bug 1774015 - Adjust layout for fxview. r=Gijs
* Set root element font-size to 15px to align with the size we set on body (in common-shared.css), allowing predictability when scaling and zoom-friendly (rem) widths
* Remove the <main> grid column-gap and manage padding/gutter around/between content areas with the --content-area-gutter variable
* Use a consistent 32px between content areas
* Simplify <main> grid to 2 columns with 2/3, 1/3 width respectively.
* Add a max-width to the page content to correspond to 1440px and horizontally center it in larger viewports
* Move the colorways content inside right-most column (grid slot) rather than *be* the column.

Differential Revision: https://phabricator.services.mozilla.com/D149457
2022-06-22 23:50:55 +00:00
Cristian Tuns
e14eba8363 Backed out changeset 2426eb39bdb7 (bug 1774169) for causing mochitest failures on browser_newtab_userTypedValue.js CLOSED TREE 2022-06-22 10:34:11 -04:00
Sarah Clements
87ec255ef4 Bug 1774169 - Add observer, keyboard nav & tests to Tab Pickup list r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D149991
2022-06-22 13:35:13 +00:00