Commit Graph

476 Commits

Author SHA1 Message Date
L. David Baron
67ba264870 Backed out changeset 046f5da25280 due to crash in layout/forms/test/ mochitests. 2009-01-13 17:47:03 -08:00
L. David Baron
4ffdcdc475 When re-resolving style, re-resolve root in undisplayed map too. (Bug 473042) r+sr=bzbarsky 2009-01-13 11:50:41 -08:00
Benjamin Smedberg
0f95227641 Bug 396185 - Make nsIFrame derivatives and helper abstract classes use a different dynamic-cast system than nsISupports:
* we know all types frames may be cast to at compile time, so instead of extensible GUID IIDs, use a big enum (see nsQueryFrame::FrameIID)
* eliminate all vestiges of refcounting, since frames aren't refcounted

Some frames (SVG frames in particular) still implement nsISupports-derived interfaces, for example nsISVGValue. There is a FrameIID for nsISVGValue that lets you go from a frame to the XPCOM interface, but you can't query back.

r+sr=roc

nsITextControlFrame didn't have an IID the first time around, but this wasn't a compile error because nsITextControlFrame::kFrameIID inherited from nsIFormControlFrame::kFrameIID. I've added a static analysis pass to verify the correct behavior, since I can't figure out a way to make the compiler do it.
2009-01-12 14:20:59 -05:00
Mats Palmgren
8b484f4af9 Put the root element in the undisplayed map so that we reconstruct it when it has its 'display' changed from 'none' to something else. (Bug 283686) r+sr=bzbarsky 2009-01-10 08:28:15 -08:00
Benjamin Smedberg
7a084ac404 Backed out changeset 4c4df6ed1b41 - Bug 396185 - Make nsIFrame not inherit from nsISupports due to mochitest failures... these appear to be crashes in nsGenericHTMLElement::GetEditorInternal. 2009-01-09 11:35:24 -05:00
Benjamin Smedberg
991a16d8bc Bug 396185 - Make nsIFrame derivatives and helper abstract classes use a different dynamic-cast system than nsISupports:
* we know all types frames may be cast to at compile time, so instead of extensible GUID IIDs, use a big enum (see nsQueryFrame::FrameIID)
* eliminate all vestiges of refcounting, since frames aren't refcounted

Some frames (SVG frames in particular) still implement nsISupports-derived interfaces, for example nsISVGValue. There is a FrameIID for nsISVGValue that lets you go from a frame to the XPCOM interface, but you can't query back.

r+sr=roc

This patch locally causes two REFTEST-UNEXPECTED-PASS for Bidi stuff. It's possible that I accidentally fixed a bug, but I'm not sure, so I'm going to wait for the tinderboxes to confirm my local results.
2008-11-05 14:25:30 -05:00
L. David Baron
4dc1cd9094 Fix assertion in bug 468645, per bzbarsky's followup review comment. r+sr=bzbarsky 2009-01-04 14:52:38 -05:00
L. David Baron
faa0746315 Pass the correct parent content when re-resolving the inner table for a display:table pseudo-element (:before or :after). (Bug 468645) r+sr=bzbarsky 2008-12-29 10:07:37 -05:00
L. David Baron
e6b1e51836 Fix style context invariants so we can re-resolve page break frames. (Bug 468645) r+sr=bzbarsky 2008-12-29 10:07:36 -05:00
Robert O'Callahan
3ea5398d9e Bug 455314. nsSVGRenderingObserver::GetReferencedFrame shouldn't try to look up the frame on a cache miss, if we're currently destroying frames. r+sr=mats 2008-12-12 21:25:16 +13:00
Graeme McCutcheon
68d99f9eba Bug 215405. Restore scroll position, but not form state, on no-store and SSL no-cache sites. r+sr=bzbarsky 2008-12-03 12:55:14 -05:00
Mats Palmgren
82461550e3 Delete mNext iteratively to avoid blowing up the stack. b=460461 r+sr=dbaron 2008-11-02 17:05:14 +01:00
L. David Baron
e7ff044de6 Merge backout of changeset 23eebebb8b48 (from bug 322475, which made us construct all our image loaders at frame construction time) because of issues with propagation of backgrounds to the canvas (bug 460796). 2008-10-28 14:36:44 -07:00
L. David Baron
3d410b3fa9 Backed out changeset 23eebebb8b48 (from bug 322475, which made us construct all our image loaders at frame construction time) because of issues with propagation of backgrounds to the canvas (bug 460796). 2008-10-28 14:36:17 -07:00
Mats Palmgren
d8910799ba Fix a couple of compile warnings. b=460468 r+sr=roc 2008-10-18 19:35:39 +02:00
Mats Palmgren
80c08b3389 DEBUG: Use a flag to track when we are inside RemoveFrame() and assert it's false in GetPrimaryFrameFor(). b=458636 r+sr=roc 2008-10-13 00:05:04 +02:00
L. David Baron
34a4887a9b Construct all our image loaders when we create frames so that we can allow arbitrary numbers of image loaders per frame (for multiple background images). (Bug 322475) r+sr=bzbarsky 2008-10-11 20:49:42 -04:00
Arpad Borsos
1b55360c07 Bug 456388 - Remove PR_STATIC_CALLBACK and PR_CALLBACK(_DECL) from the tree; r+sr=brendan 2008-10-10 17:04:34 +02:00
L. David Baron
233883e095 Fix a bunch of issues relating to dynamic changes of border images. (Bug 445810) r=robarnold sr=bzbarsky 2008-07-26 09:14:49 -07:00
1c8607b1e0 Force reflow on default font change, since style data comparison is not sufficient for things not reflected in style data. b=394057 r+sr=roc a=blocking1.9+ 2008-02-08 11:52:46 -08:00
7f1beaf030 get rid of nsStyleStruct base type. b=408933, r+sr=dbaron, a=beltzner 2008-01-10 12:56:49 -08:00
4456d3cc53 update last continuation assertion to account for overflow container continuations b=399687 r+sr=roc a=beltzner 2007-11-12 11:05:42 -08:00
5d9f3dd84d Implement hixie's first-line proposal: only inherit properties that inherit by default from ::first-line. Inherit the reset properties from its style parent (which is the node that we'd inherit from if the ::first-line were not there). Bug 395623, r+sr=dbaron, a=beltzner 2007-11-07 09:13:00 -08:00
25179a8425 Bug 399384: Make first-letter frames use nearest ancestor blockFrame's content node, instead of direct parent's. r=bzbarsky, r+a=roc 2007-10-19 10:41:29 -07:00
b2384da643 Elimninate the last known source of bogus "wrong parent style context" warnings, and make these warnings into assertions. Bug 374297, r+sr+a=dbaron 2007-10-08 19:45:10 -07:00
2b88818524 Make sure we always resolve style contexts with the right parent. Bug 390689, r+sr+a=dbaron 2007-10-03 19:58:48 -07:00
9011ed7502 paginate absolutely-positioned elements, b=154892 r+sr=roc a=roc 2007-10-01 22:57:45 -07:00
82b997b0b0 Bug 391847. Coalesce accessible mutation events for the same subtree. r=ginn.chen, sr=bz, a=bz 2007-08-14 11:47:49 -07:00
c712323ffd Bug 390692. Fix live region support to provide useful information on the node that's being shown or hidden, or has a text change event. r=ginn.chen, sr=roc, a=roc 2007-08-10 18:44:44 -07:00
e7aaf35d8f Backing out bug 275196, xml:id, to fix tp regression 2007-07-26 07:16:19 -07:00
2156f3dd89 Bug 275196, xml:id, r=sicking, sr=dbaron 2007-07-26 05:22:01 -07:00
da6d55cdc6 Make attribute changes that also cause a state change properly reresolve style
when a selector uses both the state and the attribute.  Bug 315920, r=dbaron,
sr=sicking.
2007-07-12 13:05:45 -07:00
98de634631 Bug 348748 - Replace all instances of NS_STATIC_CAST and friends with C++ casts (and simultaneously bitrot nearly every patch in existence). r=bsmedberg on the script that did this. Tune in next time for Macro Wars: Episode II: Attack on the LL_* Macros. 2007-07-08 00:08:04 -07:00
0f08b75950 Remove unused getKey callback from PLDHashTableOps/JSDHashTableOps. b=374906 r=bsmedberg 2007-03-27 08:33:38 -07:00
sharparrow1@yahoo.com
8b76f791bf Bug 371536: Stop creating views for positioned elements. r+sr=roc. 2007-02-26 14:00:21 +00:00
jonas@sicking.cc
7a41bbf68d Bug 370332: Kill nsIBindingManager and nsIStyleRuleSupplier. r=dbaron for the layout/style parts, r/sr=jst for the rest. 2007-02-16 23:02:08 +00:00
cvshook@sicking.cc
e80f1dba4e Kill remainders of ns(XBL|HTML|XUL|Layout)Atoms. r/sr=jst b=368128 2007-01-30 00:06:41 +00:00
timeless@mozdev.org
f4ef17d178 Bug 355300 There should be only one nsGkAtoms creature
r=dbaron
2006-12-26 17:47:52 +00:00
roc+@cs.cmu.edu
6cb241d14f Bug 363813. Reparent style contexts for special-siblings because they may depend on our frame's style context. r+sr=dbaron 2006-12-21 20:03:09 +00:00
dbaron@dbaron.org
d21cb374bd Bug 300030: Move intrinsic width computation out of nsIFrame::Reflow and into its own methods on nsIFrame. Replace reflow reasons, types, and commands with dirty bits/notifications. Thanks to bzbarsky for almost all of the HTML form controls (mozilla/layout/forms) changes, and many others for help testing and patching. For detailed commit logs, see REFLOW_YYYYMMDD_BRANCH, where YYYYMMDD is one of 20061031, 20060830, 20060603, 20060302, 20060119, 20051011, 20050804, 20050429, 20050315, 20050111, and 20041213. 2006-12-08 05:38:33 +00:00
bzbarsky@mit.edu
16fe90d4c2 Make ReconstructDocElementHierarchy work correctly even if we first blew away a
pseudo which had the root as its content.  Bug 343293, r+sr=roc
2006-12-04 20:35:55 +00:00
bzbarsky@mit.edu
b2fb39fae7 When doing ContentRemoved, IndexOf() will always return -1. So don't use it.
Bug 360524, r+sr=roc
2006-11-13 21:27:44 +00:00
bzbarsky@mit.edu
5f6f3dc247 Add asserts and documentation to enfoce correct behavior. Bug 316267 followup,
r+sr=roc.
2006-11-06 01:17:32 +00:00
aaronleventhal@moonset.net
93baf2fc47 Fixing bustage 2006-10-05 15:07:54 +00:00
aaronleventhal@moonset.net
b89725be55 Bug 354745. Show/hide events not fired for layout changes in a changelist. r+sr=bz 2006-10-05 13:35:23 +00:00
bzbarsky@mit.edu
d3c5e68677 Fix the way we do notifications so we don't notify twice for <head>. Bug
332644, r=mrbkap, sr=peterv
2006-05-12 20:36:39 +00:00
darin@meer.net
0700b87ece landing patch for bug 326273 "Implement nsIThreadManager" (Mac portions by Mark Mentovai) with reviews from bienvenu, bsmedberg, bzbarsky, josh, roc, and ssieb 2006-05-10 17:30:15 +00:00
cvshook@sicking.cc
5df20de104 Bug 335911: Change nsIContent::IsContentOfType to nsINode::IsNodeOfType. r/sr=bz 2006-05-05 06:52:21 +00:00
roc+@cs.cmu.edu
24f6f0ed12 Bug 328926. Remove aPresContext parameter from nsIFrame::Destroy, nsIFrame::SetInitialChildList and nsIFrame::RemovedAsPrimaryFrame. patch by Marc Liddell, r+sr=roc 2006-04-10 00:16:29 +00:00
uriber@gmail.com
22e9c20f19 Bug 331958: Crash when selecting text, using rtl object with css generated content and designMode. r+sr=dbaron 2006-04-08 14:17:35 +00:00