We're flashing a warning message "NO video with supported format and MIME type
found." when we're loading a YouTube page in Fennec. This is because YouTube
are calling load() on a video element with no src attribute or source children
in a click handler in order to defeat the "requires user interaction to play"
restrictions on mobile Chrome and Safari in that video element.
We're showing the warning message to help developers diagnose why loads are
unintentionally failing. However, the behaviour that YouTube are doing is
intentional, and YouTube are likely to not be the only ones doing this. So we
should change our video controls to not display the warning message in this
case. We should be compatible with other browsers.
We'll still log a debug message to the browser console as to why the load
is failing, to help developers who hit this unintentionally.
MozReview-Commit-ID: IpugbMOloJt
Since the UI is now changed in listeners inside the system group, they
are invoked after the listeners added by the content. Because of that,
UI check needs to be asynchronously, otherwise we would be checking the
state before videocontrols update. For the same reason, mouse/keyboard
operations need to be invoked asynchronously as well, otherwise they
would be applied based on the UI before update. This shouldn't change
what is tested here, as user inputs are asynchronous by nature.
MozReview-Commit-ID: 4h9Oa9qMVc5
Listeners in the system group are invoked after listeners in the default
group, so we can check defaultPrevented synchronously, and we have to
change the play state according to the state of the play button.
Due to the same reason above, we need to check the UI async in tests.
MozReview-Commit-ID: Bs4MZvGefJj
The size is reduced by making the message only carry the count of blocked popups, and not the full list of popup URLs that were blocked. The parent becomes responsible for retrieving the list from the child when it needs to display it.
MozReview-Commit-ID: DsxLFD8iE3t
CLOSED TREE
Backed out changeset 788365ddaf61 (bug 1274520)
Backed out changeset 6c204be833d1 (bug 1274520)
Backed out changeset 4f15271e5488 (bug 1274520)
This patch was generated by the command:
find * -type f -exec sed -i -f ../mozpropsub {} \;
in the root of the repository, with the file ../mozpropsub containing:
s/-moz-padding-end\>/padding-inline-end/g
s/-moz-padding-start\>/padding-inline-start/g
s/-moz-margin-end\>/margin-inline-end/g
s/-moz-margin-start\>/margin-inline-start/g
s/-moz-border-end\>/border-inline-end/g
s/-moz-border-end-color\>/border-inline-end-color/g
s/-moz-border-end-style\>/border-inline-end-style/g
s/-moz-border-end-width\>/border-inline-end-width/g
s/-moz-border-start\>/border-inline-start/g
s/-moz-border-start-color\>/border-inline-start-color/g
s/-moz-border-start-style\>/border-inline-start-style/g
s/-moz-border-start-width\>/border-inline-start-width/g
s/\<MozPaddingEnd\>/paddingInlineEnd/g
s/\<MozPaddingStart\>/paddingInlineStart/g
s/\<MozMarginEnd\>/marginInlineEnd/g
s/\<MozMarginStart\>/marginInlineStart/g
s/\<MozBorderEnd\>/borderInlineEnd/g
s/\<MozBorderEndColor\>/borderInlineEndColor/g
s/\<MozBorderEndStyle\>/borderInlineEndStyle/g
s/\<MozBorderEndWidth\>/borderInlineEndWidth/g
s/\<MozBorderStart\>/borderInlineStart/g
s/\<MozBorderStartColor\>/borderInlineStartColor/g
s/\<MozBorderStartStyle\>/borderInlineStartStyle/g
s/\<MozBorderStartWidth\>/borderInlineStartWidth/g
The diffs for the following files:
layout/style/nsCSSPropAliasList.h
layout/style/test/property_database.js
layout/style/test/test_value_computation.html
were then manually removed from the patch.
MozReview-Commit-ID: 8fbYnlZcn9U
