Commit Graph

2639 Commits

Author SHA1 Message Date
Florian Queze
6cc0b6e992 Bug 1355056 - replace (function(args) { /* do stuff using this */ }).bind(this) with arrow functions, r=jaws. 2017-04-27 00:25:45 +02:00
Jared Wein
e7ac863d1c Bug 1359849 - Guard against exceptions thrown while cleaning up the video controls. r=gijs
MozReview-Commit-ID: 2cwIE7Xdp7O
2017-04-26 12:36:34 -04:00
Jessica Jong
b47d720978 Bug 1301310 - Hide input date/time picker only when input element blurs. r=mossop
If we rely on XUL panel's default behavior, the picker is hidden and opened
again when we jump from one inner field to another with a mouse click, this is
because XUL pannel gets hidden when user clicks outside it with
noautohide=false. In order to avoid this, we should close it explicitly only
when input element blurs.

MozReview-Commit-ID: GxPxd0wPWgM
2017-04-20 15:04:10 +08:00
Florian Queze
46616cd166 Bug 1357061 - remove potentially useless ensureElementIsVisible call (that currently causes a sync reflow) when an arrowscrollbox handles an underflow event, r=dao. 2017-04-19 23:09:34 +02:00
Marco Bonardo
03626ed85f Bug 1356285 - micro-optimization in richlistbox selectedIndex setter. r=enndeakin+6102
MozReview-Commit-ID: 6fnhubnDUZ1
2017-04-13 19:01:48 +02:00
Florian Queze
ddf0cda8da Bug 1355161 - script-generated patch to replace .{currentThread,mainThread}.dispatch(..., Ci.nsIThread.DISPATCH_NORMAL) with .dispatchToMainThread(...), r=froydnj. 2017-04-14 18:29:12 +02:00
Kris Maglione
ab1c97a5f5 Bug 1317697: Fix reference to undefined property warnings. r=mixedpuppy
MozReview-Commit-ID: vngYhAOgbV
2017-04-13 15:10:23 -07:00
Florian Queze
3168acdda1 Bug 1356569 - Update the no-useless-parameters eslint rule to report trailing optional parameters for addObserver, appendElement and notifyObservers, r=jaws. 2017-04-14 21:51:40 +02:00
Florian Queze
d3c36892fa Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws. 2017-04-14 21:51:38 +02:00
Sebastian Hengst
4cd95d4a02 Backed out changeset 18d45aa984d6 (bug 1355161) 2017-04-14 23:39:23 +02:00
Sebastian Hengst
42670ceca0 Backed out changeset 322fde2d53bf (bug 1356569) so bug 1355161 can be backed out. r=backout 2017-04-14 23:39:22 +02:00
Sebastian Hengst
bd45d9fed8 Backed out changeset c724e1485608 (bug 1356569) 2017-04-14 23:39:15 +02:00
Florian Queze
a69f5bd324 Bug 1356569 - Update the no-useless-parameters eslint rule to report trailing optional parameters for addObserver, appendElement and notifyObservers, r=jaws. 2017-04-14 21:51:40 +02:00
Florian Queze
9b4f73599f Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws. 2017-04-14 21:51:38 +02:00
Florian Queze
35cd8ba883 Bug 1355161 - script-generated patch to replace .{currentThread,mainThread}.dispatch(..., Ci.nsIThread.DISPATCH_NORMAL) with .dispatchToMainThread(...), r=froydnj. 2017-04-14 18:29:12 +02:00
Florian Queze
96125eca5e Bug 1353563 - Avoid calling getBoundingClientRect from adjustSiteIconStart, r=mak. 2017-04-14 17:15:20 +02:00
Jessica Jong
b668a5e487 Bug 1320227 - [DateTimeInput] Localize placeholders for <input type=date>. r=mossop
MozReview-Commit-ID: Bn0xjuuVhgU
2017-04-11 15:24:23 +08:00
Masayuki Nakano
183fb59ce4 Bug 1349828 Smooth scroller of <scrollbox> should not try to scroll to outside of the range r=mstange
The scroll destination of the smooth scroller of <scrollbox> can be outside of the actual scrollable range.  Therefore, it doesn't make scroll slower even when the end appears.

This patch makes the destination always in the scrollable range.

MozReview-Commit-ID: CfEGzhG7Jh7
2017-04-10 19:56:40 +09:00
Drew Willcoxon
3099774257 Bug 1295458 - Rework key and mouse handling for the one-off search buttons. r=florian
MozReview-Commit-ID: DKbU8r2BrA8
2017-04-11 08:40:11 -07:00
Jared Wein
ffb4cdda2c Bug 1354196 - Forward the text-shadow CSS property to the select popup for styling. r=mossop
MozReview-Commit-ID: 3jzZOIiJyXT
2017-04-10 16:03:03 -04:00
Mark Striemer
3e713a9229 Bug 1329942 - Fix alignment of webextensions permissions doorhanger r=florian
MozReview-Commit-ID: K0YM26lgOY5
2017-02-28 15:26:12 -06:00
Jared Wein
1e51b20488 Bug 1355211 - Scroll events should be prevented in all cases except when allowunderflowscroll is true and the scrollbar is hidden. r=enndeakin+6102
MozReview-Commit-ID: GXhf9bM6ZIo
2017-04-10 16:45:33 -04:00
Kaku Kuo
5a08bb3972 Bug 1354465 P2 - use mozvideoonlyseekbegin event to start throbber timer; r=jaws,jwwang
MozReview-Commit-ID: 4zwcoB8M3xI
2017-04-07 18:06:20 +08:00
Marco Bonardo
2ac33d24f7 Bug 1353708 - Avoid autocomplete call to richlistbox's ensureElementIsVisible when there can't be a scrollbar. r=florian
EnsureElementIsVisible can cause a Layout flush, so we should try to avoid it when possible.

MozReview-Commit-ID: Dr0D8vPl9rd
2017-04-05 18:45:16 +02:00
Jessica Jong
25b328a566 Bug 1346085 - Part 3: RTL support for date/time input box. r=gandalf,mossop
Set the .dir property of the input box wrapper to `rtl` if this is a RTL
locale.

MozReview-Commit-ID: D2qJVjvzxNW
2017-04-05 15:02:37 +08:00
Jessica Jong
100fa585bf Bug 1346085 - Part 2: Set input element's focus state when inner fields are focused/blurred. r=smaug
Since the inner fields of date/time input are now <span> instead of <input>
text, we are adding an API for binding code to set the focus state of the
bound input element when inner fields are focused/blurred.

MozReview-Commit-ID: 9wvu57xT6HZ
2017-04-05 15:02:30 +08:00
Jessica Jong
3fea189cdd Bug 1346085 - Part 1: Use <span> for editable fields in date/time input box. r=mossop
When adding support for RTL in date/time input box, we noticed that bidi text
was not displayed properly with mixed of inline and block elements. By
changing our editabled fields from <input> to <span>, we can rely on bidi
algorithm and markups to display the inner fields in the right order.

MozReview-Commit-ID: 7r8OVSJXJRU
2017-04-05 15:00:13 +08:00
Jared Wein
902f0f9250 Bug 1348828 - Only prevent default behavior of scroll event if the tree is scrollable. r=enndeakin+6102
MozReview-Commit-ID: AGS103gy08O
2017-04-03 21:51:11 -04:00
Kaku Kuo
4228a1f7f3 Bug 1350852 P2 - use mozvideoonlyseekcompleted to cancel throbber while resuming video decoder; r=jaws,jwwang
MozReview-Commit-ID: CV3LsfA6s1O
2017-03-27 18:22:55 +08:00
Ray Lin
35d419ea30 Bug 1350191 - Change keypress event propagation to capture to correctly preventDefault if control is focused. r=jaws
We could not avoid controls being focused after De-XUL, in order
to preventDefault before event propagate to focused control, we should
change the way of keypress event propagation in media controls.

MozReview-Commit-ID: 4KNPU4XlSDJ
2017-03-25 11:48:30 +08:00
Ray Lin
87004eef08 Bug 1348224 - Don't call _adjustAcItem() if result's type is different from existing item's type. r=adw
MozReview-Commit-ID: D0b4TPnD8KY
2017-03-17 16:40:33 +08:00
Ray Lin
0cf17dbdca Bug 1350315 - Hide cursor when video controls fadeout for desktop. r=Gijs
We used to have this rule in shared stylesheet for both mobile and
desktop, but the namespace mismatched after visual refresh (De-XUL).
Now we should add this rule back to hide cursor while fading out.

MozReview-Commit-ID: HDZKn8CrQ5X
2017-03-25 11:41:44 +08:00
Jessica Jong
5ecfc283af Bug 1344624 - [DateTimeInput] (l10n) Part 2: Display formatted numbers in <input type=date>. r=mossop
MozReview-Commit-ID: BOaNefKe2Pb
2017-03-24 11:13:26 +08:00
Jessica Jong
7c58493ec0 Bug 1344624 - [DateTimeInput] (l10n) Part 1: Display formatted numbers in <input type=time>. r=mossop
Add a new attribute "rawValue" in each of the numeric fields. We store the
non-formatted number in this attribute, and display formatted number using
Intl.NumberFormat.

MozReview-Commit-ID: JkcBObFoYQ3
2017-03-24 11:13:20 +08:00
Jan Henning
bca286138d Bug 1328868 - Part 3 - Make the effective text zoom retrievable from JS. r=tnikkel
We want to read this value during testing.

MozReview-Commit-ID: FVA7VdvSTEt
2017-02-25 19:27:15 +01:00
Jared Wein
5a181760cc Bug 1348068 - Enable the key-spacing rule for eslint and fix the related issues. r=standard8
Running eslint with --fix didn't fix many of the issues. The majority here had to be fixed by hand but a significant majority of the issues were related to a few files that I was able to use find-and-replace with. I regret not making this in to separate commits of the hand-fixes and the fixes from --fix but I don't recall --fix fixing any of the issues.

MozReview-Commit-ID: ANyg2qfo3Qx
2017-03-21 14:29:43 -04:00
Zibi Braniecki
e1617486a8 Bug 1347314 - Migrate calls to ChromeRegistry::GetSelectedLocale to use LocaleService::GetAppLocale. r=jfkthame,Pike
In cases, where the caller is looking for the locale to be used for JS Intl API,
we can now replace it with `undefined` which causes JS Intl API to use the default
locale which since bug 1346674 is resolved to the app locale.

This allows us to remove a lot of calls for the app locale.

The remaining ones are split between `AsBCP47` and `AsLangTag`.
Here, the `AsLangTag` is used, as described in the API docs, for cases where
the language string is used for localization purposes, such as language negotaition
matching to our language resources etc.
`AsBCP47` is used when the returned value is handed over to ICU API.

MozReview-Commit-ID: DzmFEUvMq3N
2017-03-14 16:09:54 -07:00
Sebastian Hengst
1f6ea2382a Backed out changeset cc308a73ad05 (bug 1347314) for eslint failure in test_device.html. r=backout 2017-03-22 18:20:26 +01:00
Zibi Braniecki
a56e4c7360 Bug 1347314 - Migrate calls to ChromeRegistry::GetSelectedLocale to use LocaleService::GetAppLocale. r=jfkthame,Pike
In cases, where the caller is looking for the locale to be used for JS Intl API,
we can now replace it with `undefined` which causes JS Intl API to use the default
locale which since bug 1346674 is resolved to the app locale.

This allows us to remove a lot of calls for the app locale.

The remaining ones are split between `AsBCP47` and `AsLangTag`.
Here, the `AsLangTag` is used, as described in the API docs, for cases where
the language string is used for localization purposes, such as language negotaition
matching to our language resources etc.
`AsBCP47` is used when the returned value is handed over to ICU API.

MozReview-Commit-ID: DzmFEUvMq3N
2017-03-14 16:09:54 -07:00
Mark Banner
0826d0b86b Bug 1348954 - Html5-video controls do not hide when in fullscreen. r=ralin
Undo incorrect change from bug 1341029, and tell ESLint about how Utils is 'global' to some of the videocontrols.xml event listeners.

MozReview-Commit-ID: 9ItMIzwYhEj
2017-03-21 17:17:49 +01:00
Jessica Jong
706e823fc6 Bug 1347069 - [DateTimeInput] (l10n) 12/24hr format for <input type=time> based on locale. r=mossop
MozReview-Commit-ID: 1QJig3ZTV7R
2017-03-21 11:11:10 +08:00
Ray Lin
52df9d8a7f Bug 1347673 - Visibility state of extra video control buttons should be recalculated each time the video controls are adjusted. r=jaws
MozReview-Commit-ID: Lj7kttJ9skU
2017-03-16 18:19:56 +08:00
Michael Layzell
6620072ae3 Bug 1337056 - Part 12: Send down permissions when calling createAboutBlankContentViewer, r=baku
MozReview-Commit-ID: LigZnHM34CC
2017-03-21 11:08:03 -04:00
Nihanth Subramanya
ce0dad089e Bug 1341742 - Split secondary action for push notification permission prompt into "not now" and "never". r=johannh
MozReview-Commit-ID: DTkUuWabNjH
2017-02-24 18:42:36 -08:00
Florian Quèze
c1bca211b8 Bug 1345294 - add an eslint rule to reject usage of {get,set}ComplexValue for nsISupportsString and suggest {get,set}StringPref instead, and make it pass, r=Mossop. 2017-03-16 19:26:02 +01:00
Florian Quèze
49d8db6821 Bug 1345294 - script generated patch (+ some hand cleanup) to replace {get,set}ComplexValue for nsISupportsString by {get,set}StringPref, r=Mossop. 2017-03-16 19:26:01 +01:00
Scott Wu
1d30884c66 Bug 1343707 - Make datetimepopup.xml binding attach lazily. r=mconley
MozReview-Commit-ID: C7LnrxIbU3K
2017-03-03 13:58:53 +08:00
Jessica Jong
27957d382c Bug 1301312 - Part 5: Handle input element's attribute change explicitly. r=smaug
MozReview-Commit-ID: AswWoeGasXZ
2017-03-15 11:39:02 +08:00
Jessica Jong
6406d154de Bug 1301312 - Part 4: Order fields in <input type=date> based on locale datetime format. r=gandalf,mconley
MozReview-Commit-ID: 42WjAsLImc6
2017-03-06 14:45:14 +08:00
Jessica Jong
cd81238b7a Bug 1301312 - Part 3: Order fields in <input type=time> based on locale datetime format. r=gandalf,mconley
MozReview-Commit-ID: ALgurGjv3d0
2017-03-06 14:44:22 +08:00