Commit Graph

574 Commits

Author SHA1 Message Date
Andrew Swan
1ab513d145 Bug 1519577 Convert toolbarbutton to a custom element r=surkov
Differential Revision: https://phabricator.services.mozilla.com/D31941
2019-05-20 10:01:02 -07:00
Andrei Oprea
552fe488c6 Bug 1543116 - Refactor BookmarkPanel to call ASRouter instead of passing actions r=k88hudson,flod
Differential Revision: https://phabricator.services.mozilla.com/D26538
2019-04-30 17:13:00 +00:00
Danny Coates
f086f3cf64 Bug 1543121 - Add buttons for toggling FxA message (in bookmark panel) r=k88hudson
Differential Revision: https://phabricator.services.mozilla.com/D28165
2019-04-25 14:47:24 +00:00
Brian Grinstead
5947a79cf0 Bug 1545983 - Update "Recent Closed Tabs" and "Recent Closed Windows" menus to reference their menupopup correctly r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D28298
2019-04-22 10:14:44 +00:00
Gijs Kruitbosch
676fbef38f Bug 1531367 - use root event for history middle clicks to get the correct URI, r=mak
Differential Revision: https://phabricator.services.mozilla.com/D23039
2019-03-12 09:22:11 +00:00
Shruti
d1dd022652 Bug 1531013: Replace makeURI with Services.io.newURI in browser-places.js r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D21668
2019-03-06 09:27:55 +00:00
Felipe Gomes
9c0e72d7da Bug 827976 - browser-places.js doesn't need to get a reference to the hidden window. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D21080
2019-03-04 18:53:03 +00:00
Cosmin Sabou
45f2559b66 Backed out 16 changesets (bug 827976) for causing bug 1532054. a=backout
Backed out changeset 54c0b12443ed (bug 827976)
Backed out changeset 92b45080d080 (bug 827976)
Backed out changeset 443087a359f9 (bug 827976)
Backed out changeset f976c2d4cebb (bug 827976)
Backed out changeset 66cffb171024 (bug 827976)
Backed out changeset 845e1d0b2402 (bug 827976)
Backed out changeset fd94066a1d76 (bug 827976)
Backed out changeset e253b264e7bd (bug 827976)
Backed out changeset 07ef335770a8 (bug 827976)
Backed out changeset 9d3805d77b99 (bug 827976)
Backed out changeset eed600ceb606 (bug 827976)
Backed out changeset 3b64368cff52 (bug 827976)
Backed out changeset 69d0378e0c09 (bug 827976)
Backed out changeset 9203871a5c6f (bug 827976)
Backed out changeset 96a507c818e2 (bug 827976)
Backed out changeset e254496ff95b (bug 827976)
2019-03-02 20:40:01 +02:00
Felipe Gomes
02c9dbb7e4 Bug 827976 - browser-places.js doesn't need to get a reference to the hidden window. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D21080
2019-03-01 21:07:00 +00:00
Marco Bonardo
a040dd21a3 Bug 1528751 - Add a custom eslint rule to check "consistent" if bracing. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D20753
2019-02-28 08:39:33 +00:00
Ricky Rosario
ed6b9ae0eb Bug 1521629 - Port search() to UrlbarInput.jsm r=dao
MozReview-Commit-ID: 70RV8IdoAKc

Differential Revision: https://phabricator.services.mozilla.com/D18381
2019-02-02 16:33:57 +00:00
Dão Gottwald
800f27d0e8 Bug 1521783 - Let typeRestrictToken focus the address bar. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D17239
2019-01-22 16:40:12 +00:00
Harry Twyford
95cb2a6ad2 Bug 1313429 - Add Touch Bar functionality to Firefox r=spohl,mikedeboer,flod
Adds Touch Bar functionality to Firefox across eight commits.

Differential Revision: https://phabricator.services.mozilla.com/D5496
2019-01-22 17:13:33 +00:00
Neil Deakin
2f5fea237e Bug 1482389, replace TreeBoxObject with XULTreeElement inherited from XULElement, r=peterv,paolo 2018-12-04 11:25:30 -05:00
Dão Gottwald
2101a64ed4 Bug 1515093 - Have bookmark confirmation pop-up show up the first 3 times a user bookmarks. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D14956
2018-12-20 08:23:16 +00:00
Toby Ward
207badbc32 Bug 1435562 - browser.tabs.warnOnOpen is now respected when opening multiple items from the library. r=Standard8
- Unified openContainerNodeInTabs and openURINodesInTabs in PlacesUIUtils into openMultipleLinksInTabs
- Users are now warned when the amount of links to be opened is equal to or exceeds browser.tabs.maxOpenBeforeWarn

Differential Revision: https://phabricator.services.mozilla.com/D12983
2018-12-10 17:04:18 +00:00
Csoregi Natalia
3043e2663f Backed out changeset 81a6b32f2a8b (bug 1435562) for causing Bug 1512180. a=backout 2018-12-06 14:20:20 +02:00
Toby Ward
608941107e Bug 1435562 - browser.tabs.warnOnOpen is now respected when opening multiple items from the library. r=Standard8
- Unified openContainerNodeInTabs and openURINodesInTabs in PlacesUIUtils into openMultipleLinksInTabs
- Users are now warned when the amount of links to be opened is equal to or exceeds browser.tabs.maxOpenBeforeWarn

Differential Revision: https://phabricator.services.mozilla.com/D12983
2018-12-04 19:20:59 +00:00
Marco Bonardo
f610a71944 Bug 1315509 - Ctrl+K shortcut should add '?' to the Address Bar if search bar is removed. r=adw
Differential Revision: https://phabricator.services.mozilla.com/D12222
2018-11-23 15:15:47 +00:00
Marco Bonardo
54feed2b6f Bug 1506461 - Enable inline suggestions for bookmark tags autocomplete. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D11773
2018-11-21 15:10:53 +00:00
Dão Gottwald
0993e17c69 Bug 1506114 - Move library-animatable-box into the navigation toolbar so it inherits the right color, and clean up related CSS. r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D11495
2018-11-09 20:03:32 +00:00
ScottDowne
0b01ad7419 Fixes bug 1488813 - Migrating Pocket off any bootstrap code r=ursula,k88hudson
Differential Revision: https://phabricator.services.mozilla.com/D6849
2018-10-12 19:38:10 +00:00
Marco Bonardo
5cc5f2c138 Bug 1477671 - Stop allowing creation of new live bookmarks from the backend. r=standard8
Differential Revision: https://phabricator.services.mozilla.com/D7083
2018-10-06 10:32:13 +01:00
Doug Thayer
6c2f2815de Bug 1426245 - Test changes r=mak
MozReview-Commit-ID: 4fhhzspxLJZ

Depends on D4606

Differential Revision: https://phabricator.services.mozilla.com/D5162
2018-10-09 14:47:31 +00:00
Doug Thayer
98d7bd0923 Bug 1426245 - Replace OnItemAdded with bookmark-item-added r=mak
See https://docs.google.com/document/d/1G45vfd6RXFXwNz7i4FV40lDCU0ao-JX_bZdgJV4tLjk/edit#
for further info. This essentially follows the same philosophy as
the onVisits migration.

MozReview-Commit-ID: I4bOvFH0ZQR

Depends on D4605

Differential Revision: https://phabricator.services.mozilla.com/D4606
2018-10-09 14:47:27 +00:00
Jared Wein
2d6a3e988f Bug 1480529 - Changed 'Bookmark All Tabs' to 'Bookmark Tab' for single tab selections. r=Felipe
I changed the toolbar context menuitem from 'Bookmark All Tabs' to 'Bookmark Selected Tabs' because it is separated from a specific tab and thus it is not clear which tab would get bookmarked if only one is selected. This seemed much clearer to me in my testing. The wording of 'Bookmark Selected Tabs' is already used elsewhere where we have 'Reload Selected Tabs', 'Close Selected Tabs', etc.

Differential Revision: https://phabricator.services.mozilla.com/D7217
2018-10-02 16:24:43 +00:00
Bogdan Tara
ad579c1651 Backed out changeset 1f4d7ab6cd6d (bug 1480529) for perma failing on browser_multiselect_tabs_bookmark.js 2018-10-02 18:33:49 +03:00
Jared Wein
f42d5228b2 Bug 1480529 - Changed 'Bookmark All Tabs' to 'Bookmark Tab' for single tab selections. r=Felipe
I changed the toolbar context menuitem from 'Bookmark All Tabs' to 'Bookmark Selected Tabs' because it is separated from a specific tab and thus it is not clear which tab would get bookmarked if only one is selected. This seemed much clearer to me in my testing. The wording of 'Bookmark Selected Tabs' is already used elsewhere where we have 'Reload Selected Tabs', 'Close Selected Tabs', etc.

Differential Revision: https://phabricator.services.mozilla.com/D7217
2018-10-02 03:19:01 +00:00
Dão Gottwald
162931004c Bug 1495291 - Remove obsolete code that marks the "Hide Bookmarks Toolbar" as checked. r=paolo
Differential Revision: https://phabricator.services.mozilla.com/D7397
2018-10-02 10:02:08 +00:00
Mark Banner
462116b7f9 Bug 1486739 - Add missing dangling commas in browser/, services/, taskcluster/ and toolkit/. r=mossop
Automatic changes by ESLint, except for manual corrections for .xml files.

Differential Revision: https://phabricator.services.mozilla.com/D4439
2018-08-31 05:59:17 +00:00
Mark Banner
c017ef2f34 Bug 1484482 - Fix the bookmarks menu when it is displayed via the hidden window. r=paolo
MozReview-Commit-ID: 7VYNxFmedZl

Differential Revision: https://phabricator.services.mozilla.com/D3923
2018-08-22 10:17:28 +00:00
ExE Boss
923f59f240 Bug 1482498 - Remove mozMatchesSelector(…) usage from browser‑places.js r=miketaylr
Differential Revision: https://phabricator.services.mozilla.com/D3766
2018-08-20 18:36:58 +00:00
Paolo Amadini
1b4a4d3c71 Bug 1481813 - Part 3 - Remove bookmarkThisPageBroadcaster. r=Standard8,bgrins
The PageActions API is now used to assign a title to the bookmark action.

This also prevents some tooltips from being set unnecessarily on menu items.

Differential Revision: https://phabricator.services.mozilla.com/D3010
2018-08-13 17:25:28 +01:00
Paolo Amadini
853c33315b Bug 1481813 - Part 2 - Move reference strings out of the bookmark broadcaster. r=Standard8
This prevents the reference string attributes from being replicated unneededly.

Differential Revision: https://phabricator.services.mozilla.com/D3008
2018-08-13 17:02:44 +01:00
Paolo Amadini
4ea606710c Bug 1481813 - Part 1 - Remove unneeded broadcaster observers for bookmarks. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D3007
2018-08-09 13:13:27 +01:00
Mark Banner
76c26311e8 Bug 1479722 - Rework PlacesUtils.setCharsetForURI to PlacesUIUtils.setCharsetForPage and avoid main thread sync io. r=mak
MozReview-Commit-ID: HeO3Mm5Dibo

Differential Revision: https://phabricator.services.mozilla.com/D2582
2018-08-01 10:13:59 +00:00
Mark Striemer
95b3e1beda Bug 1478042 - Check if gBrowser exists in History menu for hidden tabs r=mak
MozReview-Commit-ID: F8zhbb4l7J8
2018-07-27 17:13:55 -05:00
Boris Zbarsky
e98236cf07 Bug 1476145 part 3. Stop using getInterface(nsIDOMWindowUtils) in browser/. r=gijs 2018-07-24 19:47:41 -04:00
Brian Grinstead
3097f96e03 Bug 1476333 - Refer to AppConstants.BROWSER_CHROME_URL to get the browser URL from the frontend;r=Gijs
Before this change, we accessed the browser URL in the following ways:

- "chrome://browser/content/browser.xul"
- "chrome://browser/content/" (which redirects to chrome://browser/content/browser.xul)
- Services.prefs.getCharPref("browser.chromeURL") which returns "chrome://browser/content/"
- getBrowserURL() from utilityOverlay.js

MozReview-Commit-ID: I5vtRke1x9t
2018-07-24 08:12:50 -07:00
Dão Gottwald
a682f07772 Bug 1476901 - Stop ever hiding editBookmarkPanelContent and editBookmarkPanelBottomButtons in the bookmark panel. r=mak
MozReview-Commit-ID: CwfHapJicIG
2018-07-19 13:43:30 +02:00
Abdoulaye O. Ly
6290b52439 Bug 1458067 - Implement ability to bookmark a selection of tabs. r=Gijs
MozReview-Commit-ID: 4KE3qSf3j0y
2018-07-12 00:25:35 +00:00
Marco Bonardo
899632d5f6 Bug 1475276 - Remove some no more necessary usage of promiseItemGuid. r=lina
Some code is unnecessarily using promiseItemGuid

Differential Revision: https://phabricator.services.mozilla.com/D2100
2018-07-12 21:38:21 +00:00
Dão Gottwald
e5e6bb2a49 Bug 1473862 - Remove URL and title arguments from PlacesCommandHook.bookmarkPage. r=standard8
MozReview-Commit-ID: MYERqUTpD6
2018-07-06 14:08:03 +02:00
Dão Gottwald
a39a79d47f Bug 1473073 - Remove PlacesCommandHook.bookmarkPage's browser argument. r=mak
MozReview-Commit-ID: BH5r7Tn8KV1
2018-07-03 22:46:46 +02:00
Dão Gottwald
541fa834f8 Bug 1472275 - Remove PlacesCommandHook.bookmarkPage's aShowEditUI argument. r=standard8
MozReview-Commit-ID: CGYSF1OvoVg
2018-06-29 19:45:35 +02:00
Dão Gottwald
7cfce3c337 Bug 1468077 - Stop disabling cmd_close and cmd_closeWindow in the bookmark panel since it seems to be half-broken and is inconsistent with other panels. r=mak
MozReview-Commit-ID: AkKaq5Kon77
2018-06-29 13:33:05 +02:00
Dão Gottwald
0a450e0d60 Bug 1459878 - Add "Show editor when saving" checkbox to the Bookmark panel. r=mak
MozReview-Commit-ID: IUji9cQmVz9
2018-06-29 12:39:30 +02:00
Dão Gottwald
21d58cc4ae Bug 1471585 - Stop assuming that BookmarkingUI.anchor can be null. r=standard8
MozReview-Commit-ID: JpObSnChEU0
2018-06-27 15:14:27 +02:00
Dão Gottwald
40e9ec9d52 Bug 1471580 - Remove unused _bookmarkPopupInitialized flag. r=standard8
MozReview-Commit-ID: LI7oXGLDyso
2018-06-27 14:57:16 +02:00
Mark Banner
b24bddc9dc Bug 1452645 - Remove load in sidebar functionality. r=lina,mak
Based on patch by mixedpuppy.

MozReview-Commit-ID: BZwOtr4VbCH
2018-06-06 21:00:45 +01:00