Commit Graph

574 Commits

Author SHA1 Message Date
Dão Gottwald
3e1a255f0a Bug 1459907 - Implement new bookmark confirmation. r=mak
MozReview-Commit-ID: DsTXTKgX72y
2018-06-23 15:28:47 +02:00
Mark Striemer
d115d51aec Bug 1446101 - Part 3: Make History > Hidden Tabs deep link to Hidden Tabs menu r=mak
MozReview-Commit-ID: KgfpYbfVjUm
2018-06-04 17:11:23 -05:00
Dão Gottwald
6d855a868e Bug 1460248 - Display screenshot and favicon in the New Bookmark dialog. r=mak
MozReview-Commit-ID: C5zMr2HlBC9
2018-06-19 20:36:20 +02:00
Sam Foster
4e88ea0295 Bug 1385262 - Restore the star icon when the bookmark animation ends. r=jaws
* Also remove unused frame at the end of the bookmark-animation

MozReview-Commit-ID: 5zOO1gXEfcz
2018-06-04 12:21:26 -07:00
Mark Banner
04568e0b5a Bug 1460579 - Replace the 'bookmarkPropertiesDialog/folderLastUsed' annotation with a key/value pair in moz_meta. r=mak
MozReview-Commit-ID: GpEPxOMDret
2018-05-11 07:35:59 +01:00
Dão Gottwald
306f193ab6 Bug 1464489 - When creating a new bookmark, the bookmark panel should be titled "New Bookmark" instead of "Page Bookmarked". r=standard8
MozReview-Commit-ID: 1OeIdsf3bx
2018-05-25 20:22:35 +02:00
Mark Banner
8853e86675 Bug 1463738 - Remove the Bookmark description UI. r=dao
This removes the bookmark description UI, but leaves the backend in-place for a release or two, so that users have time to save anything they want (e.g. via backup).
The backend will be removed in bug 1402890.

MozReview-Commit-ID: La4AYFar7eK
2018-05-23 17:15:09 +01:00
Tawny Hoover
ec89441940 Bug 1400323 - Refactor code for openInTabClosesMenu pref to avoid needing setTimeout on Mac. (cleanup on popuphidden) r=mak
MozReview-Commit-ID: FR6vZksnFEz
2018-05-17 22:32:47 -04:00
Mark Striemer
c598ee9ff8 Bug 1455300 - Part 2: Include hidden tabs in the History menu r=mak
MozReview-Commit-ID: 8sKrAJVIAD5
2018-05-10 16:01:36 -05:00
Dão Gottwald
cda5638fb0 Bug 1464384 - Stop returning true/false from focusAndSelectUrlBar. r=mak
MozReview-Commit-ID: BKmsjCRZiLs
2018-05-25 15:38:09 +02:00
Dão Gottwald
f564e75ad7 Bug 1459887 - Relabel the "Remove Bookmark" button to "Cancel" in the New Bookmark dialog. r=standard8
MozReview-Commit-ID: EcCW2eBzfBT
2018-05-25 10:53:53 +02:00
Mark Banner
bcb5601b9f Bug 824502 - Change folder=<id> to parent=<guid> in Places' bookmark queries. r=mak
This allows queries to be stable across devices, and requires less work to obtain the ids.

MozReview-Commit-ID: 5KAKKags7o9
2018-04-26 09:05:00 +01:00
Dão Gottwald
8a4e4ea835 Bug 1459885 - Implement new header style and lay out labels above input fields in the new bookmarks dialog. r=mak
MozReview-Commit-ID: 9FmGhfP9aDo
2018-05-22 12:21:52 +02:00
Kris Maglione
fd7e9e6a69 Bug 1456035: Part 4 - Convert callers of XPCOMUtils.generateQI to ChromeUtils.generateQI. r=mccr8
This also removes any redundant Ci.nsISupports elements in the interface
lists.

This was done using the following script:

acecb401b7/processors/chromeutils-generateQI.jsm

MozReview-Commit-ID: AIx10P8GpZY
2018-04-22 20:55:06 -07:00
Neil Deakin
ddc248eb52 Bug 1446961, remove obsolete calls to showPopup and replace usages of the popup box object with the same methods defined on popups, r=paolo 2018-04-27 11:04:36 -04:00
Paolo Amadini
7f627ce196 Bug 1391948 - Don't use checkboxes for the "View Bookmarks Toolbar" and "View Bookmarks Sidebar" items in the Bookmarks button menu. r=mak
MozReview-Commit-ID: 2P3yV6xHLxi
2018-04-11 12:42:18 +01:00
Jonathan Kingston
9b880fdc20 Bug 1374741 - Within browser/ make openUILinkIn() provide the correct triggeringPrincipal. r=gijs
MozReview-Commit-ID: 1NQrlWzIBja
2018-02-21 14:28:48 +00:00
Manish Kumar
012e316f55 Bug 1450588 - Remove old bookmark animation code and images. r=ntim,dao 2018-04-04 10:47:50 +02:00
Paolo Amadini
5621a22a69 Bug 1434860 - Part 2 - Remove support for menu-button toolbar buttons. r=enn
MozReview-Commit-ID: MTLaIPzg7a
2018-04-03 16:26:03 +01:00
Masayuki Nakano
3ed74d7cc4 Bug 1449018 - The bookmark panel should listen to keypress event at the system event group r=mak
The bookmark panel should handle keypress events at the system event group
because it needs to handle keypress events after autocomplete module which
handles keypress events at the system event group.

MozReview-Commit-ID: 9KjBlQ59gHw
2018-03-27 16:50:18 +09:00
Marco Bonardo
59a5035ca3 Bug 1448362 - Remove some unused code from Places. r=standard8
MozReview-Commit-ID: DQCoYyZIvGD
2018-03-23 16:26:56 +01:00
Brendan Dahl
2021b6eed4 Bug 1444228 - Remove editBookmarkOverlay.xul. r=standard8
Move the main contents of editBookmarkOverlay.xul into an include file and
inline the DTD and CSS files where used. Convert several chrome tests to
browser tests since the preprocessor is hard to use within the testing
framework.


MozReview-Commit-ID: DpPBOpZSuBN
2018-03-16 09:26:49 -07:00
Mark Banner
8bda7e6d85 Bug 1310295 - Make left pane queries virtual in the Places Library window. r=kitcambridge,mak
MozReview-Commit-ID: DcEMAlrXu8R
2018-02-16 20:30:04 +00:00
Dorel Luca
37af71af05 Backed out 2 changesets (bug 1310295) for Mochitest and TV failures on browser/components/places/tests/browser/browser_bookmark_folder_moveability.js
Backed out changeset a277657bfffa (bug 1310295)
Backed out changeset b1af75c617ea (bug 1310295)
2018-03-14 18:23:46 +02:00
Mark Banner
60c4119b69 Bug 1310295 - Make left pane queries virtual in the Places Library window. r=kitcambridge,mak
MozReview-Commit-ID: DcEMAlrXu8R
2018-02-16 20:30:04 +00:00
Marco Bonardo
47da5f79b5 Bug 1439315 - 1 - rename InsertionPoint to PlacesInsertionPoint. r=standard8
MozReview-Commit-ID: 1NfkueEUPXC
2018-02-28 12:10:12 +01:00
Florian Quèze
f6add2cafd Bug 1433175 - scripted patch to replace Components.classes[, Components.interfaces.nsI, Components.utils. and Components.results. with Cc, Ci, Cu and Cr, r=Mossop. 2018-02-28 18:51:33 +01:00
Tawny Hoover
049ae1b18d Bug 1420749 - Allow browser.bookmarks.openInTabClosesMenu to work with containers as well as single menuitems r=mak
MozReview-Commit-ID: Bba3pLyHZUV
2018-02-08 20:59:08 -05:00
Mark Banner
00472aedd4 Bug 1423896 - Make the All Bookmarks folder for the left pane of the Library a virtual query. r=mak
MozReview-Commit-ID: HzJ9y1fiEz1
2017-12-07 14:15:39 +00:00
Coroiu Cristina
8fb5593ad1 Backed out 5 changesets (bug 1423896) for bustage at /src/toolkit/components/places/nsNavHistoryResult.cpp on a CLOSED TREE
Backed out changeset 4012bc74e900 (bug 1423896)
Backed out changeset 12239646395f (bug 1423896)
Backed out changeset abf61cd5fb77 (bug 1423896)
Backed out changeset 569173c95238 (bug 1423896)
Backed out changeset 6401e950298d (bug 1423896)
2018-02-07 14:07:31 +02:00
Mark Banner
2339900150 Bug 1423896 - Make the All Bookmarks folder for the left pane of the Library a virtual query. r=mak
MozReview-Commit-ID: HzJ9y1fiEz1
2017-12-07 14:15:39 +00:00
Marco Bonardo
6ce4a99bbd Bug 1434241 - showEditBookmarkPopup should stop accepting itemIds. r=standard8
MozReview-Commit-ID: 8doEkhc8Wyd
2018-01-31 13:49:35 +01:00
Kris Maglione
0bb74efdf1 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Cosmin Sabou
f09d6d985d Backed out 3 changesets (bug 1431533) for Android mochitest failures on testEventDispatcher on a CLOSED TREE
Backed out changeset a1eca62826a1 (bug 1431533)
Backed out changeset 34c999fa006b (bug 1431533)
Backed out changeset e2674287e57f (bug 1431533)
2018-01-30 07:17:48 +02:00
Kris Maglione
fd67f090b2 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Brindusan Cristian
483ba301cb Backed out 2 changesets (bug 1431533) for ESlint failures on a CLOSED TREE
Backed out changeset 6e56f4c8843e (bug 1431533)
Backed out changeset 12fc4dee861c (bug 1431533)
2018-01-30 02:32:43 +02:00
Kris Maglione
683a97d172 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Mark Banner
dbe8b88641 Bug 1131491 - Remove browser.places.useAsyncTransactions preference - async transactions are now the only version. r=mak
MozReview-Commit-ID: 9EKNvA8Q9jo
2018-01-22 13:36:41 +00:00
Gijs Kruitbosch
e64b940f37 Bug 1388029 - remove useless param from PanelUI.showSubView, r=jaws
MozReview-Commit-ID: 9hkYtLxAOtQ
2017-11-07 11:54:47 +00:00
Mike de Boer
55a1cbe966 Bug 1120110 - Consistently save pages bookmarked using 'Bookmark This Page' anywhere into the 'Other Bookmarks' folder. r=mak
Since we're not passing an optional parent folder around anymore, this patch also
removes PlacesCommandHook.bookmarkCurrentPage() in favor of a simplified
PlacesCommandHook.bookmarkPage() signature.

MozReview-Commit-ID: HmzwmATgQyw
2017-10-23 14:10:04 +02:00
Dan Banner
5af4450327 Bug 1408777 - Automatically fix instances of missing semicolons in the tree. r=Standard8
MozReview-Commit-ID: Jm8BRgt6mIv
2017-10-15 20:50:39 +01:00
Gijs Kruitbosch
9ef3115a9b Bug 1404263 - update the bookmarks toolbar item in the bookmarking tools subview when it is shown, r=mikedeboer
MozReview-Commit-ID: 1zesvAmYkAM
2017-10-04 11:49:14 +01:00
Jared Wein
1d711432fe Bug 1403550 - Update the X offset of the library button when the window is resized. r=sfoster
MozReview-Commit-ID: J3XpTOZwO1Y
2017-09-27 12:40:04 -04:00
Drew Willcoxon
e3b9b7a9a0 Bug 1402721 - Add/edit bookmark panel should open anchored on the page action (ellipsis) button instead of on the identity block (left side of the address bar) when the bookmarks star action is not pinned/visible. r=Gijs
MozReview-Commit-ID: JMviXx5ov7F
2017-09-25 13:30:08 -07:00
Gijs Kruitbosch
07dfbf4aaf Bug 1401238 - remove recent bookmarks from the bookmarks menu button and toplevel bookmarks menu, r=mak
MozReview-Commit-ID: 7JT9xCq9zcS
2017-09-20 00:38:39 +01:00
Gijs Kruitbosch
cbee9f0379 Bug 1397790 - add 'open' active state to urlbar buttons, use a more distinct background colour for it, r=abenson+572682,adw
MozReview-Commit-ID: 7QrhAB79yNw
2017-09-19 15:13:25 +01:00
Tawny Hoover
621b5e9802 Bug 260611 - Introduce pref browser.bookmarks.openInTabClosesMenu to optionally leave menu open for single bookmark menuitem clicks that open in new tab. r=mak
MozReview-Commit-ID: HreM02pdzWP
2017-09-11 12:12:21 -04:00
Jared Wein
c23fe136ee Bug 1399651 - Don't run the library animations in popup windows with toolbar=false. r=Gijs
MozReview-Commit-ID: 2vswZ2BTFwp
2017-09-13 19:37:43 -04:00
Drew Willcoxon
db557af3c5 Bug 1386745 - Activated URL/address/location bar makes bookmark doorhanger/panelUI located under "Show site information" button area after landing patch from bug #1352063. r=Gijs
MozReview-Commit-ID: Kzymx5qbp4i
2017-09-08 10:16:38 -07:00
Marco Bonardo
f5fe23e92e Bug 1398019 - Favicons missing in Bookmarks toolbar on startup. r=past
This is due to the fact now we set the icons only when the nodes visibility is updated.
The patch always updates nodes visibility when we rebuild the toolbar.
updateChevron() is being renamed accordingly and acts regardless of chevron.collapsed.

MozReview-Commit-ID: Cz1U710J42M
2017-09-08 11:43:08 +02:00