corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
872,378 Commits 1 Branch 0 Tags
b068dcffb1324b82fb2cfab5454360760cb15f45
Commit Graph

1528 Commits

Author SHA1 Message Date
Artur Iunusov
0c3dca4f67 Bug 1671548 - Remove fission experiment support code and prefs, r=smaug, 
r=tritter

- backed out changesets: 1660057, 1667426, 1674214,
1669749, 1685801, 1667381
- fission.experiment support removed everywhere, including telemetry

Differential Revision: https://phabricator.services.mozilla.com/D165169
 2023-01-17 10:05:36 +00:00
Butkovits Atila
c78e806a19 Backed out changeset 2dcea9f0eb7e (bug 1768730) for causing python failures. CLOSED TREE 2023-01-10 10:13:31 +02:00
hanna alemu
78b16c7240 Bug 1768730 - [Cleanup] Remove legacy spotlight messaging surface r=Mardak,fluent-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D165254
 2023-01-10 07:15:56 +00:00
negin
999e89b206 Bug 1805313 - Update Onboarding template to support two CTA buttons r=pdahiya,omc-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D164594
 2023-01-06 15:25:33 +00:00
Mark Banner
00abf03e4f Bug 1808202 - Convert newtab DeDupe.jsm, ActorConstants.jsm and Actions.jsm to ES modules and update imports. r=Mardak 
Depends on D165820

Differential Revision: https://phabricator.services.mozilla.com/D165821
 2023-01-05 09:58:30 +00:00
hanna alemu
aa11bbbe1c Bug 1805318 - [Cleanup] Update link shown in MobileDownloads component r=omc-reviewers,jprickett 
Differential Revision: https://phabricator.services.mozilla.com/D165890
 2023-01-04 07:17:14 +00:00
Shane Hughes
bf1bcee6bd Bug 1807970 - Use translate for about:welcome progress bar transitions. r=emcminn 
Differential Revision: https://phabricator.services.mozilla.com/D165713
 2023-01-03 22:46:35 +00:00
Noemi Erli
1906571b03 Backed out changeset 32a27bcc7e0a (bug 1805318) for causing newtab failures CLOSED TREE 2023-01-03 12:24:06 +02:00
hanna alemu
bde552a0f7 Bug 1805318 - [Cleanup] Update link shown in MobileDownloads component r=omc-reviewers,jprickett 
Differential Revision: https://phabricator.services.mozilla.com/D165265
 2023-01-03 09:15:35 +00:00
Sylvestre Ledru
d2b8ba7f8a Bug 1750450 - Fix 'Non-consecutive header level increase' DONTBUILD 
Differential Revision: https://phabricator.services.mozilla.com/D165655
 2022-12-31 16:33:30 +00:00
Sylvestre Ledru
1fd63074c1 Bug 1807899 - Remove the trailing whitespace and Windows CR on md files r=linter-reviewers,necko-reviewers,marco,jesup 
Differential Revision: https://phabricator.services.mozilla.com/D165662
 2022-12-30 15:23:21 +00:00
Shane Hughes
52500a8c09 Bug 1806095 - Fix oversights in about:welcome progress bar. r=emcminn 
Avoid an unnecessary hook trigger and clean up the handling of the start
screen behavior.

Differential Revision: https://phabricator.services.mozilla.com/D165063
 2022-12-22 18:17:32 +00:00
Barret Rennie
9a9c859213 Bug 1798832 - Remove WhatsNew layout_title_content_variable field r=omc-reviewers,emcminn 
The layout_title_content_variable is no longer used, so it can be removed.

Differential Revision: https://phabricator.services.mozilla.com/D163044
 2022-12-20 15:30:53 +00:00
Barret Rennie
a35c59d0ab Bug 1802351 - Document the provider field r=omc-reviewers,emcminn 
Differential Revision: https://phabricator.services.mozilla.com/D163043
 2022-12-20 15:30:53 +00:00
Emily McMinn
6f68f8a82a Bug 1790387 - A11y improvements for the Feature Callout step indicator r=aminomancer,bolsson 
Differential Revision: https://phabricator.services.mozilla.com/D159629
 2022-12-15 21:48:42 +00:00
Shane Hughes
426d10750c Bug 1804954 - isFxASignedIn targeting attribute. r=mviar 
Differential Revision: https://phabricator.services.mozilla.com/D164383
 2022-12-15 17:54:02 +00:00
Meg Viar
5d7af98413 Bug 1805387 - On Firefox locales with long strings the title of the PDF callout message overlaps with the X button r=jprickett 
Move the dismiss button in Feature Callouts so it cannot overlap the title of the message.

Differential Revision: https://phabricator.services.mozilla.com/D164607
 2022-12-14 16:17:01 +00:00
Shane Hughes
ea74f8cc33 Bug 1804726 - Refactor about:welcome transitions. r=emcminn 
This patch accomplishes a couple different things in one go.
about:welcome has a feature to allow switching screens by history
navigation. But the screen transitions don't play in that case. There
was also an issue (see bug 1804098) where rounding inconsistencies could
cause 1px gaps to appear in the animated progress bar, because of the
use of transform. By converting the progress bar into a single element
and just modulating its width, we can stop using transform and also
enable transitions for history navigation. Technically, this also allows
us to advance by more than 1 screen without messing up the animations,
though this is not currently used. Incidentally, it simplifies the CSS.

Differential Revision: https://phabricator.services.mozilla.com/D164310
 2022-12-14 03:32:56 +00:00
Shane Hughes
c145c22abc Bug 1804786 - Fix enzyme unit tests. r=mviar 
Modify the enzyme assertions in unit tests so they can fail when
regressed. Update the same tests since now they would fail otherwise.
One of them also required fixing a bug in MSLocalized.jsx.

Differential Revision: https://phabricator.services.mozilla.com/D164403
 2022-12-12 18:04:12 +00:00
Cristian Tuns
bbf7fa7f65 Backed out changeset 5d55a5accdeb (bug 1804726) for causing mochitest failures on browser_aboutwelcome_configurable_ui.js CLOSED TREE 2022-12-11 22:13:21 -05:00
Shane Hughes
dfdf59950f Bug 1804726 - Refactor about:welcome transitions. r=emcminn 
This patch accomplishes a couple different things in one go.
about:welcome has a feature to allow switching screens by history
navigation. But the screen transitions don't play in that case. There
was also an issue (see bug 1804098) where rounding inconsistencies could
cause 1px gaps to appear in the animated progress bar, because of the
use of transform. By converting the progress bar into a single element
and just modulating its width, we can stop using transform and also
enable transitions for history navigation. Technically, this also allows
us to advance by more than 1 screen without messing up the animations,
though this is not currently used. Incidentally, it simplifies the CSS.

Differential Revision: https://phabricator.services.mozilla.com/D164310
 2022-12-12 02:26:42 +00:00
scott
9d50f3d711 Bug 1804533 - Save to Pocket and Pocket newtab pass rollout metadata to Pocket links r=gvn 
Differential Revision: https://phabricator.services.mozilla.com/D164125
 2022-12-08 17:39:36 +00:00
hanna alemu
a6db112731 Bug 1794485 - Remove colorway variation from about:welcome codebase r=pdahiya,dmose,desktop-theme-reviewers,dao 
Differential Revision: https://phabricator.services.mozilla.com/D159324
 2022-12-07 19:05:24 +00:00
Shane Hughes
1d574e4e44 Bug 1804098 - Avoid subpixel rounding inconsistencies in about welcome progress bar. r=negin 
Differential Revision: https://phabricator.services.mozilla.com/D163866
 2022-12-07 17:03:07 +00:00
Shane Hughes
83343af82b Bug 1794702 - Add a wipe transition for MR onboarding progress bar. r=yozhang 
Differential Revision: https://phabricator.services.mozilla.com/D159821
 2022-12-02 07:03:56 +00:00
scott
2aba9c12cd Bug 1799974 - Pocket newtab fixing loading of page to have less shifting. r=gvn 
Differential Revision: https://phabricator.services.mozilla.com/D163621
 2022-12-02 00:40:05 +00:00
Greg Tatum
5f08f17bf3 Bug 1685180 - Ensure more programmatic fluent args have values; r=nordzilla 
Depends on D162597

Differential Revision: https://phabricator.services.mozilla.com/D163626
 2022-12-01 21:40:57 +00:00
Cristian Tuns
e4f818ecc2 Backed out changeset 732eca22ad6f (bug 1799974) for causing node failures CLOSED TREE 2022-12-01 14:59:56 -05:00
scott
f0ca205e0d Bug 1799974 - Pocket newtab fixing loading of page to have less shifting. r=gvn 
Differential Revision: https://phabricator.services.mozilla.com/D163621
 2022-12-01 19:28:48 +00:00
scott
81b2abcdfd Bug 1803410 - Pocket newtab topsites, fixing replaced pinned edge cases. r=nanj 
Differential Revision: https://phabricator.services.mozilla.com/D163510
 2022-12-01 17:38:57 +00:00
Shane Hughes
db26095c40 Bug 1795288 - Feature Callouts: add dismiss telemetry. r=mviar 
Differential Revision: https://phabricator.services.mozilla.com/D163531
 2022-12-01 16:42:18 +00:00
scott
34d6c900b7 Bug 1803206 - Pocket newtab sponsored topsite fixing image resize. r=nanj 
Differential Revision: https://phabricator.services.mozilla.com/D163363
 2022-11-30 03:57:12 +00:00
scott
e6e0377789 Bug 1803107 - Pocket newtab topsites fixing pinning issue with sponsored Pocket tile. r=nanj 
Differential Revision: https://phabricator.services.mozilla.com/D163339
 2022-11-29 19:10:47 +00:00
scott
e7f4d6f040 Bug 1802265 - Pocket newtab topsite spoc use title instead of sponsor. r=nanj 
Differential Revision: https://phabricator.services.mozilla.com/D162947
 2022-11-24 20:03:53 +00:00
negin
1779c1057f Bug 1800126 - [Cleanup] Refactor OnboardingVideo in its own component r=yozhang 
[try](https://treeherder.mozilla.org/jobs?repo=try&revision=50e8d3a693d5a8cf6a6f3bf601c9cd241f5145e6)

Differential Revision: https://phabricator.services.mozilla.com/D162420
 2022-11-23 17:50:13 +00:00
Punam Dahiya
ce3fbde864 Bug 1801762 - Add checkbox interaction telemetry for easy setup experiment r=Mardak 
Differential Revision: https://phabricator.services.mozilla.com/D162677
 2022-11-22 20:52:51 +00:00
Csoregi Natalia
dcbfe3fab0 Backed out changeset 6b0244ce90fb (bug 1800126) for causing newtab failures. CLOSED TREE 2022-11-22 18:09:09 +02:00
negin
9eab44a4b6 Bug 1800126 - [Cleanup] Refactor OnboardingVideo in its own component r=yozhang 
Differential Revision: https://phabricator.services.mozilla.com/D162420
 2022-11-22 15:25:41 +00:00
Shane Hughes
8ceb90e910 Bug 1800087 - Fix ASRouter references to RS collections. r=barret 
ASRouter's remote message providers were written to include a property
to specify the desired collection on the Remote Settings Kinto server.
But this property was mistakenly labeled `bucket` in many places. This
could be confusing because Kinto storage is organized by both buckets
and collections, with buckets being a higher level of organization and
collections belonging to buckets. Each individual message provider
specifies a collection like "cfr", while the bucket is set by the router
code ("main"). This carried over to everything that interacted with the
providers, so this patch effectively replaces every reference to a
"message provider bucket" with "message provider collection." But more
importantly, provider definitions are stored as JSON strings in
preference values, so these definitions erroneously contained key-value
pairs like `bucket: "cfr"` which should have been `collection: "cfr"`.
That means the pref values themselves must be migrated to ensure that
modified prefs continue to work. Existing tests are updated and a new
test is added for the migrator, to meet minimum coverage requirements.
Documentation is also updated to reflect the correct property name.

Differential Revision: https://phabricator.services.mozilla.com/D162067
 2022-11-17 18:32:13 +00:00
Emily McMinn
e8b3e6267b Bug 1781091 - Update RTAMO to match MR1 designs r=mviar,fluent-reviewers,flod 
Differential Revision: https://phabricator.services.mozilla.com/D161482
 2022-11-17 17:13:35 +00:00
negin
f321eec644 Bug 1800655 - The “send yourself a download link” from the “Mobile” screen of the new and existing users’ Onboarding does not redirect to any page r=aminomancer 
Because of the `::before` element which requires a z-index of 1 to render the box-shadow, it was causing links to be unclickable/behind the element. By adding `pointer-events: none` to the pseudo element, it is possible to click through the elements again/interact with the `<a>` tag

Differential Revision: https://phabricator.services.mozilla.com/D162226
 2022-11-16 20:16:48 +00:00
negin
0d72b18f0c Bug 1797851 - Add telemetry to video section in onboarding r=pdahiya,emcminn 
Differential Revision: https://phabricator.services.mozilla.com/D161704
 2022-11-16 17:10:34 +00:00
yoenzhang
e97af2d130 Bug 1797843 - Add support to play streaming video inside new user onboarding r=pdahiya 
Differential Revision: https://phabricator.services.mozilla.com/D161233
 2022-11-15 04:46:36 +00:00
Mark Banner
9ecec1531f Bug 1800319 - Change newtab code so that the ESLint rule no-console is an error, except for console.error calls. r=Mardak 
Differential Revision: https://phabricator.services.mozilla.com/D161942
 2022-11-13 21:02:41 +00:00
Cristian Tuns
3b81ff80a1 Backed out changeset 3b4e0751850a (bug 1797843) for causing mochitest failures nsContentSecurityUtils.cpp CLOSED TREE 2022-11-12 00:57:11 -05:00
yoenzhang
cd279e0fc6 Bug 1797843 - Add support to play streaming video inside new user onboarding r=pdahiya 
Differential Revision: https://phabricator.services.mozilla.com/D161233
 2022-11-12 05:24:59 +00:00
Punam Dahiya
eac66c92d8 Bug 1798336 - Add multiselect section to onboarding template r=emcminn 
Differential Revision: https://phabricator.services.mozilla.com/D161230
 2022-11-10 21:59:44 +00:00
Shane Hughes
01940e9978 Bug 1795808 - HCM: Don't use static colors in about:welcome. r=hanna_a 
Differential Revision: https://phabricator.services.mozilla.com/D161616
 2022-11-10 18:50:15 +00:00
hanna alemu
ad8c25fedf Bug 1796900 - Don't nag users about Firefox View r=mviar,barret 
Differential Revision: https://phabricator.services.mozilla.com/D160284
 2022-11-09 20:06:58 +00:00
scott
4f01a04373 Bug 1799649 - Pocket newtab sponsored topsite drag position change fix. r=nanj 
Differential Revision: https://phabricator.services.mozilla.com/D161625
 2022-11-08 21:24:47 +00:00