Commit Graph

1528 Commits

Author SHA1 Message Date
Norisz Fay
32ae2d7897 Backed out changeset 67d785ab3cb3 (bug 1829039) for causing node-newtab failure on aboutwelcome.scss CLOSED TREE 2023-05-09 17:35:44 +03:00
negin
dd6b50d41e Bug 1829039 - Updates embedded migration wizard styles to match figma r=aminomancer
This patch fixes the font size inconsistencies, extra whitespace above title, and introduces simplified animations for [Embedded Migration Wizard](https://www.figma.com/file/c83OEio9DhCQKuabx2tIEl/NUO-Experiments-2023?node-id=976-31535) screen. Other feedback from the initial bug has been broken down into other bugs:

* [Position relative feedback bug](https://bugzilla.mozilla.org/show_bug.cgi?id=1829272)
* [Checkbox spacing](https://bugzilla.mozilla.org/show_bug.cgi?id=1829733)
* Logo feedback - syncing up with Gabrielle and will file a follow-up bug depending on what we want to do (figma does not include the logo)

Differential Revision: https://phabricator.services.mozilla.com/D176352
2023-05-09 13:46:13 +00:00
Shane Hughes
2c1e31da7b Bug 1829043 - Add actions for AboutWelcome embedded migration wizard. r=pdahiya,mconley
Add some properties to the migration wizard screen JSON to specify what
action to perform when CTAs inside the embedded migration wizard are
clicked. This lets us advance screens when the cancel or finish button
is clicked, and send telemetry when the start button is clicked. In
theory we could perform any special message actions too, but for now we
only need telemetry and screen navigation.

Differential Revision: https://phabricator.services.mozilla.com/D176358
2023-05-08 18:23:47 +00:00
Katherine Patenio
f2226c4d20 Bug 1828433 - restore underlines for links in new tab page. r=amy
This patch restores link underlines in the new tab page, particularly the settings page and discovery stream (top sites, pocket tiles, and recent activity). Only links that had underlines on hover were updated. `text-decoration: none` is added for cards to maintain original styling.

Differential Revision: https://phabricator.services.mozilla.com/D176819
2023-05-08 16:28:50 +00:00
Cristian Tuns
05c7ba7f52 Backed out changeset 743c4f059b79 (bug 1829039) for causing bc failures in browser_aboutwelcome_multistage_mr.js CLOSED TREE 2023-05-05 19:50:02 -04:00
negin
087c181c62 Bug 1829039 - Updates embedded migration wizard styles to match figma r=aminomancer,mconley
Differential Revision: https://phabricator.services.mozilla.com/D176352
2023-05-05 19:30:31 +00:00
Stanca Serban
8fc4f98984 Backed out changeset 72f882230f63 (bug 1829039) for causing mochitests failures in browser_aboutwelcome_multistage_mr.js. CLOSED TREE 2023-05-05 04:28:52 +03:00
negin
c514f3673d Bug 1829039 - Updates embedded migration wizard styles to match figma r=aminomancer,mconley
This patch fixes the font size inconsistencies, extra whitespace above title, and lack of transition animations for [Embedded Migration Wizard](https://www.figma.com/file/c83OEio9DhCQKuabx2tIEl/NUO-Experiments-2023?node-id=976-31535) screen. Other feedback from the initial bug has been broken down into other bugs:

* [Position relative feedback bug](https://bugzilla.mozilla.org/show_bug.cgi?id=1829272)
* [Checkbox spacing](https://bugzilla.mozilla.org/show_bug.cgi?id=1829733)
* Logo feedback - syncing up with Gabrielle and will file a follow-up bug depending on what we want to do (figma does not include the logo)

Differential Revision: https://phabricator.services.mozilla.com/D176352
2023-05-04 23:32:12 +00:00
Cosmin Sabou
5eecdbf11c Backed out changeset cdaa6a0312f0 (bug 1829039) for causing increase in failures on browser_aboutwelcome_multistage_mr.js. CLOSED TREE 2023-05-03 19:40:03 +03:00
negin
717bd31e75 Bug 1829039 - Updates embedded migration wizard styles to match figma r=aminomancer,mconley
This patch fixes the font size inconsistencies, extra whitespace above title, and introduces simplified animations for [Embedded Migration Wizard](https://www.figma.com/file/c83OEio9DhCQKuabx2tIEl/NUO-Experiments-2023?node-id=976-31535) screen. Other feedback from the initial bug has been broken down into other bugs:

* [Position relative feedback bug](https://bugzilla.mozilla.org/show_bug.cgi?id=1829272)
* [Checkbox spacing](https://bugzilla.mozilla.org/show_bug.cgi?id=1829733)
* Logo feedback - syncing up with Gabrielle and will file a follow-up bug depending on what we want to do (figma does not include the logo)

Differential Revision: https://phabricator.services.mozilla.com/D176352
2023-05-03 13:46:47 +00:00
hanna alemu
2ac6135d00 Bug 1816511 - Allow messaging about:welcome users by screen usage r=omc-reviewers,pdahiya,jprickett,aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D172836
2023-05-02 13:53:07 +00:00
Punam Dahiya
daa96c9a8e Bug 1823779 - Evaluate screen targeting and update screen state on index change r=Mardak,omc-reviewers,negin
Differential Revision: https://phabricator.services.mozilla.com/D174044
2023-04-29 20:10:42 +00:00
Mike Conley
4d8e83d0c3 Bug 1830178 - Rename FXA_SIGNIN_TAB_FLOW message to FXA_SIGNIN_FLOW and allow for signing in via a new window. r=aminomancer,Mardak
Differential Revision: https://phabricator.services.mozilla.com/D176684
2023-04-28 15:38:24 +00:00
Mike Conley
143026f39c Bug 1829426 - Add a 'welcome back' screen to onboarding for users going through the device migration flow. r=Mardak,fluent-reviewers,flod
Significant portions of this were written by Shane Hughes <shughes@mozilla.com> -
specifically the parts that move the Firefox Account sign-in flow for tabs into
a SpecialMessageAction, and making AboutWelcomeUtils.handleUserAction return
a Promise.

Differential Revision: https://phabricator.services.mozilla.com/D176453
2023-04-28 15:38:24 +00:00
Noemi Erli
b2042001fc Backed out 2 changesets (bug 1830178, bug 1829426) for causing failures in browser_aboutwelcome_multistage_mr.js CLOSED TREE
Backed out changeset 917f6a2ef432 (bug 1830178)
Backed out changeset 47704fa0c047 (bug 1829426)
2023-04-28 08:19:22 +03:00
Mike Conley
e3bd3985bf Bug 1830178 - Rename FXA_SIGNIN_TAB_FLOW message to FXA_SIGNIN_FLOW and allow for signing in via a new window. r=aminomancer,Mardak
Differential Revision: https://phabricator.services.mozilla.com/D176684
2023-04-28 03:17:28 +00:00
Mike Conley
a0043ccde6 Bug 1829426 - Add a 'welcome back' screen to onboarding for users going through the device migration flow. r=Mardak,fluent-reviewers,flod
Significant portions of this were written by Shane Hughes <shughes@mozilla.com> -
specifically the parts that move the Firefox Account sign-in flow for tabs into
a SpecialMessageAction, and making AboutWelcomeUtils.handleUserAction return
a Promise.

Differential Revision: https://phabricator.services.mozilla.com/D176453
2023-04-28 03:17:28 +00:00
scottdowne
4b486920aa Bug 1812690 - Pocket newtab enabling onboarding experience for new users seeing the Pocket section for the first time. r=gvn,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D174710
2023-04-25 16:49:25 +00:00
Mike Conley
b0e076cb45 Bug 1828117 - Add a convenient ASRouterTargeting attribute for clients installed via guided device migration from SUMO. r=Mardak
Differential Revision: https://phabricator.services.mozilla.com/D176185
2023-04-24 15:38:41 +00:00
Barret Rennie
473c313805 Bug 1823777 - Add checked and unchecked checkbox actions to about:welcome checkboxes r=omc-reviewers,pdahiya
about:welcome checkboxes can now set an `checkedAction` and an
`uncheckedAction`, which will occur when the checkbox is checked or unchecked,
respectively, and the primary button is clicked.

The old `action` parameter is still supported for backwards compatability, but
`checkedAction` takes precedence.

Differential Revision: https://phabricator.services.mozilla.com/D174192
2023-04-22 04:40:13 +00:00
scottdowne
de18d8fccf Bug 1812689 - Pocket newtab new regions implementation r=gvn
Differential Revision: https://phabricator.services.mozilla.com/D173853
2023-04-21 17:57:28 +00:00
Mike Conley
711b1c4d9a Bug 1820640 - Add a card to about:welcome that embeds the Migration Wizard if configured to do so. r=pdahiya,omc-reviewers
This adds a card to the about:welcome defaults that embeds the new Migration Wizard
if  browser.migrate.content-modal.about-welcome-behavior is set to "embedded".

This requires adding a useEmbeddedMigrationWizard targeting attribute to
ASRouterTargeting.

Differential Revision: https://phabricator.services.mozilla.com/D175945
2023-04-21 03:18:12 +00:00
Dão Gottwald
995349acbb Bug 1828440 - BuiltInThemes cleanup: remove obsolete findActiveColorwayCollection, isColorwayFromCurrentCollection, isMonochromaticTheme, monochromaticSortIndices. r=amy,willdurand
Differential Revision: https://phabricator.services.mozilla.com/D175647
2023-04-19 11:05:28 +00:00
Punam Dahiya
36013464e6 Bug 1827572 - Telemetry impression pings should wait for filtered screens r=Mardak
Differential Revision: https://phabricator.services.mozilla.com/D175293
2023-04-19 06:59:35 +00:00
Cristian Tuns
3b4b9be6e5 Backed out changeset 96f01a59fe31 (bug 1827572) for causing bc failures in /browser_aboutwelcome_multistage_mr.js CLOSED TREE 2023-04-18 09:28:45 -04:00
Punam Dahiya
c646894134 Bug 1827572 - Telemetry impression pings should wait for filtered screens r=Mardak
Differential Revision: https://phabricator.services.mozilla.com/D175293
2023-04-18 05:49:54 +00:00
hanna alemu
306343134d Bug 1825658 - Modify "addon_recommendation" CFR template to support Facebook container experiment r=jprickett,barret
Differential Revision: https://phabricator.services.mozilla.com/D174844
2023-04-14 15:36:39 +00:00
William Durand
ad508fc1aa Bug 1828074 - Add new targeting attribute for RTAMO in ASRouter. r=omc-reviewers,aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D175463
2023-04-14 14:11:36 +00:00
Noemi Erli
100160f533 Backed out changeset e054b7d5f984 (bug 1825658) for causing newtab failures CLOSED TREE 2023-04-13 18:36:23 +03:00
hanna alemu
f004fa7c10 Bug 1825658 - Modify "addon_recommendation" CFR template to support Facebook container experiment r=jprickett,barret
Differential Revision: https://phabricator.services.mozilla.com/D174844
2023-04-13 15:03:33 +00:00
Emily McMinn
d2fc230432 Bug 1827283 - Wrap image alt-text in Localized r=omc-reviewers,aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D175070
2023-04-11 23:16:44 +00:00
Russell Chan
b653cce8ee Bug 1825063 - Add ability to hide the arrow from the feature callout r=fxview-reviewers,omc-reviewers,aminomancer,sclements
Differential Revision: https://phabricator.services.mozilla.com/D174342
2023-04-11 14:01:03 +00:00
Mike Conley
1a8461cd0b Bug 1826360 - Do not include sponsored tiles for about:home startup cache r=mconley,thecount
Differential Revision: https://phabricator.services.mozilla.com/D174646
2023-04-04 18:25:43 +00:00
Mike Conley
f0a43e9d62 Bug 1794617 - Add ASRouter targeting for whether or not the user has ever migrated bookmarks, history, or passwords. r=dmose,omc-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D173579
2023-04-03 20:47:12 +00:00
Mark Banner
45cdad50d5 Bug 1825715 - Replace disabling of ESLint rule prettier/prettier with prettier-specific disabling (other). r=Gijs,necko-reviewers,credential-management-reviewers,devtools-reviewers,dimi
Differential Revision: https://phabricator.services.mozilla.com/D174217
2023-04-01 16:40:01 +00:00
Emily McMinn
e47831b644 Bug 1823776 - Handle SHOW_MIGRATION_WIZARD inside nested MULTI_ACTION r=pdahiya,omc-reviewers,aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D173558
2023-03-31 21:19:50 +00:00
Cristian Tuns
6c67c5639a Backed out 3 changesets (bug 1825715) for causing node failures with checkBundles CLOSED TREE
Backed out changeset 53faa883781a (bug 1825715)
Backed out changeset 5ce3ad6ce483 (bug 1825715)
Backed out changeset 7f0b08e89cd1 (bug 1825715)
2023-03-31 17:23:28 -04:00
Mark Banner
84946e9a9f Bug 1825715 - Replace disabling of ESLint rule prettier/prettier with prettier-specific disabling (other). r=Gijs,necko-reviewers,credential-management-reviewers,devtools-reviewers,dimi
Differential Revision: https://phabricator.services.mozilla.com/D174217
2023-03-31 20:32:18 +00:00
Lina Butler
0ea22d21eb Bug 1821556 - Collect the tile position and number of tile rows in newtab pings. r=nanj
This commit:

* Adds a `position` key to the `topsites.{impression, click}` events.
  This position is zero-based, to align with `pocket_position`.
* Refactors the impression stats actions in `TelemetryFeed` to receive
  the zero-based tile position, and adds one to the structured
  ingestion payloads and scalar values.
* Adds a new Glean metric, `topsites.rows`, to record the number of
  rows shown on the New Tab page.

Differential Revision: https://phabricator.services.mozilla.com/D172292
2023-03-31 05:21:20 +00:00
Shane Hughes
bf95d82c8b Bug 1822211 - Add vertical button layout for center layout Spotlight. r=omc-reviewers,barret
Differential Revision: https://phabricator.services.mozilla.com/D172516
2023-03-30 21:28:08 +00:00
ogiorgis
0c5d75ef6a Bug 1621950 - fix some myst ref warnings r=firefox-source-docs-reviewers,devtools-reviewers,sylvestre
Differential Revision: https://phabricator.services.mozilla.com/D173843
2023-03-30 08:01:22 +00:00
Shane Hughes
ca232ede40 Bug 1813716 - Encapsulate aboutwelcome container and make its ID more unique. r=omc-reviewers,fxview-reviewers,sfoster,jprickett
Differential Revision: https://phabricator.services.mozilla.com/D172493
2023-03-29 21:51:09 +00:00
Shane Hughes
3301924585 Bug 1822893 - Add formAutofill trigger and targeting attributes creditCardsSaved and addressesSaved. r=omc-reviewers,jprickett
Differential Revision: https://phabricator.services.mozilla.com/D172842
2023-03-29 07:07:42 +00:00
Shane Hughes
7cf9a86c67 Bug 1818829 - Implement Feature Callout theme configuration. r=jprickett,omc-reviewers,fxview-reviewers,sfoster
Add logic to apply theme colors to Feature Callout based on where it's
going to show. We can use in-content CSS properties for Firefox View and
other themed system pages, but not for PDF.js, nor for any callouts we
might show in the browser chrome in the future. For the browser chrome
in general, we can use the lightweight theme properties directly, in the
same way the chrome frontend does. But PDF.js is a special case, since
although it exists in the chrome, it's meant to appear like it's in the
PDF.js viewer. And the PDF.js viewer has its own theme totally
independent of everything else. So this dynamically applies themes from
different sources.

This also fixes the bug where the PDF.js color scheme could mismatch the
PDF.js viewer if the browser theme and system color scheme don't match,
e.g. where system color scheme is light but a dark theme is installed,
or vice versa. For PDF.js specifically, we can use the
-moz-content-prefers-color-scheme media query to follow the color scheme
as it exists in the PDF.js viewer page instead of the color scheme in
the chrome window where the Feature Callout actually exists.

It also adds or modifies some colors that were previously missing or
different from the prototype, fixes the illegibility of buttons in HCM
and forced colors mode, and makes some other minor color changes.

Differential Revision: https://phabricator.services.mozilla.com/D173088
2023-03-28 00:38:42 +00:00
Cosmin Sabou
c31085cb42 Backed out changeset fecef27ba1fa (bug 1818829) for causing newtab failures on _feature-callout-theme.scss. CLOSED TREE 2023-03-28 02:46:44 +03:00
Shane Hughes
43bb7f08b0 Bug 1818829 - Implement Feature Callout theme configuration. r=jprickett,omc-reviewers,fxview-reviewers,sfoster
Add logic to apply theme colors to Feature Callout based on where it's
going to show. We can use in-content CSS properties for Firefox View and
other themed system pages, but not for PDF.js, nor for any callouts we
might show in the browser chrome in the future. For the browser chrome
in general, we can use the lightweight theme properties directly, in the
same way the chrome frontend does. But PDF.js is a special case, since
although it exists in the chrome, it's meant to appear like it's in the
PDF.js viewer. And the PDF.js viewer has its own theme totally
independent of everything else. So this dynamically applies themes from
different sources.

This also fixes the bug where the PDF.js color scheme could mismatch the
PDF.js viewer if the browser theme and system color scheme don't match,
e.g. where system color scheme is light but a dark theme is installed,
or vice versa. For PDF.js specifically, we can use the
-moz-content-prefers-color-scheme media query to follow the color scheme
as it exists in the PDF.js viewer page instead of the color scheme in
the chrome window where the Feature Callout actually exists.

It also adds or modifies some colors that were previously missing or
different from the prototype, fixes the illegibility of buttons in HCM
and forced colors mode, and makes some other minor color changes.

Differential Revision: https://phabricator.services.mozilla.com/D173088
2023-03-27 23:07:45 +00:00
Amy Churchwell
2f47bbd936 Bug 1811372 - Use prefers-reduced-motion query for the new tab customization panel. r=mhowell
Differential Revision: https://phabricator.services.mozilla.com/D173575
2023-03-24 22:22:33 +00:00
Emily McMinn
0f9bd3b4c7 Bug 1817020 - Add "document" role to MultiStageProtonScreen to trigger read-all for NVDA r=Jamie
Adds `role: document` to the section-main of MultiStageProtonScreen, which will primarily affect the read-all and keyboard navigation behaviour for the upgrade spotlight. This should address points mentioned in bug 1817020, along with Russell's patch here: https://phabricator.services.mozilla.com/D172725

Differential Revision: https://phabricator.services.mozilla.com/D169970
2023-03-24 15:34:41 +00:00
Punam Dahiya
cefb307533 Bug 1820566 - Show FxA screen based of user import selection r=jprickett
Differential Revision: https://phabricator.services.mozilla.com/D172593
2023-03-22 05:51:12 +00:00
Shane Hughes
6595d7a3b6 Bug 1786582 - Update fluent and fluent-react in newtab. r=barret
Differential Revision: https://phabricator.services.mozilla.com/D172720
2023-03-22 04:15:39 +00:00