Commit Graph

609 Commits

Author SHA1 Message Date
Mike Conley
3e4aa35ac7 Bug 1819343 - Add a skeleton loading page for the new MigrationWizard component. r=kpatenio
Differential Revision: https://phabricator.services.mozilla.com/D171741
2023-03-06 21:39:01 +00:00
brian
ed9f9dee81 Bug 1809347 Implement the page that appears if no other browsers to import cannot be found. r=mconley,fluent-reviewers,flod.
Differential Revision: https://phabricator.services.mozilla.com/D168981
2023-03-03 20:35:52 +00:00
steven wang
86f423adb8 Bug 1816690 - Default all visible resource checkboxes to checked (and invisible ones to unchecked) when selecting a browser/profile pair. r=mconley.
Differential Revision: https://phabricator.services.mozilla.com/D171502
2023-03-03 19:13:17 +00:00
Barret Rennie
81b53ac824 Bug 1818868 - Port osfile.jsm usage to IOUtils in browser/components/migration/ r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D170976
2023-02-27 16:28:57 +00:00
achris16
270ad398ef Bug 1467094 - Import from Chromium Snap Profile r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D169497
2023-02-22 15:49:00 +00:00
steven wang
f9ef9d9cf3 Bug 1813598 - Add a Cancel and Done button to the bottom of the progress page of the wizard. r=mconley,fluent-reviewers,flod.
Differential Revision: https://phabricator.services.mozilla.com/D169496
2023-02-17 04:31:08 +00:00
Mike Conley
c8fa25ba9b Bug 1816197 - Part 2: Add an optional callback to MigratorBase.migrate to get migration updates. r=NeilDeakin,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D169527
2023-02-16 20:40:00 +00:00
Andi-Bogdan Postelnicu
d016916382 Bug 1519636 - Reformat recent changes to the Google coding style. r=glandium
Updated with clang-format version 15.0.5 (taskcluster-MKK8dHUpQkGfPLA793lizg)
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D168658
2023-02-13 15:02:07 +00:00
Nolan Ishii
e8b4b50efd Bug 1803446 Implement 'variant 2' version of the main selector page for the migration wizard. r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D166949
2023-02-08 15:58:24 +00:00
steven wang
c3c050ab64 Bug 1801051 - Remove cookies migration (except for FirefoxProfileMigrator). r=mconley.
Differential Revision: https://phabricator.services.mozilla.com/D168348
2023-02-07 20:11:42 +00:00
Mike Conley
07c9adc0ac Bug 1814912 - Use an HTML5 dialog instead of gSubDialog for the new migration wizard in about:preferences. r=Gijs,settings-reviewers
I also renamed migration-dialog.[js|html|css] to migration-dialog-window.[js|html|css] to
make it clearer that those resources are for when the wizard is being shown in a separate
window. I also updated the documentation to reflect this.

Differential Revision: https://phabricator.services.mozilla.com/D169014
2023-02-07 14:25:47 +00:00
Otto Länd
c333f002e7 Bug 1811281, 1812704: apply code formatting via Lando
# ignore-this-changeset
2023-01-31 16:24:28 +00:00
Mike Conley
58108e2c7e Bug 1812704 - Wire up the new MigrationWizard to MigrationUtils to let it perform migrations. r=NeilDeakin
Differential Revision: https://phabricator.services.mozilla.com/D167998
2023-01-31 15:30:58 +00:00
Mike Conley
9c17617fb0 Bug 1811281 - Open new MigrationWizard dialog as a SubDialog in about:preferences rather than a TabDialog. r=Gijs,settings-reviewers
This does a few things to support this new behaviour:

1. Adds the ability for about:preferences category modules to indicate that
   they want to specially handle subcategories. In this particular case, it
   causes the "migrate" subcategory of the "general" category to open up the
   migration dialog.
2. Updates MigrationUtils to open about:preferences#general-migrate if the opener
   is a tabbrowser window.
3. Adds some utility functions to make writing tests easier.
4. Updates existing tests to expect the wizard to be opened in the about:preferences
   subdialog.
5. Makes pressing "Escape" close the migration wizard when it's loaded in the
   migration-dialog.html document.

Differential Revision: https://phabricator.services.mozilla.com/D167873
2023-01-31 15:30:57 +00:00
Mike Conley
f5afc7a2e3 Bug 1811935 - Adjust visibility of the resource types available for each migrator / profile pair in the new migration wizard. r=Gijs
This causes the MigrationWizardChild to request the full collection of available
migrators and user profiles, and then based on which resourceTypes those migrators
and user profiles have available, changes the visibility of the checkboxes in the
selection page of the new MigrationWizard component.

Differential Revision: https://phabricator.services.mozilla.com/D167617
2023-01-25 12:53:31 +00:00
Marian-Vasile Laza
9f616e2e60 Backed out changeset 97ee58e6c65d (bug 1811935) for causing bc failures on browser_dialog_cancel_close.js. CLOSED TREE 2023-01-25 04:06:11 +02:00
Mike Conley
2683edea63 Bug 1811935 - Adjust visibility of the resource types available for each migrator / profile pair in the new migration wizard. r=Gijs
This causes the MigrationWizardChild to request the full collection of available
migrators and user profiles, and then based on which resourceTypes those migrators
and user profiles have available, changes the visibility of the checkboxes in the
selection page of the new MigrationWizard component.

Differential Revision: https://phabricator.services.mozilla.com/D167617
2023-01-24 21:15:03 +00:00
Marco Bonardo
275a5e4803 Bug 1760074 - Frequent failure of test_MigrationUtils_timedRetry.js. r=Gijs
For how much it may sound strange, sometimes all the reads just happen before
the write, so they won't see the table.
Also fixes a wrong check on previousException.

Differential Revision: https://phabricator.services.mozilla.com/D167478
2023-01-23 15:44:10 +00:00
Mark Banner
2bd093b567 Bug 1811334 - Automatically replace Cu.reportError with console.error (most of browser/components). r=settings-reviewers,mconley
Differential Revision: https://phabricator.services.mozilla.com/D167297
2023-01-20 17:49:21 +00:00
Otto Länd
2d62b90a6e Bug 1809498, 1810240: apply code formatting via Lando
# ignore-this-changeset
2023-01-17 20:33:50 +00:00
Mike Conley
d538cb869d Bug 1810240 - Make sure migration dialog container resizes when the wizard changes size. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D166839
2023-01-17 20:30:59 +00:00
Mike Conley
1bb03a6fc0 Bug 1809498 - Make browser.migrate.content-modal.enabled also control opening the new migration-dialog.html document. r=niklas
Differential Revision: https://phabricator.services.mozilla.com/D166838
2023-01-17 20:30:58 +00:00
Mike Conley
10d5cbd8c2 Bug 1809330 - Allow the MigrationWizard to close dialogs that it is embedded in. r=niklas
Differential Revision: https://phabricator.services.mozilla.com/D166392
2023-01-16 22:25:40 +00:00
Mike Conley
ce5bae69ff Bug 1803447 - Implement progress page for the new migration wizard. r=hjones,kpatenio,mstriemer
Differential Revision: https://phabricator.services.mozilla.com/D165090
2023-01-16 22:25:40 +00:00
Csoregi Natalia
797db34488 Backed out 2 changesets (bug 1803447, bug 1809330) for failures on browser_dialog_cancel_close.js. CLOSED TREE
Backed out changeset 57167994f026 (bug 1809330)
Backed out changeset 4c1fd71421ab (bug 1803447)
2023-01-14 04:10:45 +02:00
Mike Conley
70e3458ae0 Bug 1809330 - Allow the MigrationWizard to close dialogs that it is embedded in. r=niklas
Differential Revision: https://phabricator.services.mozilla.com/D166392
2023-01-13 18:28:04 +00:00
Mike Conley
614f7fc403 Bug 1803447 - Implement progress page for the new migration wizard. r=hjones,kpatenio,mstriemer
Differential Revision: https://phabricator.services.mozilla.com/D165090
2023-01-13 18:28:03 +00:00
Ben Hearsum
01f485b050 Bug 1805919: disable tests that are currently failing against MSIX packages. r=jmaher,necko-reviewers,kershaw
Differential Revision: https://phabricator.services.mozilla.com/D165754
2023-01-11 14:45:03 +00:00
brian
ec76ee9539 Bug 1619090 - Clean up crypto modules that are used/referenced from various platforms. r=mconley,credential-management-reviewers,dimi.
Differential Revision: https://phabricator.services.mozilla.com/D164831
2023-01-05 15:38:11 +00:00
Marco Bonardo
c4325e1a9b Bug 1457131 - Remove no longer necessary PlacesUtils.toolbarFolderId. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D165769
2023-01-04 13:16:10 +00:00
Marco Castelluccio
ba39d286d5 Bug 1801836 - Remove no longer necessary 'from __future__' imports. r=linter-reviewers,glandium,webdriver-reviewers,perftest-reviewers,geckoview-reviewers,jld,ahal,owlish,afinder DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D165395
2022-12-23 22:45:46 +00:00
Mike Conley
b194903466 Bug 718280 - Part 3: Get rid of some leftover wrappedJSObject usage now that the migrators aren't acquired through XPCOM. r=NeilDeakin
Depends on D164139

Differential Revision: https://phabricator.services.mozilla.com/D164140
2022-12-13 17:01:25 +00:00
Mike Conley
439288e699 Bug 718280 - Part 2: Move registration of migrators into MigrationUtils instead of components.conf. r=NeilDeakin
Depends on D164138

Differential Revision: https://phabricator.services.mozilla.com/D164139
2022-12-13 17:01:24 +00:00
Sandor Molnar
c46a05c875 Backed out 9 changesets (bug 1800917, bug 718280) for causing xpc failures in browser/components/migration/tests/unit/test_Edge_db_migration.js CLOSED TREE
Backed out changeset d55b95d9d14f (bug 1800917)
Backed out changeset 8427f1e65df4 (bug 1800917)
Backed out changeset 2d0f77d324f2 (bug 718280)
Backed out changeset eba58fd1ed1c (bug 718280)
Backed out changeset 33027a0f9ce9 (bug 718280)
Backed out changeset 237be1f62d01 (bug 718280)
Backed out changeset 007afe158ae5 (bug 718280)
Backed out changeset f1dea7abdfb7 (bug 718280)
Backed out changeset 47e2cccd33c7 (bug 718280)
2022-12-13 00:50:16 +02:00
Mike Conley
8d7cf18a05 Bug 718280 - Part 3: Get rid of some leftover wrappedJSObject usage now that the migrators aren't acquired through XPCOM. r=NeilDeakin
Differential Revision: https://phabricator.services.mozilla.com/D164140
2022-12-12 16:04:03 +00:00
Mike Conley
12b8c61465 Bug 718280 - Part 2: Move registration of migrators into MigrationUtils instead of components.conf. r=NeilDeakin
Differential Revision: https://phabricator.services.mozilla.com/D164139
2022-12-12 16:04:03 +00:00
Mike Conley
56e95c55b0 Bug 1802961 - Convert MigratorPrototype into an ES6 class and move into its own ESM as MigratorBase to be subclassed. r=NeilDeakin
Differential Revision: https://phabricator.services.mozilla.com/D163257
2022-12-06 17:50:39 +00:00
Mike Conley
b3072d6b33 Bug 1802358 - Enable require-jsdoc / valid-jsdoc for browser/components/migration. r=kpatenio
This doesn't do a thorough job of actually documenting things, it just makes sure that
the existing documentation abides by the JSDoc formatting rules. I did flesh out some
documentation here and there, but writing new / updating / clarifying documentation is
left as later work.

Differential Revision: https://phabricator.services.mozilla.com/D163133
2022-12-06 17:50:38 +00:00
Mike Conley
29c8bccf6f Bug 1801314 - Add initial infrastructure for a migration wizard reusable component. r=Gijs,kpatenio,NeilDeakin,niklas,mstriemer
This adds:

1. A new <migration-wizard> component
2. A new migration-dialog.html document that loads it
3. JSWindowActors for communicating between whatever process the migration-wizard is
   loaded in and the parent process. The actors are currently restricted to running
   in these documents:
     about:welcome
     about:preferences
     chrome://browser/content/migration/migration-dialog.html
4. A very small, simple mochitest-chrome test for testing the widget
5. Some Fluent strings for the new <migration-wizard>, dropped into a new folder in
   /browser called "locales-preview". This is so that both the jar packaging can
   put the Fluent file somewhere sensible that doesn't (currently) require our
   localizers to translate, but also so that Storybook can load that Fluent file.
6. Modifications to our Storybook infrastructure so that attempts to load items
   from locales-preview will map to the browser/locales-preview folder.
7. A Storybook story for the <migration-wizard> that puts it in a few basic states.
   Most of those states aren't actually implemented yet, but are left in the story to
   make it easier to develop those states in the component.

The hope is that when this is done, it should be relatively straight-forward to
embed the <migration-wizard> not just in the migration-dialog.html document (which
is used for tab modals and the stand alone migration dialog), but also in existing
in-content pages like about:welcome and about:preferences.

For those worried about the TODO strings or incomplete behaviour, remember that this
is just a base for building upon, and that this component / dialog isn't actually
exposed to users yet.

The dialog can be opened manually via:

```lang=js
gBrowser.getTabDialogBox(gBrowser.selectedBrowser).open("chrome://browser/content/migration/migration-dialog.html")
```

and see the documentation in browser/components/storybook/README.md for guidance on
how to view this component using Storybook.

Differential Revision: https://phabricator.services.mozilla.com/D162623
2022-12-06 17:50:38 +00:00
Gijs Kruitbosch
789f034153 Bug 1803158 - also fix sessionstore import in fx refresh test CLOSED TREE
Differential Revision: https://phabricator.services.mozilla.com/D163961
2022-12-06 18:22:44 +00:00
Gijs Kruitbosch
965c6e86fc Bug 1803158 - convert session restore consumers to reference the sys.mjs files instead, r=webdriver-reviewers,perftest-reviewers,extension-reviewers,credential-management-reviewers,Standard8,sgalich,whimboo,sparky,willdurand
Differential Revision: https://phabricator.services.mozilla.com/D163350
2022-12-06 16:02:03 +00:00
Butkovits Atila
b517540509 Backed out 7 changesets (bug 1802358, bug 1801314, bug 1802961) for causing documentation failures.
Backed out changeset bb0f5e137128 (bug 1802961)
Backed out changeset 4c2a66bfe913 (bug 1802961)
Backed out changeset baaa090cada1 (bug 1802961)
Backed out changeset d98ee38a13bb (bug 1802961)
Backed out changeset 618dcf6d8284 (bug 1802961)
Backed out changeset 59d98ca9fd51 (bug 1802358)
Backed out changeset bce1ea9149bd (bug 1801314)
2022-12-06 18:21:11 +02:00
Mike Conley
16b3a62829 Bug 1802961 - Convert MigratorPrototype into an ES6 class and move into its own ESM as MigratorBase to be subclassed. r=NeilDeakin
Differential Revision: https://phabricator.services.mozilla.com/D163257
2022-12-06 14:46:42 +00:00
Mike Conley
79f19336b8 Bug 1802358 - Enable require-jsdoc / valid-jsdoc for browser/components/migration. r=kpatenio
This doesn't do a thorough job of actually documenting things, it just makes sure that
the existing documentation abides by the JSDoc formatting rules. I did flesh out some
documentation here and there, but writing new / updating / clarifying documentation is
left as later work.

Differential Revision: https://phabricator.services.mozilla.com/D163133
2022-12-06 14:46:41 +00:00
Mike Conley
060df6bb4b Bug 1801314 - Add initial infrastructure for a migration wizard reusable component. r=Gijs,kpatenio,NeilDeakin,niklas,mstriemer
This adds:

1. A new <migration-wizard> component
2. A new migration-dialog.html document that loads it
3. JSWindowActors for communicating between whatever process the migration-wizard is
   loaded in and the parent process. The actors are currently restricted to running
   in these documents:
     about:welcome
     about:preferences
     chrome://browser/content/migration/migration-dialog.html
4. A very small, simple mochitest-chrome test for testing the widget
5. Some Fluent strings for the new <migration-wizard>, dropped into a new folder in
   /browser called "locales-preview". This is so that both the jar packaging can
   put the Fluent file somewhere sensible that doesn't (currently) require our
   localizers to translate, but also so that Storybook can load that Fluent file.
6. Modifications to our Storybook infrastructure so that attempts to load items
   from locales-preview will map to the browser/locales-preview folder.
7. A Storybook story for the <migration-wizard> that puts it in a few basic states.
   Most of those states aren't actually implemented yet, but are left in the story to
   make it easier to develop those states in the component.

The hope is that when this is done, it should be relatively straight-forward to
embed the <migration-wizard> not just in the migration-dialog.html document (which
is used for tab modals and the stand alone migration dialog), but also in existing
in-content pages like about:welcome and about:preferences.

For those worried about the TODO strings or incomplete behaviour, remember that this
is just a base for building upon, and that this component / dialog isn't actually
exposed to users yet.

The dialog can be opened manually via:

```lang=js
gBrowser.getTabDialogBox(gBrowser.selectedBrowser).open("chrome://browser/content/migration/migration-dialog.html")
```

and see the documentation in browser/components/storybook/README.md for guidance on
how to view this component using Storybook.

Differential Revision: https://phabricator.services.mozilla.com/D162623
2022-12-06 14:46:41 +00:00
Emily McMinn
58f6523296 Bug 1789899 - Remove OSFile from the Chrome profile migrator r=barret
Differential Revision: https://phabricator.services.mozilla.com/D163149
2022-11-29 20:18:12 +00:00
Barret Rennie
d1a2566d45 Bug 1541508 - Use Services.env in browser/ r=mossop
Differential Revision: https://phabricator.services.mozilla.com/D160136
2022-11-25 19:09:06 +00:00
brian
549c74ccef Bug 1673047 - Remove browser.migrate.showBookmarksToolbarAfterMigration pref and set the default behavior to the 'true' branch. r=mconley.
Differential Revision: https://phabricator.services.mozilla.com/D161375
2022-11-22 15:30:56 +00:00
Marco Castelluccio
5bcb4a1506 Bug 1790816 - Reformat browser/ with isort. r=linter-reviewers,search-reviewers,Standard8 DONTBUILD
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D162667
2022-11-22 11:09:34 +00:00
Mark Banner
5d1820b074 Bug 1799314 - Convert consumers of testing modules to import ES modules direct (browser/). r=Gijs,settings-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D161914
2022-11-17 12:00:30 +00:00