Commit Graph

609 Commits

Author SHA1 Message Date
Narcis Beleuzu
81813a40f3 Backed out 12 changesets (bug 1824112) for mochitest failures on test_autocomplete_autofill_related_realms_no_dupes.html . CLOSED TREE
Backed out changeset 1b884731cc88 (bug 1824112)
Backed out changeset a5c59331e797 (bug 1824112)
Backed out changeset fec2998bed4f (bug 1824112)
Backed out changeset 3b86742b481e (bug 1824112)
Backed out changeset fdf4845c5a44 (bug 1824112)
Backed out changeset 378d2832774b (bug 1824112)
Backed out changeset f24f6a88b9a0 (bug 1824112)
Backed out changeset dd3b06a85ac8 (bug 1824112)
Backed out changeset e19d6f69fd8a (bug 1824112)
Backed out changeset e96c54b21c45 (bug 1824112)
Backed out changeset b51f68d02f4c (bug 1824112)
Backed out changeset 30aa8323efcd (bug 1824112)
2023-05-02 15:02:59 +03:00
Johannes J. Schmidt
2dccf786ac Bug 1824112 - switch to addLoginAsync in tests r=credential-management-reviewers,sync-reviewers,sgalich,markh
Differential Revision: https://phabricator.services.mozilla.com/D175704
2023-05-02 09:22:07 +00:00
steven wang
07404a0f13 Bug 1827425 - Import form autofill entries from Chrome-based browsers. r=mconley.
Differential Revision: https://phabricator.services.mozilla.com/D175588
2023-05-02 00:41:10 +00:00
Sandor Molnar
8ba3c187c7 Backed out 3 changesets (bug 1824112) for causing failures related in toolkit/components/passwordmgr/<...> CLOSED TREE
Backed out changeset 54334826f02e (bug 1824112)
Backed out changeset 01a71441e86a (bug 1824112)
Backed out changeset 1d21bc78852c (bug 1824112)
2023-04-24 12:20:18 +03:00
Johannes J. Schmidt
da31c33064 Bug 1824112 - switch to addLoginAsync in tests r=credential-management-reviewers,sync-reviewers,sgalich,markh
Differential Revision: https://phabricator.services.mozilla.com/D175704
2023-04-24 07:52:22 +00:00
Mike Conley
efc612f60b Bug 1829196 - Use the term 'Continue' rather than 'Done' in the success state of the new migration wizard when embedding. r=niklas,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D176072
2023-04-21 03:18:13 +00:00
Mike Conley
a98705b9fd Bug 1828758 - Make Password file migrator only available if importing logins from CSV is enabled. r=kpatenio
Differential Revision: https://phabricator.services.mozilla.com/D175804
2023-04-18 22:36:26 +00:00
Mike Conley
4922e2e5c2 Bug 1827204 - Set the right aria roles and attributes for the browser profile selector in the new migration wizard. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D175052
2023-04-18 14:31:50 +00:00
Brian
85c3bf414d Bug 1824640 - Write a test that ensures that if there are no browser profile migrators available, the new Migration Wizard is sent to the NO_BROWSERS_FOUND page. r=mconley.
Differential Revision: https://phabricator.services.mozilla.com/D175149
2023-04-18 14:09:31 +00:00
Mike Conley
3b8c2d4517 Bug 1827274 - Allow users to use file importers after showing NO_BROWSERS_FOUND page in the new migration wizard. r=kpatenio,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D175069
2023-04-14 17:37:57 +00:00
Mike Conley
a6b4bb2db1 Bug 1821187 - Add infrastructure for file migrators in the new Migration Wizard. r=fluent-reviewers,kpatenio,flod
This also includes our first file migrator, which imports passwords from CSV/TSV files.

Depends on D174537

Differential Revision: https://phabricator.services.mozilla.com/D173033
2023-04-13 20:15:03 +00:00
Butkovits Atila
08ba617ed0 Backed out 2 changesets (bug 1821187) for causing failures at browser_file_migration.js. CLOSED TREE
Backed out changeset 8402100dfc12 (bug 1821187)
Backed out changeset 2a7196e34b3d (bug 1821187)
2023-04-13 05:28:27 +03:00
Mike Conley
cd18f710fc Bug 1821187 - Add infrastructure for file migrators in the new Migration Wizard. r=fluent-reviewers,kpatenio,flod
This also includes our first file migrator, which imports passwords from CSV/TSV files.

Differential Revision: https://phabricator.services.mozilla.com/D173033
2023-04-13 01:28:38 +00:00
Mike Conley
40cfbea3c0 Bug 1827431 - Make sure to select the appropriate profile when choosing what resource data is available for migration. r=niklas
We weren't passing the appropriate profile object to getMigrateData, and thanks to mocking,
we didn't catch this in automated testing.

This patch fixes the issue, and updates our mocking helpers to ensure that the expected
profile object gets passed to the `getResources` calls during mochitest-browser tests.

Differential Revision: https://phabricator.services.mozilla.com/D175144
2023-04-12 16:01:41 +00:00
Mike Conley
a1a329e69b Bug 1827206 - Focus the Done button after migration completes in the new wizard. r=kpatenio
Differential Revision: https://phabricator.services.mozilla.com/D175050
2023-04-11 20:53:23 +00:00
Mike Conley
02d9100424 Bug 1827205 - Make sure browser / profile selector is focused when showing the selection page in the new migration wizard. r=kpatenio
Differential Revision: https://phabricator.services.mozilla.com/D175049
2023-04-11 20:53:22 +00:00
Ebilite Uchenna
ed5dc481d8 Bug 1824611 - Convert consumers of toolkit/components/passwordmgr to import ES modules directly. r=Standard8,credential-management-reviewers,settings-reviewers,fxview-reviewers,sclements,sgalich,geckoview-reviewers,owlish
Differential Revision: https://phabricator.services.mozilla.com/D174446
2023-04-11 19:06:24 +00:00
Nolan Ishii
26618c8cf1 Bug 1822133 Write a test that checks that disabled migrators do not appear in the new Migration Wizard. r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D173854
2023-04-11 17:46:16 +00:00
Tooru Fujisawa
18d749f6ff Bug 1821308 - Part 2: Convert ctypes.jsm consumers to use ESM. r=Standard8,geckoview-reviewers,application-update-reviewers,credential-management-reviewers,sgalich,bytesized,m_kato
Differential Revision: https://phabricator.services.mozilla.com/D173811
2023-04-11 01:25:15 +00:00
Mike Conley
2075b4ef54 Bug 1825854 - Add a preference to control the behavior of the migration wizard when opened from about:welcome. r=settings-reviewers,mstriemer
This is controlled by the migrationWizard.aboutWelcomeBehavior Nimbus feature variable.

Differential Revision: https://phabricator.services.mozilla.com/D174326
2023-04-05 21:40:46 +00:00
Angel_V129
d4af15e01a Bug 1819423 - Add support for importing synced bookmarks for Chrome-based browsers. r=kpatenio.
Differential Revision: https://phabricator.services.mozilla.com/D173391
2023-04-05 15:34:01 +00:00
elephanteatsapple
bf129f986c Bug 1824870 - Fix Sinon usage in browser_safari_permissions.js. r=mconley,kpatenio
This makes it so that we properly use and restore a Sinon sandbox when stubbing out things
on the SafariProfileMigrator, whereas before we were merely stubbing and not restoring.

Differential Revision: https://phabricator.services.mozilla.com/D174647
2023-04-04 17:08:37 +00:00
Mike Conley
e893ea3c9b Bug 1825632 - Collect migration interaction telemetry for each resource type, not just the last one migrated. r=dmose
Differential Revision: https://phabricator.services.mozilla.com/D174165
2023-04-03 20:47:12 +00:00
steven wang
f6145d6708 Bug 1819334 - Display an error message when no importable resources can be found for a browser / profile pair. r=mconley,fluent-reviewers.
Differential Revision: https://phabricator.services.mozilla.com/D173544
2023-03-31 15:17:19 +00:00
Mike Conley
77137ac6ce Bug 1801981 - Use the word "favorites" instead of "bookmarks" when importing from IE / Edge. r=niklas,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D173567
2023-03-29 17:58:22 +00:00
CanadaHonk
de0de3489c Bug 1801379 - Migrate Sinon.jsm to an ES module r=extension-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,fxview-reviewers,devtools-reviewers,Standard8,nchevobbe,sclements,dimi,mconley,bytesized,robwu
Migrated `testing/modules/Sinon.sys.mjs` to an ES module.

`testing` should now be 100% ESM 🎉

Differential Revision: https://phabricator.services.mozilla.com/D173643
2023-03-29 07:34:10 +00:00
Mike Conley
4c8c666841 Bug 1825024 - Make sure that the Select All checkbox is checked if all visible resources are checked, and unchecked otherwise. r=kpatenio
Differential Revision: https://phabricator.services.mozilla.com/D173851
2023-03-28 19:26:26 +00:00
Mike Conley
8df981ea97 Bug 1825009 - Make sure that Select All only checks resources that are visible. r=kpatenio
This also adds some belt-and-suspenders checks here so that even if the Migration Wizard
somehow gets confused and sends resource types that the migrator can't import from, they'll
just get ignored rather than having a forever-progress-spinner for that resource type.

Differential Revision: https://phabricator.services.mozilla.com/D173848
2023-03-28 19:26:26 +00:00
Norisz Fay
6c27e66d65 Backed out changeset 073659e911d4 (bug 1822133) for causing bc failures on browser_disabled_migrator.js 2023-03-28 21:24:46 +03:00
Nolan Ishii
eb01bd1b81 Bug 1822133 Write a test that checks that disabled migrators do not appear in the new Migration Wizard. r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D173854
2023-03-28 17:02:49 +00:00
Mike Conley
eccb282189 Bug 1822676 - Have the new Migration Wizard request permissions if necessary for Safari import. r=NeilDeakin
Differential Revision: https://phabricator.services.mozilla.com/D172840
2023-03-27 20:08:54 +00:00
Cosmin Sabou
4b7311ed63 Backed out changeset fe5dd9d4dcbb (bug 1822676) for causing macOS shippable bc failures on browser_safari_permissions.js. 2023-03-27 21:21:39 +03:00
Mike Conley
034a782282 Bug 1794617 - Record interaction preferences when bookmarks, history, or passwords are imported. data-review=jhirsch,r=Gijs
These preferences are sent via Telemetry through TelemetryEnvironment.

For the FirefoxProfileMigrator, which is used for profile resets, we don't
set these prefs during the migration of those resources. Instead, during
OTHERDATA, we examine the prefs.js of the old profile for the prefs and
attempt to migrate them to a new prefs file in the new profile.

Differential Revision: https://phabricator.services.mozilla.com/D173481
2023-03-27 17:25:26 +00:00
Mike Conley
bd4fe113d7 Bug 1822676 - Have the new Migration Wizard request permissions if necessary for Safari import. r=NeilDeakin
Differential Revision: https://phabricator.services.mozilla.com/D172840
2023-03-27 16:51:12 +00:00
Iulian Moraru
16af5615b7 Backed out changeset 518a61189274 (bug 1822676) for causing doc-generate failures. CLOSED TREE 2023-03-27 19:12:29 +03:00
Mike Conley
5919c6fa99 Bug 1822676 - Have the new Migration Wizard request permissions if necessary for Safari import. r=NeilDeakin
Differential Revision: https://phabricator.services.mozilla.com/D172840
2023-03-27 14:48:39 +00:00
Mike Conley
3f1dad74c9 Bug 1823965 - Update success strings for HISTORY and FORMDATA resource imports in the new migration wizard. r=niklas,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D173319
2023-03-23 20:42:20 +00:00
Nolan Ishii
ed95067087 Bug 1822309 - Disable the 'Import' button in the selection page of the new Migration Wizard if no resource types are selected. r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D172810
2023-03-22 15:55:01 +00:00
Mike Conley
e8af8e6305 Bug 1820790 - Generalize the 180 day history import limit, and apply it to IE and Edge (EdgeHTML) migrators. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D172718
2023-03-21 15:18:34 +00:00
Mike Conley
c3739b9d73 Bug 1814278 - Align the spacing and layout of the new Migration Wizard more closely to the spec. r=kpatenio,fluent-reviewers,flod,settings-reviewers
Along with bringing us closer to the layout and spacing from Figma, this does the following:

1. Changes the header element to an <h1> and uses CSS to get the expected font size. This should
   make the organization of the wizard make more sense to screenreaders.
2. Handles the "single resource" case for Variant 2, where we hide "Select All" and align the
   resource list to the left if there's only a single resource to import.
3. Fixes a string to match the spec.

Differential Revision: https://phabricator.services.mozilla.com/D173054
2023-03-21 12:35:19 +00:00
Mike Conley
6efbf62ca8 Bug 1822692 - Add tests for migration wizard entrypoint telemetry. r=Gijs
Depends on D172735

Differential Revision: https://phabricator.services.mozilla.com/D172815
2023-03-20 21:55:15 +00:00
Mike Conley
0d347f3bbf Bug 1822686 - Add a browser profile selector button to the new Migration Wizard more closely aligned with the specification. r=kpatenio
Differential Revision: https://phabricator.services.mozilla.com/D172832
2023-03-20 16:42:26 +00:00
elephanteatsapple
2f039e6f10 Bug 1811933 -Replace placeholder <select> and <options> in MigrationWizard with a <button> and a <panel-list>. r=mconley,settings-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D170420
2023-03-20 14:56:41 +00:00
steven wang
410aed13c6 Bug 1819167 - Put a message above the resource checkboxes in Variant 1 of the MigrationWizard. r=mconley,fluent-reviewers,flod.
Differential Revision: https://phabricator.services.mozilla.com/D172524
2023-03-16 14:14:07 +00:00
Angel_V129
df90d47fcf Bug 1814941 - Chrome - Don't list resources for import when those resources won't actually bring things over. r=kpatenio.
Differential Revision: https://phabricator.services.mozilla.com/D169034
2023-03-16 14:07:52 +00:00
Nolan Ishii
f243dbd6d7 Bug 1820798 - Variant 2 selector page details section should default to closed. r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D172583
2023-03-15 19:16:13 +00:00
Alvin Lew
cc50311702 Bug 326701 - Favicons should be imported from Safari r=mconley
Depends on D162361

Differential Revision: https://phabricator.services.mozilla.com/D161306
2023-03-13 16:54:59 +00:00
BryanMacoy
622a092b6f Bug 711995 - Favicons should be imported from Chrome. r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D162361
2023-03-13 16:54:58 +00:00
Nolan Ishii
2fe7189288 Bug 1815749 Make variant 2's list of resource types in the <summary> reflect the checked items within the <details>. r=mconley,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D170228
2023-03-13 16:16:16 +00:00
Mike Conley
09574d63a6 Bug 1819343 - Allow MigrationWizard initialization to be kicked off either on binding to the DOM or with script. r=kpatenio,settings-reviewers,Gijs
Up until now, we've used the connectedCallback to initialize the MigrationWizard. That's
been fine, except that it requires us to remove and then re-add the element to the DOM
if we want to "reset" it and start over.

This patch adds a method "requestState" to the MigrationWizard that kicks off the
initialization. Embedders can set the `auto-request-state` attribute on the
element if they're happy to just use the connectedCallback.

Finally, this adds an intrinsic width to the entire MigrationWizard element to reduce
flicker when transitioning between states.

Differential Revision: https://phabricator.services.mozilla.com/D171742
2023-03-06 21:39:01 +00:00