Commit Graph

585 Commits

Author SHA1 Message Date
Sam Foster
4a8bd7b5f3 Bug 1833522 - Share some of sessionstore's test helpers for use in recently-closed tab tests. r=sclements,fxview-reviewers,sessionstore-reviewers
* Move closeTab and openAndCloseTab to the helpers module and replace a couple of uses
* Move waitForBrowserState/promiseBrowserState and replace a couple of uses

Differential Revision: https://phabricator.services.mozilla.com/D187636
2023-09-08 00:36:32 +00:00
Mike Kaply
068962bb83 Bug 1851525 - Allow Firefox View icon to be set via Nimbus. r=sclements,desktop-theme-reviewers,fxview-reviewers,dao,sfoster
Differential Revision: https://phabricator.services.mozilla.com/D187458
2023-09-07 18:01:32 +00:00
Mike Kaply
1efa6e4e81 Bug 1850385 - Handle cases where sync "worked" but we have no devices. r=sclements,fxview-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D186957
2023-09-07 10:44:01 +00:00
Mike Kaply
26d0ca572d Bug 1851830 - Move new Firefox View tests into their own subdir. r=fxview-reviewers,sfoster
Differential Revision: https://phabricator.services.mozilla.com/D187557
2023-09-06 17:08:22 +00:00
Sandor Molnar
3898c4b253 Backed out changeset f5f15b313e48 (bug 1851525) for causing bc failures in browser/base/content/test/performance/browser_startup_images.js 2023-09-06 17:46:35 +03:00
Mike Kaply
399f06dfdf Bug 1851525 - Allow Firefox View icon to be set via Nimbus. r=sclements,desktop-theme-reviewers,fxview-reviewers,dao,sfoster
Differential Revision: https://phabricator.services.mozilla.com/D187458
2023-09-06 13:41:27 +00:00
Kelly Cochrane
fe7250d244 Bug 1846255 - Fix tab key navigation for 'Show more' link in Open Tabs cards r=jsudiaman,fxview-reviewers,sclements
Differential Revision: https://phabricator.services.mozilla.com/D187123
2023-09-05 15:39:05 +00:00
Stanca Serban
e67acd7a11 Backed out changeset 798de3f71896 (bug 1846255) for causing OSX mochitests failures in test_opentabs.html. CLOSED TREE 2023-09-05 18:20:21 +03:00
Kelly Cochrane
be00a4904f Bug 1846255 - Fix tab key navigation for 'Show more' link in Open Tabs cards r=jsudiaman,fxview-reviewers,sclements
Differential Revision: https://phabricator.services.mozilla.com/D187123
2023-09-05 14:23:23 +00:00
Sarah Clements
6bde708b88 Bug 1851453 - Disable notification dot in firefox view r=mkaply
Differential Revision: https://phabricator.services.mozilla.com/D187372
2023-09-04 14:17:18 +00:00
Jonathan Sudiaman
4c61f4aca1 Bug 1842602 - Add observer handler functions to viewpage.mjs in about:firefoxview-next r=sfoster,fxview-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D187214
2023-09-01 14:58:46 +00:00
Shane Hughes
3ead9a6e2e Bug 1842366 - Part 2: Allow rendering Feature Callout in panels. r=jprickett,desktop-theme-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D183074
2023-08-31 08:14:41 +00:00
Butkovits Atila
5cbed29ced Backed out 2 changesets (bug 1842366) for causing Xpcshell failures at test_PanelTestProvider.js. CLOSED TREE
Backed out changeset bcc147043981 (bug 1842366)
Backed out changeset c9e538ad8526 (bug 1842366)
2023-08-31 07:43:26 +03:00
Shane Hughes
4db2cd3f28 Bug 1842366 - Part 2: Allow rendering Feature Callout in panels. r=jprickett,desktop-theme-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D183074
2023-08-31 03:29:05 +00:00
Sarah Clements
ac182b4208 Bug 1847981 - Flip pref to make firefoxview-next the default r=fxview-reviewers,sfoster
Differential Revision: https://phabricator.services.mozilla.com/D186849
2023-08-29 15:21:41 +00:00
Kelly Cochrane
3efa9b6ff1 Bug 1845356 - Update Firefox View toolbarbutton icon and label/tooltip r=fluent-reviewers,desktop-theme-reviewers,fxview-reviewers,flod,dao,sclements
Differential Revision: https://phabricator.services.mozilla.com/D184970
2023-08-29 12:40:52 +00:00
Cristian Tuns
8c85348a92 Backed out changeset c35a3bb94b22 (bug 1845356) for causing bc failures in browser_feature_callout_position.js CLOSED TREE 2023-08-28 17:53:19 -04:00
Kelly Cochrane
519c6a54e9 Bug 1845356 - Update Firefox View toolbarbutton icon and label/tooltip r=fluent-reviewers,desktop-theme-reviewers,fxview-reviewers,flod,dao,sclements
Differential Revision: https://phabricator.services.mozilla.com/D184970
2023-08-28 19:52:09 +00:00
Sam Foster
f078d2dc51 Bug 1845836 - Include closed tabs from closed windows in fxview-next's recently closed tabs list. r=kcochrane,dao,fxview-reviewers,sessionstore-reviewers,sclements
* Add a browser.sessionstore.closedTabsFromClosedWindows pref and consult it when building recently-closed tab lists in firefoxview-next
* Add a _resolveClosedDataSource to SessionStore which allows us to find the window state and _closedTabs given a DOMWindow, a window closedId, or a window session store Id.
* Carry window closedId and source window Id into tab items when building recently-closed tab lists in firefoxview-next. This gives us the necessary context when we need to undoClose or forget a tab item in the list.
* Add a getClosed TabCount and TabData for Closed Windows method to SessionStore
* Modify undoCloseTab and forgetClosedTab to accept source params we can resolve to window state data using _resolveClosedDataSource

Differential Revision: https://phabricator.services.mozilla.com/D185108
2023-08-22 20:42:57 +00:00
Kelly Cochrane
694558cb1e Bug 1842616 - Add telemetry for Recently Closed tabs r=mkaply,fxview-reviewers,sclements
Differential Revision: https://phabricator.services.mozilla.com/D186190
2023-08-18 16:06:33 +00:00
Kelly Cochrane
a5472eccee Bug 1846572 - Adding role='application' to fix keyboard navigation in Firefox View with NVDA on Windows r=mkaply,fluent-reviewers,ayeddi,flod
Differential Revision: https://phabricator.services.mozilla.com/D185339
2023-08-17 16:22:30 +00:00
Cristina Horotan
b7e7458627 Backed out changeset 7d891879797e (bug 1846572) for causing bc failures at browser_firefoxview_next.js CLOSED TREE 2023-08-16 02:55:34 +03:00
Kelly Cochrane
21a8b1bd68 Bug 1846572 - Adding role='application' to fix keyboard navigation in Firefox View with NVDA on Windows r=mkaply,fluent-reviewers,ayeddi,flod
Differential Revision: https://phabricator.services.mozilla.com/D185339
2023-08-15 21:52:20 +00:00
Mike Kaply
982779a66b Bug 1846597 - Use proper semantic styling for headers in view. r=jsudiaman,fxview-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D185612
2023-08-11 14:03:36 +00:00
Kelly Cochrane
84d3e01388 Bug 1846545 - Update card-container to use 'pageName' and 'showViewAll' properties r=mkaply,fxview-reviewers,sclements
Differential Revision: https://phabricator.services.mozilla.com/D185852
2023-08-10 17:00:16 +00:00
Shane Hughes
d7c28ab5e7 Bug 1784343 - Disable browser_feature_callout_position test on linux. r=fxview-reviewers,sfoster
Differential Revision: https://phabricator.services.mozilla.com/D185698
2023-08-08 21:28:48 +00:00
Kelly Cochrane
cd7a096ba5 Bug 1845709 - Add a cards-container in synced tabs to fix scrolling issues. r=kcochrane,fxview-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D185590
2023-08-08 14:11:13 +00:00
Mike Kaply
98e49dc18a Bug 1845489 - Don't set errorState if there isn't one. r=jsudiaman,fxview-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D185565
2023-08-07 19:49:24 +00:00
Kelly Cochrane
aadbaf770f Bug 1846393 - Fix for browser_history_firefoxview_next.js test failures r=fxview-reviewers,sclements
Differential Revision: https://phabricator.services.mozilla.com/D185080
2023-08-02 14:18:53 +00:00
Iulian Moraru
081f900d00 Bug 1846393 - disable browser_history_firefoxview_next.js for permanent test failure which started with new month
The new month triggered a new card for July

Differential Revision: https://phabricator.services.mozilla.com/D184993
2023-08-01 15:10:54 +00:00
Mike Kaply
8098393414 Bug 1845122 - Use ID for indexing devices to properly handle duplicates. r=sfoster,fxview-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D184764
2023-08-01 11:49:09 +00:00
Sam Foster
7bb84fd335 Bug 1842610 - Add SessionStore.forgetClosedWindowById and forgetClosedTabById and update RecentlyClosedTabsInView to use the new forget and aggregated getClosedTabData methods. r=kcochrane,fxview-reviewers,sessionstore-reviewers,dao,sclements
* We already make use of the closedId in RecentlyClosedTabsInView to re-open the tab via SS.undoCloseById so it made sense to do the same for forgetting a closed tab
* In the test setup, one of tabs is opened and closed in a different window. This gives us coverage both for the closed tab list rendering, as well as re-opening and forgeting tabs with different source windows
* Both the forget-by-closed-id methods match undoClosedById's behavior and throw if the closedId doesnt match a closed window or tab

Differential Revision: https://phabricator.services.mozilla.com/D184192
2023-07-31 18:54:43 +00:00
Shane Hughes
0f4e587520 Bug 1845862 - Support primary buttons in Feature Callout. r=jprickett
Differential Revision: https://phabricator.services.mozilla.com/D184788
2023-07-28 20:51:17 +00:00
Shane Hughes
b6556b9453 Bug 1845419 - Allow Feature Callout page_event_listeners to set timers and hook callout lifecycle events. r=jprickett
Differential Revision: https://phabricator.services.mozilla.com/D184536
2023-07-27 16:26:26 +00:00
Mark Banner
d3d891e3d7 Bug 1845079 - Update more consumers to import ES modules directly. r=arai,settings-reviewers,credential-management-reviewers,sync-reviewers,sgalich
Differential Revision: https://phabricator.services.mozilla.com/D184371
2023-07-24 15:32:45 +00:00
Mike Kaply
064e2e5319 Bug 1844672 - No need to look for current device, it's not in the tab array. r=fxview-reviewers,sfoster
Differential Revision: https://phabricator.services.mozilla.com/D184169
2023-07-23 16:02:54 +00:00
Shane Hughes
0e39523d2a Bug 1838295 - Feature Callout fallback anchor system. r=jprickett
Differential Revision: https://phabricator.services.mozilla.com/D184067
2023-07-23 02:57:02 +00:00
Cristian Tuns
f0bbf8faa6 Backed out changeset 6f0a2e1e42f5 (bug 1838295) for causing bc failures in browser_feature_callout_in_chrome.js CLOSED TREE 2023-07-22 01:40:06 -04:00
Shane Hughes
ab73a1849d Bug 1838295 - Feature Callout fallback anchor system. r=jprickett
Differential Revision: https://phabricator.services.mozilla.com/D184067
2023-07-22 03:47:34 +00:00
Kelly Cochrane
87f5a31d01 Bug 1841795 - Add Recently Closed empty states in about:firefoxview-next r=mkaply,fluent-reviewers,fxview-reviewers,flod,sclements
Differential Revision: https://phabricator.services.mozilla.com/D184029
2023-07-20 15:46:51 +00:00
Jonathan Sudiaman
f4a53f1a04 Bug 1836261 - Add additional options to PlacesQuery#getHistory() r=mak,kcochrane,fxview-reviewers,bolsson
Differential Revision: https://phabricator.services.mozilla.com/D182922
2023-07-20 01:57:06 +00:00
Tooru Fujisawa
ce5ebcc064 Bug 1843789 - Part 3: Rewrite testing/mochitest/BrowserTestUtils/BrowserTestUtils.sys.mjs consumers in html/xhtml to use ChromeUtils.importESModule. r=ahal,fxview-reviewers,sfoster
Differential Revision: https://phabricator.services.mozilla.com/D183659
2023-07-18 23:06:30 +00:00
Tooru Fujisawa
75ea53fcda Bug 1843788 - Part 2: Rewrite testing/modules/TestUtils.sys.mjs consumers in html/xhtml to use ChromeUtils.importESModule. r=ahal,credential-management-reviewers,fxview-reviewers,sgalich,sfoster
Differential Revision: https://phabricator.services.mozilla.com/D183656
2023-07-18 23:06:29 +00:00
Mike Kaply
1264da4c06 Bug 1826608 - Implement open tabs from other device in new Firefox View. r=sclements,kcochrane,fluent-reviewers,fxview-reviewers,bolsson
Differential Revision: https://phabricator.services.mozilla.com/D180836
2023-07-18 19:08:04 +00:00
Kelly Cochrane
ab66bdc5e6 Bug 1826604 - Add History empty states and banner in about:firefoxview-next r=mkaply,fxview-reviewers,sclements,bolsson
Differential Revision: https://phabricator.services.mozilla.com/D183197
2023-07-18 13:42:11 +00:00
Shane Hughes
99e82b0f08 Bug 1821826 - Refactor FeatureCallout to support generic triggers. r=omc-reviewers,fxview-reviewers,tabbrowser-reviewers,dao,jprickett,sclements
Also disable the Firefox View feature tour to avoid any risk of
regressions. The feature tour code will be removed in a later patch.
It's still present for now for testing purposes.

Differential Revision: https://phabricator.services.mozilla.com/D180927
2023-07-11 16:00:40 +00:00
Kelly Cochrane
51cec58770 Bug 1828606 - Implement Recently Closed component in next iteration of Firefox View r=sfoster,fluent-reviewers,fxview-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D182600
2023-07-10 19:46:10 +00:00
Cristina Horotan
4754aab8ed Backed out changeset 00270dd961d6 (bug 1828606) for causing leaked window related bc failures 2023-07-10 17:29:20 +03:00
Kelly Cochrane
24c3ac8d12 Bug 1828606 - Implement Recently Closed component in next iteration of Firefox View r=sfoster,fluent-reviewers,fxview-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D182600
2023-07-10 13:46:53 +00:00
Sam Foster
1bd6b02cd7 Bug 1819675 - Introduce a feature pref to toggle the recently-closed tabs from all windows behavior.r=sclements,dao,extension-reviewers,fxview-reviewers,robwu,sessionstore-reviewers
* Add a default-true pref to provide an escape hatch allowing us to revert to previous behavior
* in which recently-closed tabs are per-window,
* and undoing closed tabs restores them to the window they were closed from.
* Ensure we set the pref for tests which depend on its value
* Add some spot-checks in tests with the pref off

Differential Revision: https://phabricator.services.mozilla.com/D179574
2023-07-06 22:49:52 +00:00