Commit Graph

309 Commits

Author SHA1 Message Date
Simon Giesecke
9754419e89 Bug 1617170 - Fix non-unified build. r=janv,dom-workers-and-storage-reviewers
Based on a patch supplied by janv@mozilla.com

Differential Revision: https://phabricator.services.mozilla.com/D67129
2020-03-17 11:28:49 +00:00
Simon Giesecke
29c1d74824 Bug 1617170 - Split StructuredCloneReadInfo into parent- and child-specific classes. r=dom-workers-and-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D64131
2020-03-11 17:30:33 +00:00
Simon Giesecke
f8051e242c Bug 1617170 - Encapsulate StructuredCloneReadInfo members. r=dom-workers-and-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D64078
2020-03-11 17:20:05 +00:00
Simon Giesecke
3f0581da35 Bug 1617170 - Encapsulate StructuredCloneFile. r=dom-workers-and-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D63681
2020-03-07 09:31:48 +00:00
Andreea Pavel
c72547b812 Backed out 8 changesets (bug 1617170) for build bustages at nsTArray.h on a CLOSED TREE
Backed out changeset ed7eaba53757 (bug 1617170)
Backed out changeset 0021ab4bcf77 (bug 1617170)
Backed out changeset 92f4ef8809ec (bug 1617170)
Backed out changeset c9561cb90821 (bug 1617170)
Backed out changeset 739dafac70bc (bug 1617170)
Backed out changeset 51c699b06d04 (bug 1617170)
Backed out changeset 2ae6b424f492 (bug 1617170)
Backed out changeset 6acafdd56175 (bug 1617170)
2020-03-06 17:57:23 +02:00
Simon Giesecke
4206068368 Bug 1617170 - Encapsulate StructuredCloneFile. r=dom-workers-and-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D63681
2020-03-06 15:34:18 +00:00
shindli
35783ef05c Backed out 5 changesets (bug 1617170) for toolchains bustages CLOSED TREE
Backed out changeset cc2aadaf5923 (bug 1617170)
Backed out changeset bda38a16aac3 (bug 1617170)
Backed out changeset 5d3ed69aca66 (bug 1617170)
Backed out changeset 90dfe1253fe4 (bug 1617170)
Backed out changeset f1a4f3952931 (bug 1617170)
2020-03-06 14:55:58 +02:00
Simon Giesecke
b7f4bc8a5c Bug 1617170 - Encapsulate StructuredCloneFile. r=dom-workers-and-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D63681
2020-03-06 12:30:35 +00:00
Simon Giesecke
c1dff4b2fc Bug 1613340 - Remove const_cast relating to CursorResponse. r=jld,dom-workers-and-storage-reviewers,edenchuang
Differential Revision: https://phabricator.services.mozilla.com/D61672
2020-03-03 13:51:18 +00:00
Simon Giesecke
1eae454229 Bug 1613340 - Remove const_cast relating to SerializedStructuredCloneReadInfo. r=jld,dom-workers-and-storage-reviewers,edenchuang
Differential Revision: https://phabricator.services.mozilla.com/D61671
2020-03-03 13:50:48 +00:00
Simon Giesecke
2011d7d8d3 Bug 1613340 - Remove const_cast relating to StructuredCloneReadInfo. r=dom-workers-and-storage-reviewers,edenchuang
Differential Revision: https://phabricator.services.mozilla.com/D61670
2020-03-03 13:45:26 +00:00
Simon Giesecke
69fde0dd8c Bug 1613854 - Avoid copying non-trivial IPDL params. r=dom-workers-and-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D62023
2020-02-18 16:37:49 +00:00
Simon Giesecke
a9b832a51f Bug 1613854 - Pass nsresult/bool/int* by value instead of const &. r=dom-workers-and-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D61992
2020-02-27 12:17:47 +00:00
Eric Rahm
a244d7a76f Bug 1617327 - Part 2: Remove nsAutoPtr usage from ipc, security, IDB. r=mccr8,janv
This removes `nsAutoPtr` usage from ipc/. security/ failed to build due to missing includes so I fixed that as well. IDB was using `ThreadLocal` from ipc which had a member changed to a `UniquePtr` so needed to be updated as well. localstorage was missing some includes.

Differential Revision: https://phabricator.services.mozilla.com/D63745
2020-02-24 19:26:40 +00:00
David Major
1e85042bfa Bug 1613606 - Bonus cleanup of IPC::Principals r=nika
All of these call sites were unnecessarily converting nsIPrincipal* => IPC::Principal => nsIPrincipal*.

Differential Revision: https://phabricator.services.mozilla.com/D62327
2020-02-10 20:52:56 +00:00
Boris Zbarsky
87a24bfad4 Bug 1611509 part 3. Remove the Date type from Web IDL. r=edgar
Differential Revision: https://phabricator.services.mozilla.com/D61054
2020-01-27 08:50:35 +00:00
Simon Giesecke
4efcf9d790 Bug 1497007 - Implemented IDBTransaction.commit. r=dom-workers-and-storage-reviewers,ytausky
Differential Revision: https://phabricator.services.mozilla.com/D55673
2020-01-17 12:47:17 +00:00
Simon Giesecke
ec35ff5810 Bug 1497007 - Fix state model, return to Inactive state after creation when returning to event loop. r=dom-workers-and-storage-reviewers,asuth
Also fix the behaviour of IDBTransaction::CanAcceptRequests, which, after the
new state model introduced along with the addition of IDBTransaction.commit to
the spec, should only depend on mReadyState. This makes the mCreated flag
redundant, which is removed by this patch.

Differential Revision: https://phabricator.services.mozilla.com/D59713
2020-01-17 10:11:58 +00:00
Andrea Marchesini
3b15153d5e Bug 1607791 - Get rid of IDBMutableFile.getFile() - part 1, r=asuth,janv
Differential Revision: https://phabricator.services.mozilla.com/D59140
2020-01-15 12:02:21 +00:00
Mihai Alexandru Michis
de0cc7e19b Backed out 9 changesets (bug 1607791, bug 1605566) for causing multiple wpt failures.
CLOSED TREE

Backed out changeset 39f34852842e (bug 1605566)
Backed out changeset 3427a92445c8 (bug 1605566)
Backed out changeset 36631ec96f1f (bug 1605566)
Backed out changeset 554b2bdce66c (bug 1605566)
Backed out changeset 37026beadbd8 (bug 1605566)
Backed out changeset f15835338319 (bug 1607791)
Backed out changeset 4c92f506cf62 (bug 1607791)
Backed out changeset 80707bcc8427 (bug 1607791)
Backed out changeset 75bc7533c899 (bug 1607791)
2020-01-15 13:45:33 +02:00
Andrea Marchesini
a87f7d5e94 Bug 1607791 - Get rid of IDBMutableFile.getFile() - part 1, r=asuth,janv
Differential Revision: https://phabricator.services.mozilla.com/D59140
2020-01-15 09:58:39 +00:00
Csoregi Natalia
683448754f Backed out 3 changesets (bug 1497007) for assertion failures on IDBTransaction.cpp. CLOSED TREE
Backed out changeset 72bc4f39b659 (bug 1497007)
Backed out changeset 99fc4eedacc7 (bug 1497007)
Backed out changeset 787c340dd3d0 (bug 1497007)
2020-01-14 15:22:26 +02:00
Simon Giesecke
22e13211f2 Bug 1497007 - Implemented IDBTransaction.commit. r=dom-workers-and-storage-reviewers,ytausky
Differential Revision: https://phabricator.services.mozilla.com/D55673
2020-01-14 11:14:29 +00:00
Simon Giesecke
5af9959598 Bug 1497007 - Fix state model, return to Inactive state after creation when returning to event loop. r=dom-workers-and-storage-reviewers,asuth
Also fix the behaviour of IDBTransaction::CanAcceptRequests, which, after the
new state model introduced along with the addition of IDBTransaction.commit to
the spec, should only depend on mReadyState. This makes the mCreated flag
redundant, which is removed by this patch.

Differential Revision: https://phabricator.services.mozilla.com/D59713
2020-01-14 11:14:52 +00:00
Simon Giesecke
556830c732 Bug 1600906 - Convert IDBCursor and BackgroundCursorChild to templates to increase type safety and reduce state. r=dom-workers-and-storage-reviewers,ytausky
This also simplifies delegating calls that are dependent on the cursor type.

Also reduce dependency on IDBCursor.h by moving enums and type traits to IDBCursorType.h

Differential Revision: https://phabricator.services.mozilla.com/D57993
2020-01-10 15:23:52 +00:00
Csoregi Natalia
8a5ddbf4ee Backed out 3 changesets (bug 1600906) for bustage on StaticAnalysisFunctions.h. CLOSED TREE
Backed out changeset aae2faf1907c (bug 1600906)
Backed out changeset d61a65e2e4ac (bug 1600906)
Backed out changeset a114b9b8e6ea (bug 1600906)
2020-01-10 17:19:22 +02:00
Simon Giesecke
6ab7211daa Bug 1600906 - Convert IDBCursor and BackgroundCursorChild to templates to increase type safety and reduce state. r=dom-workers-and-storage-reviewers,ytausky
This also simplifies delegating calls that are dependent on the cursor type.

Also reduce dependency on IDBCursor.h by moving enums and type traits to IDBCursorType.h

Differential Revision: https://phabricator.services.mozilla.com/D57993
2020-01-10 14:21:18 +00:00
Simon Giesecke
c0d76c854a Bug 1600906 - Use scoped enums in IDBCursor. r=dom-workers-and-storage-reviewers,ytausky
Depends on D57990

Differential Revision: https://phabricator.services.mozilla.com/D57991
2020-01-06 14:19:39 +00:00
Simon Giesecke
8474756b6f Bug 1600906 - Use std::move instead of swap, use const where then possible. r=dom-workers-and-storage-reviewers,ytausky
Depends on D57988

Differential Revision: https://phabricator.services.mozilla.com/D57989
2020-01-09 14:43:57 +00:00
Simon Giesecke
d4d82dcbd0 Bug 1600906 - Merge identical switch cases. r=dom-workers-and-storage-reviewers,ttung
Depends on D57986

Differential Revision: https://phabricator.services.mozilla.com/D57987
2019-12-20 15:33:40 +00:00
Simon Giesecke
8658429ae3 Bug 1600283 - Replaced use of nsAutoPtr by UniquePtr. r=dom-workers-and-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D55520
2019-12-19 09:57:49 +00:00
Simon Giesecke
c749476dd0 Bug 1600283 - Remove uses of plain pointers. r=dom-workers-and-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D55485
2019-12-16 13:18:26 +00:00
Simon Giesecke
ab0c72c7bb Bug 1600283 - Remove uses of already_AddRefed. r=dom-workers-and-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D55484
2019-12-16 13:18:13 +00:00
Simon Giesecke
66bd4949a5 Bug 1600283 - Reduce uses of plain pointers. r=dom-workers-and-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D55477
2019-12-13 12:18:21 +00:00
Jeff Walden
5c07885dcf Bug 1602882 - Move array operations to a new js/Array.h header. r=sfink,bzbarsky
Differential Revision: https://phabricator.services.mozilla.com/D56595
2019-12-11 06:17:44 +00:00
Simon Giesecke
3d8add6c11 Bug 1598164 - Implement transaction inactive state according to spec. r=dom-workers-and-storage-reviewers,ytausky
Differential Revision: https://phabricator.services.mozilla.com/D55142
2019-12-04 12:59:09 +00:00
Simon Giesecke
2bd9382253 Bug 1596129 - Removed redundant assertions after infallible EmplaceBack calls. r=dom-workers-and-storage-reviewers,ytausky
Differential Revision: https://phabricator.services.mozilla.com/D53932
2019-12-04 12:48:38 +00:00
Simon Giesecke
b5c4af6154 Bug 1598164 - Align ReadyState with states defined in the spec. r=dom-workers-and-storage-reviewers,edenchuang
Differential Revision: https://phabricator.services.mozilla.com/D54322
2019-11-28 16:00:29 +00:00
Simon Giesecke
95becfdeb5 Bug 1599420 - Ensure that strong references to newly created cursors are kept until the DOM Binding is created. r=dom-workers-and-storage-reviewers,ttung,janv
Differential Revision: https://phabricator.services.mozilla.com/D54704
2019-11-26 14:38:16 +00:00
ssengupta
81b0b574f5 Bug 1595085 - BackgroundCursorChild::SendContinueInternal discards cached responses conditionally also for ContinuePrimaryKey r=sg
Differential Revision: https://phabricator.services.mozilla.com/D54518
2019-11-26 13:33:56 +00:00
Simon Giesecke
1566651f9c Bug 1596129 - Make use of range-based for in BackgroundRequestChild::ActorDestroy. r=dom-workers-and-storage-reviewers,ttung,asuth
Differential Revision: https://phabricator.services.mozilla.com/D52861
2019-11-20 16:21:34 +00:00
Simon Giesecke
ea36fa48c3 Bug 1596129 - Make use of std::transform instead of custom for loop in BackgroundRequestChild::HandleResponse. r=dom-workers-and-storage-reviewers,ttung
Depends on D52859

Differential Revision: https://phabricator.services.mozilla.com/D52860
2019-11-20 15:12:34 +00:00
Simon Giesecke
62a6d0bcbf Bug 1596129 - Merge BackgroundRequestChild array members mPreprocessHelpers and mCloneDatas into one. r=dom-workers-and-storage-reviewers,ttung,asuth
Differential Revision: https://phabricator.services.mozilla.com/D52859
2019-11-21 16:46:08 +00:00
Simon Giesecke
932af40030 Bug 1596129 - Avoid unnecessary copy of params in BackgroundRequestChild::RecvPreprocess. r=dom-workers-and-storage-reviewers,ttung
Depends on D52844

Differential Revision: https://phabricator.services.mozilla.com/D52858
2019-11-20 13:19:39 +00:00
Simon Giesecke
8cbb209463 Bug 1596129 - Removed code duplication between HandlePreprocess overloads. r=dom-workers-and-storage-reviewers,ttung
Differential Revision: https://phabricator.services.mozilla.com/D52844
2019-11-20 13:26:16 +00:00
Simon Giesecke
cac5640aee Bug 1168606 - Set flag to invalidate in-flight responses as well. r=asuth
Differential Revision: https://phabricator.services.mozilla.com/D52559
2019-11-14 16:14:02 +00:00
Simon Giesecke
d568eb0b6c Bug 1168606 - Resolved clang-tidy warnings. r=ttung,asuth
Differential Revision: https://phabricator.services.mozilla.com/D49274
2019-11-08 13:22:28 +00:00
Simon Giesecke
28b496cf72 Bug 1168606 - Replace pseudo-move constructor of StructuredCloneReadInfo by explicit DeserializeStructuredCloneReadInfo function. r=ttung,asuth
Differential Revision: https://phabricator.services.mozilla.com/D46593
2019-11-08 13:22:08 +00:00
Simon Giesecke
ba25650bd1 Bug 1168606 - Do not use mContinueCalled for determining whether to cache a cursor response. r=ttung,asuth
Depends on D45674

Differential Revision: https://phabricator.services.mozilla.com/D45675
2019-11-05 16:46:31 +00:00
Simon Giesecke
ead2cad6c6 Bug 1168606 - Removed duplication between different BackgroundCursorChild::HandleResponse overloads. r=ttung,asuth
Differential Revision: https://phabricator.services.mozilla.com/D45674
2019-11-05 16:46:23 +00:00