corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
743,381 Commits 1 Branch 0 Tags
89633e20a41a4b51c11056d7ace53cc7fd5f86b3
Commit Graph

309 Commits

Author SHA1 Message Date
Simon Giesecke
8d8a549253 Bug 1653276 - Ensure that IndexedDB operations are cancelled when nsGlobalWindowInner::FreeInnerObjects is called. r=dom-workers-and-storage-reviewers,janv 
Differential Revision: https://phabricator.services.mozilla.com/D92209
 2020-10-07 09:58:37 +00:00
Butkovits Atila
cfef5854d7 Backed out changeset 0f0d637acf76 (bug 1653276) for failures complaining about ActorsChild.cpp. CLOSED TREE 2020-10-06 21:35:10 +03:00
Simon Giesecke
5a50831cf9 Bug 1653276 - Ensure that IndexedDB operations are cancelled when nsGlobalWindowInner::FreeInnerObjects is called. r=dom-workers-and-storage-reviewers,janv 
Differential Revision: https://phabricator.services.mozilla.com/D92209
 2020-10-06 15:27:19 +00:00
Simon Giesecke
8b7e779fe9 Bug 1663924 - Replace output parameter of PromptIfNeeded by return value. r=dom-workers-and-storage-reviewers,janv 
Differential Revision: https://phabricator.services.mozilla.com/D91158
 2020-10-06 08:39:40 +00:00
Simon Giesecke
535b627ea9 Bug 1666219 - Renamed QM_TRY_VAR etc. to QM_TRY_UNWRAP etc. r=dom-workers-and-storage-reviewers,ttung,janv 
Also change some left-over QM_TRY_VAR uses with const target declarations to
QM_TRY_INSPECT et al.

Differential Revision: https://phabricator.services.mozilla.com/D90873
 2020-10-02 13:23:49 +00:00
Sebastian Hengst
07e61ece2b Backed out 5 changesets (bug 1666219, bug 1665347) for crashing hazard task. CLOSED TREE. 
Backed out changeset c261ec06a826 (bug 1665347)
Backed out changeset 212c9df41410 (bug 1665347)
Backed out changeset 435f02d9f1d7 (bug 1665347)
Backed out changeset 7b36a79247b7 (bug 1666219)
Backed out changeset af8025162523 (bug 1665347)
 2020-10-01 23:17:19 +02:00
Simon Giesecke
8b03004195 Bug 1666219 - Renamed QM_TRY_VAR etc. to QM_TRY_UNWRAP etc. r=dom-workers-and-storage-reviewers,ttung,janv 
Also change some left-over QM_TRY_VAR uses with const target declarations to
QM_TRY_INSPECT et al.

Differential Revision: https://phabricator.services.mozilla.com/D90873
 2020-10-01 15:37:50 +00:00
Bogdan Tara
7bbd692ffa Backed out 5 changesets (bug 1666219, bug 1665347) for indexedDB related bustage CLOSED TREE 
Backed out changeset 5cd7e2d67f91 (bug 1665347)
Backed out changeset 9159fdd05097 (bug 1665347)
Backed out changeset 64a086636738 (bug 1665347)
Backed out changeset 5ef18af381ec (bug 1666219)
Backed out changeset 3b81349a5f39 (bug 1665347)
 2020-10-01 17:41:23 +03:00
Simon Giesecke
ed2c55bd64 Bug 1666219 - Renamed QM_TRY_VAR etc. to QM_TRY_UNWRAP etc. r=dom-workers-and-storage-reviewers,ttung,janv 
Also change some left-over QM_TRY_VAR uses with const target declarations to
QM_TRY_INSPECT et al.

Differential Revision: https://phabricator.services.mozilla.com/D90873
 2020-10-01 12:02:26 +00:00
Jan Varga
19f36c67d1 Bug 1662087 - Replace explicit error handling involving mozilla::Result::isErr with IDB_TRY/IDB_TRY_VAR in ActorsChild.cpp; r=dom-workers-and-storage-reviewers,sg 
Differential Revision: https://phabricator.services.mozilla.com/D88831
 2020-09-07 15:52:52 +00:00
Kris Maglione
c67b4248ac Bug 1650257: Part 2 - Abort SetNewDocument() if ancestors are discarded/cached. r=nika,smaug,sg 
Differential Revision: https://phabricator.services.mozilla.com/D87486
 2020-08-31 18:51:56 +00:00
Simon Giesecke
26ee659f28 Bug 1660800 - Make DelayedActionRunnable hold a strong reference to the target. r=dom-workers-and-storage-reviewers,asuth 
Differential Revision: https://phabricator.services.mozilla.com/D88144
 2020-08-28 15:50:38 +00:00
Simon Giesecke
b3e540427f Bug 1660816 - Make PBackgroundIDBCursor protocol refcounted. r=dom-workers-and-storage-reviewers,asuth 
Differential Revision: https://phabricator.services.mozilla.com/D88143
 2020-08-28 15:50:23 +00:00
Razvan Maries
639bed10fd Backed out 2 changesets (bug 1660800, bug 1660816) as per Simon's request. CLOSED TREE 
Backed out changeset 55d2e05d2e0b (bug 1660800)
Backed out changeset 7b9687fb7d41 (bug 1660816)
 2020-08-28 18:45:54 +03:00
Simon Giesecke
9f2e79fe3c Bug 1660800 - Make DelayedActionRunnable hold a strong reference to the target. r=dom-workers-and-storage-reviewers,asuth 
Differential Revision: https://phabricator.services.mozilla.com/D88144
 2020-08-28 10:02:33 +00:00
Simon Giesecke
ab38435cfa Bug 1660816 - Make PBackgroundIDBCursor protocol refcounted. r=dom-workers-and-storage-reviewers,asuth 
Differential Revision: https://phabricator.services.mozilla.com/D88143
 2020-08-28 14:43:51 +00:00
Simon Giesecke
4afef81588 Bug 1650076 - Clean up ThreadLocal. r=dom-workers-and-storage-reviewers,asuth 
Move ThreadLocal to a separate header file.
Reuse LoggingIdString in ThreadLocal (and make use of nsAutoCStringN).

Differential Revision: https://phabricator.services.mozilla.com/D82018
 2020-07-03 09:40:12 +00:00
Simon Giesecke
9fbdc8d323 Bug 1650076 - Fix bad printf format strings/argument lists. r=dom-workers-and-storage-reviewers,asuth 
Differential Revision: https://phabricator.services.mozilla.com/D82016
 2020-07-03 09:39:24 +00:00
Cosmin Sabou
ac68fa95fe Backed out 4 changesets (bug 1650076) for build bustages on indexedDB/ProfilerHelpers.h. CLOSED TREE 
Backed out changeset 42951b61e9dc (bug 1650076)
Backed out changeset 18b34fb0ddbd (bug 1650076)
Backed out changeset 1d378f2af866 (bug 1650076)
Backed out changeset 42df520d1cff (bug 1650076)
 2020-07-03 11:49:58 +03:00
Simon Giesecke
c51dc55a49 Bug 1650076 - Clean up ThreadLocal. r=dom-workers-and-storage-reviewers,asuth 
Move ThreadLocal to a separate header file.
Reuse LoggingIdString in ThreadLocal (and make use of nsAutoCStringN).

Differential Revision: https://phabricator.services.mozilla.com/D82018
 2020-07-03 08:08:27 +00:00
Simon Giesecke
1d44b0cddf Bug 1650076 - Fix bad printf format strings/argument lists. r=dom-workers-and-storage-reviewers,asuth 
Differential Revision: https://phabricator.services.mozilla.com/D82016
 2020-07-03 08:08:05 +00:00
Simon Giesecke
5b492099f3 Bug 1648454 - Use NotNull with IDBRequest where applicable. r=dom-workers-and-storage-reviewers,asuth 
Differential Revision: https://phabricator.services.mozilla.com/D81078
 2020-07-01 20:14:23 +00:00
Andrea Marchesini
edcb7f704f Bug 1648141 - IPCBlobInputStream to RemoteLazyInputStream - part 1 - mozIRemoteLazyInputStream interface, r=smaug 
Differential Revision: https://phabricator.services.mozilla.com/D80924
 2020-06-29 11:02:53 +00:00
Razvan Maries
6b44dbdf8c Backed out 8 changesets (bug 1648141) for build bustages on RemoteLazyInputStreamThread.cpp. CLOSED TREE 
Backed out changeset e9b4ca0ee700 (bug 1648141)
Backed out changeset b9bb847cee47 (bug 1648141)
Backed out changeset 11dfce46ec14 (bug 1648141)
Backed out changeset d824d2f67f27 (bug 1648141)
Backed out changeset e5b8292e7095 (bug 1648141)
Backed out changeset c1a3d5fa0c61 (bug 1648141)
Backed out changeset 24fdb83db3cd (bug 1648141)
Backed out changeset 749d894dde52 (bug 1648141)
 2020-06-29 13:59:16 +03:00
Andrea Marchesini
bd53c6502a Bug 1648141 - IPCBlobInputStream to RemoteLazyInputStream - part 1 - mozIRemoteLazyInputStream interface, r=smaug 
Differential Revision: https://phabricator.services.mozilla.com/D80924
 2020-06-29 10:25:08 +00:00
Jean-Yves Avenard
05adafa9ef Bug 1637500 - P2. Rename methods as they are not always dealing with "threads". r=froydnj 
Before P1, GetCurrentThreadSerialEventTarget would have always returned the same data as NS_GetCurrentThread, making the comment incorrect Now it will properly return the running TaskQueue if any.

This change of name more clearly exposes what they are doing, as we aren't always dealing with threads directly; but a nsISerialEventTarget

Differential Revision: https://phabricator.services.mozilla.com/D80354
 2020-06-23 05:05:36 +00:00
Jean-Yves Avenard
a5c6bb8904 Bug 1646054 - P1. Remove EventTargetWrapper class. r=froydnj 
We also establish the intent of bug 1602167 on the TaskQueue object

Differential Revision: https://phabricator.services.mozilla.com/D80351
 2020-06-22 13:55:21 +00:00
Simon Giesecke
73079e9c45 Bug 1632128 - Dissolve FileHandleResultHelper class into a function. r=dom-workers-and-storage-reviewers,janv 
Differential Revision: https://phabricator.services.mozilla.com/D75053
 2020-05-14 09:42:33 +00:00
Simon Giesecke
e66798a9c0 Bug 1632128 - Dissolve ResultHelper class into a function. r=dom-workers-and-storage-reviewers,janv 
Differential Revision: https://phabricator.services.mozilla.com/D74890
 2020-05-14 09:42:23 +00:00
Simon Giesecke
f6413cd8b4 Bug 1632128 - De-virtualize IDBFileRequest::SetResult(Callback). r=dom-workers-and-storage-reviewers,janv 
Differential Revision: https://phabricator.services.mozilla.com/D74875
 2020-05-14 09:42:21 +00:00
Simon Giesecke
c933223b4a Bug 1632128 - De-virtualize IDBRequest::SetResult(Callback). r=dom-workers-and-storage-reviewers,janv 
Differential Revision: https://phabricator.services.mozilla.com/D74874
 2020-05-14 09:42:18 +00:00
Simon Giesecke
2eda7385e6 Bug 1632128 - Use mozilla::Variant for FileHandleResultHelper. r=dom-workers-and-storage-reviewers,janv 
Differential Revision: https://phabricator.services.mozilla.com/D74870
 2020-05-14 09:42:16 +00:00
Simon Giesecke
9bef119753 Bug 1632128 - Use mozilla::Variant for ResultHelper. r=dom-workers-and-storage-reviewers,janv 
Differential Revision: https://phabricator.services.mozilla.com/D71936
 2020-05-14 09:42:13 +00:00
Simon Giesecke
337ce45d84 Bug 1633719 - Use *InitializedOnce* with NotNull instead of *InitializedOnce*NotNull for pointers. r=dom-workers-and-storage-reviewers,janv 
Differential Revision: https://phabricator.services.mozilla.com/D73025
 2020-05-14 09:14:04 +00:00
Bogdan Tara
32cb177a3b Backed out 2 changesets (bug 1623278, bug 1633719) for assertion failure on NotNull.h CLOSED TREE 
Backed out changeset 8a21ea441fc7 (bug 1623278)
Backed out changeset ab6a041c0d57 (bug 1633719)
 2020-05-14 11:34:50 +03:00
Simon Giesecke
08e6a873ee Bug 1633719 - Use *InitializedOnce* with NotNull instead of *InitializedOnce*NotNull for pointers. r=dom-workers-and-storage-reviewers,janv 
Differential Revision: https://phabricator.services.mozilla.com/D73025
 2020-05-14 07:47:46 +00:00
ssengupta
a7115a9506 Bug 1635399 - Function PrincipalInfoToPrincipal now returns Result<nsCOMPtr<nsIPrincipal>, nsresult> r=ckerschb 
Differential Revision: https://phabricator.services.mozilla.com/D73868
 2020-05-12 19:02:05 +00:00
Andrew Sutherland
95c9d04f17 Bug 1631970 - Delay converting uint64 results to JSVals. r=sg 
The rooting hazard analysis is getting upset because of the usage where
a non-GCThing JSVal is declared on the stack and AcquireTransaction() is
called.  The analysis doesn't know that it's guaranteed that the value is
NaN-boxed and can't be a GC thing.  It also doesn't know that the SafeRefPtr
can't already have a value so a release is impossible.

Arguably the hazard analysis doesn't need to know these things though.

This fix delays the point at which we convert the uint64 into a JS::Value.
The [call to GetResult](https://searchfox.org/mozilla-central/rev/446160560bf32ebf4cb7c4e25d7386ee22667255/dom/indexedDB/IDBRequest.cpp#300)
already has a rooted result and the (Auto)JSAPI initialized, so this is
arguably cleaner and less scary in terms of holding raw pointers in the
ResultHelper that aren't necessary.

This fix doesn't correct the ResultTypeJSValHandle which is a similar
situation, except it's a reference to
[UndefinedHandleValue](https://searchfox.org/mozilla-central/rev/446160560bf32ebf4cb7c4e25d7386ee22667255/js/src/vm/Value.cpp#23)
which is I suppose more fine from a GC perspective.  Still somewhat ugly
as used in ResultHelper, but I'm presuming we'll clean ResultHelper up
in the future to use a Variant, at which point we can explicitly indicate
we want `undefined`.

Differential Revision: https://phabricator.services.mozilla.com/D74800
 2020-05-12 10:39:00 +00:00
Simon Giesecke
5b03cecaea Bug 1623278 - Make transaction actors refcounted. r=dom-workers-and-storage-reviewers,nika,janv 
Differential Revision: https://phabricator.services.mozilla.com/D71933
 2020-05-06 12:20:32 +00:00
Simon Giesecke
04e45d8a43 Bug 1618542 - Add use of new transformation algorithms in ActorsChild. r=dom-workers-and-storage-reviewers,janv 
Differential Revision: https://phabricator.services.mozilla.com/D69044
 2020-04-21 14:35:03 +00:00
Simon Giesecke
cb31f1e722 Bug 1623278 - Use SafeRefPtr for IDBTransaction. r=dom-workers-and-storage-reviewers,ttung,janv 
Differential Revision: https://phabricator.services.mozilla.com/D67287
 2020-04-21 14:32:51 +00:00
Simon Giesecke
b9883a12fd Bug 1623278 - Use SafeRefPtr for IDBFactory. r=dom-workers-and-storage-reviewers,asuth 
Differential Revision: https://phabricator.services.mozilla.com/D66972
 2020-04-01 09:54:43 +00:00
Simon Giesecke
49753c8414 Bug 1597954 - Switch indexedDB to use InitializedOnce from mfbt. r=dom-workers-and-storage-reviewers,janv 
Differential Revision: https://phabricator.services.mozilla.com/D65710
 2020-04-01 09:53:39 +00:00
André Bargull
5ec91f8150 Bug 1625138 - Part 41: Remove no longer needed includes for mozilla/TypeTraits. r=froydnj 
Also adds missing includes in some files, these were previously only transivitely
included through mozilla/TypeTraits.h.

Differential Revision: https://phabricator.services.mozilla.com/D68561
 2020-03-28 16:00:09 +00:00
André Bargull
6a24aefe02 Bug 1625138 - Part 38: Replace mozilla::IsSame with std::is_same in dom/. r=froydnj 
Differential Revision: https://phabricator.services.mozilla.com/D68557
 2020-03-28 13:57:21 +00:00
André Bargull
100578b6da Bug 1606962: Replace mozilla::EnableIf with std::enable_if. r=froydnj,jgilbert 
Differential Revision: https://phabricator.services.mozilla.com/D68401
 2020-03-28 13:35:31 +00:00
Simon Giesecke
8574adfe02 Bug 1617170 - Split StructuredCloneFile into parent- and child-specific classes. r=janv,dom-workers-and-storage-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D65167
 2020-03-19 11:35:03 +00:00
Mihai Alexandru Michis
6c0bae252a Backed out 10 changesets (bug 1623278, bug 1617170, bug 1620273, bug 1597954) for causing bustages. 
CLOSED TREE

Backed out changeset 50c0e58dd654 (bug 1623278)
Backed out changeset b31ddbcdd2f2 (bug 1597954)
Backed out changeset 8b03993a9234 (bug 1623278)
Backed out changeset ad7b08acadd6 (bug 1623278)
Backed out changeset bb094a6084b3 (bug 1623278)
Backed out changeset 7fdf38a403bb (bug 1623278)
Backed out changeset d69cf5fcb571 (bug 1620273)
Backed out changeset 5abef9862e60 (bug 1617170)
Backed out changeset 11d9ccb4ddd8 (bug 1617170)
Backed out changeset 6df7028b41d0 (bug 1617170)
 2020-03-19 13:30:26 +02:00
Simon Giesecke
5abddf36b5 Bug 1597954 - Switch indexedDB to use InitializedOnce from mfbt. r=dom-workers-and-storage-reviewers,janv 
Differential Revision: https://phabricator.services.mozilla.com/D65710
 2020-03-19 09:34:40 +00:00
Simon Giesecke
8ca4232326 Bug 1617170 - Split StructuredCloneFile into parent- and child-specific classes. r=janv,dom-workers-and-storage-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D65167
 2020-03-19 09:57:27 +00:00