corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
901,613 Commits 1 Branch 0 Tags
84c498dc3b56e47b5845c511d73b0edfec19e17f
Commit Graph

406 Commits

Author SHA1 Message Date
Goloman Adrian
8d0a2fbb16 Backed out changeset 6539a7d0d9ca (bug 1894239) for causing xpcshell failures at test_selectable_profile_launch.js. CLOSED TREE 2024-11-01 20:43:36 +02:00
Dave Townsend
0085ce80d2 Bug 1894239: Enable MOZ_SELECTABLE_PROFILES by default. r=jhirsch,omc-reviewers,niklas,emcminn,mconley 
This also removes some tests of `MOZ_SELECTABLE_PROFILES` from `browser/components/profiles` files
where the test is pointless because that test is excluded from the build if `MOZ_SELECTABLE_PROFILES`
is unset.

Differential Revision: https://phabricator.services.mozilla.com/D227372
 2024-11-01 17:08:27 +00:00
Cristian Tuns
8f3ca1449e Backed out changeset 7df0f0dd73a1 (bug 1894239) for causing bc failures in /browser_appmenu.js CLOSED TREE 2024-11-01 12:48:39 -04:00
Dave Townsend
52f716131a Bug 1894239: Enable MOZ_SELECTABLE_PROFILES by default. r=jhirsch,omc-reviewers,niklas,emcminn,mconley 
This also removes some tests of `MOZ_SELECTABLE_PROFILES` from `browser/components/profiles` files
where the test is pointless because that test is excluded from the build if `MOZ_SELECTABLE_PROFILES`
is unset.

Differential Revision: https://phabricator.services.mozilla.com/D227372
 2024-11-01 14:38:45 +00:00
Emily McMinn
803813abef Bug 1903708 - Enable about:messagepreview to preview private browsing messages r=omc-reviewers,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D220289
 2024-10-30 22:10:37 +00:00
hanna alemu
6d1493ff8d Bug 1899747 - Add option to extend feature callout page_event_listener to all windows r=omc-reviewers,mviar,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D213239
 2024-10-30 20:56:29 +00:00
Punam Dahiya
8d7c4d95e6 Bug 1927878 - Make Attribution parameters in devtools editable r=emcminn,omc-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D227263
 2024-10-29 23:26:31 +00:00
Mike Conley
398b96c057 Bug 1926585 - Append the right menu identifier to the utm_content param for FxAMenuMessage. r=pdahiya,omc-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D226650
 2024-10-24 16:06:45 +00:00
hanna alemu
c8150a4dc2 Bug 1911877 - [Docs] Feature callout doc incorrectly says randomize is a property of tiles rather than MultiSelectItem r=omc-reviewers,emcminn 
Differential Revision: https://phabricator.services.mozilla.com/D226400
 2024-10-22 15:22:48 +00:00
negin
a5e13562b4 Bug 1917928 - make logging FxMS telemetry more discoverable r=omc-reviewers,hanna_a 
Updates https://firefox-source-docs.mozilla.org/browser/components/asrouter/docs/telemetry.html to include a section on local debugging/telemetry testing with telemetry logs and glean.

Differential Revision: https://phabricator.services.mozilla.com/D223000
 2024-10-21 19:01:02 +00:00
Rebecca King
d7e1907648 Bug 1916815 - Replace --in-content-accent-color variable with the --color-accent-primary token r=desktop-theme-reviewers,dao 
Differential Revision: https://phabricator.services.mozilla.com/D224509
 2024-10-21 14:50:46 +00:00
Mike Conley
50825d3ded Bug 1922594 - Add image assets for FxA menu messages. r=pdahiya,omc-reviewers 
This also tweaks some styles for the fxa-menu-message so that we're
more aligned with the Figma specification.

Differential Revision: https://phabricator.services.mozilla.com/D225894
 2024-10-19 20:45:50 +00:00
Mike Conley
a52a1d1d9f Bug 1922594 - Add strings for FxA menu messages and the ability to experiment with the sign-in CTA on both panels. r=fluent-reviewers,omc-reviewers,skhamis,desktop-theme-reviewers,bolsson,pdahiya,hjones 
The CTAs for the AppMenu have a collapsed state (since the AppMenu has a Sign In
button to the right of the CTA taking up space), whereas the CTAs for
the FxA avatar panel do not.

Differential Revision: https://phabricator.services.mozilla.com/D224948
 2024-10-19 20:45:50 +00:00
Norisz Fay
295237067d Backed out 2 changesets (bug 1922594) for causing bc failures on browser_sync.js CLOSED TREE 
Backed out changeset 32bbfcc1607a (bug 1922594)
Backed out changeset 9372edf868fe (bug 1922594)
 2024-10-19 03:25:51 +03:00
Mike Conley
51c773a1f0 Bug 1922594 - Add image assets for FxA menu messages. r=pdahiya,omc-reviewers 
This also tweaks some styles for the fxa-menu-message so that we're
more aligned with the Figma specification.

Differential Revision: https://phabricator.services.mozilla.com/D225894
 2024-10-18 20:43:30 +00:00
Mike Conley
53a3f31513 Bug 1922594 - Add strings for FxA menu messages and the ability to experiment with the sign-in CTA on both panels. r=fluent-reviewers,omc-reviewers,skhamis,desktop-theme-reviewers,bolsson,pdahiya,hjones 
The CTAs for the AppMenu have a collapsed state (since the AppMenu has a Sign In
button to the right of the CTA taking up space), whereas the CTAs for
the FxA avatar panel do not.

Differential Revision: https://phabricator.services.mozilla.com/D224948
 2024-10-18 20:43:29 +00:00
Emily McMinn
f3bbb3366b Bug 1918536 - CREATE_NEW_SELECTABLE_PROFILE Special Message Action && test message r=jhirsch,omc-reviewers,pdahiya 
Differential Revision: https://phabricator.services.mozilla.com/D222980
 2024-10-17 18:18:59 +00:00
hanna alemu
c1335b0cb7 Bug 1892548 - Remove faulty test r=omc-reviewers,mviar 
Removes the react_to_trigger test that causes intermittent failures on different platforms. The method that renders the infobar message (showInfoBarMessage) and the defaultBrowserCheck trigger are covered by other tests separately.

Differential Revision: https://phabricator.services.mozilla.com/D225532
 2024-10-15 19:52:11 +00:00
Hanna Jones
99fc51fda2 Bug 1921088 - Upgrade Stylelint and related libraries to the latest version r=Standard8,devtools-reviewers,omc-reviewers,home-newtab-reviewers,nchevobbe,thecount,desktop-theme-reviewers,dao,aminomancer 
In addition to upgrding our Stylelint packages, this patch also introduces the @stylistic/stylelint-plugin to preserve a number of rules that were completely removed in v16. It also migrates the code for the custom plugin introduced in bug 1838298 to ES Modules.

Differential Revision: https://phabricator.services.mozilla.com/D224250
 2024-10-15 19:39:46 +00:00
Mike Conley
8f93af2686 Bug 1920799 - Add tests for the new menu messaging surface for the FxA CTA message. r=pdahiya,omc-reviewers,home-newtab-reviewers,nbarrett 
To manually test the message, make sure to set
`browser.newtabpage.activity-stream.asrouter.devtoolsEnabled` to `true`,
and then visit about:asrouter. Scroll down to the message with ID
FXA_ACCOUNTS_APPMENU_PROTECT_BROWSING_DATA, and click "Show".

This will default to opening the AppMenu with the message. You can open
it for the PXI menu by changing `testingTriggerContext` in the test
message definition from "app_menu" to "pxi_menu".

Differential Revision: https://phabricator.services.mozilla.com/D224790
 2024-10-15 16:15:09 +00:00
Mike Conley
dd4373aecb Bug 1920799 - Add a new messaging surface to the AppMenu and PXI menus for describing the value of signing into an FxA. r=pdahiya,Gijs,desktop-theme-reviewers,omc-reviewers,home-newtab-reviewers,fluent-reviewers,hjones,skhamis,nbarrett 
Developing tests in a later patch in this series.

Differential Revision: https://phabricator.services.mozilla.com/D223409
 2024-10-15 16:15:09 +00:00
Chris H-C
724b00c304 Bug 1920562 - Remove JS uses of Services.telemetry.setEventRecordingEnabled r=florian,extension-reviewers,settings-reviewers,pip-reviewers,credential-management-reviewers,search-reviewers,devtools-reviewers,sync-reviewers,sessionstore-reviewers,omc-reviewers,migration-reviewers,firefox-desktop-core-reviewers ,urlbar-reviewers,sfoster,nchevobbe,valentin,Gijs,dimi,lina,mconley,pdahiya,willdurand 
Differential Revision: https://phabricator.services.mozilla.com/D223833
 2024-10-08 20:14:42 +00:00
jabram
32769d20ee Bug 1865371 - Replace --in-content-box-background with --background-color-box r=cmkm,desktop-theme-reviewers,credential-management-reviewers,omc-reviewers,aminomancer,dao,issammani 
Differential Revision: https://phabricator.services.mozilla.com/D222674
 2024-10-07 20:15:01 +00:00
Sandor Molnar
92076e16a7 Backed out 5 changesets (bug 1920562) for causing xpc assertion failures. CLOSED TREE 
Backed out changeset 8f085ab589a8 (bug 1920562)
Backed out changeset 4405387ae770 (bug 1920562)
Backed out changeset a68fd13a33ae (bug 1920562)
Backed out changeset cd3672fc08ed (bug 1920562)
Backed out changeset 62ab18879eea (bug 1920562)
 2024-10-08 00:16:13 +03:00
hanna alemu
ad40840097 Bug 1910641 - Update the FxMS Bookmarks Bar button for the onboarding setup checklist experiment r=mviar,omc-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D224537
 2024-10-07 17:56:24 +00:00
Chris H-C
e944bfe7a2 Bug 1920562 - Remove JS uses of Services.telemetry.setEventRecordingEnabled r=florian,settings-reviewers,pip-reviewers,credential-management-reviewers,search-reviewers,devtools-reviewers,sync-reviewers,sessionstore-reviewers,omc-reviewers,migration-reviewers,firefox-desktop-core-reviewers ,urlbar-reviewers,sfoster,nchevobbe,valentin,Gijs,dimi,lina,mconley,pdahiya 
Differential Revision: https://phabricator.services.mozilla.com/D223833
 2024-10-07 17:29:57 +00:00
Shane Hughes
e919464011 Bug 1922147 - Use only textareas for ASRouterAdmin targeting editors. r=omc-reviewers,emcminn 
Differential Revision: https://phabricator.services.mozilla.com/D224270
 2024-10-03 17:16:22 +00:00
Florian Quèze
93b33a0974 Bug 1922217 - Migrate telemetry events to use Glean APIs for messaging_experiments, r=chutten,omc-reviewers,pdahiya. 
Differential Revision: https://phabricator.services.mozilla.com/D223291
 2024-10-03 11:45:27 +00:00
Jason Prickett
2817fb56a2 Bug 1901617 - Create onboarding checklist r=mviar,omc-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D221538
 2024-09-26 17:54:01 +00:00
Eric Chen
7ccb2cc84f Bug 1896804 - adding support for architecture based experiment targeting r=nalexander,omc-reviewers,mviar 
Differential Revision: https://phabricator.services.mozilla.com/D223424
 2024-09-25 18:32:21 +00:00
Dão Gottwald
26e76365e7 Bug 1920500 - Remove --button-primary-bgcolor, --button-primary-hover-bgcolor, --button-primary-active-bgcolor, --button-primary-color. r=desktop-theme-reviewers,reusable-components-reviewers,emilio,hjones 
Differential Revision: https://phabricator.services.mozilla.com/D223137
 2024-09-25 05:13:31 +00:00
hanna alemu
7598b19c9a Bug 1913431 - modify activeNotifications to account for newtab topic selection modal r=omc-reviewers,mviar,emcminn 
Differential Revision: https://phabricator.services.mozilla.com/D222379
 2024-09-24 21:15:26 +00:00
negin
02f4e905ae Bug 1918745 - Adds 'FOX_DOODLE_SET_DEFAULT' and 'FAKESPOT_CALLOUT_' rollouts as test messages in NimbusRolloutMessageProvider r=omc-reviewers,pdahiya 
Differential Revision: https://phabricator.services.mozilla.com/D222151
 2024-09-20 20:18:28 +00:00
Joel Maher
beccd9e33d Bug 1917222 - remove skip-if statements when the tests pass for browser-chrome browser/components/a-pref. r=aryx,extension-reviewers,settings-reviewers,credential-management-reviewers,fxview-reviewers,omc-reviewers,migration-reviewers,home-newtab-reviewers,robwu,mconley,dimi,nsharpley,thecount,pdahiya 
Differential Revision: https://phabricator.services.mozilla.com/D221307
 2024-09-19 02:52:04 +00:00
kpatenio
f4e025a957 Bug 1916016 - update opt-in card for migration to Firefox sidebar r=fluent-reviewers,omc-reviewers,shopping-reviewers,fchasen,pdahiya 
- Updated `AboutWelcomeChild.sys.mjs` to a new opt-in card `FS_OPT_IN_SIDEBAR_VARIANT` that is rendered only if `browser.shopping.experience2023.integratedSidebar`
- Updated styling for the integrated RC in `aboutwelcome.css`
- Added non-exposed strings to `shopping.ftl`
- Updated tests to work for both integrated and non-integrated versions

Differential Revision: https://phabricator.services.mozilla.com/D221396
 2024-09-18 20:51:03 +00:00
Sandor Molnar
446bc20f4d Backed out changeset cf3a30d74dec (bug 1916016) for causing xpc failures @ test_sorted_alphabetically.js CLOSED TREE 2024-09-19 01:08:05 +03:00
kpatenio
9e138be518 Bug 1916016 - update opt-in card for migration to Firefox sidebar r=fluent-reviewers,omc-reviewers,shopping-reviewers,fchasen,pdahiya 
- Updated `AboutWelcomeChild.sys.mjs` to a new opt-in card `FS_OPT_IN_SIDEBAR_VARIANT` that is rendered only if `browser.shopping.experience2023.integratedSidebar`
- Updated styling for the integrated RC in `aboutwelcome.css`
- Added non-exposed strings to `shopping.ftl`
- Updated tests to work for both integrated and non-integrated versions

Differential Revision: https://phabricator.services.mozilla.com/D221396
 2024-09-18 20:51:03 +00:00
Dão Gottwald
a968b39209 Bug 1919262 - Remove --button-color. r=desktop-theme-reviewers,reusable-components-reviewers,emilio,hjones 
Differential Revision: https://phabricator.services.mozilla.com/D222439
 2024-09-18 06:04:39 +00:00
Iulian Moraru
7fadac62f4 Backed out changeset 8faf0e38aae6 (bug 1918745) for causing xpcshell failures on test_NimbusRolloutMessageProvider.js. 2024-09-16 22:08:37 +03:00
negin
0dd29c39bf Bug 1918745 - Adds 'FOX_DOODLE_SET_DEFAULT' and 'FAKESPOT_CALLOUT_' rollouts as test messages in NimbusRolloutMessageProvider r=omc-reviewers,pdahiya 
Adds `FOX_DOODLE_SET_DEFAULT` and `FAKESPOT_CALLOUT_` and removes `Q4_DEVICE_MIGRATION` and `ADDONS_STAFF_PICK` as part of live rollouts.


```
Processing rollout: 1-click-set-to-default-existing-profiles-rollout
  Processing branch: treatment-b
    Importing message: FOX_DOODLE_SET_DEFAULT
Processing rollout: us-review-checker-rollout-v2
  Processing branch: treatment-a
    Importing message 1 of 4: FAKESPOT_CALLOUT_NO_OP_DUMMY
    Importing message 2 of 4: FAKESPOT_CALLOUT_CLOSED_NOT_OPTED_IN_AUTO_OPEN
    Importing message 3 of 4: FAKESPOT_CALLOUT_PDP_NOT_OPTED_IN_REMINDER
    Importing message 4 of 4: FAKESPOT_CALLOUT_OPTED_OUT_SURVEY
Processing rollout: recommend-add-ons-staff-pick-relaunch-treatment-a-rollout
```

Differential Revision: https://phabricator.services.mozilla.com/D222151
 2024-09-16 17:17:01 +00:00
hanna alemu
84f87d979e Bug 1919061 - Fix mis-matched feature config name for configurable Bookmarks button surface r=omc-reviewers,mviar 
This fixes a bug where ASrouter was not receiving Bookmarks Bar button messages from Experimenter

Differential Revision: https://phabricator.services.mozilla.com/D222302
 2024-09-16 16:55:51 +00:00
hanna alemu
8bb0544d31 Bug 1915019 - Include hidden and isBuiltin in addonsInfo targeting values r=omc-reviewers,mviar 
Differential Revision: https://phabricator.services.mozilla.com/D222174
 2024-09-16 13:12:02 +00:00
Julian Descottes
fba56f38cc Bug 1917003 - [eslint] Fix violations for reject-multiple-await r=perftest-reviewers,credential-management-reviewers,places-reviewers,issammani,daisuke,sparky 
Depends on D221187

Differential Revision: https://phabricator.services.mozilla.com/D221306
 2024-09-16 09:13:30 +00:00
Sebastian Hengst
2cc2b0108b Bug 1892548 - disable browser_asrouter_infobar.js on Linux debug for frequent intermittent failures. r=intermittent-reviewers,omc-reviewers,ahal,hanna_a DONTBUILD 
Differential Revision: https://phabricator.services.mozilla.com/D221794
 2024-09-12 21:25:30 +00:00
Mark Banner
fe5b823483 Bug 1917530 - Enable ESLint rule no-shadow by default across the tree, disabling where it currently fails. r=frontend-codestyle-reviewers,mossop 
Differential Revision: https://phabricator.services.mozilla.com/D221445
 2024-09-12 21:08:44 +00:00
Mark Banner
aabcf18c26 Bug 1917530 - Fix some ESLint no-shadow issues in misc code. r=frontend-codestyle-reviewers,perftest-reviewers,translations-reviewers,omc-reviewers,migration-reviewers,webcompat-reviewers,urlbar-reviewers,dao,twisniewski,sparky,mconley,emcminn,mossop 
Differential Revision: https://phabricator.services.mozilla.com/D221443
 2024-09-12 21:08:44 +00:00
Sandor Molnar
b59809ee6a Backed out 8 changesets (bug 1917532, bug 1575506, bug 1917530) for causing node newtab failures CLOSED TREE 
Backed out changeset 8d6f7bc74d08 (bug 1917532)
Backed out changeset 7c963e72cf06 (bug 1575506)
Backed out changeset d5e110187781 (bug 1917530)
Backed out changeset 1d2325ffded6 (bug 1917530)
Backed out changeset 8a361e37e32c (bug 1917530)
Backed out changeset c4011d92c7f7 (bug 1917530)
Backed out changeset 1a45047dfb3c (bug 1917530)
Backed out changeset ed6b35444c45 (bug 1917530)
 2024-09-12 20:45:28 +03:00
Mark Banner
4b68d25082 Bug 1917530 - Enable ESLint rule no-shadow by default across the tree, disabling where it currently fails. r=frontend-codestyle-reviewers,mossop 
Differential Revision: https://phabricator.services.mozilla.com/D221445
 2024-09-12 16:41:59 +00:00
Mark Banner
e3981e1099 Bug 1917530 - Fix some ESLint no-shadow issues in misc code. r=frontend-codestyle-reviewers,perftest-reviewers,translations-reviewers,omc-reviewers,migration-reviewers,webcompat-reviewers,urlbar-reviewers,dao,twisniewski,sparky,mconley,emcminn,mossop 
Differential Revision: https://phabricator.services.mozilla.com/D221443
 2024-09-12 16:41:58 +00:00
Dão Gottwald
a771bc70eb Bug 1917588 - Stop setting --button-bgcolor, --button-hover-bgcolor, --button-active-bgcolor in browser-shared.css. r=desktop-theme-reviewers,emilio 
Differential Revision: https://phabricator.services.mozilla.com/D221480
 2024-09-09 14:57:46 +00:00