corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
901,613 Commits 1 Branch 0 Tags
84c498dc3b56e47b5845c511d73b0edfec19e17f
Commit Graph

406 Commits

Author SHA1 Message Date
Nathan Barrett
84c498dc3b Bug 1951426 - Request messages from OMC in newtab r=home-newtab-reviewers,omc-reviewers,mconley,aminomancer,maxx 
Differential Revision: https://phabricator.services.mozilla.com/D240175
 2025-03-24 17:42:04 +00:00
Beth Rennie
ab06202815 Bug 1953530 - Move most Nimbus telemetry code into a single module r=nimbus-reviewers,chumphreys,omc-reviewers,aminomancer 
This patch does not change the targeting context telemetry as it is
sufficiently complicated and isolated from the rest of the telemetry.

Differential Revision: https://phabricator.services.mozilla.com/D241325
 2025-03-21 17:53:20 +00:00
Emily McMinn
3b5c94bb3f Bug 1949271 - Add tab groups callouts for SessionRestore && add userPrefs.cfrFeatures to all tab groups callouts r=omc-reviewers,aminomancer,beth 
Differential Revision: https://phabricator.services.mozilla.com/D239808
 2025-03-21 16:10:57 +00:00
Goloman Adrian
ac2cd44a24 Backed out 4 changesets (bug 1953632, bug 1951782, bug 1951426, bug 1954848) for causing build bustages. CLOSED TREE 
Backed out changeset 6825e2911771 (bug 1954848)
Backed out changeset 56f68e9e9ab5 (bug 1953632)
Backed out changeset bda4413155d7 (bug 1951782)
Backed out changeset 04623acb0ff2 (bug 1951426)
 2025-03-21 20:38:15 +02:00
Nathan Barrett
3957775da8 Bug 1951426 - Request messages from OMC in newtab r=home-newtab-reviewers,omc-reviewers,mconley,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D240175
 2025-03-21 15:26:34 +00:00
Stanca Serban
81fcbe2dae Backed out 2 changesets (bug 1953530) for causing mochitests failures in browser_asrouter_experimentsAPILoader.js. 
Backed out changeset 40e98c849875 (bug 1953530)
Backed out changeset fc38ba906d3f (bug 1953530)
 2025-03-21 03:44:47 +02:00
Beth Rennie
af8fe3e1c9 Bug 1953530 - Move most Nimbus telemetry code into a single module r=nimbus-reviewers,chumphreys,omc-reviewers,aminomancer 
This patch does not change the targeting context telemetry as it is
sufficiently complicated and isolated from the rest of the telemetry.

Differential Revision: https://phabricator.services.mozilla.com/D241325
 2025-03-20 16:21:40 +00:00
Stanca Serban
4380403c09 Backed out 4 changesets (bug 1951426, bug 1954848, bug 1953632, bug 1951782) for causing Node tests failures. CLOSED TREE 
Backed out changeset 2a8c811ce373 (bug 1954848)
Backed out changeset 04b8c4b9620a (bug 1953632)
Backed out changeset b51759b5f846 (bug 1951782)
Backed out changeset fc971f683077 (bug 1951426)
 2025-03-20 23:36:40 +02:00
Nathan Barrett
9e01a2ba3e Bug 1951426 - Request messages from OMC in newtab r=home-newtab-reviewers,omc-reviewers,mconley,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D240175
 2025-03-20 14:12:21 +00:00
Jason Prickett
d51e46b708 Bug 1953129 - Cap totalSearches pref at 100 r=omc-reviewers,urlbar-reviewers,mviar,jteow 
Differential Revision: https://phabricator.services.mozilla.com/D241671
 2025-03-18 23:08:15 +00:00
Rebecca King
7a5cd481d5 Bug 1947884 - Add background property to dismiss button on Review Checker callouts - r=shopping-reviewers,omc-reviewers,kpatenio,emcminn 
Differential Revision: https://phabricator.services.mozilla.com/D240229
 2025-03-17 19:22:39 +00:00
Shane Hughes
e7f24e223a Bug 1948423 - Skip targeting and trigger listener creation for messages with skip_in_tests. r=omc-reviewers,negin 
Differential Revision: https://phabricator.services.mozilla.com/D238374
 2025-03-07 04:36:57 +00:00
negin
e4a5516610 Bug 1895755 - Updates default min-height for feature callout ctas to 24px r=omc-reviewers,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D238832
 2025-03-06 21:14:52 +00:00
Punam Dahiya
3903db65e6 Bug 1899019 - Part 2 - Move FxMS metrics and pings definitions r=home-newtab-reviewers,omc-reviewers,mconley,negin 
Differential Revision: https://phabricator.services.mozilla.com/D238892
 2025-03-04 20:51:54 +00:00
hanna.alemu
66860e7c8b Bug 1922646 - Add a delay between the default Set to Default prompt and showing the INFOBAR_DEFAULT_AND_PIN_87 message r=omc-reviewers,pdahiya 
Differential Revision: https://phabricator.services.mozilla.com/D234206
 2025-03-04 20:31:35 +00:00
Emily McMinn
c4129a5ba8 Bug 1945700 - Add a boolean background property to dismiss buttons that enables contrasting colours r=omc-reviewers,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D237640
 2025-02-28 23:12:17 +00:00
Punam Dahiya
b4e0e43942 Bug 1899019 - Part 1 - Add FxMS metrics.yaml and pings.yaml files r=chutten,omc-reviewers,negin 
Differential Revision: https://phabricator.services.mozilla.com/D238891
 2025-02-27 23:31:50 +00:00
Meg Viar
35da1f9427 Bug 1940580 - On-train limited rollout of TOS preonboarding modal for Mac, Linux, and MSIX r=nalexander,hanna_a,omc-reviewers,beth,Gijs 
- Support an on-train limited rollout of the TOS preonboarding modal for platforms where first run experiments are not supported (Mac, Linux, MSIX)
- This patch lands the initial feature work and an uplift in 137 release will enable it for 1% of users. Later in 137, a second uplift will increase the population to 25%.
- Two nimbus features with fallback prefs are available for testing, the fallback prefs are `browser.preonboarding.onTrainRolloutEnabled` and `browser.preonboarding.onTrainRolloutPopulation`.

Differential Revision: https://phabricator.services.mozilla.com/D238304
 2025-02-27 16:23:20 +00:00
Shane Hughes
e9c7fc6d9f Bug 1950189 - Allow callouts to be dismissed by Esc even if they're not focused. r=omc-reviewers,emcminn 
Differential Revision: https://phabricator.services.mozilla.com/D239402
 2025-02-27 08:31:42 +00:00
hanna.alemu
bf18e2022a Bug 1934718 - Update NimbusRolloutMessageProvider with messaging rollouts in Fx136 r=omc-reviewers,pdahiya 
Differential Revision: https://phabricator.services.mozilla.com/D239439
 2025-02-27 01:58:29 +00:00
Emilio Cobos Álvarez
1ed7833723 Back out bug 1950189 because I pushed it accidentally. 
MANUAL PUSH: Back out CLOSED TREE
 2025-02-27 01:16:22 +01:00
Shane Hughes
cbe67161c2 Bug 1950189 - Allow callouts to be dismissed by Esc even if they're not focused. r=#omc-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D239402
 2025-02-27 01:00:36 +01:00
Emily McMinn
de64394a0c Bug 1949599 - Remove animated onboarding callouts for Tab Groups r=omc-reviewers,jprickett 
Differential Revision: https://phabricator.services.mozilla.com/D239181
 2025-02-26 17:02:18 +00:00
Sandor Molnar
695882bbbf Backed out changeset d6f61409b245 (bug 1899019) for causing build bustages @ AsrouterMetrics.h CLOSED TREE 2025-02-26 08:02:04 +02:00
Punam Dahiya
88d6323bef Bug 1899019 - Part 1 - Add FxMS metrics.yaml and pings.yaml files r=chutten,omc-reviewers,negin 
Differential Revision: https://phabricator.services.mozilla.com/D238891
 2025-02-25 23:16:59 +00:00
Gregory Pappas
2300895022 Bug 1750304 - Move isChinaRepack out of AppConstants r=settings-reviewers,home-newtab-reviewers,Gijs,pdahiya,omc-reviewers,mossop,mconley 
AppConstants seems like the wrong place for this method

Differential Revision: https://phabricator.services.mozilla.com/D239276
 2025-02-25 20:46:37 +00:00
Rebecca King
b3a22ac978 Bug 1938253 - Implement Callout 3 for integrated version of Review Checker - r=kpatenio,shopping-reviewers,fluent-reviewers,settings-reviewers,omc-reviewers,aminomancer,bolsson,mossop 
Differential Revision: https://phabricator.services.mozilla.com/D233053
 2025-02-24 18:15:36 +00:00
negin
4b16185899 Bug 1919598 - Land Firefox View Discoverability treatment-b in mc- r=omc-reviewers,fluent-reviewers,emcminn,accessibility-frontend-reviewers,nstroud 
Differential Revision: https://phabricator.services.mozilla.com/D229198
 2025-02-24 15:21:41 +00:00
Rebecca King
622361d010 Bug 1938413 - Implement callout 4A and callout 4B for RC in the sidebar when a user disables auto-open r=kpatenio,emcminn,shopping-reviewers,fluent-reviewers,omc-reviewers,bolsson,sidebar-reviewers,jsudiaman 
Differential Revision: https://phabricator.services.mozilla.com/D234974
 2025-02-21 23:30:51 +00:00
negin
3d8c9dcaaf Bug 1919598 - Avoid creating a notification box during activeNotifications r=omc-reviewers,pdahiya 
Differential Revision: https://phabricator.services.mozilla.com/D238817
 2025-02-21 23:05:26 +00:00
Rebecca King
ddf1ba4c90 Bug 1938417 - Implement callout 5 for Review Checker in the sidebar when a user turns off Review Checker - r=kpatenio,emcminn,shopping-reviewers,fluent-reviewers,omc-reviewers,bolsson 
Differential Revision: https://phabricator.services.mozilla.com/D234997
 2025-02-21 22:07:22 +00:00
Emily McMinn
31aeebfe5f Bug 1949261 - Tab Groups message refinements and strings r=omc-reviewers,dao,fluent-reviewers,bolsson,pdahiya,jprickett 
Differential Revision: https://phabricator.services.mozilla.com/D238837
 2025-02-21 16:53:18 +00:00
Goloman Adrian
3624802d33 Backed out changeset 8b98d8d87760 (bug 1948423) for causing bc failures @browser_foxdoodle_set_default.js. CLOSED TREE 2025-02-20 06:56:38 +02:00
Shane Hughes
378d8ec5e5 Bug 1948423 - Skip targeting and trigger listener creation for messages with skip_in_tests. r=omc-reviewers,negin 
Differential Revision: https://phabricator.services.mozilla.com/D238374
 2025-02-20 03:03:45 +00:00
Meg Viar
4066ecbd13 Bug 1948717 - Add flag that enables running actions in MULTI_ACTION SMA in sequential order r=jprickett,omc-reviewers,nalexander 
To support the upcoming TOS preonboarding experiment, we want to ensure the following actions occur sequentially:
  - setting prefs, including `datareporting.healthreport.uploadEnabled` (`SET_PREF`)
  - submitting the onboarding opt-out ping, if applicable (`SUBMIT_ONBOARDING_OPT_OUT_PING`)
  - notifying that the data reporting notification has been interacted with (`DATAREPORTING_NOTIFY_DATA_POLICY_INTERACTED`).

When these actions occur out of order, it is possible for telemetry to be enabled and then disabled. This is likely what accounts for the onboarding-opt-out followed by deletion-request pings witnessed by QA in Bug 1948717.

We believe that the issue is that the `MULTI_ACTION` SMA does not guarantee any ordering of its child actions: see [[ https://searchfox.org/mozilla-central/rev/0d1f8ff61fe506646fe3898ef727817b4436ab32/toolkit/components/messaging-system/lib/SpecialMessageActions.sys.mjs#687-696 | here ]]. That's by design, since early actions including pinning and set-to-default, which are slow and can be run concurrently. But here, we expect sequential ordering (and also [[ https://searchfox.org/mozilla-central/rev/0d1f8ff61fe506646fe3898ef727817b4436ab32/browser/components/aboutwelcome/content-src/components/MultiStageAboutWelcome.jsx#578-585 | in the code ]]).

The obvious way to address this is to have the MULTI_ACTION order its child actions. However, this needs to be a flag, since we have existing consumers and we want to minimize disruption.

This patch adds support for an `orderedExecution` flag on message `action` configurations for those with type `MULTI_ACTION`. This applies to nested `MULTI_ACTIONS` using `collectSelect` as well, assuming each `MULTI_ACTION` has the `orderedExecution` flag.

Differential Revision: https://phabricator.services.mozilla.com/D238816
 2025-02-20 00:28:02 +00:00
mark
c2958a4a93 Bug 1936120 - Enforce no quotes around Lit expressions r=reusable-components-reviewers,credential-management-reviewers,fxview-reviewers,omc-reviewers,backup-reviewers,sidebar-reviewers,frontend-codestyle-reviewers,profiles-reviewers,mtigley,mconley,hjones,jsudiaman,niklas,Standard8,pdahiya 
* Enables lit/quoted-expressions rule to enforce that no surrounding
  quotes when expressions are bound to attributes and properties in Lit templates.
  See f71ea1741e/docs/rules/quoted-expressions.md

* Updates all violations to adhere to lit/quoted-expressions rule

Differential Revision: https://phabricator.services.mozilla.com/D237657
 2025-02-19 16:19:42 +00:00
jprickett
aa7d7f50c8 Bug 1927504 - Update feature callout documentation r=omc-reviewers,mviar DONTBUILD 
Differential Revision: https://phabricator.services.mozilla.com/D231349
 2025-02-18 20:30:41 +00:00
Butkovits Atila
91a59f70d0 Backed out changeset aedc669b8499 (bug 1919598) for causing failures at browser_tabnotificationbox_switch_tabs.js. CLOSED TREE 2025-02-14 19:24:24 +02:00
negin
4935d2153f Bug 1919598 - Land Firefox View Discoverability treatment-b in mc- r=omc-reviewers,fluent-reviewers,emcminn,accessibility-frontend-reviewers,nstroud 
Differential Revision: https://phabricator.services.mozilla.com/D229198
 2025-02-14 16:05:20 +00:00
Sarah Chung
802e677efa Bug 1942154 - fix npm package vulnerabilities in asrouter and aboutwelcome r=omc-reviewers,dmose 
Differential Revision: https://phabricator.services.mozilla.com/D234580
 2025-02-13 21:11:05 +00:00
Sarah Chung
4a5e5fad96 Bug 1947536 - expose qr code in desktop to mobile adoption message to assistive technology r=emcminn,omc-reviewers,fluent-reviewers,bolsson 
Differential Revision: https://phabricator.services.mozilla.com/D237898
 2025-02-12 20:37:21 +00:00
Meg Viar
da90402d32 Bug 1947510 - Save default MultiSelect choices even if component defaults to a collapsed state r=omc-reviewers,hanna_a,jprickett 
We want to capture the default state of multiselect checklist items when a user clicks the primary CTA on an aboutwelcome screen, even if the checklist hasn't been rendered yet (such as when the user needs to click a button to toggle it in to view).

Differential Revision: https://phabricator.services.mozilla.com/D237773
 2025-02-11 22:22:30 +00:00
Punam Dahiya
1fd0f99f8e Bug 1940816 - Put newtab chrome and resource assets under chrome://newtab and resource://newtab r=home-newtab-reviewers,omc-reviewers,mconley,credential-management-reviewers,marco,emcminn,valentin,dimi CLOSED TREE 
Differential Revision: https://phabricator.services.mozilla.com/D236880
 2025-02-10 17:55:34 +00:00
Sarah Chung
ccdd8c7af2 Bug 1947182 - update targeting for desktop to mobile adoption message r=emcminn,omc-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D237616
 2025-02-10 21:51:11 +00:00
Norisz Fay
29170cefc4 Backed out changeset 5785f202084e (bug 1940816) for causing Bpgo bustage CLOSED TREE 2025-02-11 06:11:10 +02:00
Punam Dahiya
7059cde7b0 Bug 1940816 - Put newtab chrome and resource assets under chrome://newtab and resource://newtab r=home-newtab-reviewers,omc-reviewers,mconley,credential-management-reviewers,marco,emcminn,valentin,dimi 
Differential Revision: https://phabricator.services.mozilla.com/D236880
 2025-02-10 17:55:34 +00:00
Punam Dahiya
4197a454e1 Bug 1946458 - Remove wallpaper select custom handling in aboutwelcome bundle r=amy,omc-reviewers,emcminn,fluent-reviewers,bolsson 
Differential Revision: https://phabricator.services.mozilla.com/D237130
 2025-02-07 21:21:19 +00:00
Emily McMinn
967f0a3050 Bug 1946512 - Add automated test for alltabsButtonAreaType r=omc-reviewers,mviar 
Differential Revision: https://phabricator.services.mozilla.com/D237113
 2025-02-06 22:52:43 +00:00
Emily McMinn
8a96646dd7 Bug 1945564 - Update Create Tab Group callout && add new callout for users who have removed the all tabs button r=omc-reviewers,dao,fluent-reviewers,bolsson,mviar 
Differential Revision: https://phabricator.services.mozilla.com/D236588
 2025-02-06 17:28:08 +00:00
Emily McMinn
b6fec0fc15 Bug 1944344 - Anchor vertical callout to tab strip if active tab is pinned r=omc-reviewers,dao,mviar 
Differential Revision: https://phabricator.services.mozilla.com/D236956
 2025-02-06 15:38:50 +00:00